8847 Commits

Author SHA1 Message Date
Jacob Richman
70d3a62125 Use defaultTargetPlatform instead of Platform.operatingSystem for ImageProvider. (#10986)
* Use defaultTargetPlatform instead of Platform.operatingSystem for ImageProvider.
Add convenience helper to make it easier to display a short string for
an enums value.

* Add comment linking to issue.
2017-06-27 09:13:35 -07:00
Alexander Aprelev
86e6ffeed4 Rev up the engine dependency (#10988) 2017-06-26 21:03:32 -07:00
Yegor
a4a276b71a rev engine (38b3e89) and Dart SDK (1.24.2) (#10985) 2017-06-26 18:08:56 -07:00
Chris Bracken
bb732b4655 Add tests for xcodeVersionSatisfactory (#10981)
And fix a typo in a test description.
2017-06-26 14:34:44 -07:00
Chris Bracken
e04907a48b Ensure Xcode major, minor version always return non-null (#10980)
Previously, xcodeMajorVersion and xcodeMinorVersion returned null unless
xcodeVersionSatisfactory had been called first. We now compute them on
demand, and cache the resultant values.
2017-06-26 13:37:59 -07:00
Chris Bracken
5141c1e8e9 Add test for unknown Xcode version string (#10979)
Also, correct an existing test description.
2017-06-26 13:11:49 -07:00
Ian Hickson
dbb734ddb5 More documentation. (#10953)
Applies comments I missed from https://github.com/flutter/flutter/pull/10904.
2017-06-26 12:05:49 -07:00
gspencergoog
ddf25d23fe Enabling StrokeJoin for paths and rectangles. (#10742)
* Prefix and Suffix support for TextFields

* Adding Tests

* Removing spurious newline.

* Fixing a small problem with the test

* Code review changes

* Code Review Changes

* Review Changes

* Export the new StrokeJoin enum

* Added example for line styles, and enabled line join styles.

* Reverting inadvertent change to main.dart.

* Updated due to code review of engine code

* Removed example.
2017-06-26 11:26:46 -07:00
Ian Hickson
dbe038ef6c Make this (working) test more verbose (#10973)
...so that we can compare it to the not-working test next to it.
2017-06-26 11:19:11 -07:00
Michael Goderbauer
13edb3209d Add Windows support to CONTRIBUTING.md (#10956) 2017-06-26 09:47:05 -07:00
Mikkel Nygaard Ravn
c5999c74c0 Add gradle wrapper to project template (#10928) 2017-06-26 12:47:43 +02:00
Sarah Zakarias
d97b13b5fd Add objc doc to the dartdoc output (#10905) 2017-06-26 12:15:24 +02:00
Devon Carew
f946171817 update our build bot exclusions (#10964) 2017-06-25 21:17:39 -07:00
Yegor
148565eed5 check existence of task files (#10959) 2017-06-23 22:12:30 -07:00
Chris Bracken
2ebb9e5dc6 Use ProcessManager for Xcode tool invocations (#10955)
1. Run all Xcode tool invocations through ProcessManager, which allows
us to mock out failures, etc. for tests.

2. Add said tests.
2017-06-23 18:50:27 -07:00
Ian Hickson
bbea0c3d1a enable routing_test in devicelab (#10958) 2017-06-23 18:13:40 -07:00
Ian Hickson
d131a8df42 Fix --keep-app-running default and make devicelab verboser (#10957) 2017-06-23 18:09:37 -07:00
Chris Bracken
845c1b7f01 Re-land Lazily initialise Xcode installation status (#10952)
This reverts commit 3e265e9e423392373a171be3d1303ebca1f4c7a4.

Rather than pre-compute Xcode install path, version, and EULA status,
compute and cache on demand.
2017-06-23 16:58:14 -07:00
Chris Bracken
3e265e9e42 Revert "Lazily initialise Xcode installation status (#10945)" (#10951)
This reverts commit bb8e2a7ccd46f8c4855391d6884b2a87c95267f6.

Triggers a doctor failure on the Mac chromebots.
2017-06-23 16:08:36 -07:00
Chris Bracken
bb8e2a7ccd Lazily initialise Xcode installation status (#10945)
Rather than pre-compute Xcode install path, version, and EULA status,
compute and cache on demand.
2017-06-23 15:56:44 -07:00
Ian Hickson
02171dcaf2 Roll engine (#10944)
Picks up primarily stability fixes.
2017-06-23 15:29:24 -07:00
Michael Goderbauer
fe40eed362 Provide haptic/acoustic feedback for tap & long-press on Android (#10920)
* Provide haptic/acoustic feedback for tap & long-press on Android

* review comments

* fixed example code

* review comments

* comment fix
2017-06-23 15:02:55 -07:00
Ian Hickson
9adb4a78a6 Deep linking: automatically push the route hiearchy on load. (#10894)
The main purpose of this PR is to make it so that when you set the
initial route and it's a hierarchical route (e.g. `/a/b/c`), it
implies multiple pushes, one for each step of the route (so in that
case, `/`, `/a`, `/a/b`, and `/a/b/c`, in that order). If any of those
routes don't exist, it falls back to '/'.

As part of doing that, I:

 * Changed the default for MaterialApp.initialRoute to honor the
   actual initial route.

 * Added a MaterialApp.onUnknownRoute for handling bad routes.

 * Added a feature to flutter_driver that allows the host test script
   and the device test app to communicate.

 * Added a test to make sure `flutter drive --route` works.
   (Hopefully that will also prove `flutter run --route` works, though
   this isn't testing the `flutter` tool's side of that. My main
   concern is over whether the engine side works.)

 * Fixed `flutter drive` to output the right target file name.

 * Changed how the stocks app represents its data, so that we can
   show a page for a stock before we know if it exists.

 * Made it possible to show a stock page that doesn't exist. It shows
   a progress indicator if we're loading the data, or else shows a
   message saying it doesn't exist.

 * Changed the pathing structure of routes in stocks to work more
   sanely.

 * Made search in the stocks app actually work (before it only worked
   if we happened to accidentally trigger a rebuild). Added a test.

 * Replaced some custom code in the stocks app with a BackButton.

 * Added a "color" feature to BackButton to support the stocks use case.

 * Spaced out the ErrorWidget text a bit more.

 * Added `RouteSettings.copyWith`, which I ended up not using.

 * Improved the error messages around routing.

While I was in some files I made a few formatting fixes, fixed some
code health issues, and also removed `flaky: true` from some devicelab
tests that have been stable for a while. Also added some documentation
here and there.
2017-06-23 14:58:29 -07:00
Ian Hickson
59524c697b Slightly improve comments in SliverMultiBoxAdaptorElement (#10939)
I got a bit confused by these comments when trying to debug this code,
let's try clearing them up a little.
2017-06-23 14:58:14 -07:00
Ian Hickson
df1a01b3b3 Add documentation. Also, add constructors to SliverGrid. (#10904) 2017-06-23 14:36:58 -07:00
Jason Simmons
856115b7e2 Clear the selection when a text widget loses focus (#10938)
Fixes https://github.com/flutter/flutter/issues/10911
2017-06-23 14:22:13 -07:00
Todd Volkert
128967cd2a Bump Dart SDK version to 1.24.0 (stable) (#10931)
https://github.com/flutter/flutter/issues/10650
2017-06-23 14:08:34 -07:00
Todd Volkert
f18083d448 Print ADB output when adb install fails (#10933)
Fixes #10929
2017-06-23 14:08:07 -07:00
Jacob Richman
8f07a5864b Add hasAGoodToStringDeep and equalsIgnoringHashCodes methods. (#10935)
* Add hasAGoodToStringDeep and equalsIgnoringHashCodes methods.

Methods simplify testing of toStringDeep calls and other cases where
methods return strings containing hash codes.
2017-06-23 14:07:09 -07:00
Chris Bracken
f4f81e9ac7 Require Xcode >= 8.0 for iOS development (#10932)
This allows us to take advantage of improved command-line tooling (e.g.,
improvements in device listing in Instruments). Now that the engine is
built with Xcode 8 and the framework is tested against Xcode 8, this
reduces the set of configurations we need to support to allow us to
focus on the supported ones: Xcode 8 and Xcode 9.
2017-06-23 14:07:01 -07:00
Ian Hickson
f4e4b93c1f Clarify image-related services docs (#10815)
...and make one of the comments accurate by fixing the code. Turns
out I forgot to add the 'silent' argument when I changed that comment.
2017-06-23 14:06:30 -07:00
Ian Hickson
ba520e7078 Some clarifications for ListView constructors (#10907) 2017-06-23 14:06:18 -07:00
Chris Bracken
9a6a3e1e27 Delete unnecessary print statement (#10937)
This print statement provides no value to the user.
2017-06-23 14:06:10 -07:00
Todd Volkert
c79e25c5a7 Stop uploading coverage and docs until dl.google.com issue is resolved (#10941)
https://github.com/flutter/flutter/issues/10940
2017-06-23 13:40:38 -07:00
Zachary Anderson
09bdab201d [fuchsia_reload] Use ssh instead of netcp/netruncmd (#10436) 2017-06-22 22:08:20 -07:00
Yegor
0426fb60b9 upgrade package:usage to get clientId fix (#10919)
The upstream fix is: 021664efd3
2017-06-22 17:57:59 -07:00
Hans Muller
da4950cf18 Wait for the driver test to settle before collecting screenshots (#10916) 2017-06-22 16:46:35 -07:00
Hans Muller
b55441a027 Do not require main asset files if variants are provided (#10901) 2017-06-22 16:45:57 -07:00
Zachary Anderson
4d490666b3 Clean up pre-existing DevFS during creation (#10843) 2017-06-22 09:48:31 -07:00
xster
02245234b6 Save development certificate choice (#10849) 2017-06-21 17:22:13 -07:00
Jason Simmons
265257ab6d Increment dev version numbers (#10897) 2017-06-21 15:33:22 -07:00
Jason Simmons
d36e2f6191 Update versions for an alpha release (#10896) 2017-06-21 15:09:10 -07:00
Jason Simmons
c78bfc5625 Roll engine (#10892) 2017-06-21 14:40:49 -07:00
P.Y. Laligand
c12b184dc3 Add missing context bits to Fuchsia tools. (#10891) 2017-06-21 14:03:13 -07:00
Devon Carew
963b90edf0 send the FLUTTER_HOST env var as analytics' app installer ID (#10889) 2017-06-21 13:02:40 -07:00
Seth Ladd
b231006ce7 analytics expects a format of cd<integer> for custom dimensions (#10864) 2017-06-21 10:54:37 -07:00
Jacob Richman
595cd23c8c Change all occurrences of '$runtimeType#$hashCode' to use the describeIdentity (#10888)
* Revert "Revert "Change all ocurrences of '$runtimeType#$hashCode' to use the idAndType method. (#10871)" (#10880)"

This reverts commit ceb814aa647ecd310794a72a7a5c28820ec57a25.
2017-06-21 10:47:06 -07:00
Alan
95f5d8d7f2 Implement Matrix4Tween.lerp() (#10829) 2017-06-21 09:40:32 -07:00
jcollins-g
3f3a36787e Update dartdoc to 0.13.0+1 for flutter (#10863) 2017-06-21 08:01:26 -07:00
Jacob Richman
ceb814aa64 Revert "Change all ocurrences of '$runtimeType#$hashCode' to use the idAndType method. (#10871)" (#10880)
This reverts commit d46e208b98d4af93d7029c3e806d443dd51fd116.
2017-06-20 22:14:59 -07:00