Eric Seidel
7ee0ee7291
Per review comments
2016-04-13 14:46:42 -07:00
Eric Seidel
237f1ac263
Add a basic scrolling test for the Gallery home page.
...
Current numbers from my Nexus 5:
"average_frame_build_time_millis": 22.6854,
"missed_frame_build_budget_count": 15,
"frame_count": 15
Filed https://github.com/flutter/flutter/issues/3296
@yjbanov @hansmuller @vlidholt
2016-04-13 14:21:51 -07:00
Ian Hickson
7861d02943
Fix dependency skew. ( #3306 )
...
...by adding tests to our examples that don't import flutter_test, which
pins the relevant dependencies.
Also, provide more information when complaining about leaked transient
callbacks in tests.
Also, make tests display full information when they have an exception,
by bypassing the throttling we have for Android logging in tests.
Also, make the word wrapping not wrap stack traces if they happen to
be included in exception output.
Also, fix a leaked transient callback in the checkbox code.
2016-04-13 13:53:39 -07:00
Adam Barth
ec4a6a96f2
Add more dartdocs to material.dart ( #3279 )
2016-04-12 14:18:58 -07:00
Adam Barth
69f994446b
Add more dartdoc to material.dart ( #3261 )
...
Now past halfway though material.dart by files.
2016-04-12 12:41:59 -07:00
Viktor Lidholt
2f60932df9
Adds nice photos and hero animations to the Grid gallery demo ( #3258 )
2016-04-12 12:12:00 -07:00
Hans Muller
ba5a04e85a
ClampOverscrolls Inherited Widget ( #3267 )
...
* ClampOverscrolls Inherited Widget
2016-04-12 10:12:44 -07:00
Viktor Lidholt
83ef964ac6
Updates selection controls gallery demo ( #3225 )
2016-04-08 14:33:34 -07:00
Hans Muller
34f23cc456
Added OverscrollIndicator, removed OverscrollIndicatorPainter ( #3220 )
...
* Added OverscrollIndicator, removed OverscrollIndicatorPainter
2016-04-08 14:21:00 -07:00
Viktor Lidholt
9b5361acab
Moves and renames gallery demos ( #3217 )
2016-04-08 11:08:21 -07:00
Adam Barth
1251f01ec7
Convert some Columns into Blocks ( #3210 )
...
These columns were secretly re-creating Block in a more complex way. Now we
just use Block directly.
2016-04-08 10:42:48 -07:00
Viktor Lidholt
f8c1d619a6
Fixes spelling in gallery button demo ( #3209 )
2016-04-08 10:24:09 -07:00
Hans Muller
6335872802
Added Scrollbar, removed ScrollbarPainter ( #3203 )
...
* Added Scrollbar, removed ScrollbarPainter
* removed a dead import
* updated per review feedback
* Only call dispatch if the widgets State is still mounted
2016-04-07 16:59:51 -07:00
Viktor Lidholt
b9e121a5fa
New version of Button demo ( #3174 )
2016-04-07 13:08:14 -07:00
Adam Barth
907215df27
Add more dartdoc to material.dart ( #3167 )
...
Also, clean up a few interfaces that looked awkward when writing docs.
2016-04-07 10:03:59 -07:00
Hans Muller
c058cf2e81
Overscroll indicator for MaterialList
...
Overscroll indicator for MaterialList
2016-04-06 16:46:37 -07:00
Ian Hickson
41338c354c
Use Material design rules for capitalisation
...
See https://www.google.com/design/spec/style/writing.html#
2016-04-06 15:59:30 -07:00
Ian Hickson
798dfa2bc9
Fix analyzer warnings
...
Fix some legit uses of GlobalKey to specify the type they want.
Fix some sketchy uses of GlobalKey in tests to fake it with "as
dynamic".
Remove some extraneous imports that made the build red.
2016-04-06 14:14:34 -07:00
Adam Barth
7ab122e557
PopupMenuButton should lazily build menu items
...
Previously, the client of PopupMenuButton needed to build all the menu times
when building the PopupMenuButton. This can get expensive if, for example, each
item in a scrollable list has a popup menu associated with it.
Now the client passes a builder function to the PopupMenuButton that gets
invoked only when its time to show the menu items.
2016-04-06 13:28:09 -07:00
Ian Hickson
d748186c51
Use callbacks for sending messages up the app
...
Using .of() to call mutating setters is not great practice since it ties
parts of the app together in ways that prevent reuse and composition.
Since people are now using the gallery app to copy from, let's use the
better practice of using callbacks.
2016-04-04 15:25:06 -07:00
Hans Muller
08bb332cbb
Merge pull request #3081 from HansMuller/gallery_tweaks
...
Gallery Tweaks
2016-04-04 14:26:23 -07:00
Adam Barth
767ce82646
Add support for discrete material sliders
...
Fixes #1541
2016-04-04 11:14:12 -07:00
Ian Hickson
79cfe1e092
Make a variety of private State members actually private.
2016-04-03 13:08:00 -07:00
Ian Hickson
285c696f14
Column->Block, uppercase BUTTON captions
2016-04-01 21:22:55 -07:00
Ian Hickson
a05909e3a7
Merge pull request #3049 from Hixie/gallery
...
Tweak the typography demo to match the spec more
2016-04-01 14:36:01 -07:00
Viktor Lidholt
4df24abb33
Merge pull request #3016 from vlidholt/linedrawing
...
Initial version of Fancy line drawer demo
2016-03-31 12:05:58 -07:00
Adam Barth
42d87c4191
Rename ToggleControlsDemo to SelectionControlsDemo
...
These are called selection controls in the spec and in the gallery UI.
2016-03-30 23:31:02 -07:00
Viktor Lidholt
a1212dbc54
Initial version of Fancy line drawer demo
2016-03-30 16:56:46 -07:00
Viktor Lidholt
56ccad99a5
Fixes the broken Weather demo
2016-03-30 11:22:43 -07:00
Hans Muller
04e020590d
Use _ScaffoldLayout to position scrollable appbars
2016-03-29 13:27:37 -07:00
Hans Muller
5a49c68893
author again
2016-03-29 08:49:49 -07:00
Adam Barth
1ba539a661
Add constants for FractionalOffsets
...
Adds some names for common FractionalOffset values.
2016-03-28 22:51:06 -07:00
Matt Perry
641604ad94
Merge pull request #2850 from mpcomplete/form
...
Added a Form widget to manage multiple Input widgets.
2016-03-28 13:55:08 -04:00
Adam Barth
7988099162
Fix Travis
...
The collections package changed to add some stricter type annotations.
We now pass those type annoations. I also sent
https://github.com/dart-lang/collection/pull/26 to make the type
annotations match what they were previously.
2016-03-26 00:27:03 -07:00
Matt Perry
a7b28a3ede
Added a Form widget to manage multiple Input widgets.
2016-03-25 17:55:38 -04:00
Viktor Lidholt
d563f50822
First pass at new Flutter gallery front page
2016-03-25 14:11:01 -07:00
Adam Barth
3c6d4f660e
Add a default MediaQuery value
...
Now MediaQuery.of always returns a non-null value. By default, you get the
values associated with the current ui.Window.
Fixes #2894
2016-03-25 13:07:42 -07:00
Ian Hickson
47e882a5a2
Merge pull request #2878 from Hixie/border-style-none
...
Support hairline borders
2016-03-25 09:29:57 -07:00
Adam Barth
1e25792590
Merge pull request #2881 from abarth/from_ltrb
...
Replace EdgeInsets.TRBL with EdgeInsets.fromLTRB
2016-03-24 15:56:44 -07:00
Hans Muller
d89ccc4aad
Scrollbar thumb color, etc
2016-03-24 15:36:17 -07:00
Adam Barth
c8c325d095
Replace EdgeInsets.TRBL with EdgeInsets.fromLTRB
...
This matches the pattern from Rect. I've left EdgeInsets.TRBL marked as
deprecated to give clients a chance to update.
Fixes #2860
2016-03-24 15:19:40 -07:00
Hixie
9fc29dbbb8
Support hairline borders
...
Previously, border with '0' was ambiguous. Sometimes we treated it as
hairline borders, sometimes as "don't show the border", though even in
the latter case we did some graphics work sometimes. Now we have an
explicit BorderStyle.none flag to not draw the border efficiently.
2016-03-24 14:05:38 -07:00
Hans Muller
70550a7a9a
Fix _LazyWidgetProvider indexing, move Ali Connors
2016-03-21 12:20:09 -07:00
Hans Muller
070fdf7754
Flexible AppBar with a TabBar
2016-03-21 10:42:52 -07:00
Adam Barth
502a4ae078
Use FractionalOffset for gradients
...
These were using Offsets, but they're really FractionalOffsets.
Fixes #2318
2016-03-15 19:30:41 -07:00
Hixie
797e27edd3
Add @override annotations to flutter framework
2016-03-14 14:02:26 -07:00
Adam Barth
89987fc040
[rename fixit] TwoLevelSublist left->leading, center->title
2016-03-14 12:24:58 -07:00
Hans Muller
23d7a23e48
Added AppBarBehavior.under, etc
2016-03-14 10:56:59 -07:00
Adam Barth
d5b2e2a01c
[rename fixit] Flex alignments
...
* justifyContent -> mainAxisAlignment
* alignItems -> crossAxisAlignment
* FlexJustifyContent -> MainAxisAlignment
* FlexAlignItems -> CrossAxisAlignment
Fixes #231
2016-03-12 18:33:47 -08:00
Adam Barth
5e1af2f37e
[rename fixit] DismissDirection left -> endToStart, right -> startToEnd
...
Removes an LTR bias in DismissDirection.
Fixes #2562
2016-03-12 18:33:47 -08:00