9578 Commits

Author SHA1 Message Date
Zachary Anderson
824fe4dfcd
[flutter_tool,fuchsia] Add missing dep to flutter_tool (#28346)
Needed for Fuchsia roll.
2019-02-22 14:31:59 -08:00
rami-a
b73dd0e81e
[Material] Add ability to set shadow color and selected shadow color for chips and for chip themes (#28163)
* Add ability to set shadow color for chips and for chip themes

* Add selected shadow color as a property as well

* Update phrasing of documentation

* Address PR feedback
2019-02-22 15:50:39 -05:00
ocavue
0f218e427c Make extended FAB's icon optional (#27711) 2019-02-22 12:47:52 -08:00
Zachary Anderson
ea4cffde60
[fuchsia] Fix paths to find and ls (#28280) 2019-02-22 08:38:02 -08:00
xster
d749e0b573
Add some more CupertinoPicker doc (#28166) 2019-02-21 22:16:29 -08:00
Stanislav Baranov
3837ec9e96
Reland #27754, now that bsdiff has moved to flutter/packages. (#28291) 2019-02-21 21:59:41 -08:00
Dan Field
74a9086037
Revert "Allow for gradle downloading missing SDK assets (#28097)" (#28295)
This reverts commit 6f5e88a59f5ac01fd55b5c3a11b7c2ddc6c7402c.
2019-02-21 16:53:45 -08:00
xster
98455df459
Add slight clarification to debugDeterministicCursor (#27898) 2019-02-21 16:18:42 -08:00
Hans Muller
617ca62709
[Material] Expand BottomNavigationBar API (reprise) (#28159) 2019-02-21 16:05:36 -08:00
Michael Goderbauer
b96ae03b42
Add backgroundColor argument to TextStyle for convenience (#28172) 2019-02-21 15:58:30 -08:00
Dan Field
6f5e88a59f
Allow for gradle downloading missing SDK assets (#28097)
* Allow for gradle downloading missing SDK assets if SDK licenses are present.

* Fix license path for missing sdkmanager

* Cirrus re-run...

* Fix condition check

* rename props, add docs, rename method

* fix tests after param changes

* Fix weird path for flutter run and add tests

* remove print, fix tests
2019-02-21 15:57:20 -08:00
Greg Spencer
b316940051
Fix the length of the valueHelp on the --sample option for the create command, and turn on wrapping. (#28264)
The wrapping for some commands was never actually turned on, so this turns it on.

Also, it shortens the `valueHelp` for the `--sample` option to be just "id" instead of "the sample ID of the desired sample from the API documentation website (http://docs.flutter.io)", which was causing the line to get far too long.

Fixes #23074
2019-02-21 15:56:59 -08:00
Greg Spencer
b45a8f464d
Revert "Remove unused --packages argument to gen_snapshot. (#28101)" (#28265)
This reverts commit 1c021506df23434dd5e881ba0e4d8c5a9f88df8d.

The pre-commit tests never actually ran, so it looked green when it wasn't. This breaks 16 tests that depend on the argument existing, even though it isn't actually used.
2019-02-21 08:47:24 -08:00
Alexandre Ardhuin
5169ab5974
format parameter list (#27261) 2019-02-21 09:27:07 +01:00
Stevie Strickland
1c021506df Remove unused --packages argument to gen_snapshot. (#28101)
This command line argument has already been removed in the main
Dart repository, so building flutter with the latest dart fails.
2019-02-21 09:03:59 +01:00
Jonah Williams
b594cf85fd
Remove extra slash from builder that is not handled on windows (#28027) 2019-02-20 19:56:02 -08:00
Jonah Williams
72b6ed35d0
Remove set literal syntax (#28238) 2019-02-20 19:55:10 -08:00
jslavitz
2c558fdb21
Adds fix for NAN value and pressure values outside of device reported min and max (#26659)
* Fix for nan pressure values and values outside min and max pressure ranges
2019-02-20 16:15:53 -08:00
jslavitz
a5820011b3
Adds media query check in editable_text (#27955)
* media query check
2019-02-20 16:14:48 -08:00
Matt Sullivan
088b6062fd
Added sample code to AnimatedWidget (#27803)
* Added sample to AnimatedWidget

* Updated AnimatedWidget example to use listenable from parent

* Made progress private and changed widget name
2019-02-20 15:50:34 -08:00
Ali EP
307848953f Fixes crossAxisSpacing overflow in RTL (#27945) 2019-02-20 15:43:01 -08:00
Sander Kersten
d1136e3109 Fix issue where SliverPersistentHeader that is both floating and pinned would scroll down when scrolling past the beginning of the ScrollView (#27433) 2019-02-20 15:42:15 -08:00
Michael Goderbauer
655800260a
Add TextOverflow.visible (#28182) 2019-02-20 15:40:25 -08:00
Dan Field
4ed096bd29
Remove json_schema and cli_util deps from flutter_tool (#28040)
* remove json_schema dep

* remove unnecessary pin

* removed unused dep

* remove unused impport

* Fix incorrect condition
2019-02-20 15:38:58 -08:00
xster
e100ddfe26
Rename SuperellipseShare ContinuousRectangleBorder (#28183) 2019-02-20 15:35:22 -08:00
xster
39b1ff1aa3
revert 26001 (#28032) 2019-02-20 15:34:44 -08:00
Kaushik Iska
9931a275b9
Add outer try block for obtainKey errors. Add docs. (#27953)
* Add outer try block for obtainKey errors. Add docs.

* change to // from ///, and do specific error handling

* Add return statement after error

* Add test
2019-02-20 15:31:07 -08:00
Michael Goderbauer
fbafe64fd7
Fix 'to to' (#28216) 2019-02-20 09:57:42 -08:00
Dan Field
dd23be3936
Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560 (#28178)
* Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560

* update goldens

* update goldens version
2019-02-19 21:35:31 -08:00
Stanislav Baranov
20d9de58d0
Revert "Add support for binary compression of dynamic patches by the flutter tool. (#27754)" (#28031)
This reverts commit b47da6c2b79d90f33d73e9225b4b3bbbd0ffd99e.
2019-02-15 18:43:36 -08:00
Dan Field
c90c3a18a2
Reland automatic discovery of observatory port for iOS (#27908)
* Discover port over mDNS 

* Update BUILD.gn for tools
2019-02-15 17:44:55 -08:00
liyuqian
7390cc5cdb
Increase our build budget to 16ms (#27709)
Because we now have 2 separate GPU and UI threads.
2019-02-15 16:12:36 -08:00
KyleWong
f9a6090082 Refactor local engine logic (#27765)
* Refactor for iOS.

* For android_xxx_unopt_arm64&ios_xxx_unopt_arm, remove the _arm64/_arm suffix.
dart generated in host_xxx_unopt/host_xxx has an arch of x86_64 which supports arm64/arm.

* Remove suffixes for various archs.
2019-02-15 15:56:49 -08:00
Hans Muller
19f79ac8da
Add extendBody parameter to Scaffold, body MediaQuery reflects BAB height (#27973) 2019-02-15 14:48:39 -08:00
Jonah Williams
c8c67b79c3
remove accidentally commited libs (#28011) 2019-02-15 11:59:23 -08:00
jslavitz
07fdfb70d3
Fixes switch vibration (#27900)
* Fixes Cupertino switch vibration
2019-02-15 10:55:06 -08:00
Gary Qian
29618f0b04
Roll engine for flutter/engine#7791 - Add trailing whitespace tracking. 2019-02-15 10:28:21 -08:00
Kate Lovett
70dfe01a15
Sample code for Icon class (#27968)
* Added sample code for a simple Icon, ref: #21136

* Removed duplicate line.

* Fixed incoreect parameter.

* Update icon.dart

Removed empty prose and added better context for sample code. Changed sample code for better visibility in execution of default app themes.

* Alas, Trailing space.

Nixed trailing space in comments.
2019-02-15 10:24:14 -08:00
Michael Goderbauer
a4de06ade0
Reapply "Fix overflow clipping/fading for text (#27892)" (#27980)
Fixes https://github.com/flutter/flutter/issues/25025
2019-02-15 09:37:33 -08:00
Todd Volkert
3b47b44348
Re-apply "Ensure all curves return 0 and 1 in .transform(t) when t=0/1" (#28006)
Re-applies #27409 by reverting #27919

The analyzer issue (dart-lang/sdk#35940) has been temporarily
worked around by virtue of #27929
2019-02-15 12:29:09 -05:00
Greg Spencer
262f12b4a9
Remove remaining "## Sample code" segments, and fix the snippet generator. (#27793)
This converts all remaining "## Sample code" segments into snippets, and fixes
the snippet generator to handle multiple snippets in the same dartdoc block
properly.

I also generated, compiled, and ran each of the existing application samples,
and fixed them up to be more useful and/or just run without errors.

This PR fixes these problems with examples:

1. Switching tabs in a snippet now works if there is more than one snippet in
   a single dartdoc block.
2. Generation of snippet code now works if there is more than one snippet.
3. Contrast of text and links in the code sample block has been improved to
   recommended levels.
4. Added five new snippet templates, including a "freeform" template to make
   it possible to show examples that need to change the app instantiation.
5. Fixed several examples to run properly, a couple by adding the "Scaffold"
   widget to the template, a couple by just fixing their code.
6. Fixed visual look of some of the samples when they run by placing many
   samples inside of a Scaffold.
7. In order to make it easier to run locally, changed the sample analyzer to
   remove the contents of the supplied temp directory before running, since
   having files that hang around is problematic (only a problem when running
   locally with the `--temp` argument).
8. Added a `SampleCheckerException` class, and handle sample checking
   exceptions more gracefully.
9. Deprecated the old "## Sample code" designation, and added enforcement for
   the deprecation.
10. Removed unnecessary `new` from templates (although they never appeared in
   the samples thanks to dartfmt, but still).

Fixes #26398
Fixes #27411
2019-02-15 07:48:49 -08:00
Martin Kustermann
7862bef13a
Use double literals where a double type is expected (#27929)
This makes the code more consistent but also fixes our flutter-analyze bot.

Issue https://github.com/dart-lang/sdk/issues/35940
2019-02-15 14:10:55 +01:00
Jonah Williams
67cf21577f
Add basic codegen app to be used for integration testing and benchmarks (#27257) 2019-02-14 23:17:16 -08:00
Jonah Williams
3205736fcf
add ui.Window fallback to TestViewConfiguration (#27987) 2019-02-14 22:49:49 -08:00
Jonah Williams
9bc5656637
Wire dart2js through flutter tool, add compilation test (#27668) 2019-02-14 22:42:30 -08:00
xster
8661d8aecd
Test text paint orders by color (#27983) 2019-02-14 19:19:53 -08:00
xster
22f8880909
Make sure the selection is still painted under the text (#27970) 2019-02-14 16:50:06 -08:00
Anthony
d1371cd269 Do not draw Slider tick marks if they are too dense (#27969) 2019-02-14 16:42:30 -08:00
Michael Goderbauer
d1707ab0ad
Revert "Fix overflow clipping/fading for text (#27892)" (#27966)
This reverts commit 46cabdab22ce59ba06949d666216ae4d10b76761.
2019-02-14 15:15:01 -08:00
KyleWong
e99c881f8d
Don't cache result for homeDirPath. (#27873) 2019-02-14 16:08:26 +08:00