firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
43,399 Commits 1 Branch 0 Tags
Commit Graph

43399 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Zachary Anderson
afb0ac9b50
Move Linux packages_autoroller to bringup (#159336) 
For https://github.com/flutter/flutter/issues/159316
 2024-11-22 17:21:05 +00:00
Dominik Toton
728cedc62a
Fix --web-header flag for flutter drive (#159039) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

This PR makes sure that `--web-header` flag works together with the
`flutter drive` command. Currently the flag is correctly parsed but it
is not properly propagated and ends up being unused when running the web
server for tests.

I have validated the fix by following the steps to reproduce from:
https://github.com/flutter/flutter/issues/159037.

#### Before the fix

No custom HTTP header in test run:
![Screenshot 2024-11-16 at 22 21
36](https://github.com/user-attachments/assets/b3d4e34b-fe2b-4d32-8b0a-2d55e5d23f69)

#### After the fix

Correct HTTP headers in test run:
![Screenshot 2024-11-16 at 22 13
43](https://github.com/user-attachments/assets/b74a41de-69c5-4968-82c0-a08d29a3252d)


Fixes #159037

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-21 20:40:11 +00:00
Jason Simmons
d7f5547ecd
Do a clean shutdown of the flutter_tools processes started by observatory_port_test (#159169) 
Killing the flutter_tools parent process may leak child processes
spawned by the tools.

Also wait for the message indicating that DevTools has started before
stopping flutter_tools. If DevTools has not fully launched, then there
may be a race between DevTools startup and flutter_tools shutdown.

Fixes https://github.com/flutter/flutter/issues/159154
 2024-11-21 19:04:06 +00:00
Ben Konyi
93d772c5cd
Added additional logging to _listCoreDevices (#159275) 
Attempting to collect additional context into the failure outlined in
https://github.com/flutter/flutter/issues/141892
 2024-11-21 18:33:15 +00:00
engine-flutter-autoroll
399403ae6a
Roll Flutter Engine from 78b87f3fe023 to d1a08064e193 (1 revision) (#159280) 
78b87f3fe0...d1a08064e1

2024-11-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
oq6Ztlu1b1mgdDSPH... to zhFzwYCH-N_wasTnM... (flutter/engine#56736)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from oq6Ztlu1b1mg to zhFzwYCH-N_w

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-21 17:54:56 +00:00
Jason Simmons
efe8737ea0
Shut down DevTools and DDS processes if flutter_tools is killed by a signal (#159238) 
See https://github.com/flutter/flutter/issues/159154
 2024-11-21 17:53:57 +00:00
Matan Lurey
c7dd6419d9
Remove RepaintBoundary that is no longer needed. (#159232) 
Closes https://github.com/flutter/flutter/issues/66006.

From what I can tell in the multi-view effort a variation of
https://github.com/flutter/flutter/pull/88609 already landed, meaning
that the current device-pixel-ratio is being used (as the tests in
#88609 are now passing), and I believe that means we can remove the
override/hack.

Will rely on "Google Testing" to run a TGP internally, or do so myself
if necessary.
 2024-11-21 17:50:46 +00:00
Matan Lurey
d1e2c5fba7
Try a speculative fix for Gradle OOMs. (#159234) 
Speculative fix for https://github.com/flutter/flutter/issues/157640.

A few observations:

- I was a bit paranoid about indented files meaning something was parsed
incorrectly
- I removed `android.enableR8=true` (not used elsewhere)
- I removed `android.experimental.enableNewResourceShrinker=true` (not
used elsewhere)
- I matched the rest of the `jvmargs` used in the standard template file

... let's hope this does good things?
 2024-11-21 17:39:13 +00:00
Elliott Brooks
a051be8585
On-device Widget Inspector button exits widget selection (#158219) 
Fixes https://github.com/flutter/devtools/issues/8155

Previously after enabling Widget Selection mode from DevTools and
selecting a widget to inspect, a user would then have to click the
on-device "Select widget" button before being able to select another
widget. This was very confusing to users; we got multiple comments on
our latest DevTools Survey that widget selection mode only worked the
first time and was broken on subsequent selections.

Now, once "Select widget mode" is enabled from DevTools, any subsequent
click is treated as a selection until the user exits from select widget
mode either via DevTools or via the Exit Selection mode button.

The user can re-position the Exit Selection button to either the left or
the right of their device (this way they can select a widget beneath
it).


![exit_select_mode_button](https://github.com/user-attachments/assets/e1170753-ade7-4226-baca-8f07667f0587)


Note: Previously this button was behind any widget selection overlays.
This PR also updates the order of the `Stack` so that exit selection
button is on top.
 2024-11-21 17:12:00 +00:00
engine-flutter-autoroll
4e03220a86
Roll Flutter Engine from 523d381893c8 to 78b87f3fe023 (2 revisions) (#159270) 
523d381893...78b87f3fe0

2024-11-21 mdebbar@google.com [web] Make sure to include all split fonts
(flutter/engine#56733)
2024-11-21 mdebbar@google.com [web] Work around wrong pointerId in
coalesced events in iOS Safari 18.2 (flutter/engine#56719)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-21 16:27:13 +00:00
jesswrd
81d2bf5d79
Remove firebase_abstract_method_smoke_test (#159145) 
Deleted Android embedding smoke test
`firebase_abstract_method_smoke_test`. It is part of v1 embedding
removal cleanup.

This test was marked bringup.

Fixes https://github.com/flutter/flutter/issues/158212

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-21 15:49:32 +00:00
engine-flutter-autoroll
7662e7eae5
Roll Packages from e95f6d8fce58 to 913b99ed8542 (7 revisions) (#159268) 
e95f6d8fce...913b99ed85

2024-11-21 brackenavaron@gmail.com [vector_graphics] handle errors from
bytes loader (flutter/packages#8080)
2024-11-21 82763757+derdilla@users.noreply.github.com [flutter_svg] Fix
SvgNetworkLoader not closing internal http client
(flutter/packages#8126)
2024-11-20 30872003+misos1@users.noreply.github.com
[video_player_avfoundation] send video load failure even when eventsink
was initialized late (flutter/packages#7194)
2024-11-20 kevmoo@users.noreply.github.com [flutter_markdown] enable
Wasm support (flutter/packages#8120)
2024-11-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[url_launcher] Add Swift Package Manager integration to example app
(#8128)" (flutter/packages#8136)
2024-11-20 737941+loic-sharma@users.noreply.github.com [url_launcher]
Add Swift Package Manager integration to example app
(flutter/packages#8128)
2024-11-20 stuartmorgan@google.com [pigeon] Enable example app build in
CI (flutter/packages#8119)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-21 15:43:59 +00:00
engine-flutter-autoroll
1578d7d5f3
Roll Flutter Engine from 69c325513a65 to 523d381893c8 (3 revisions) (#159263) 
69c325513a...523d381893

2024-11-21 55750689+AthulJoseph27@users.noreply.github.com [Flutter GPU]
Added support to set Scissor. (flutter/engine#56302)
2024-11-21 tugorez@users.noreply.github.com Enable view focus
(flutter/engine#54966)
2024-11-21 robert.ancell@canonical.com Allow GTK style enum naming
(flutter/engine#56731)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-21 14:45:09 +00:00
Jonah Williams
f7869a4799
[flutter_tools] opt iOS/macOS apps out of Metal API validation via migrator, update templates in repo. (#159228) 
Setting "enableGPUValidationMode = "1"" disables Metal API validation. I
know, I know.

Fixes https://github.com/flutter/flutter/issues/159227
 2024-11-21 01:36:55 +00:00
Justin McCandless
b473698019
Scribe Android handwriting text input (#148784) 
Enables the Scribe feature, or Android stylus handwriting text input.


![scribe](https://github.com/flutter/flutter/assets/389558/25a54ae9-9399-4772-8482-913ec7a9b330)

This PR only implements basic handwriting input. Other features will be
done in subsequent PRs:

 * https://github.com/flutter/flutter/issues/155948
 * https://github.com/flutter/flutter/issues/156018

I created and fixed issue about stylus hovering while working on this:
https://github.com/flutter/flutter/issues/148810

Original PR for iOS Scribble, the iOS version of this feature:
https://github.com/flutter/flutter/pull/75472
FYI @fbcouch 

~~Depends on https://github.com/flutter/engine/pull/52943~~ (merged).

Fixes https://github.com/flutter/flutter/issues/115607

<details>

<summary>Example code I'm using to test this feature (but any TextField
works)</summary>

```dart
import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';
import 'package:flutter/services.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final FocusNode _focusNode1 = FocusNode();
  final FocusNode _focusNode2 = FocusNode();
  final FocusNode _focusNode3 = FocusNode();
  final TextEditingController _controller3 = TextEditingController(
    text: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.',
  );

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Scribe demo'),
      ),
      body: Center(
        child: Padding(
          padding: const EdgeInsets.symmetric(horizontal: 74.0),
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              TextField(
                focusNode: _focusNode1,
                autofocus: false,
              ),
              TextField(
                focusNode: _focusNode2,
              ),
              TextField(
                focusNode: _focusNode3,
                minLines: 4,
                maxLines: 4,
                controller: _controller3,
              ),
              TextButton(
                onPressed: () {
                  _focusNode1.unfocus();
                  _focusNode2.unfocus();
                  _focusNode3.unfocus();
                },
                child: const Text('Unfocus'),
              ),
              TextButton(
                onPressed: () {
                  _focusNode1.requestFocus();
                  SchedulerBinding.instance.addPostFrameCallback((Duration _) {
                    SystemChannels.textInput.invokeMethod('TextInput.hide');
                  });
                },
                child: const Text('Focus 1'),
              ),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

---------

Co-authored-by: Nate Wilson <nate.w5687@gmail.com>
 2024-11-21 01:33:14 +00:00
Matan Lurey
5ead4e15a7
Terminate non-detached test devices on flutter run completion (#159170) 
See https://github.com/flutter/flutter/issues/159154.
See https://github.com/flutter/flutter/pull/159169.

Before this PR, it appeared we were accidentally leaking (keeping
active) `flutter_tester` instances (or any test device) after `flutter
run` completion, even if the runner was not explicitly detached. I
_think_ this is a bug, but I'll check with the tools team and possibly
@jonahwilliams before finalizing this.

/cc @jason-simmons

---------

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
 2024-11-21 01:21:25 +00:00
Matan Lurey
1d24fa8f60
Un-skip tests that use flutter build apk. (#159231) 
Closes https://github.com/flutter/flutter/issues/158560.

I believe but am not sure as of
https://github.com/flutter/flutter/pull/159170 merging, many process
flakes that were consuming memory and in turn, making Gradle
particularly sensitive to timing out or being killing by the OS for
low-memory, have been rectified.

It is possible there are additional problems, but they aren't visible at
the moment.

I'd like to re-enable these and keep tracking their stability.
 2024-11-21 01:13:50 +00:00
engine-flutter-autoroll
17e38a4b78
Roll Flutter Engine from 2d32cf3a7971 to 69c325513a65 (1 revision) (#159229) 
2d32cf3a79...69c325513a

2024-11-20 dkwingsmt@users.noreply.github.com Fix: Impeller playground's
shapes should react to controllers (flutter/engine#56734)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-20 23:30:38 +00:00
engine-flutter-autoroll
364e4be816
Roll Flutter Engine from 3828681d1f86 to 2d32cf3a7971 (3 revisions) (#159226) 
3828681d1f...2d32cf3a79

2024-11-20 flar@google.com [DisplayList] migrate DlImageFilter code to
Impeller geometry classes (flutter/engine#56720)
2024-11-20 robert.ancell@canonical.com Split channel messaging out of
handlers (flutter/engine#56667)
2024-11-20 jason-simmons@users.noreply.github.com Revert "Added assert
for opengles thread safety (#56585)" (flutter/engine#56730)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-20 22:10:10 +00:00
engine-flutter-autoroll
53bd6435ae
Roll Flutter Engine from 3245c8976976 to 3828681d1f86 (1 revision) (#159217) 
3245c89769...3828681d1f

2024-11-20 dacoharkes@google.com [et] Add Android x64 configurations
(flutter/engine#56703)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-20 21:12:13 +00:00
Matan Lurey
bf36437cae
Add --dry-run to dev/bots/test.dart. (#158956) 
Closes https://github.com/flutter/flutter/issues/158884.

/cc @reidbaker.

Example output:

```sh
% SHARD=tool_integration_tests SUBSHARD=6_6 dart dev/bots/test.dart --dry-run 
▌13:59:18▐ STARTING ANALYSIS
▌13:59:18▐ --dry-run enabled. Tests will not actually be executed.
▌13:59:18▐ SHARD=tool_integration_tests
▌13:59:18▐ SUBSHARD=6_6
▌13:59:18▐ |> bin/flutter: 
  --version
▌13:59:18▐ |> bin/cache/dart-sdk/bin/dart (packages/flutter_tools): 
  run
  test
  --reporter=expanded
  --file-reporter=json:/var/folders/qw/qw_3qd1x4kz5w975jhdq4k58007b7h/T/metrics_1731621558619861.json
  --test-randomize-ordering-seed=20241114
  -j1
  test/integration.shard/shader_compiler_test.dart
  test/integration.shard/overall_experience_test.dart
  test/integration.shard/expression_evaluation_test.dart
  test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart
  test/integration.shard/isolated/native_assets_test.dart
  test/integration.shard/isolated/native_assets_agp_version_test.dart
  test/integration.shard/coverage_collection_test.dart
  test/integration.shard/devtools_uri_test.dart
  test/integration.shard/deprecated_gradle_settings_test.dart
  test/integration.shard/batch_entrypoint_test.dart
  test/integration.shard/bash_entrypoint_test.dart
  test/integration.shard/background_isolate_test.dart
```
 2024-11-20 21:01:54 +00:00
Gray Mackall
f2446f2dfb
Add docs for setting up Android Studio to auto format Kotlin code (#159209) 
Docs to make Android Studio auto format kotlin code in a way compatible
with the format check that we make in CI.

Open to suggestions as to a better place to put them, but there wasn't
an existing doc that seemed like an obvious fit to me.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
Co-authored-by: Reid Baker <hamilton.reid.baker@gmail.com>
 2024-11-20 20:58:39 +00:00
engine-flutter-autoroll
ae9c8e8e2e
Roll Flutter Engine from 80d77505fdde to 3245c8976976 (1 revision) (#159214) 
80d77505fd...3245c89769

2024-11-20 jonahwilliams@google.com [Impeller] flush all GLES cmd
buffers together. (flutter/engine#56724)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-20 19:42:36 +00:00
StanleyCocos
3f1ea760e8
Fix: The enableFeedback property of InkWell cannot be set to a nullab… (#158907) 
*I found that enableFeedback can be set to null, but in actual use,
setting it to null has no effect and is overwritten by true. I think
this is an issue.*


```dart
class InkWell extends InkResponse {
  const InkWell({
    super.key,
    super.child,
    super.onTap,
    super.onDoubleTap,
    super.onLongPress,
    super.onTapDown,
    super.onTapUp,
    super.onTapCancel,
    super.onSecondaryTap,
    super.onSecondaryTapUp,
    super.onSecondaryTapDown,
    super.onSecondaryTapCancel,
    super.onHighlightChanged,
    super.onHover,
    super.mouseCursor,
    super.focusColor,
    super.hoverColor,
    super.highlightColor,
    super.overlayColor,
    super.splashColor,
    super.splashFactory,
    super.radius,
    super.borderRadius,
    super.customBorder,
    bool? enableFeedback = true,
    super.excludeFromSemantics,
    super.focusNode,
    super.canRequestFocus,
    super.onFocusChange,
    super.autofocus,
    super.statesController,
    super.hoverDuration,
  }) : super(
    containedInkWell: true,
    highlightShape: BoxShape.rectangle,
    enableFeedback: enableFeedback ?? true,
  );
}
```

Call Error
```dart
InkWell(
    enableFeedback: null,
)
```
 2024-11-20 19:23:24 +00:00
engine-flutter-autoroll
1894436ec3
Roll Flutter Engine from 3f19207e820e to 80d77505fdde (1 revision) (#159210) 
3f19207e82...80d77505fd

2024-11-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
dJ0gh-z1KVnSzvfjW... to oq6Ztlu1b1mgdDSPH... (flutter/engine#56728)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from dJ0gh-z1KVnS to oq6Ztlu1b1mg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-20 18:29:12 +00:00
engine-flutter-autoroll
1c79e33741
Roll Packages from fc4adc78aa24 to e95f6d8fce58 (6 revisions) (#159201) 
fc4adc78aa...e95f6d8fce

2024-11-19 louisehsu@google.com [in_app_purchase_storekit] disallow ios
versions lower than supported from enabling storekit
(flutter/packages#8110)
2024-11-19 49699333+dependabot[bot]@users.noreply.github.com
[interactive_media_ads]: Bump
com.google.ads.interactivemedia.v3:interactivemedia from 3.35.1 to
3.36.0 in /packages/interactive_media_ads/android
(flutter/packages#8046)
2024-11-19 49699333+dependabot[bot]@users.noreply.github.com
[interactive_media_ads]: Bump androidx.annotation:annotation from 1.8.2
to 1.9.1 in /packages/interactive_media_ads/android
(flutter/packages#7980)
2024-11-19 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_android] Updates plugin to use `ProxyApis`s
(flutter/packages#7794)
2024-11-19 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds support to define parameters that control
the rendering of ads (flutter/packages#8057)
2024-11-19 engine-flutter-autoroll@skia.org Roll Flutter from
b3818f6b5979 to 8536b96ebb3e (22 revisions) (flutter/packages#8124)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-20 15:44:31 +00:00
Martin Kustermann
e2d8121708
Remove dependency on [Target] and instead operate on [Architecture] (#159196) 
The dart-lang/native repository contains a `Target` class that is almost
not needed anymore. The remaining uses are mainly due to kernel asset
mapping (which we may be able to remove in the future).

This PR removes usages of that `Target` (in favor of `Architecture`)
class in most places in flutter tools.
This makes the code also cleaner because we no longer have an implicit
assumption that
a `List<Target>` all belong to the same operating system.
 2024-11-20 12:44:43 +00:00
HongeSun
15a03a4ada
Fix git command in Quality-Assurance.md (#155146) 
Correct the Quality-Assurance contributing doc's wrong git command.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-11-20 06:32:04 +00:00
engine-flutter-autoroll
0234757554
Roll Flutter Engine from 7eb87547cbc6 to 3f19207e820e (4 revisions) (#159176) 
7eb87547cb...3f19207e82

2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from d776efdac21b to
2614590b4f32 (1 revision) (flutter/engine#56718)
2024-11-19 chris@bracken.jp TestMetalContext: Use ARC-managed Metal
types (flutter/engine#56717)
2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from a694b9e85a49 to
d776efdac21b (3 revisions) (flutter/engine#56716)
2024-11-19 skia-flutter-autoroll@skia.org Roll Dart SDK from
b01654fa26c7 to dde57dc75c15 (3 revisions) (flutter/engine#56714)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-20 00:21:22 +00:00
Matan Lurey
1fdcb757fd
Make runner non-nullable as it always is. (#159156) 2024-11-20 00:11:39 +00:00
Taha Tesser
1686fa7eb4
Update Material 3 CircularProgressIndicator for new visual style (#158104) 
Related [Update both `ProgressIndicator` for Material 3
redesign](https://github.com/flutter/flutter/issues/141340)
Fixes [Issue: Cannot theme progress indicators, many properties
missing](https://github.com/flutter/flutter/issues/131690)
Fixes [Cannot override default `CircularProgressIndicator`
size](https://github.com/flutter/flutter/issues/158106)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
          // progressIndicatorTheme: const ProgressIndicatorThemeData(
          //   constraints: BoxConstraints.tightFor(width: 100, height: 100),
          //   strokeWidth: 12
          // ),
          ),
      home: Scaffold(
        appBar: AppBar(title: const Text('CircularProgressIndicator')),
        body: const Center(
          child: Row(
            mainAxisAlignment: MainAxisAlignment.spaceEvenly,
            children: [
              CircularProgressIndicator(year2023: false, value: 0.5),
              CircularProgressIndicator(year2023: false),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

### Preview 

<img width="579" alt="Screenshot 2024-11-04 at 16 01 57"
src="https://github.com/user-attachments/assets/d27768c6-5570-48d0-9eed-565e02be8041">

### New custom `CircularProgressIndicator.constraints` and stroke  width

<img width="579" alt="Screenshot 2024-11-04 at 16 02 40"
src="https://github.com/user-attachments/assets/c67c4a31-58f4-4f82-bfb6-f1b78a000bac">


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 23:23:26 +00:00
engine-flutter-autoroll
a1c7a0dda4
Roll Flutter Engine from 4ff696b555dc to 7eb87547cbc6 (3 revisions) (#159168) 
4ff696b555...7eb87547cb

2024-11-19 chris@bracken.jp EmbedderTest: templatise GetEmbedderContext
(flutter/engine#56709)
2024-11-19 chris@bracken.jp display_list: Extract backend-specific
surface providers (flutter/engine#56711)
2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 78ef6b7a574f to
a694b9e85a49 (5 revisions) (flutter/engine#56713)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 21:55:12 +00:00
Jenn Magder
c12f75066d
Add platform-android label for all flutter_tools *android* files (#159166) 
Label PRs that touch any `*android*` files in flutter_tool with
`platform-android`. In particular this should catch the template android
directories.

Labeler log:
https://github.com/flutter/flutter/actions/runs/11921551623/job/33225914301?pr=159166#step:2:240

<details>

<summary>Included files</summary>

```
$ git ls-files 'packages/flutter_tools/*android**'
packages/flutter_tools/ide_templates/intellij/dev/manual_tests/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/flutter_gallery/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/hello_world/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/platform_channel/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/platform_view/android.iml.copy.tmpl
packages/flutter_tools/ide_templates/intellij/examples/stocks/android.iml.copy.tmpl
packages/flutter_tools/lib/src/android/README.md
packages/flutter_tools/lib/src/android/adb.dart
packages/flutter_tools/lib/src/android/android.dart
packages/flutter_tools/lib/src/android/android_builder.dart
packages/flutter_tools/lib/src/android/android_console.dart
packages/flutter_tools/lib/src/android/android_device.dart
packages/flutter_tools/lib/src/android/android_device_discovery.dart
packages/flutter_tools/lib/src/android/android_emulator.dart
packages/flutter_tools/lib/src/android/android_sdk.dart
packages/flutter_tools/lib/src/android/android_studio.dart
packages/flutter_tools/lib/src/android/android_studio_validator.dart
packages/flutter_tools/lib/src/android/android_workflow.dart
packages/flutter_tools/lib/src/android/application_package.dart
packages/flutter_tools/lib/src/android/build_validation.dart
packages/flutter_tools/lib/src/android/deferred_components_gen_snapshot_validator.dart
packages/flutter_tools/lib/src/android/deferred_components_prebuild_validator.dart
packages/flutter_tools/lib/src/android/deferred_components_validator.dart
packages/flutter_tools/lib/src/android/gradle.dart
packages/flutter_tools/lib/src/android/gradle_errors.dart
packages/flutter_tools/lib/src/android/gradle_utils.dart
packages/flutter_tools/lib/src/android/java.dart
packages/flutter_tools/lib/src/android/migrations/android_studio_java_gradle_conflict_migration.dart
packages/flutter_tools/lib/src/android/migrations/cmake_android_16k_pages_migration.dart
packages/flutter_tools/lib/src/android/migrations/min_sdk_version_migration.dart
packages/flutter_tools/lib/src/android/migrations/multidex_removal_migration.dart
packages/flutter_tools/lib/src/android/migrations/top_level_gradle_build_file_migration.dart
packages/flutter_tools/lib/src/build_system/targets/android.dart
packages/flutter_tools/lib/src/commands/android_analyze.dart
packages/flutter_tools/lib/src/isolated/native_assets/android/native_assets.dart
packages/flutter_tools/templates/app_shared/android-java.tmpl/app/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-java.tmpl/app/src/main/java/androidIdentifier/MainActivity.java.tmpl
packages/flutter_tools/templates/app_shared/android-java.tmpl/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-java.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/app/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/app/src/main/kotlin/androidIdentifier/MainActivity.kt.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/build.gradle.kts.tmpl
packages/flutter_tools/templates/app_shared/android-kotlin.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/.gitignore
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/debug/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/drawable-v21/launch_background.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/drawable/launch_background.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-hdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-mdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-xhdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-xxhdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/values-night/styles.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/main/res/values/styles.xml
packages/flutter_tools/templates/app_shared/android.tmpl/app/src/profile/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/gradle.properties.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/gradle/wrapper/gradle-wrapper.properties.tmpl
packages/flutter_tools/templates/app_shared/android.tmpl/settings.gradle.kts.tmpl
packages/flutter_tools/templates/module/android/deferred_component/build.gradle.tmpl
packages/flutter_tools/templates/module/android/deferred_component/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/gradle/build.gradle.tmpl
packages/flutter_tools/templates/module/android/gradle/gradle.properties.tmpl
packages/flutter_tools/templates/module/android/gradle/settings.gradle.tmpl
packages/flutter_tools/templates/module/android/gradle/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/java/androidIdentifier/host/MainActivity.java.tmpl
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/res/drawable/launch_background.xml
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/res/mipmap-hdpi/ic_launcher.png
packages/flutter_tools/templates/module/android/host_app_common/app.tmpl/src/main/res/values/styles.xml
packages/flutter_tools/templates/module/android/host_app_editable/settings.gradle.copy.tmpl
packages/flutter_tools/templates/module/android/host_app_ephemeral/settings.gradle.copy.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/Flutter.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/Flutter.tmpl/flutter.iml.copy.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/Flutter.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/include_flutter.groovy.copy.tmpl
packages/flutter_tools/templates/module/android/library_new_embedding/settings.gradle.copy.tmpl
packages/flutter_tools/templates/module/common/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/src/main/java/androidIdentifier/pluginClass.java.tmpl
packages/flutter_tools/templates/plugin/android-java.tmpl/src/test/java/androidIdentifier/pluginClassTest.java.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/src/main/kotlin/androidIdentifier/pluginClass.kt.tmpl
packages/flutter_tools/templates/plugin/android-kotlin.tmpl/src/test/kotlin/androidIdentifier/pluginClassTest.kt.tmpl
packages/flutter_tools/templates/plugin/android.tmpl/.gitignore
packages/flutter_tools/templates/plugin/android.tmpl/settings.gradle.tmpl
packages/flutter_tools/templates/plugin/android.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/templates/plugin_ffi/android.tmpl/build.gradle.tmpl
packages/flutter_tools/templates/plugin_ffi/android.tmpl/projectName_android.iml.tmpl
packages/flutter_tools/templates/plugin_shared/android.tmpl/.gitignore
packages/flutter_tools/templates/plugin_shared/android.tmpl/settings.gradle.tmpl
packages/flutter_tools/templates/plugin_shared/android.tmpl/src/main/AndroidManifest.xml.tmpl
packages/flutter_tools/test/android_java11_integration.shard/android_dependency_version_checking_test.dart
packages/flutter_tools/test/android_preview_integration.shard/README.md
packages/flutter_tools/test/android_preview_integration.shard/flutter_build_preview_sdk_test.dart
packages/flutter_tools/test/commands.shard/hermetic/android_analyze_test.dart
packages/flutter_tools/test/general.shard/android/adb_log_reader_test.dart
packages/flutter_tools/test/general.shard/android/android_device_discovery_test.dart
packages/flutter_tools/test/general.shard/android/android_device_port_forwarder_test.dart
packages/flutter_tools/test/general.shard/android/android_device_start_test.dart
packages/flutter_tools/test/general.shard/android/android_device_test.dart
packages/flutter_tools/test/general.shard/android/android_emulator_test.dart
packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart
packages/flutter_tools/test/general.shard/android/android_install_test.dart
packages/flutter_tools/test/general.shard/android/android_project_migration_test.dart
packages/flutter_tools/test/general.shard/android/android_sdk_test.dart
packages/flutter_tools/test/general.shard/android/android_studio_test.dart
packages/flutter_tools/test/general.shard/android/android_studio_validator_test.dart
packages/flutter_tools/test/general.shard/android/android_workflow_test.dart
packages/flutter_tools/test/general.shard/android/build_validation_test.dart
packages/flutter_tools/test/general.shard/android/deferred_components_gen_snapshot_validator_test.dart
packages/flutter_tools/test/general.shard/android/deferred_components_prebuild_validator_test.dart
packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart
packages/flutter_tools/test/general.shard/android/gradle_find_bundle_test.dart
packages/flutter_tools/test/general.shard/android/gradle_test.dart
packages/flutter_tools/test/general.shard/android/gradle_utils_test.dart
packages/flutter_tools/test/general.shard/android/java_test.dart
packages/flutter_tools/test/general.shard/android/migration/cmake_android_16k_pages_migration_test.dart
packages/flutter_tools/test/general.shard/android/template_test.dart
packages/flutter_tools/test/general.shard/android_plugin_test.dart
packages/flutter_tools/test/general.shard/build_system/targets/android_test.dart
packages/flutter_tools/test/general.shard/isolated/android/native_assets_test.dart
packages/flutter_tools/test/integration.shard/android_e2e_api_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_daemon_cache_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_deprecated_plugin_apply_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_flutter_source_path_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_java_version_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_legacy_flutter_plugins_strings_in_comments_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_outputs_app_link_settings_test.dart
packages/flutter_tools/test/integration.shard/android_gradle_print_build_variants_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_compilesdkversion_mismatch_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_example_app_build_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_ndkversion_mismatch_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_new_output_dir_test.dart
packages/flutter_tools/test/integration.shard/android_plugin_skip_unsupported_test.dart
packages/flutter_tools/test/integration.shard/flutter_build_android_app_project_builddir_test.dart
packages/flutter_tools/test/integration.shard/gradle_non_android_plugin_test.dart
packages/flutter_tools/test/src/android_common.dart
```

</details>

Expand https://github.com/flutter/flutter/pull/158970

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 21:53:38 +00:00
engine-flutter-autoroll
79c5ae0c7a
Roll Flutter Engine from d5820a638885 to 4ff696b555dc (1 revision) (#159164) 
d5820a6388...4ff696b555

2024-11-19 47866232+chunhtai@users.noreply.github.com Update
Engine-Clang-Tidy-Linter.md (flutter/engine#56708)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 20:51:18 +00:00
Bernardo Ferrari
1fdb159d11
Reland Add UI Benchmarks (#153368) 
Reland https://github.com/flutter/flutter/pull/143799 which is part 1 of
https://github.com/flutter/flutter/pull/138481 and
https://github.com/flutter/flutter/issues/146211.

Could someone run this in device-lab so we are 100% sure it works? I
don't know if it was a flake or what last time. Locally it works well.
 2024-11-19 20:47:15 +00:00
Mohellebi abdessalem
f0dc0b798f
fix lint usage of task inside resolve_dependecies.gradle file (#158022) 
according to
[Gradle](https://docs.gradle.org/current/userguide/task_configuration_avoidance.htmll)
:`As of Gradle 5.1, we recommend that the configuration avoidance APIs
be used whenever tasks are created.`

![writing-tasks-4](https://github.com/user-attachments/assets/407c79bb-7bfa-4bea-9b13-dec01c60dc1c)
what android studio lint is failing ?
![Capture d’écran 2024-11-01
214856](https://github.com/user-attachments/assets/af745305-6310-406c-b427-fb8a5dd5755c)


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 20:32:05 +00:00
engine-flutter-autoroll
41006014ab
Roll Flutter Engine from cff1e751f853 to d5820a638885 (5 revisions) (#159155) 
cff1e751f8...d5820a6388

2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 0b74a1bb1b55 to
78ef6b7a574f (6 revisions) (flutter/engine#56707)
2024-11-19 chris@bracken.jp Move renderer config to EmbedderTestContext
(flutter/engine#56699)
2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 8a1a84509501 to
0b74a1bb1b55 (1 revision) (flutter/engine#56702)
2024-11-19 skia-flutter-autoroll@skia.org Roll Dart SDK from
05d58364e92f to b01654fa26c7 (1 revision) (flutter/engine#56694)
2024-11-19 chris@bracken.jp EmbedderTest: Eliminate unused include
(flutter/engine#56698)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 19:38:09 +00:00
Mohellebi abdessalem
1d01955721
Removing redundant backticks in flutter\packages\flutter_tools\gradle\gradle.kts (#159051) 
`what android studio lint is failing ?`

![Capture d’écran 2024-11-19
110315](https://github.com/user-attachments/assets/d86605f6-0060-4721-9233-09d8ec5774d4)

![Capture d’écran 2024-11-19
110338](https://github.com/user-attachments/assets/7ee7465e-7a06-43db-bebb-ca87dda3cdc8)
see #147122
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 19:32:22 +00:00
Mairramer
fc53c71381
Fixes initial validation with AutovalidateMode.always on first build (#156708) 
Fixes #142701
This PR fixes an issue where on the first build
`AutovalidateMode.always` was not called.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 19:11:00 +00:00
Taha Tesser
56cfef73fc
Introduce new Material 3 Slider shapes (#152237) 
fixes [Update `Slider` for Material 3
redesign](https://github.com/flutter/flutter/issues/141842)
previous implementation https://github.com/flutter/flutter/pull/147783

### Description

This PR introduces new Material 3 Slider design. 

### Slider Preview

<img width="912" alt="Screenshot 2024-07-24 at 16 38 11"
src="https://github.com/user-attachments/assets/9645ff6c-b72a-40aa-ae95-4f76994f8302">

<img width="912" alt="Screenshot 2024-07-24 at 16 38 24"
src="https://github.com/user-attachments/assets/fbaed8bb-2717-43a9-9415-ea1365165d9a">

### Value indicator Preview



https://github.com/user-attachments/assets/45fa001c-de81-433a-a8e9-6c0d6a2335c0

### New stop indicator



https://github.com/user-attachments/assets/ad05621d-042d-4b17-9dbb-7f7b802a2593


### Customized 

<img width="912" alt="Screenshot 2024-07-24 at 16 41 49"
src="https://github.com/user-attachments/assets/2f279240-5af8-4bc8-9c65-a4b4ac718101">



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 19:10:44 +00:00
Matan Lurey
8536b96ebb
Terminate flutter test when no longer needed in integration test. (#159117) 
Towards https://github.com/flutter/flutter/issues/51421.

```sh
flutter_tools % dart test test/integration.shard/break_on_framework_exceptions_test.dart

02:38 +29: All tests passed!

54692 ttys003    0:00.02 /opt/homebrew/bin/zsh -il
```

Requires https://github.com/flutter/flutter/pull/159115 for the process
cleanup to work properly, but this is safe to land as-is, otherwise we
still accumulate `flutter` processes over and over as each test case
runs which is not WAI.
 2024-11-19 16:16:08 +00:00
Matan Lurey
c5379557b3
Terminate the test device if the flutter tool is signal-killed. (#159115) 
Closes https://github.com/flutter/flutter/issues/20949.

Signals (such as SIGTERM or SIGKILL) end up flowing through
`exitWithHooks`, which in turn, after running hooks, call `exit().` That
means, as a result, any `try { } finally { }` guarded execution may
_not_ run, which happens to also be how `flutter_tester` instances are
cleaned up if they have not terminated.

This PR adds in-progress `flutter_tester` runs (or any platform
`flutter_platform` supports) to the shutdown hooks, guaranteeing that
the finalizers (which in turn, kill the process) are _always_ executed
as long as either the test completes, _or_ `exitWithHooks` is called.

The existing integration tests (`integration.shard/test_test.dart`)
still pass as well.
 2024-11-19 16:10:32 +00:00
engine-flutter-autoroll
0e1c6330ea
Roll Packages from c1eabf5e32cc to fc4adc78aa24 (10 revisions) (#159143) 
c1eabf5e32...fc4adc78aa

2024-11-18 magder@google.com [ci] Take screenshot when native drive test
is taking longer than 10 minutes (flutter/packages#8050)
2024-11-18 jessiewong401@gmail.com Applied Gradle Plugins Declaratively
for Most Remaining Plugin Example Apps (Part 3) (flutter/packages#8037)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 2.0.21 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7867)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump androidx.test.ext:junit-ktx from 1.1.5 to 1.2.1 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#8097)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.20 to 2.0.21 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7869)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [gradle]:
Bump org.hamcrest:hamcrest from 2.2 to 3.0 in /packages/espresso/android
(flutter/packages#8092)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com [pigeon]:
Bump io.mockk:mockk from 1.13.12 to 1.13.13 in
/packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#7868)
2024-11-18 49699333+dependabot[bot]@users.noreply.github.com
[shared_pref]: Bump io.mockk:mockk from 1.13.12 to 1.13.13 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#7866)
2024-11-18 magder@google.com Add autosubmit label to dependabot PRs
(flutter/packages#8101)
2024-11-18 engine-flutter-autoroll@skia.org Roll Flutter from
0e2d55e0e7b2 to b3818f6b5979 (23 revisions) (flutter/packages#8118)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 15:44:31 +00:00
Reid Baker
eea2fe7781
Deflake api 35 emulator tests by updating emulator definitions version to latest available from chrome infra (#158017) 
Update to the latest definitions of emulator configurations.

Specifically to past https://crrev.com/c/5908894 which added `gpu_mode:
"swangle_indirect"` to the api 35 proto. This should help with emulator
stability on versions past android 13.
Related to  b/371020223
Related: https://github.com/flutter/engine/pull/56313 
Research notes / my findings for how this system works at
go/flutter-android-ci-emulator
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
 2024-11-19 15:35:58 +00:00
engine-flutter-autoroll
87872a6095
Roll Flutter Engine from b6723e33b858 to cff1e751f853 (1 revision) (#159141) 
b6723e33b8...cff1e751f8

2024-11-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
io00npG_eDCYC7bac... to dJ0gh-z1KVnSzvfjW... (flutter/engine#56701)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from io00npG_eDCY to dJ0gh-z1KVnS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 14:57:28 +00:00
Bruno Leroux
043c59b075
Fix InkWell overlayColor resolution ignores selected state (#159072) 
## Description

This PR fixes `InkWell` overlay colors resolution.
The `InkWell` overlay color is resolved when the `InkWell` is either
focused, hovered , and/or pressed.
This resolution happens at two places:
- first when the highlight is created.
- then on each build, using the inner function named
`getHighlightColorForType`.
This second resolution should be aware of other current states (such as
selected) as it might impact the color resolution.

For instance, several Material styles have colors resolution define
similarly to:

dc44547d0d/packages/flutter/lib/src/material/date_picker_theme.dart (L982-L1006)

## Related Issue

Fixes [InkWell overlay colors aren't applied on MaterialState.selected
state](https://github.com/flutter/flutter/issues/159063)
First step for [Date picker overlay colors aren't applied on
MaterialState.selected state](Date picker overlay colors aren't applied
on MaterialState.selected state).

## Tests

Adds 3 tests.
 2024-11-19 11:33:40 +00:00
engine-flutter-autoroll
966aeb28ea
Roll Flutter Engine from 983b7b85d122 to b6723e33b858 (3 revisions) (#159134) 
983b7b85d1...b6723e33b8

2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 17601e471acf to
8a1a84509501 (4 revisions) (flutter/engine#56700)
2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 8d652f142911 to
17601e471acf (1 revision) (flutter/engine#56696)
2024-11-19 robert.ancell@canonical.com Add missing cancellable to text
input handler (flutter/engine#56666)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 09:17:26 +00:00
engine-flutter-autoroll
57dca6946d
Roll Flutter Engine from c1b0e18a70b3 to 983b7b85d122 (2 revisions) (#159124) 
c1b0e18a70...983b7b85d1

2024-11-19 lhkbob@gmail.com Remove SK_USE_LEGACY_BLUR_RASTER staging
flag (flutter/engine#56618)
2024-11-19 skia-flutter-autoroll@skia.org Roll Skia from 492e8347d7a4 to
8d652f142911 (1 revision) (flutter/engine#56693)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 04:22:04 +00:00
engine-flutter-autoroll
4426413ec6
Roll Flutter Engine from 878f593802e1 to c1b0e18a70b3 (13 revisions) (#159118) 
878f593802...c1b0e18a70

2024-11-19 jonahwilliams@google.com [Impeller] use sync fence for image
uploads. (flutter/engine#56609)
2024-11-18 reidbaker@google.com Update emulator definitions version to
latest available from chrome infra (flutter/engine#56313)
2024-11-18 skia-flutter-autoroll@skia.org Roll Dart SDK from
625e0a9cb67a to 05d58364e92f (1 revision) (flutter/engine#56688)
2024-11-18 chris@bracken.jp iOS: Eliminate unguarded-availability
opt-out (flutter/engine#56689)
2024-11-18 jacksongardner@google.com [skwasm] Use
`displayWidth`/`displayHeight` instead of `codedWidth`/`codedHeight`
(flutter/engine#56686)
2024-11-18 chris@bracken.jp Extract TestGLContext to separate
translation unit (flutter/engine#56647)
2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from b79e71223284 to
492e8347d7a4 (2 revisions) (flutter/engine#56687)
2024-11-18 jason-simmons@users.noreply.github.com Update the Skia build
scripts for a refactoring of the Fontconfig font manager
(flutter/engine#56684)
2024-11-18 chris@bracken.jp iOS,macOS: Enable ARC in
flutter_cflags_objc[c] (flutter/engine#56685)
2024-11-18 matanlurey@users.noreply.github.com Re-land "Remove
`android_jit_release_x86`." (flutter/engine#56681)
2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 0d24bd3268ef to
b79e71223284 (1 revision) (flutter/engine#56683)
2024-11-18 tugorez@users.noreply.github.com Flutter views can gain focus
(flutter/engine#54985)
2024-11-18 skia-flutter-autoroll@skia.org Roll Skia from 0b74d5c3eb4f to
0d24bd3268ef (1 revision) (flutter/engine#56680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-19 02:08:20 +00:00
Loïc Sharma
6b6f481f19
[SwiftPM] Move where the migration checks feature flags (#159110) 
Previously, the Swift Package Manager app migration would only be
registered if the feature was on.

Now, the Swift Package Manager app migration is always registered but
only runs if the SwiftPM feature is on. This change will make it easier
to introduce a separate feature flag for just the SwiftPM app migration.

This is a refactoring with no semantic change.

Part of https://github.com/flutter/flutter/issues/151567

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-19 01:23:08 +00:00