Andrew Kolos
c9eb4ae9cc
remove bringup status for recently re-subsharded targets ( #158217 )
...
Cleans up https://github.com/flutter/flutter/pull/158196 and https://github.com/flutter/flutter/pull/158146
<details>
<summary> Pre-launch checklist </summary>
</details>
2024-11-10 21:49:24 +00:00
engine-flutter-autoroll
286eb1303c
Roll Flutter Engine from 690cdfd09beb to 9b4c3b3d5518 (1 revision) ( #158418 )
...
690cdfd09b...9b4c3b3d55jason-simmons@users.noreply.github.com Remove the unsafe_html analysis rule (flutter/engine#56479 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-09 22:03:26 +00:00
Flutter GitHub Bot
893a0c8fcd
Marks Mac_benchmark complex_layout_scroll_perf_macos__timeline_summary to be flaky ( #158252 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_benchmark complex_layout_scroll_perf_macos__timeline_summary"
}
-->
Issue link: https://github.com/flutter/flutter/issues/158251
2024-11-09 19:45:40 +00:00
engine-flutter-autoroll
fca4f88b95
Roll Flutter Engine from ca6f5110d9d3 to 690cdfd09beb (1 revision) ( #158414 )
...
ca6f5110d9...690cdfd09bskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aLUsXLv5iMZFOgcAS... to TZVo85tD5mpzhcafg... (flutter/engine#56478 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from aLUsXLv5iMZF to TZVo85tD5mpz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-09 16:09:23 +00:00
engine-flutter-autoroll
995ff31bbd
Roll Flutter Engine from 2f097cfd3d2d to ca6f5110d9d3 (3 revisions) ( #158411 )
...
2f097cfd3d...ca6f5110d9chris@bracken.jp iOS: Use fml::CFRef in place of Scoped (flutter/engine#56463 )
2024-11-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 307869c696e8 to ed9a5b1110ae (2 revisions) (flutter/engine#56465 )
2024-11-08 chris@bracken.jp fml: delete unused scoped_policy (flutter/engine#56462 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-09 03:07:32 +00:00
engine-flutter-autoroll
bf1fac785e
Roll Flutter Engine from 54df0b8a4784 to 2f097cfd3d2d (1 revision) ( #158407 )
...
54df0b8a47...2f097cfd3da-siva@users.noreply.github.com Manual roll Dart SDK from cfa1826c3df1 to 307869c696e8 (1 revision) (flutter/engine#56460 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-09 00:16:06 +00:00
engine-flutter-autoroll
d8334d53d7
Roll Flutter Engine from b7134d373ef8 to 54df0b8a4784 (2 revisions) ( #158405 )
...
b7134d373e...54df0b8a47rosscomputerguy@protonmail.com [Linux] Replace deprecated macros in fl_application_test.cc (flutter/engine#56257 )
2024-11-08 jonahwilliams@google.com [iOS] fix tracking of previous platform views. (flutter/engine#56461 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-08 23:22:12 +00:00
engine-flutter-autoroll
fdbfbca12a
Roll Flutter Engine from 6b77347edfc5 to b7134d373ef8 (3 revisions) ( #158402 )
...
6b77347edf...b7134d373echris@bracken.jp fml: Use CFRef where possible and add docs (flutter/engine#56436 )
2024-11-08 mdebbar@google.com [web] Split all 1MB+ fallback fonts (including CJK) (flutter/engine#56388 )
2024-11-08 chris@bracken.jp yapf: Add more detailed error message and TODO (flutter/engine#56458 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-08 22:28:24 +00:00
engine-flutter-autoroll
d6918a48d3
Roll Flutter Engine from 1b567e80386e to 6b77347edfc5 (4 revisions) ( #158398 )
...
1b567e8038...6b77347edfchris@bracken.jp Add FlutterTaskRunnerDescription.destruction_callback (flutter/engine#56445 )
2024-11-08 skia-flutter-autoroll@skia.org Roll Skia from d0ee80612f86 to 778b21720a61 (5 revisions) (flutter/engine#56457 )
2024-11-08 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 50c620224f27 to cfa1826c3df1 (2 revisions) (flutter/engine#56456 )
2024-11-08 flar@google.com [Impeller] Switch to uniform arrays for gradient data on non-SSBO hardware (flutter/engine#56441 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-08 21:43:05 +00:00
engine-flutter-autoroll
2efdc74792
Roll Flutter Engine from a08bd5a07c2a to 1b567e80386e (1 revision) ( #158393 )
...
a08bd5a07c...1b567e8038jason-simmons@users.noreply.github.com In the embedder Impeller render target, use a multisample texture for the depth buffer only if MSAA is supported (flutter/engine#56444 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-08 19:55:12 +00:00
André Stein
1511370a92
[TextInput] Add TextInputType.webSearch ( #15762 ) ( #158323 )
...
This PR adds `TextInputType.webSearch` that allows to show a keyboard with ready access to a "." key on iOS. On Android this is re-mapped to `url` which shows the same behaviour as `webSearch` on iOS. This fixes issue #157562 .
There also is a [corresponding *engine* PR](https://github.com/flutter/engine/pull/56428 ).
Screenshot from iOS demo app:
2024-11-08 18:26:05 +00:00
Phil Quitslund
e222381e29
remove redundant arguments ( #158349 )
...
An upcoming fix to the analyzer will (correctly) catch these args as
redundant
(https://dart-review.googlesource.com/c/sdk/+/394004/2/pkg/analyzer/lib/src/dart/ast/ast.dart ).
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-11-08 09:30:26 -08:00
engine-flutter-autoroll
c8510f29cc
Roll Flutter Engine from 44d788f4651b to a08bd5a07c2a (3 revisions) ( #158375 )
...
44d788f465...a08bd5a07cskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pG2aukmcwvp71aKuS... to aLUsXLv5iMZFOgcAS... (flutter/engine#56450 )
2024-11-08 skia-flutter-autoroll@skia.org Roll Skia from 7ae36ecfe93d to d0ee80612f86 (2 revisions) (flutter/engine#56448 )
2024-11-08 codefu@google.com Move off deprecated upload-artifactv3 (flutter/engine#56439 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pG2aukmcwvp7 to aLUsXLv5iMZF
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-08 15:32:29 +00:00
Taha Tesser
7abb083ae2
Add ability to override NavigationDestination.label padding for NavigationBar ( #158260 )
...
Fixes [Long NavigationBar tab titles can't be padded from the sides of the screen](https://github.com/flutter/flutter/issues/158130 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
navigationBarTheme: const NavigationBarThemeData(
labelTextStyle:
WidgetStatePropertyAll(TextStyle(overflow: TextOverflow.ellipsis)),
labelPadding: EdgeInsets.symmetric(horizontal: 16, vertical: 4),
)),
home: Scaffold(
body: Center(
child: Text(
'Custom NavigationBar label padding',
style: Theme.of(context).textTheme.titleMedium,
),
),
bottomNavigationBar: NavigationBar(
destinations: const [
NavigationDestination(
icon: Icon(Icons.favorite_rounded),
label: 'Long Label Text',
),
NavigationDestination(
// icon: SizedBox.shrink(),
icon: Icon(Icons.favorite_rounded),
label: 'Long Label Text',
),
NavigationDestination(
icon: Icon(Icons.favorite_rounded),
label: 'Long Label Text',
),
],
),
),
);
}
}
```
</details>
### Default `NavigationDestination.label` padding with long label
<img width="458" alt="Screenshot 2024-11-06 at 14 30 52" src="https://github.com/user-attachments/assets/637e5e66-e05f-49fa-a4ae-72083b6ff884 ">
### Custom `NavigationDestination.label` padding with long label
<img width="458" alt="Screenshot 2024-11-06 at 14 32 02" src="https://github.com/user-attachments/assets/23ebf715-30d3-433c-92cd-c8f0fdb1571b ">
2024-11-08 14:19:18 +00:00
stuartmorgan
2afadc2cdf
Add flutter/package code generation instructions ( #158326 )
...
Adds general instructions for updating generated code in
flutter/packages, covering the common cases of Pigeon and Mockito
generation.
Fixes https://github.com/flutter/flutter/issues/158321
2024-11-08 08:17:07 -05:00
engine-flutter-autoroll
0059575b18
Roll Flutter Engine from 8e19915c19fc to 44d788f4651b (3 revisions) ( #158362 )
...
8e19915c19...44d788f465jonahwilliams@google.com [Impeller] Add support for ImageFilter.shader (flutter/engine#53490 )
2024-11-07 skia-flutter-autoroll@skia.org Roll Skia from 2ed9606702f1 to 7ae36ecfe93d (4 revisions) (flutter/engine#56442 )
2024-11-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 6a3684b96121 to 50c620224f27 (1 revision) (flutter/engine#56438 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-08 02:47:31 +00:00
engine-flutter-autoroll
710fe2bdf4
Roll Flutter Engine from bcb281cde579 to 8e19915c19fc (4 revisions) ( #158354 )
...
bcb281cde5...8e19915c19skia-flutter-autoroll@skia.org Roll Skia from e9a7546ef3d9 to 2ed9606702f1 (1 revision) (flutter/engine#56434 )
2024-11-07 jason-simmons@users.noreply.github.com [Impeller] Use Matrix::MakeTranslateScale to compute the source-to-destination mapping in DrawImageRect (flutter/engine#56433 )
2024-11-07 chris@bracken.jp iOS: Eliminate ScopedBlock, ScopedTypeRef, ScopedPolicy (flutter/engine#56410 )
2024-11-07 jacksongardner@google.com [skwasm] Make sure to include the transfer list when using postMessage. (flutter/engine#56431 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-08 00:26:24 +00:00
Renzo Olivares
97eef6afc5
Make _SelectableRegionSelectionContainerDelegate public ( #147080 )
...
This change makes `_SelectableRegionContainerDelegate` public so it can be reused and extended by users of `SelectionContainer`. Extending `MultiSelectableRegionContainerDelegate` does not by default provide selection managing across multiple selectables, so often users will copy the implementation found in `_SelectableRegionContainerDelegate`.
`_SelectableRegionContainerDelegate` -> `StaticSelectionContainerDelegate`.
2024-11-07 23:00:52 +00:00
Jason Simmons
8461ceea43
Manual roll Flutter Engine from 371c86fb6b49 to bcb281cde579 ( #158346 )
...
Includes changes required by the new Dart formatter.
2024-11-07 22:39:19 +00:00
Kate Lovett
777ce1b0da
Add clarification on review timelines in PR template ( #158345 )
...
Adds a reference to tree hygiene to help clarify expectations for review timelines.
2024-11-07 22:13:46 +00:00
Ben Konyi
998f42a3f0
Increase Java heap limit to 8GB for plugin integration tests using deferred components ( #158330 )
...
Should help resolve https://github.com/flutter/flutter/issues/156953
2024-11-07 15:24:25 -05:00
flutter-pub-roller-bot
dff06fde60
Roll pub packages ( #158337 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-11-07 20:15:01 +00:00
engine-flutter-autoroll
ecb6db5c51
Roll Flutter Engine from ac50b20ae5c9 to 371c86fb6b49 (5 revisions) ( #158336 )
...
ac50b20ae5...371c86fb6bjonahwilliams@google.com [Impeller] disable overdraw prevention for source draws. (flutter/engine#56403 )
2024-11-07 chris@bracken.jp macOS: fix leak in CurrentKeyboardLayout (flutter/engine#56420 )
2024-11-07 chris@bracken.jp macOS: Fix use after free in FlutterViewControllerTests (flutter/engine#56418 )
2024-11-07 skia-flutter-autoroll@skia.org Roll Skia from 6f16a8c83bf4 to e9a7546ef3d9 (3 revisions) (flutter/engine#56426 )
2024-11-07 skia-flutter-autoroll@skia.org Roll Skia from 8444ee0c8a76 to 6f16a8c83bf4 (1 revision) (flutter/engine#56425 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-07 19:05:27 +00:00
Matan Lurey
3c689ce6b7
Fix a breakage caused by the test being unskipped. ( #158335 )
...
https://github.com/flutter/flutter/pull/158204 collided with
https://github.com/flutter/flutter/pull/157462 .
Fortunately the change is 1-line in 1-test.
2024-11-07 10:16:18 -08:00
engine-flutter-autoroll
eff34e2b4a
Roll Flutter Engine from 8a963cfc134c to ac50b20ae5c9 (1 revision) ( #158308 )
...
8a963cfc13...ac50b20ae5skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from z1otZzn3yKuGnu1st... to pG2aukmcwvp71aKuS... (flutter/engine#56424 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from z1otZzn3yKuG to pG2aukmcwvp7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-07 18:11:09 +00:00
Matan Lurey
78cfc1ae9b
Plugin.isDevDependency if exclusively in dev_dependencies (#157462 )
...
Work towards https://github.com/flutter/flutter/issues/56591 .
I explicitly want an LGTM from @andrewkolos @jmagman @jonahwilliams before merging.
---
After this PR, `<Plugin>.isDevDependency` is resolved based on the following logic, IFF:
- The plugin comes from a package _A_ listed in the app's package's `dev_dependencies: ...`
- The package _A_ is not a normal dependency of any transitive non-dev dependency of the app
See [`compute_dev_dependencies_test.dart`](51676093a3/packages/flutter_tools/test/general.shard/compute_dev_dependencies_test.darthttps://github.com/dart-lang/sdk/issues/56968 )._
_/cc @camsim99 @cbracken @johnmccutchan for visibility on the change._
2024-11-07 18:09:22 +00:00
stuartmorgan
bd65732cd2
Add recently imported packages to issue template ( #158324 )
...
Adds path_parsing, vector_graphics, and flutter_svg to the list of 1P packages to select from when reporting issues. (vector_graphics_codec/compiler and flutter_svg_test are not listed separately since they are conceptually part of a package group, not unlike federated plugin packages.)
2024-11-07 16:11:27 +00:00
engine-flutter-autoroll
673d6046b7
Roll Flutter Engine from 076688d95818 to 8a963cfc134c (1 revision) ( #158304 )
...
076688d958...8a963cfc13skia-flutter-autoroll@skia.org Roll Skia from cf33c4e96e81 to 8444ee0c8a76 (4 revisions) (flutter/engine#56422 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-07 05:01:38 +00:00
engine-flutter-autoroll
eef8daf090
Roll Flutter Engine from 94dac953a95f to 076688d95818 (2 revisions) ( #158303 )
...
94dac953a9...076688d958yjbanov@google.com [web:a11y] make header a <header> when non-empty and heading when empty (flutter/engine#55996 )
2024-11-06 jonahwilliams@google.com [Impeller] make sure binding nullptr texture does not crash. (flutter/engine#56381 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-07 02:33:29 +00:00
Polina Cherkasova
1f1eec06f1
Make leak tracking bots blocking. ( #157866 )
...
See http://flutter.dev/go/leak-tracker-make-bots-blocking
2024-11-07 00:23:04 +00:00
engine-flutter-autoroll
c55f6048d9
Roll Flutter Engine from b36ca3319825 to 94dac953a95f (1 revision) ( #158297 )
...
b36ca33198...94dac953a9jonahwilliams@google.com [Impeller] keep imgui hostbuffer alive. (flutter/engine#56409 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-07 00:09:12 +00:00
engine-flutter-autoroll
c12a3dc5b3
Roll Flutter Engine from 58ac1dadd69d to b36ca3319825 (9 revisions) ( #158295 )
...
58ac1dadd6...b36ca33198jacksongardner@google.com [skwasm] Fix empty backdrop drawing. (flutter/engine#56385 )
2024-11-06 jonahwilliams@google.com [Impeller] generate stroke vertices into point arena. (flutter/engine#56390 )
2024-11-06 jason-simmons@users.noreply.github.com [Impeller] Do not capture the temporary ImpellerMapping struct pointer when storing release callbacks in libImpeller (flutter/engine#56411 )
2024-11-06 68449066+zijiehe-google-com@users.noreply.github.com Roll ICU from 9408c6fd4a39 to 4239b1559d11 (2 revisions) (flutter/engine#56407 )
2024-11-06 chris@bracken.jp iOS,macOS: Add Obj-C cflags to all Obj-C targets (flutter/engine#56386 )
2024-11-06 skia-flutter-autoroll@skia.org Roll Skia from afaed8923682 to cf33c4e96e81 (5 revisions) (flutter/engine#56408 )
2024-11-06 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 1c1d0420539f to d456f613465a (6 revisions) (flutter/engine#56406 )
2024-11-06 chinmaygarde@google.com [Impeller] Avoid errors due to triangle fans usage on Molten. (flutter/engine#56321 )
2024-11-06 skia-flutter-autoroll@skia.org Roll Skia from b4df8dda7ffc to afaed8923682 (14 revisions) (flutter/engine#56404 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-06 23:16:26 +00:00
Paul Salmon
1ad0db51ae
Added cusor control properties to CupertinoSearchTextField and tests ( #158240 )
...
Adding control over the cursor to CupertinoSearchTextField: cursorWidth, cursorHeight, cursorRadius, cursorOpacityAnimates and cursorColor.
fixes https://github.com/flutter/flutter/issues/158239
2024-11-06 23:04:55 +00:00
Ben Konyi
933323488b
Fix flakiness in hot_reload_test.dart ( #158271 )
...
The test was immediately checking the contents of stdout after the daemon indicated that the hot reload had completed. This could cause a race since the reloaded code may not have had time to execute.
Fixes https://github.com/flutter/flutter/issues/158245
2024-11-06 22:14:19 +00:00
Gray Mackall
b8e56e3063
Fix use of deprecated buildDir in Android templates/tests/examples ( #157560 )
...
Replace deprecated `Project.buildDir` [getter](https://docs.gradle.org/current/javadoc/org/gradle/api/Project.html#getBuildDir() ) and [setter](https://docs.gradle.org/current/javadoc/org/gradle/api/Project.html#setBuildDir(java.io.File) ) uses.
2024-11-06 21:34:23 +00:00
engine-flutter-autoroll
2e23f7b30e
Roll Flutter Engine from f03f11300a9d to 58ac1dadd69d (5 revisions) ( #158283 )
...
f03f11300a...58ac1dadd6jonahwilliams@google.com [Impeller] split downsample shader into GLES variant. (flutter/engine#56376 )
2024-11-06 skia-flutter-autoroll@skia.org Roll Skia from 82175b411c80 to b4df8dda7ffc (1 revision) (flutter/engine#56398 )
2024-11-06 matanlurey@users.noreply.github.com Add and document and explicit `toARGB32`. (flutter/engine#56329 )
2024-11-06 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from _fkA2GjLQH4bc_n2p... to 6FgM4KTbxxmyYoiOs... (flutter/engine#56392 )
2024-11-05 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 3e840340c412 to 1c1d0420539f (2 revisions) (flutter/engine#56391 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-06 19:57:09 +00:00
flutter-pub-roller-bot
231583bf67
Roll pub packages ( #158281 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2024-11-06 19:37:09 +00:00
Jenn Magder
a987694f43
Delete firebase_android_embedding_v2_smoke_test ( #158223 )
...
Delete the Android V2 embedding smoke test now that the V1 embedding has been deleted https://github.com/flutter/flutter/issues/143531 .
Additionally, this was in bringup for months.
Fixes https://github.com/flutter/flutter/issues/158221
2024-11-06 18:21:07 +00:00
Yegor
99861b0b98
[web] fix --ab option for web benchmarks ( #154574 )
...
Fix the `--ab` option in the benchmark harness:
- Make `--local-engine-host` optional. The web engine doesn't need it, so it doesn't build it. But the tool crashes by failing to find it.
- Disable icon tree shaking because `--ab` runs against local engine build, whose Dart kernel version is out of sync with the framework, which crashes the const finder.
2024-11-06 18:07:17 +00:00
chunhtai
cfa3b08578
excluding website-cms from critical pr triage ( #158220 )
...
Since we skipped all website cms pr during critical triage anyway
2024-11-06 17:11:14 +00:00
Valentin Vignal
0c97067f80
Add test for image.frame_builder.0.dart ( #158247 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/image/image.frame_builder.0.dart`
2024-11-06 16:40:14 +00:00
engine-flutter-autoroll
4bc83fe310
Roll Packages from 721943194945 to bb5a25815cae (6 revisions) ( #158267 )
...
7219431949...bb5a25815cmagder@google.com [ci] Upload screenshots, logs, and Xcode test results for drive and integration_test runs (flutter/packages#7430 )
2024-11-05 737941+loic-sharma@users.noreply.github.com Remove use_modular_headers! from Podfiles (flutter/packages#7796 )
2024-11-05 30872003+misos1@users.noreply.github.com [camera_avfoundation] enable more than 30 fps (flutter/packages#7394 )
2024-11-05 engine-flutter-autoroll@skia.org Roll Flutter from 8591d0c16a6c to 29d40f7f6826 (25 revisions) (flutter/packages#8027 )
2024-11-05 stuartmorgan@google.com [ci] Add vector_graphics and flutter_svg to autolabeler (flutter/packages#8025 )
2024-11-05 alex@mariuti.com [vector_graphics_compiler] wasm compatibility (flutter/packages#8021 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-06 16:29:08 +00:00
Valentin Vignal
73546b3b71
Add test for image.loading_builder.0.dart ( #158248 )
...
Contributes to https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/widgets/image/image.loading_builder.0.dart`
2024-11-06 14:26:28 +00:00
Martin Kustermann
3a83e43ede
Make flutter_tools use newest package:{native_assets_builder,native_assets_cli,native_toolchain_c} ( #158214 )
...
Almost all of the code is just adopting to changes to the APIs of
`package:native_assets_builder`, `package:native_assets_cli` and
`package:native_toolchain_c`
There's only two semantic changes
* Removes a test that checks for a verification error if a build hook
produces a static library if the preferred linking mode is dynamic:
=> The test is written in a very hacky way. By monkey patching the build
config.json that flutter build actually made. This monkey patching
relies on package:cli_config which is now no longer used.
=> The actual code that checks for this mismatch lives in
dart-lang/native repository and is tested there. So there's really no
need to duplicate that.
* The `package:native_assets_builder` no longer knows about code assets.
This is something a user of that package (e.g. flutter tools) adds. Now
the dry-run functionality will invoke build hooks who produce code
assets without an architecture.
=> The `package:native_assets_builder` used to expand such a code asset
to N different code assets (one for each supported architecture)
=> This logic was now moved to flutter tools. => In the near future
we're going to this dry-run complexity, which will then also get rid of
this uglyness (of expanding to all archs of an OS).
2024-11-06 14:12:34 +01:00
Bruno Leroux
22a7afd99a
Fix RawScrollbar examples and desktop test ( #158237 )
...
## Description
Fix the formatting of some `RawScrollbar` examples.
Fix and rename one test file (name without `_test` suffix).
2024-11-06 08:34:36 +00:00
Bruno Leroux
66e8f53ba0
Cleanup MenuAnchor and Improve DropdownMenu tests readability ( #158175 )
...
## Description
This PR fixes some typos on `MenuAnchor` and improve the readability of a `DropdownMenu` test utility function.
@justinmc I'm still considering creating a test utils file for DropdownMenu but there are few utilities and I'm worried that helper functions in utils file will cripple completion results (not a big deal because it is just for people working on the framework) but I think this should be used carefully. For instance the function `getButtonMaterial` would have to be renamed to something less generic if exposed more broadly (`getMenuItemButtonMaterial` for instance).
2024-11-06 07:14:05 +00:00
engine-flutter-autoroll
5a3fd44aec
Roll Flutter Engine from a3741d6248b7 to f03f11300a9d (2 revisions) ( #158222 )
...
a3741d6248...f03f11300arobert.ancell@canonical.com Document fields in FlEngine (flutter/engine#56266 )
2024-11-05 matanlurey@users.noreply.github.com Add missing TOC. (flutter/engine#56389 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-06 01:16:37 +00:00
LouiseHsu
dff191625f
Update error message for Cocoapods support for synchronized groups/folders ( #158206 )
...
Update to https://github.com/flutter/flutter/issues/156733
2024-11-06 01:08:54 +00:00
Matan Lurey
2f7a1aa20b
Restore skipped iOS test by looping over FakeAsync elapse. ( #158204 )
...
Closes https://github.com/flutter/flutter/issues/60675 .
From what I can tell `FakeAsync` wasn't necessary to making this be testable (or at least it isn't anymore?)
2024-11-06 01:05:01 +00:00
Aparin Kirill
7a57b69fcf
fix: ensure draggable_scrollable_sheet respects shouldCloseOnMinExten… ( #156338 )
...
This PR fixes the `shouldCloseOnMinExtent` flag in `draggable_scrollable_sheet.dart`.
*The `shouldCloseOnMinExtent` flag was not functioning correctly in the `DraggableScrollableSheet` widget. This PR ensures that the flag is properly handled, preventing the sheet from closing when it reaches the minimum extent if the flag is set to false. Before/after screenshots are not applicable for this change.*
In the code sample below, before my fix, the sheet would close when scrolled down. After my fix, it behaves as expected by respecting the `shouldCloseOnMinExtent` parameter.
### Code Sample
```dart
import 'package:flutter/material.dart';
Future<void> main() async {
runApp(const MaterialApp(
home: Home(),
));
}
class Home extends StatelessWidget {
const Home({
super.key,
});
@override
Widget build(BuildContext context) => Scaffold(
body: Center(
child: FilledButton(
onPressed: () async => showModalBottomSheet(
context: context,
isScrollControlled: true,
isDismissible: false,
builder: (context) => DraggableScrollableSheet(
expand: false,
maxChildSize: 0.9,
minChildSize: 0.25,
initialChildSize: 0.5,
shouldCloseOnMinExtent: false,
builder: (context, scrollController) => Navigator(
onGenerateRoute: (settings) => MaterialPageRoute(
settings: settings,
builder: (context) => ListView.builder(
controller: scrollController,
itemExtent: 100,
itemCount: 100,
itemBuilder: (context, index) => Center(
child: Text('$index'),
),
),
),
),
),
),
child: const Text('Open sheet'),
),
),
);
}
```
2024-11-06 00:55:06 +00:00
