firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
35,072 Commits 1 Branch 0 Tags
Commit Graph

9 Commits

Author SHA1 Message Date
Qun Cheng
4e7e4512b6
Reorder materialStateProperty defaults (#125905) 
Fixes #122250. This PR is to make sure all the MaterialStateProperty defaults are able to correctly resolve different states. 
* When a widget is pressed, it is also hovered, so we need to put the `MaterialState.pressed` check before `MaterialState.hovered`. 
* When a widget is focused, the widget should still be able to be hovered, so we should check `MaterialState.hovered` before `MaterialState.focused`.
* There are also cases like in _InputDecoratorDefaultsM3, the `MaterialState.disabled` should be checked before `MaterialState.error`.

 the order should be disabled, (error), pressed, hovered, focused.
 2023-05-11 00:03:09 +00:00
Taha Tesser
ad009fb7ac
Fix Material 3 tab indicator weight and position (#125883) 
fixes https://github.com/flutter/flutter/issues/123112

### Description
1. Add proper M3 indicator height aka`IndictorWeight` from the M3 specs for the primary tab bar with label indicator size.
db6074ade4/dev/tools/gen_defaults/data/navigation_tab_primary.json (L9)
(this was held due to `indicatorWeight` having a hard-coded value) 

and added a secondary tab bar indicator height.
2. Set a minimum value for the rounded indicator to maintain the indicator shape.
3. With proper indicator height, the rounded indicator position is also fixed.
4. Fix round indicator is shown for the primary tab bar with tab indicator size.
5. Above changes fix https://github.com/flutter/flutter/issues/123112.
6. Fix the `startOffset` const value from https://github.com/flutter/flutter/pull/125036  to match docs and move it to a variable.
 2023-05-05 14:09:18 +00:00
Taha Tesser
a732a74888
Introduce TabBar.tabAlignment (#125036) 
fixes https://github.com/flutter/flutter/issues/124195

This introduces `TabBar.tabAlignment` while keeping the default alignment for both M2 and M3.
 2023-05-01 16:59:55 +00:00
Kate Lovett
3dfc60c0d1
Revert "Fix divider width in scrollable TabBar for Material 3 and add dividerHeight parameter (#123127)" (#123616) 
Revert "Fix divider width in scrollable `TabBar` for  Material 3 and add `dividerHeight` parameter"
 2023-03-28 16:45:15 +00:00
Taha Tesser
3512c2cd76
Fix divider width in scrollable TabBar for Material 3 and add dividerHeight parameter (#123127) 
Fix divider width in scrollable `TabBar` for  Material 3 and add `dividerHeight` parameter
 2023-03-27 22:52:59 +00:00
Pierre-Louis
02d5c7595b
Add support for secondary tab bar (#122756) 
Add support for secondary tab bar
 2023-03-23 22:49:59 +00:00
Taha Tesser
a52293843c
[Reland] Add Material 3 support for TabBar (#116283) 
* Add Material 3 support for `TabBar`

* M3 `TabBar` revert fix and tests
 2022-11-30 17:58:07 +00:00
Pierre-Louis
b2672fe835
Revert "Add Material 3 support for TabBar (#116110)" (#116273) 
This reverts commit 900b395451bb29748b07ac45467b93b2f5490102.
 2022-11-30 13:20:19 +00:00
Taha Tesser
900b395451
Add Material 3 support for TabBar (#116110) 2022-11-29 22:36:37 +00:00