41017 Commits

Author SHA1 Message Date
Jenn Magder
57890e5aa7
Stop running module_test_ios in devicelab and x64 Macs (#148264)
As of https://github.com/flutter/flutter/pull/147934 `module_test_ios` is passing on non-devicelab machines.  Remove the devicelab build and mark the arm non-devicelab build as not flaky.

@vashworth's summary from https://github.com/flutter/flutter/issues/112033#issuecomment-2108671235:

> So I believe [the idea](https://github.com/flutter/flutter/pull/141910) was to move `Mac_arm64_ios module_test_ios` to `Mac_arm64 module_test_ios` so it doesn't run on a devicelab bot.
> 
> However, it fails when running on a chromium bot due to a `Trying to load an unsigned library` issue, even though it's using a simulator:
> https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_arm64%20module_test_ios
> 
> It's unclear why, but it seemed that removing the [lines](https://github.com/flutter/flutter/issues/112033#issuecomment-1652268832) that force disabling of codesigning allowed it to run. [@godofredoc was going to do a follow up PR to fix it](https://github.com/flutter/flutter/pull/141910#discussion_r1462346593), but it was probably forgotten. 

Also remove the x64 version of this test, since there's nothing arch-specific going on here and it happens to be flaky due to an infrastructure issues.

Fixes https://github.com/flutter/flutter/issues/112033
Fixes https://github.com/flutter/flutter/issues/144680
2024-05-15 18:33:03 +00:00
engine-flutter-autoroll
39651e84ea
Roll Flutter Engine from d35a1a603c80 to bf1c6da0dd31 (1 revision) (#148369)
d35a1a603c...bf1c6da0dd

2024-05-15 jonahwilliams@google.com [Impeller] make default glyph atlas size much bigger. (flutter/engine#52787)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 14:43:27 +00:00
engine-flutter-autoroll
ddd6c86950
Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) (#148367)
55c62ff82c...d35a1a603c

2024-05-15 jason-simmons@users.noreply.github.com Roll FreeType from af4c2d86 to bfc3453f (flutter/engine#52829)
2024-05-14 jonahwilliams@google.com [Impeller] immediately encode blit commands for Vulkan. (flutter/engine#52794)
2024-05-14 34871572+gmackall@users.noreply.github.com Fix non-vd android platform view input event offsets (flutter/engine#52532)
2024-05-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 0380354e2448 to 0b77fbab8cf5 (1 revision) (flutter/engine#52827)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 02:00:17 +00:00
engine-flutter-autoroll
dafce76ff8
Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) (#148365)
a1d930a3a8...55c62ff82c

2024-05-14 jonahwilliams@google.com [Impeller] reland: directly encode blit commands for Metal. (flutter/engine#52819)
2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from 81ba2eea7b42 to d0d87c26b489 (2 revisions) (flutter/engine#52825)
2024-05-14 chris@bracken.jp [docs] Suggest using same Xcode version as bots (flutter/engine#52821)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-15 00:39:36 +00:00
engine-flutter-autoroll
ea85c561fe
Roll Flutter Engine from dfb5871260a6 to a1d930a3a84d (2 revisions) (#148360)
dfb5871260...a1d930a3a8

2024-05-14 zanderso@users.noreply.github.com [et] Print reproxy stats when RBE shuts down (flutter/engine#52818)
2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from e26aee36345f to 81ba2eea7b42 (3 revisions) (flutter/engine#52820)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 23:58:25 +00:00
engine-flutter-autoroll
f9afa8f7fe
Roll Flutter Engine from 1b508a071c96 to dfb5871260a6 (1 revision) (#148356)
1b508a071c...dfb5871260

2024-05-14 jason-simmons@users.noreply.github.com Migrate third_party/gradle to flutter/third_party/gradle (flutter/engine#52814)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 22:40:21 +00:00
dependabot[bot]
cbc51f15eb
Bump codecov/codecov-action from 4.3.1 to 4.4.0 (#148355)
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.1 to 4.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v4.4.0</h2>
<h2>What's Changed</h2>
<ul>
<li>chore: Clarify isPullRequestFromFork by <a href="https://github.com/jsoref"><code>@​jsoref</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1411">codecov/codecov-action#1411</a></li>
<li>build(deps): bump actions/checkout from 4.1.4 to 4.1.5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1423">codecov/codecov-action#1423</a></li>
<li>build(deps): bump github/codeql-action from 3.25.3 to 3.25.4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1421">codecov/codecov-action#1421</a></li>
<li>build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1420">codecov/codecov-action#1420</a></li>
<li>feat: remove GPG and run on spawn by <a href="https://github.com/thomasrockhu-codecov"><code>@​thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1426">codecov/codecov-action#1426</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from 7.8.0 to 7.9.0 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1428">codecov/codecov-action#1428</a></li>
<li>chore(release): 4.4.0 by <a href="https://github.com/thomasrockhu-codecov"><code>@​thomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1430">codecov/codecov-action#1430</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.3.1...v4.4.0">https://github.com/codecov/codecov-action/compare/v4.3.1...v4.4.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="6d798873df"><code>6d79887</code></a> chore(release): 4.4.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1430">#1430</a>)</li>
<li><a href="37364fa731"><code>37364fa</code></a> build(deps-dev): bump <code>@​typescript-eslint/parser</code> from 7.8.0 to 7.9.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1428">#1428</a>)</li>
<li><a href="2791a5c4fe"><code>2791a5c</code></a> fix: remove GPG and run on spawn (<a href="https://redirect.github.com/codecov/codecov-action/issues/1426">#1426</a>)</li>
<li><a href="b71af43c1e"><code>b71af43</code></a> build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1420">#1420</a>)</li>
<li><a href="29f97fc54f"><code>29f97fc</code></a> build(deps): bump github/codeql-action from 3.25.3 to 3.25.4 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1421">#1421</a>)</li>
<li><a href="645d2a5926"><code>645d2a5</code></a> build(deps): bump actions/checkout from 4.1.4 to 4.1.5 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1423">#1423</a>)</li>
<li><a href="f691d469fb"><code>f691d46</code></a> chore: Clarify isPullRequestFromFork (<a href="https://redirect.github.com/codecov/codecov-action/issues/1411">#1411</a>)</li>
<li>See full diff in <a href="5ecb98a3c6...6d798873df">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.3.1&new-version=4.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-05-14 22:35:49 +00:00
Valentin Vignal
f335145529
Fix memory leaks in SnackBar (#147212) 2024-05-14 15:26:10 -07:00
Valentin Vignal
b23f34657e
Fix memory leaks in open upwards page transition (#148046) 2024-05-14 15:25:58 -07:00
chunhtai
de9ca5c1c8
Fixes semantics ordering when there are multiple TextFields with pref… (#148267)
…ix and suffix

fixes https://github.com/flutter/flutter/issues/148248
2024-05-14 22:22:51 +00:00
engine-flutter-autoroll
2d3e55da28
Roll Flutter Engine from ae9ff69a0840 to 1b508a071c96 (2 revisions) (#148351)
ae9ff69a08...1b508a071c

2024-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] immediately encode blit commands for Metal. (#52795)" (flutter/engine#52816)
2024-05-14 jonahwilliams@google.com [Impeller] immediately encode blit commands for Metal. (flutter/engine#52795)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 21:39:22 +00:00
Bruno Leroux
ced962d870
Add missing InputDecorator.hintText tests (#148113)
## Description

This PR reorganized some `InputDecorator.hintText` tests and add many of them (theses tests are organized similarly to the M3 spec, see https://m3.material.io/components/text-fields/specs).

This is somewhat repetitive but it helped me to catch two hint styling issues (wrong colors and font), I added TODOs because I will file the fixes once this PR is merged (just in case the fixes break some Google tests). The test I added are from lines 2779 to 3952 (below it is existing tests that I moved). 

## Related Issue

Part of https://github.com/flutter/flutter/issues/139076
2024-05-14 21:29:53 +00:00
Kate Lovett
4a1e3eaaa2
Fix abi key for local golden file testing (#148072)
Fixes https://github.com/flutter/flutter/issues/148022
2024-05-14 20:58:18 +00:00
yim
e2ef38d19f
Maintain the same layout constraints for item in the ReorderableList during dragging as before dragging. (#147863)
Fixes #147419
2024-05-14 20:52:59 +00:00
derdilla
4ecc1b092b
test material text field example (#147864)
Adds simple tests to the last two [TextField](https://api.flutter.dev/flutter/material/TextField-class.html) examples as part of fixing #130459.
2024-05-14 20:46:46 +00:00
Victor Sanni
7d92700042
Move toggleable to widget layer (#148272)
Currently, toggleable exists independently in the material and cupertino
libraries. Cupertino's toggleable is a minimal copy of material's, and
so it makes sense to have only one toggleable in the widgets layer.

This change makes it easier for cupertino's toggleables (switch, radio,
checkbox) to potentially have as many capabilities as material
toggleables (for example, resolving in different widget states), thus
increasing support for the cupertino library.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

---------

Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
2024-05-14 13:46:35 -07:00
engine-flutter-autoroll
a24b764a11
Roll Flutter Engine from 08b44d906fab to ae9ff69a0840 (1 revision) (#148341)
08b44d906f...ae9ff69a08

2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from 7dad6da92119 to e26aee36345f (1 revision) (flutter/engine#52810)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 19:35:59 +00:00
Andrew Kolos
c7574be4a3
add another print trace to runInView (#148337)
In service of https://github.com/flutter/flutter/issues/146879. See https://github.com/flutter/flutter/issues/146879#issuecomment-2110781156. I wonder if something is going wrong in the process of subscribing to the isolate event stream in the VM service. This adds a print trace to the `catch` clause of this subscription call.
2024-05-14 19:34:04 +00:00
engine-flutter-autoroll
034aa2f760
Roll Flutter Engine from 7bf865774d06 to 08b44d906fab (4 revisions) (#148338)
7bf865774d...08b44d906f

2024-05-14 30870216+gaaclarke@users.noreply.github.com [Impeller] migrated one test over from aiks to dl (flutter/engine#52786)
2024-05-14 jason-simmons@users.noreply.github.com [Impeller] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage (flutter/engine#52790)
2024-05-14 magder@google.com Refactor Semantics in preparation for ARC migration (flutter/engine#52729)
2024-05-14 zanderso@users.noreply.github.com Rolls in buildroot with stack protection flag (flutter/engine#52774)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 18:50:07 +00:00
engine-flutter-autoroll
d2da1b280b
Roll Flutter Engine from 491f460a25fb to 7bf865774d06 (1 revision) (#148325)
491f460a25...7bf865774d

2024-05-14 skia-flutter-autoroll@skia.org Roll Dart SDK from fe75fa5f7dc0 to 0380354e2448 (1 revision) (flutter/engine#52808)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 15:59:37 +00:00
engine-flutter-autoroll
2e11854da1
Roll Packages from 1412041fa3fe to fd714bd7d516 (1 revision) (#148324)
1412041fa3...fd714bd7d5

2024-05-14 32538273+ValentinVignal@users.noreply.github.com [go_router] Use the correct configuration to build the state passed to the `onExit` (flutter/packages#6623)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 15:48:25 +00:00
engine-flutter-autoroll
a39555d4fe
Roll Flutter Engine from c381b852605f to 491f460a25fb (1 revision) (#148319)
c381b85260...491f460a25

2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from 421d8d034e6e to 7dad6da92119 (1 revision) (flutter/engine#52806)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 15:12:10 +00:00
engine-flutter-autoroll
cb656c21f0
Roll Flutter Engine from b4b798d2e706 to c381b852605f (1 revision) (#148303)
b4b798d2e7...c381b85260

2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from 7045b90f1ef8 to 421d8d034e6e (1 revision) (flutter/engine#52803)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 10:02:26 +00:00
engine-flutter-autoroll
e62b6ea39e
Roll Flutter Engine from 0de6701b537a to b4b798d2e706 (2 revisions) (#148299)
0de6701b53...b4b798d2e7

2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from 19153175a79b to 7045b90f1ef8 (3 revisions) (flutter/engine#52801)
2024-05-14 jonahwilliams@google.com [Impeller] use render pass to clear glyph atlas texture to transparent black. (flutter/engine#52791)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 08:59:26 +00:00
engine-flutter-autoroll
ff8e06dc7b
Roll Flutter Engine from 764c33c3c773 to 0de6701b537a (2 revisions) (#148297)
764c33c3c7...0de6701b53

2024-05-14 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.7.1 to 1.7.3 (flutter/engine#52798)
2024-05-14 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/engine#52799)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 08:13:02 +00:00
engine-flutter-autoroll
d1b8ae7827
Roll Flutter Engine from 797eab742925 to 764c33c3c773 (1 revision) (#148290)
797eab7429...764c33c3c7

2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from 349fdd5f0b69 to 19153175a79b (1 revision) (flutter/engine#52797)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 07:26:25 +00:00
engine-flutter-autoroll
08adc90589
Roll Flutter Engine from 84687fe0f199 to 797eab742925 (1 revision) (#148288)
84687fe0f1...797eab7429

2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from 93912d50850d to 349fdd5f0b69 (2 revisions) (flutter/engine#52796)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 06:23:10 +00:00
engine-flutter-autoroll
21177cced4
Roll Flutter Engine from bee398d95abe to 84687fe0f199 (3 revisions) (#148282)
bee398d95a...84687fe0f1

2024-05-14 matanlurey@users.noreply.github.com Replace `json_utils` with a modern `extension type`, add tests. (flutter/engine#52769)
2024-05-14 jason-simmons@users.noreply.github.com Move libcxx to //flutter/third_party (flutter/engine#52773)
2024-05-14 dustingreen@google.com [fuchsia][sysmem2] route fuchsia.sysmem2.Allocator (flutter/engine#52708)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 05:06:32 +00:00
engine-flutter-autoroll
c8b0c9acec
Roll Flutter Engine from a1cdcb6a6687 to bee398d95abe (2 revisions) (#148280)
a1cdcb6a66...bee398d95a

2024-05-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 7c7767ecc3d7 to fe75fa5f7dc0 (1 revision) (flutter/engine#52792)
2024-05-14 skia-flutter-autoroll@skia.org Roll Skia from 400c6fbeace8 to 93912d50850d (1 revision) (flutter/engine#52788)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 04:03:55 +00:00
engine-flutter-autoroll
1484d09103
Roll Flutter Engine from 13a561cb6d5a to a1cdcb6a6687 (1 revision) (#148276)
13a561cb6d...a1cdcb6a66

2024-05-13 chinmaygarde@google.com Delete Settings::msaa_samples. (flutter/engine#52780)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 01:58:26 +00:00
engine-flutter-autoroll
2e23114d1a
Roll Flutter Engine from 7dcbd93e5c1a to 13a561cb6d5a (6 revisions) (#148274)
7dcbd93e5c...13a561cb6d

2024-05-13 jonahwilliams@google.com [Impeller] rectangle packer actually packs. (flutter/engine#52781)
2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from 75b3286ecaac to 400c6fbeace8 (6 revisions) (flutter/engine#52783)
2024-05-13 magder@google.com ios_external_view_embedder to ARC (flutter/engine#52782)
2024-05-13 skia-flutter-autoroll@skia.org Roll Dart SDK from a0a940f07d56 to 7c7767ecc3d7 (2 revisions) (flutter/engine#52777)
2024-05-13 chinmaygarde@google.com Remove outdated comment. (flutter/engine#52778)
2024-05-13 chinmaygarde@google.com [Impeller] Prepare a SkiaGPU-less iOS build. (flutter/engine#52748)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-14 01:16:25 +00:00
engine-flutter-autoroll
13cd57a7ee
Roll Flutter Engine from aeff9b174c84 to 7dcbd93e5c1a (1 revision) (#148266)
aeff9b174c...7dcbd93e5c

2024-05-13 magder@google.com Remove -[NSNotificationCenter removeObserver:] in deallocs (flutter/engine#52772)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 23:55:05 +00:00
Jenn Magder
51d99e79d0
Mark platform_views_scroll_perf_ad_banners__timeline_summary not flaky (#148263)
New build been consistently passing
https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_ios%20platform_views_scroll_perf_ad_banners__timeline_summary/960
2024-05-13 23:07:05 +00:00
Andrew Kolos
7d263507fb
add more print traces in hot runner workflow (#148258)
In service of https://github.com/flutter/flutter/issues/146879. See https://github.com/flutter/flutter/issues/146879#issuecomment-2108784673 in particular for the purpose of this PR. This adds a few more `printTrace` calls to try to see where we are getting stuck.
2024-05-13 22:51:48 +00:00
chunhtai
a36ff80cf6
Refactors page API (#137792)
fixes https://github.com/flutter/flutter/issues/137458

Chagnes:
1. Navigator.pop will always pop page based route
2. add a onDidRemovePage callback to replace onPopPage
3. Page.canPop and Page.onPopInvoked mirrors the PopScope, but in Page class.

migration guide https://github.com/flutter/website/pull/10523
2024-05-13 22:45:51 +00:00
dependabot[bot]
27f683d6c3
Bump github/codeql-action from 3.25.3 to 3.25.5 (#148262)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.3 to 3.25.5.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.25.5 - 13 May 2024</h2>
<ul>
<li>Add a compatibility matrix of supported CodeQL Action, CodeQL CLI, and GitHub Enterprise Server versions to the <a href="https://github.com/github/codeql-action/blob/main/README.md">https://github.com/github/codeql-action/blob/main/README.md</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2273">#2273</a></li>
<li>Avoid printing out a warning for a missing <code>on.push</code> trigger when the CodeQL Action is triggered via a <code>workflow_call</code> event. <a href="https://redirect.github.com/github/codeql-action/pull/2274">#2274</a></li>
<li>The <code>tools: latest</code> input to the <code>init</code> Action has been renamed to <code>tools: linked</code>. This option specifies that the Action should use the tools shipped at the same time as the Action. The old name will continue to work for backwards compatibility, but we recommend that new workflows use the new name. <a href="https://redirect.github.com/github/codeql-action/pull/2281">#2281</a></li>
</ul>
<h2>3.25.4 - 08 May 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.2. <a href="https://redirect.github.com/github/codeql-action/pull/2270">#2270</a></li>
</ul>
<h2>3.25.3 - 25 Apr 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.17.1. <a href="https://redirect.github.com/github/codeql-action/pull/2247">#2247</a></li>
<li>Workflows running on <code>macos-latest</code> using CodeQL CLI versions before v2.15.1 will need to either upgrade their CLI version to v2.15.1 or newer, or change the platform to an Intel MacOS runner, such as <code>macos-12</code>. ARM machines with SIP disabled, including the newest <code>macos-latest</code> image, are unsupported for CLI versions before 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/2261">#2261</a></li>
</ul>
<h2>3.25.2 - 22 Apr 2024</h2>
<p>No user facing changes.</p>
<h2>3.25.1 - 17 Apr 2024</h2>
<ul>
<li>We are rolling out a feature in April/May 2024 that improves the reliability and performance of analyzing code when analyzing a compiled language with the <code>autobuild</code> <a href="https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages#codeql-build-modes">build mode</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2235">#2235</a></li>
<li>Fix a bug where the <code>init</code> Action would fail if <code>--overwrite</code> was specified in <code>CODEQL_ACTION_EXTRA_OPTIONS</code>. <a href="https://redirect.github.com/github/codeql-action/pull/2245">#2245</a></li>
</ul>
<h2>3.25.0 - 15 Apr 2024</h2>
<ul>
<li>
<p>The deprecated feature for extracting dependencies for a Python analysis has been removed. <a href="https://redirect.github.com/github/codeql-action/pull/2224">#2224</a></p>
<p>As a result, the following inputs and environment variables are now ignored:</p>
<ul>
<li>The <code>setup-python-dependencies</code> input to the <code>init</code> Action</li>
<li>The <code>CODEQL_ACTION_DISABLE_PYTHON_DEPENDENCY_INSTALLATION</code> environment variable</li>
</ul>
<p>We recommend removing any references to these from your workflows. For more information, see the release notes for CodeQL Action v3.23.0 and v2.23.0.</p>
</li>
<li>
<p>Automatically overwrite an existing database if found on the filesystem. <a href="https://redirect.github.com/github/codeql-action/pull/2229">#2229</a></p>
</li>
<li>
<p>Bump the minimum CodeQL bundle version to 2.12.6. <a href="https://redirect.github.com/github/codeql-action/pull/2232">#2232</a></p>
</li>
<li>
<p>A more relevant log message and a diagnostic are now emitted when the <code>file</code> program is not installed on a Linux runner, but is required for Go tracing to succeed. <a href="https://redirect.github.com/github/codeql-action/pull/2234">#2234</a></p>
</li>
</ul>
<h2>3.24.10 - 05 Apr 2024</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="b7cec75265"><code>b7cec75</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2287">#2287</a> from github/update-v3.25.5-4a5197247</li>
<li><a href="6778fe4553"><code>6778fe4</code></a> Update changelog for v3.25.5</li>
<li><a href="4a51972477"><code>4a51972</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2280">#2280</a> from github/henrymercer/on-demand-ffs</li>
<li><a href="a8c32fd278"><code>a8c32fd</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2283">#2283</a> from github/henrymercer/disable-fail-fast</li>
<li><a href="f73b0b70eb"><code>f73b0b7</code></a> Disable fail fast for non-generated workflows</li>
<li><a href="c59e05245f"><code>c59e052</code></a> Disable fail fast in generated workflows</li>
<li><a href="33e416c056"><code>33e416c</code></a> Comment that <code>legacyApi</code> is false by default</li>
<li><a href="67f8a36bdb"><code>67f8a36</code></a> Merge branch 'main' into henrymercer/on-demand-ffs</li>
<li><a href="4995c49010"><code>4995c49</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2282">#2282</a> from github/henrymercer/no-build-mode-tracing-improv...</li>
<li><a href="def4d2cd4e"><code>def4d2c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2273">#2273</a> from github/aeisenberg/specify-versions</li>
<li>Additional commits viewable in <a href="d39d31e687...b7cec75265">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.25.3&new-version=3.25.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-05-13 22:26:41 +00:00
engine-flutter-autoroll
f76cb2204b
Roll Flutter Engine from 11502404a52a to aeff9b174c84 (2 revisions) (#148260)
11502404a5...aeff9b174c

2024-05-13 magder@google.com Migrate FlutterDartProject and FlutterPluginAppLifeCycleDelegate to ARC (flutter/engine#52719)
2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from dde1f5dba183 to 75b3286ecaac (1 revision) (flutter/engine#52763)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 22:22:06 +00:00
Ellet
876aa48ea5
Use super.key instead of manually passing the Key parameter to the parent class (#147621)
*Use `super.key` instead of manually passing the `Key` parameter using super(key: key) in the constructors.*

Since if you create a widget the new default will use `super.key` instead of `Key? key : super(key: key)` this small change is to maintain the consistency, it has no semantic change

also there are some other places that might need to be updated:

![image](https://github.com/flutter/flutter/assets/73608287/898f62f5-10f9-4d76-a46c-6def328177cb)

this file for example generate l10n project and it has all the dart code as String, it might have tests that validate the output somewhere that I might miss, also there are some other places like the `_Segment` class where it require `ValueKey` instead if `Key` so I didn't update them (even though it's possible)
2024-05-13 22:12:49 +00:00
Daco Harkes
3391ddf55d
Try fix module test (#147934)
Issue

* https://github.com/flutter/flutter/issues/112033

Suggested in https://github.com/flutter/flutter/issues/112033#issuecomment-1652268832, and makes the test pass for me locally on the M1 Macbook.
2024-05-13 21:30:01 +00:00
auto-submit[bot]
45e80fd63b
Reverts "Reland Native ios context menu (#143002) (#148238)" (#148254)
Reverts: flutter/flutter#148238
Initiated by: zanderso
Reason for reverting: Failures in post submit https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8748025189669617649/+/u/run_test.dart_for_web_canvaskit_tests_shard_and_subshard_3/stdout
Original PR Author: justinmc

Reviewed By: {hellohuanlin}

This change reverts the following previous change:
Reland of https://github.com/flutter/flutter/pull/143002, which was reverted in https://github.com/flutter/flutter/pull/148237 due to unresolved docs references. Not sure why those weren't caught in presubmit.

```
dartdoc:stdout: Generating docs for package flutter...
dartdoc:stderr:   error: unresolved doc reference [TextInput.showSystemContextMenu]
dartdoc:stderr:     from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/widgets/media_query.dart:579:14)
dartdoc:stderr:     in documentation inherited from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/widgets/media_query.dart:579:14)
dartdoc:stderr:   error: unresolved doc reference [showSystemContextMenu]
dartdoc:stderr:     from services.SystemContextMenuController.hide: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/services/text_input.dart:2554:16)
dartdoc:stderr:   error: unresolved doc reference [hideSystemContextMenu]
dartdoc:stderr:     from services.SystemContextMenuController.show: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/services/text_input.dart:2509:16)
```
2024-05-13 20:50:26 +00:00
Justin McCandless
42b3d9eb7f
Reland Native ios context menu (#143002) (#148238)
It's now possible to use the native-rendered text selection context menu on iOS. This sacrifices customizability in exchange for avoiding showing a notification when the user presses "Paste". It's off by default, but to enable, see the example system_context_menu.0.dart.
2024-05-13 12:53:36 -07:00
engine-flutter-autoroll
4c567a98b8
Roll Flutter Engine from 636374fd00ee to 11502404a52a (1 revision) (#148242)
636374fd00...11502404a5

2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from 2a7830d74a8b to dde1f5dba183 (1 revision) (flutter/engine#52762)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 18:50:08 +00:00
engine-flutter-autoroll
f3949685e0
Roll Packages from 6c4482a64492 to 1412041fa3fe (16 revisions) (#148239)
6c4482a644...1412041fa3

2024-05-13 stuartmorgan@google.com [in_app_purchase] Update country code Android example (flutter/packages#6722)
2024-05-13 engine-flutter-autoroll@skia.org Roll Flutter from 1dfb46e9c087 to 125543505d26 (6 revisions) (flutter/packages#6723)
2024-05-13 43054281+camsim99@users.noreply.github.com [camera] Change default Android implementation from `camera_android` to `camera_android_camerax` (flutter/packages#6629)
2024-05-13 15619084+vashworth@users.noreply.github.com [image_picker_ios] Make all headers public for SwiftPM to keep inline with CocoaPods (flutter/packages#6707)
2024-05-12 engine-flutter-autoroll@skia.org Roll Flutter from 2aa05c16509b to 1dfb46e9c087 (3 revisions) (flutter/packages#6715)
2024-05-11 engine-flutter-autoroll@skia.org Roll Flutter from 2bfb1b0e2f61 to 2aa05c16509b (26 revisions) (flutter/packages#6713)
2024-05-10 stuartmorgan@google.com [quick_actions] Add Swift Package Manager support (flutter/packages#6682)
2024-05-10 stuartmorgan@google.com [url_launcher] Add Swift Package Manager support (flutter/packages#6677)
2024-05-10 43054281+camsim99@users.noreply.github.com [Android][webview_flutter] Run integration tests on emulators running Android 34 (flutter/packages#6499)
2024-05-10 50643541+Mairramer@users.noreply.github.com [image_picker_android] - will fix crash on Android 12+ devices (flutter/packages#6691)
2024-05-10 43054281+camsim99@users.noreply.github.com [camerax] Make fixes required to swap camera_android_camerax for camera_android (flutter/packages#6697)
2024-05-10 737941+loic-sharma@users.noreply.github.com Update .gitignore for Swift Package Manager (flutter/packages#6705)
2024-05-10 34871572+gmackall@users.noreply.github.com [quick_actions_android] Switch to `Compat` version of `ShortcutManager` to support Google surfaces (flutter/packages#6638)
2024-05-10 737941+loic-sharma@users.noreply.github.com [local_auth_darwin] Adds Swift Package Manager compatibility (flutter/packages#6708)
2024-05-10 engine-flutter-autoroll@skia.org Roll Flutter from 00f40667c16a to 2bfb1b0e2f61 (9 revisions) (flutter/packages#6706)
2024-05-09 38299943+VictorOhashi@users.noreply.github.com [go_router] Feat add route redirect shellroutes (#114559) (flutter/packages#6432)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 18:36:12 +00:00
engine-flutter-autoroll
f77d6463a2
Roll Flutter Engine from 0050bf9a8094 to 636374fd00ee (1 revision) (#148216)
0050bf9a80...636374fd00

2024-05-13 skia-flutter-autoroll@skia.org Roll Dart SDK from f1a6336d2147 to a0a940f07d56 (1 revision) (flutter/engine#52761)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 18:11:08 +00:00
auto-submit[bot]
14d88ee0c8
Reverts "Native ios context menu (#143002)" (#148237)
Reverts: flutter/flutter#143002
Initiated by: cbracken
Reason for reverting: unresolved docs links. See failure here: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20docs_test/16540/overview

```
dartdoc:stdout: Generating docs for package flutter...
dartdoc:stderr:   error: unresolved doc reference [TextInput.showSystemContextMenu]
dartdoc:stderr:     from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutt
Original PR Author: justinmc

Reviewed By: {Renzo-Olivares, hellohuanlin}

This change reverts the following previous change:
In order to work around the fact that iOS 15 shows a notification on pressing Flutter's paste button (https://github.com/flutter/flutter/issues/103163), this PR allows showing the iOS system context menu in text fields.

<img width="385" alt="Screenshot 2024-02-06 at 11 52 25 AM" src="https://github.com/flutter/flutter/assets/389558/d82e18ee-b8a3-4082-9225-cf47fa7f3674">

It is currently opt-in, which a user would typically do like this (also in example system_context_menu.0.dart):

```dart
      contextMenuBuilder: (BuildContext context, EditableTextState editableTextState) {
        // If supported, show the system context menu.
        if (SystemContextMenu.isSupported(context)) {
          return SystemContextMenu.editableText(
            editableTextState: editableTextState,
          );
        }
        // Otherwise, show the flutter-rendered context menu for the current
        // platform.
        return AdaptiveTextSelectionToolbar.editableText(
          editableTextState: editableTextState,
        );
      },
```

Requires engine PR https://github.com/flutter/engine/pull/50095.

## API changes

### SystemContextMenu
A widget that shows the system context menu when built, and removes it when disposed. The main high-level way that most users would use this PR. Only works on later versions of iOS.

### SystemContextMenuController
Used under the hood to hide and show a system context menu. There can only be one visible at a time.

### MediaQuery.supportsShowingSystemContextMenu
Sent by the iOS embedder to tell the framework whether or not the platform supports showing the system context menu. That way the framework, or Flutter developers, can decide to show a different menu.

### `flutter/platform ContextMenu.showSystemContextMenu`
Sent by the framework to show the menu at a given `targetRect`, which is the current selection rect.

### `flutter/platform ContextMenu.hideSystemContextMenu`
Sent by the framework to hide the menu. Typically not needed, because the platform will hide the menu when the user taps outside of it and after the user presses a button, but it handles edge cases where the user programmatically rebuilds the context menu, for example.

### `flutter/platform System.onDismissSystemContextMenu`
Sent by the iOS embedder to indicate that the system context menu has been hidden by the system, such as when the user taps outside of the menu.  This is useful when there are multiple instances of SystemContextMenu, such as with multiple text fields.
2024-05-13 17:43:36 +00:00
Justin McCandless
125543505d
Native ios context menu (#143002)
It's now possible to use the native-rendered text selection context menu on iOS. This sacrifices customizability in exchange for avoiding showing a notification when the user presses "Paste". It's off by default, but to enable, see the example system_context_menu.0.dart.
2024-05-13 08:48:56 -07:00
derdilla
708fe97f9e
test sliver fill remaining examples (#148041)
Par of #130459. Adds tests all `SliverFillRemaining` examples.
2024-05-13 15:30:49 +00:00
engine-flutter-autoroll
e5f7800171
Roll Flutter Engine from fab7a7417888 to 0050bf9a8094 (1 revision) (#148211)
fab7a74178...0050bf9a80

2024-05-13 skia-flutter-autoroll@skia.org Roll Dart SDK from ff786d99b517 to f1a6336d2147 (1 revision) (flutter/engine#52758)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 11:37:27 +00:00
engine-flutter-autoroll
9abde3e615
Roll Flutter Engine from e568e5db9391 to fab7a7417888 (1 revision) (#148207)
e568e5db93...fab7a74178

2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from 4bc37d0feedb to 2a7830d74a8b (1 revision) (flutter/engine#52756)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 08:47:24 +00:00
engine-flutter-autoroll
d09e37afed
Roll Flutter Engine from 57e74a1b3860 to e568e5db9391 (2 revisions) (#148204)
57e74a1b38...e568e5db93

2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from cbe627d5ba15 to 4bc37d0feedb (1 revision) (flutter/engine#52754)
2024-05-13 skia-flutter-autoroll@skia.org Roll Skia from 4e9362762a0f to cbe627d5ba15 (1 revision) (flutter/engine#52752)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-13 08:02:46 +00:00