9166 Commits

Author SHA1 Message Date
Justin McCandless
89fa4cc502
Add InputDecoration alignLabelWithHint parameter (#24993)
* InputDecorator param for alignment of label

* Put baseline/center code in the right place where label is layed out

* Fix existing test

* Test top label positioning

* Rename to alignLabelWithHint, and make it a bool

* Test for TextField with and without alignLabelWithHint set

* alignLabelWithHint in theme as well

* debugFillProperties addition and test

* Small style fixes for review

* Fix analyze const error
2018-12-18 10:04:20 -08:00
Hans Muller
9b6229ab56
TextField.onChanged() doc update (#25473) 2018-12-18 09:03:57 -08:00
Danny Tuppeny
cbb168e7b9
Fix (probably) bad assert when running flutter test with asserts and --start-paused (#25512)
Fixes #25201.
2018-12-18 16:03:56 +00:00
Alexandre Ardhuin
32d65fef1c
fix some formatting issues (#25474) 2018-12-18 10:05:12 +01:00
Devon Carew
ba71933f58
don't warn for non-matching device discoverers (#25440)
* don't warn for non-matching device discoverers

* remove an out of date test
2018-12-17 14:54:18 -08:00
Dan Field
0a798105ef
Support Java 1.8 (#25470) 2018-12-17 14:40:48 -08:00
Devon Carew
632e21b40b
fix the daemon device.getDevices call (#25443) 2018-12-17 12:38:14 -08:00
Justin McCandless
a039b2ca8c
Revert "Revert "obscureText and enableInteractiveSelection defaults"" (#25342)
* Revert "Add imports section to sample code templates, and more docs. (#25184)"

This reverts commit 95b01247852e957719c55bd9939dc0c1e1e13e91.

* Revert "Use stderr instead of stdout to contain errors in flutter attach test (#25305)"

This reverts commit 2b819dd257b85179f16ed6f8511c3728c58babec.

* Revert "Allow detection of taps on TabBar (#23919)"

This reverts commit 01694ab62d33d345718d26e32a80db8d553f0ace.

* Revert "a549981da Roll src/third_party/skia a69b10312977..5eb29448dfbd (1 commits) (flutter/engine#7211) (#25333)"

This reverts commit a37099f3b16cf218980f864effa1b99cbd6d2ffd.

* Revert "Revert "obscureText and enableInteractiveSelection defaults (#24527)" (#25335)"

This reverts commit c5457068df5feb8aa0fdecb05de4260962760b2a.

* Password fields are no longer selectable nor copiable
2018-12-17 11:15:27 -08:00
Zachary Anderson
b18a2b1794
[fuchsia] Get Dart VM service ports from The Hub (#25332) 2018-12-17 11:10:47 -08:00
Hans Muller
9619b53d06
Update localizations (#25394) 2018-12-17 10:23:21 -08:00
Danny Tuppeny
c19142d8b7
Support ANDROID_SDK_ROOT in addition to ANDROID_HOME (#25221)
* Fall back to ANDROID_SDK_ROOT if ANDROID_HOME is not set

And update descriptions to use the non-deprecated ANDROID_SDK_ROOT.

Fixes #15114.

* Remove trailing whitespace

* Update dev/devicelab/lib/framework/adb.dart

Co-Authored-By: DanTup <danny@tuppeny.com>

* Reformat long line
2018-12-17 17:29:09 +00:00
Michael Goderbauer
59bfab157e
Reland "Call mark* methods before attaching child (#25239)" (#25395)
This reverts commit ea7d086e11e31d32fef1f6217566361f763c1429.

The revert did not fix the flakiness.
2018-12-15 13:29:54 -08:00
Stanislav Baranov
c5251cdc02
Flutter tool support for automatic saving of JIT compilation trace (#25301) 2018-12-14 16:09:17 -08:00
Hans Muller
30fb97be42
Fixed Typography null factory constructor (#24932) 2018-12-14 16:01:17 -08:00
jslavitz
ad2e3eb3b5
Adds support for floating cursor (#25384)
* Adds support for floating cursor.
2018-12-14 15:17:33 -08:00
Jonah Williams
b4f1d5a924
Add fuchsia devices to daemon command (#25344) 2018-12-14 14:37:55 -08:00
S McDowall
4c24bcc862 Remove TextField.noMaxLength, use maxLength = -1 instead (#24999) 2018-12-14 14:18:35 -08:00
David Shuckerow
1a60b166f2
Add ipv6 and observatory port support to the attach command (#25303)
* Add ipv6 and observatory port support to the attach command.

* Remove whitespace

* Explain why a name change is useful here

* Refactor common flags out into the parent

* Add an additional test case for when observatory port is provided but debug port is not

* Remove whitespace

* Fix flag validation
2018-12-14 18:03:49 -04:00
Jonah Williams
a0efb78640
Revert "drop/restore focus when app becomes invisible/visible" (#25390) 2018-12-14 12:45:07 -08:00
Hans Muller
8c439fd39f
IntrinsicWidth stepWidth or stepHeight == 0.0 (#25228) 2018-12-14 12:30:01 -08:00
Jonah Williams
ff97e255b5
drop/restore focus when app becomes invisible/visible (#24744) 2018-12-14 12:15:52 -08:00
Michael Goderbauer
ea7d086e11
Revert "Call mark* methods before attaching child (#25239)" (#25382)
This reverts commit 5c1f1d7618e27a3ed5a97971edc95eff9d0ba967.

Reverting to see if that fixes flakiness of flutter_gallery__transition_perf_with_semantics in devicelab.
2018-12-14 10:30:49 -08:00
Jonah Williams
4cd87705b7
Revert "Adds support for floating cursor (#24761)" (#25352)
This reverts commit 46878d848566769e51f21407de2fead528c1d2c4.
2018-12-13 20:36:08 -08:00
jslavitz
46878d8485
Adds support for floating cursor (#24761)
* Adds support for floating cursor!
2018-12-13 20:14:27 -08:00
Jasper van Riet
01694ab62d Allow detection of taps on TabBar (#23919) 2018-12-13 13:01:34 -08:00
Justin McCandless
c5457068df
Revert "obscureText and enableInteractiveSelection defaults (#24527)" (#25335)
This reverts commit f8f5953d8002cb17b861486dff93e5456ca54efd.
2018-12-13 11:58:37 -08:00
Justin McCandless
f8f5953d80
obscureText and enableInteractiveSelection defaults (#24527)
* obscureText true defaults to disabling selection

* Tests and comments for selectable text field

* Improve selection docs

* Refactor so that all enableInteractiveSelection params are null by default, delegate to selectionEnabled

* Fix selection param macros
2018-12-13 11:09:13 -08:00
Justin McCandless
952d24bf1e
Text field style merge (#24449)
* Merge TextField style with global style so that style changes don't override unspecified fields

* Test that a style param is merged with the theme

* Test a few more style properties

* Analysis fix
2018-12-13 08:32:55 -08:00
MH Johnson
92efec3998
[Material] Theme-able elevation on dialogs. (#24169)
* Themable elevation on dialogs.

* Added `BackgroundColor` in widget + theme

* Addressing Comments

* Fix test name

* Add debugFillProperties test
2018-12-13 09:11:01 -05:00
Michael Goderbauer
5c1f1d7618
Call mark* methods before attaching child (#25239) 2018-12-12 16:45:51 -08:00
David Shuckerow
e6292c8da1
Revert "Add ipv6 and observatory port support to the attach command." (#25288)
* Revert "e5195ee47 Remove unnecessary includes of Ganesh headers (flutter/engine#7189) (#25282)"

This reverts commit f198d66332f0f95f1932d35457801809b6e1d543.

* Revert "Validate style in TextField (#24587)"

This reverts commit 9a8e2f0c4b07d81fb3a0d3274443d26a7f34e9fe.

* Revert "Allow snippets tool to be run from arbitrary CWDs (#25243)"

This reverts commit 4a110b6227a10637e1671f1f7ced7faf4da45d5e.

* Revert "Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269)"

This reverts commit e29b023a6bbbd6b106aaf8802db3192ff3d3cf9c.

* Revert "Add ipv6 and observatory port support to the attach command. (#24537)"

This reverts commit 9150b3f031a9b1f743e25b9516a72a0bb3064adc.
2018-12-12 16:56:50 -04:00
Jonah Williams
f30029bae1
Run flutter tests through mini test engine when run directly (flutter run -t test_file) (#24930) 2018-12-12 12:51:16 -08:00
Justin McCandless
9a8e2f0c4b
Validate style in TextField (#24587)
* Validate style in TextField

* Fix analyze problems

* Use assert and move to top

* Simplified assertion
2018-12-12 09:44:43 -08:00
Danny Tuppeny
e29b023a6b
Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269)
* Update VS Code validator to match Android Studio

- Now shows a tick (instead of partial) if installed
- Now shows a cross (instead of dot) if extension is not installed

Fixes #22931.
2018-12-12 17:36:42 +00:00
David Shuckerow
9150b3f031 Add ipv6 and observatory port support to the attach command. (#24537) 2018-12-12 08:28:02 -08:00
Danny Tuppeny
2994d3562a
Add some a basic debug stepping tests (#24515) 2018-12-12 10:56:54 +00:00
Trevor Wang
114335dff0 Support TextField multi-line hint text #20941 (#24976) 2018-12-11 22:46:05 -08:00
xster
65df90d8b5
Add navigatorKey to CupertinoTabView (#25183) 2018-12-11 19:29:13 -08:00
Michael Goderbauer
8ca8dbf062
Do not fade out text for pinned & floating AppBar (#25051) 2018-12-11 19:24:00 -08:00
Jonah Williams
c461e93363
Revert "Ensure that cache dirs and files have appropriate permissions" (#25240) 2018-12-11 15:33:57 -08:00
Hans Muller
234855ca3d
Handle a TabBarView special case: last tab deleted before animation ends (#24892) 2018-12-11 14:22:27 -08:00
Jimmy Casey
3cca1a2ec3 Fixed Spelling. (#25217) 2018-12-11 10:50:51 -08:00
Justin McCandless
6901cd4625
TextFormField cursor params (#24635)
* cursor fields on textformfield

* Test pass-through of cursor properties
2018-12-11 10:42:10 -08:00
Hans Muller
f14055529b
Fixed an InheritedWidget doc typo (#25168) 2018-12-11 09:53:45 -08:00
Jonah Williams
b080a476c8
Fuchsia multiple devices and target (#24953) 2018-12-11 09:18:21 -08:00
Hans Muller
f8a7abb6b8
Add a check for build methods that return context.widget (#25046) 2018-12-11 08:59:28 -08:00
Danny Tuppeny
3f1c308e58
Don't require the AVD folder to exist in order to run flutter emulators (#25154)
Fixes #24750.
2018-12-11 15:27:25 +00:00
Michael Goderbauer
7120dab553
Don't crash if pinned & floating AppBar has less than minExtent remainingPaintExtent (#25048)
Fixes https://github.com/flutter/flutter/issues/21887
2018-12-11 07:18:53 -08:00
Michael Goderbauer
b023a57483
Fix debugPrint(null) to not crash (#24942) 2018-12-11 00:16:43 -08:00
Michael Goderbauer
46599167d5
Remove offstage wording from KeepAlive (#24881)
What KeepAlive does is different from the Offstage widget. Let's not confuse these two and be more speicific in the wording for KeepAlive.
2018-12-10 22:37:46 -08:00