9174 Commits

Author SHA1 Message Date
Danny Tuppeny
2d5ed986e1
Update integration tests to use vm_service_lib (#23937)
* Move integration tests to use vm_service_lib
* Turn off debug logging that was accidentally committed
* Run update-packages --force to fix checksum for new dev dependency
* Trim trailing whitespace
2018-11-08 07:55:54 +00:00
Jonah Williams
d04fa1a670
only pass packages once (#24074) 2018-11-07 21:57:00 -08:00
Greg Spencer
a6e901130e
Convert existing '## Sample code' samples to '{@tool sample}...{@end-tool}' form. (#24077)
This converts existing ## Sample code samples to {@tool sample}...{@end-tool} form.

Also:
1. Fixed a minor bug in analyze-sample-code.dart
2. Made the snippet tool only insert descriptions if the description is non-empty.
3. Moved the Card diagram to before the code sample.
2018-11-07 20:35:10 -08:00
Dan Field
9d53d7f848
Update pubspec template docs for module/plugin (#24081)
* Document module pubspec

* update doc on plugin template

* clarify language
2018-11-07 17:20:18 -08:00
Ian Hickson
f9374fe071
Update the URL to the recommend bug report (#23708)
We have templates now.
2018-11-07 17:12:35 -08:00
jslavitz
5dac7a2347
Removes check for Homebrew if all necessary packages are present. (#23844)
* Removes need for homebrew installation if all other packages are installed. Modifies test to work with this new functionality.
2018-11-07 15:21:05 -08:00
Jonah Williams
00c07266c1
add frontend server as a non dart dep of fuchsia_tool (#24075) 2018-11-07 15:14:35 -08:00
Ryan Macnak
d92d175bcb Opt into deterministic snapshots.
Also, remove old flags.
2018-11-07 14:44:20 -08:00
Hans Muller
4bb62b4348
Stop TextFields from wobbling within scrollables (#24015) 2018-11-07 14:27:25 -08:00
jslavitz
50fb729609
Includes frameworkVersion in JSON version output (#23891)
* Include framework version in JSON output and adds test
2018-11-07 12:28:22 -08:00
jslavitz
7342816084
Adds fix for double comparison error (#24026)
* adds fix for rounding error
2018-11-07 12:27:08 -08:00
Dan Field
3d01e89e7a
Unbreak WidgetsApp when only a builder specified (#23976)
* update assert add test

* update docs
2018-11-07 12:16:35 -08:00
Jonah Williams
6c88b2e9fb
restore compileExpressionService (#24063) 2018-11-07 12:04:05 -08:00
Michael Beckler
9abce96e8e BottomNavigationBar: bug fix for dealing with animations with shifting tabs (#22264)
Should fix #22226.

Code introduced in #20890 caused a regression that broke color flooding animations in a BottomNavigationBar that has BottomNavigationBarType.shifting.

The original issue (#19653) dealt with background color changes not occurring until another tab was selected. The result is that the background color instantly changes whenever the state changes and when the widget changes, instead of allowing a new widget to animate the background color change.
2018-11-07 09:20:27 -08:00
Dan Field
220cceedb5
Fix heroes transition when initial route is not '/' (#24039)
* early return for initialRoute + test
2018-11-07 00:06:34 -08:00
Dan Field
028087d0fc
fix identifier for release.xcconfig in module template (#23978) 2018-11-06 22:44:01 -08:00
Jonah Williams
2fc2581be4
unpin mockito (#24021) 2018-11-06 17:24:39 -08:00
jslavitz
34fa90b062
Improves SDK Search Error Messages (#23884)
* Improves error message and adds test.
2018-11-06 15:13:35 -08:00
Jonah Williams
81c7af342d
Add fuchsia specific entrypoint (#23916) 2018-11-06 14:36:35 -08:00
Jonah Williams
ab2d0323a7
cleanup accessibility test skips in gallery (#23977) 2018-11-06 13:29:23 -08:00
Jonah Williams
e862580518
move file back (#24014) 2018-11-06 11:09:57 -08:00
xster
7be8562202
Add cupertino_icons dependency to module pubspec template (#23961) 2018-11-06 10:52:00 -08:00
Jonah Williams
a43e3a4a2f
Retry remove package:test from flutter (#24007) 2018-11-06 10:48:34 -08:00
Jonah Williams
23a7535a39
Revert "Remove package:test dependency from flutter_test (#23755)" (#24004)
This reverts commit 71e9bd6f25125112473d5a094ee77fadaf7c259e.
2018-11-06 09:12:48 -08:00
Jonah Williams
71e9bd6f25
Remove package:test dependency from flutter_test (#23755) 2018-11-06 08:39:27 -08:00
Jonah Williams
9b66fea2ea
Follow up to https://github.com/flutter/flutter/pull/23436 (#23876) 2018-11-06 08:37:53 -08:00
Todd Volkert
07d1ba87e0
Update doctor instructions for libimobiledevice installation (#23946)
https://github.com/flutter/flutter/issues/22595
2018-11-05 15:10:13 -08:00
mattijsf
54becbf3bf Ignore unreachable iOS devices in IOSDevice.getAttachedDevices (#23776) 2018-11-05 15:09:39 -08:00
Stanislav Baranov
ba4cf054bd
Propagate positions of secondary pointers in UP events on Android (#23797) 2018-11-05 12:43:00 -08:00
Hans Muller
7245c4a6f6
Warn about supported locales that lack localizations (#23850) 2018-11-05 12:39:31 -08:00
Florian Huonder
02355d4c19 Added the DialogTheme to the material exports so that it is accessible. (#23858) 2018-11-05 09:34:05 -08:00
Dan Field
212374f0b7
Fix tests for ANSI terminals (#23906) 2018-11-05 07:56:30 -08:00
Alexandre Ardhuin
344ebe02ff
avoid returning null for Future (#23784) 2018-11-05 16:38:23 +01:00
Greg Spencer
202b045b50
Rewrite the analyze-sample-code script to also analyze snippets (#23893)
This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.

It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.

I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.

For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
2018-11-05 07:31:35 -08:00
Alexander Aprelev
34bc1e3c8c
Fix hanging of flutter run when running on more than one simulator. (#23932)
This stops reading from pipe-to-file log after the build is completed. Attempting to read from pipe-to-file keeps open blocked because nobody is going to write into that pipe.
2018-11-05 07:29:37 -08:00
Danny Tuppeny
8e7c8048de
Don't search in %LocalAppData% if it's not set (#23933)
It's not usual for this not to be set, but it affected at least one user (#23909) and there are a non-zero number of people online saying it's not set. It's better that we don't crash.

Fixes #23909.
2018-11-05 08:57:49 +00:00
sjindel-google
db9fe3f827
Fix text field clipping when erasing rapidly. (#23894)
`RenderEditable.paint` assumes that if the length of the text fits within the
visible region, then the text will be rendered at the start of the region and be
completely visible. This is not always true, since the text may still be
rendered at an offset if an animation is ongoing when the text begins to fit.

This fixes #22288 and #14121
2018-11-04 03:20:44 +01:00
jslavitz
a4a0ff9ab4
Makes FlexibleSpaceBarSettings public (#23803)
* Makes FlexibleSpaceSettingsPublic and adds a test
2018-11-02 17:38:38 -07:00
Yegor
f03b00706f
code readability: fix awkward variable shadowing (#23886) 2018-11-02 17:07:00 -07:00
Hans Muller
dd30efa190
Revert "Restore "Flutter gallery: updated Shrine demo" (#23878)" (#23888)
This reverts commit 76a1abd4c779a3f54f6a6a49340eca03a99d522c.
2018-11-02 15:32:02 -07:00
Hans Muller
76a1abd4c7
Restore "Flutter gallery: updated Shrine demo" (#23878) 2018-11-02 14:33:10 -07:00
Jonah Williams
d52f315c35
Add new benchmark to track cost of dependencies to a User (#23856) 2018-11-02 13:38:54 -07:00
Jason Simmons
36b9983212
Dartdoc comment for FontLoader.loadFont (#23882) 2018-11-02 13:22:09 -07:00
jslavitz
3aa104fe60
Allows progress indicator height to be controlled by parent (#23540)
* Adds functionality for progress indicator height to be controlled by the parent.
2018-11-02 09:50:14 -07:00
Jason Simmons
00565c2dda
An API for dynamically loading fonts (#23595)
See https://github.com/flutter/flutter/issues/17910
2018-11-02 09:44:26 -07:00
liyuqian
744b872f65
Add unit tests to mutate layer fields (#23599)
So we're sure that:
1. We won't break the API by not allowing to mutate fields
2. We won't forget to markNeedsAddToScene after mutation
2018-11-02 08:02:22 -07:00
Alexandre Ardhuin
6c32c15f3c
add some const classes (#21954) 2018-11-02 14:25:06 +01:00
Jonah Williams
d80999d6b8
Support attach on fuchsia devices (#23436) 2018-11-01 20:04:52 -07:00
Alexander Aprelev
47f62109d2
Specify UDID for idevicelistener. (#23854)
This is needed to run flutter app on multiple iOS devices at a time.
2018-11-01 20:04:42 -07:00
Jonah Williams
0b35937b13
Revert "Flutter gallery: updated Shrine demo (#23539)" (#23848)
This reverts commit 949cfcf172cce8a714719765b2e79039c5eb8200.
2018-11-01 19:30:11 -07:00