14005 Commits

Author SHA1 Message Date
Jonah Williams
a7db3591cb
[flutter_tools] deflake fastReassemble test (#62152) 2020-07-24 15:17:39 -07:00
Zachary Anderson
5e0ba2290f
Pass --disable-dart-dev in more places (#62217) 2020-07-24 13:37:08 -07:00
chunhtai
561735ad89
Revert "remove usage to applyTextScaleFactorToWidgetSpan (#61636)" (#62144)
This reverts commit c816fabd0af48a861afdeb78bb6ebe4b7cbd3707.
2020-07-23 10:35:21 -07:00
Alexandre Ardhuin
8428cf30eb
Add template flutter.widgets.transitionRoute.reverseTransitionDuration (#62136) 2020-07-23 09:22:20 -07:00
Pedro Massango
f025ca2fc6
Update basic.dart (#61961) 2020-07-23 08:46:04 -07:00
Alexandre Ardhuin
a07219a310
migrate physics to nullsafety (#61941) 2020-07-23 08:41:04 -07:00
Abdur Rafay Saleem
b50b5eadb0
Improved docs for minLines in EditableText (#61796) 2020-07-23 08:36:04 -07:00
LongCatIsLooong
64173f75c3
Check if a double is NaN before converting to it int (#61940) 2020-07-23 08:31:08 -07:00
Ming Lyu (CareF)
056e455e94
Add a E2E based performance test case (#61509) 2020-07-23 08:31:04 -07:00
Michael Goderbauer
8e58c51d1a
Update viewport dimensions when scrollDirection changes (#61973) 2020-07-23 08:30:26 -07:00
Michael Goderbauer
4b4287ba78
Make it an error to break macros in docs (and fix existing broken macros) (#62071) 2020-07-23 08:29:46 -07:00
Greg Spencer
cac22cdb08
Fix ExcludeFocus so it won't refocus a sibling of the focused node. (#61756)
This changes FocusNode.descendantsAreFocusable so that it doesn't allow the enclosing scope to re-focus a node that is a descendant of the node with descendantsAreFocusable set to false.

Because of the order in which the internal state for descendantsAreFocusable was being set, setting it to false was causing a sibling node to be focused when descendantsAreFocusable of the parent was set to false, even though it shouldn't have been focusable, because the enclosing scope would search for a candidate to be focused before the internal state was set to false.

Instead of looping over the children and telling them all to unfocus (and select the previously focused node), this unfocuses the node that has descendantsAreFocusable set to false, with the disposition UnfocusDisposition.previouslyFocusedChild, so that its enclosing scope will look for a previously focused child that isn't part of the subtree being excluded.

This affects how the ExcludeFocus widget behaves when turning on exclude.
2020-07-23 08:27:53 -07:00
Abdur Rafay Saleem
b8df8a8368
Allowed specifying reverseTransitionDuration in PageRouteBuilder class (#61752) 2020-07-22 18:41:09 -07:00
chunhtai
c816fabd0a
remove usage to applyTextScaleFactorToWidgetSpan (#61636) 2020-07-22 18:41:06 -07:00
Jonah Williams
a19fd72db5
[flutter_tools] check in script for generating per library unit coverage (#61996)
Allows generating a per-library coverage summary like https://gist.github.com/jonahwilliams/f298381c3fb9f472b2dfe54b82a20a88
2020-07-22 18:40:12 -07:00
Jonah Williams
3a976feb58
[flutter_tools] clean plugin dependencies file (#62061)
Clean even more, in case the plugin dependency update logic is wrong-o.
2020-07-22 18:39:33 -07:00
Greg Spencer
60314646b3
Find the target platform more accurately on the web. (#61587) 2020-07-22 18:36:08 -07:00
Pragya
d95f79f95f
Updated instructions of 'flutter help attach' (#61569) 2020-07-22 18:31:12 -07:00
Ming Lyu (CareF)
9e2e0ef3b4
implement handlePointerEventRecord for LiveWidgetController (#61266) 2020-07-22 18:31:08 -07:00
Todd Volkert
e91b833933
Minor doc updates (#62008) 2020-07-22 18:28:08 -07:00
Todd Volkert
67a9ae173b
Update Actions.invoke to return the result of invoking the action. (#62012)
The boolean value as to whether the action was found and enabled
is less useful than just returning the result of invoking the action
itself.
2020-07-22 18:27:38 -07:00
Pierre-Louis
629395f7ad
Add per thumb Range Slider semantics (#61439) 2020-07-22 18:26:11 -07:00
David Martos
6d303af97e
Use the correct Transform in the WidgetInspector overlay (#59566) (#60990) 2020-07-22 18:26:07 -07:00
huangchaoyang
9da74f66ca
Show correct errors when plugins yaml forgot the 'flutter.plugins.pla… (#61338) 2020-07-22 18:24:03 -07:00
Yazeed Al-Khalaf
d41b1fbb50
✒ Spell Check All .md Files Related to Flutter 💙 (#61564)
* 🐛 Fix Spelling Issues in Main README.md

* 🐛 Fix spelling issues in dev README.md

* 🐛 Fix spelling issues in complex_layout README.md

* 🐛 Fix spelling issues in macrobenchmarks README.md

* 🐛 Fix spelling issues in platform_views_layout README.md

* 🐛 Fix spelling issues in test_Apps/stocks README.md

* 🐛 Fix spelling issues in bots README.md

* ✒ Spell Check dev/ci README.md

* ✒ Spell Check dev/ci/docker_linux README.md

* ✒ Spell Check dev/devicelab README.md

* ✒ Spell Check dev/docs README.md

* ✒ Spell Check dev/snippets README.md

* ✒ Spell Check dev/snippets/config/templates README.md

* ✒ Spell Check dev/tools/gen_keycodes README.md

* ✒ Spell Check dev/tools/vitool README.md

* ✒ Spell Check examples/catalog README.md

* ✒ Spell Check examples/flutter_view README.md

* ✒ Spell Check examples/image_list README.md

* ✒ Spell Check examples/layers README.md

* ✒ Spell Check examples/platform_channel README.md

* ✒ Spell Check examples/platform_channel_swift README.md

* ✒ Spell Check examples/platform_view README.md

* ✒ Spell Check packages/_flutter_web_build_script README.md

* ✒ Spell Check packages/flutter_localizations README.md

* ✒ Spell Check packages/flutter_tools README.md

* ✒ Spell Check CODE_OF_CONDUCT.md

* ✒ Spell Check dev/integration_test/android_splash_screens/splash_Screen_load_rotate README.md

* ✒ Spell Check dev/integration_test/android_views README.md

* ✒ Spell Check dev/integration_tests/flutter_driver_screenshot_test README.md

* ✒ Spell Check dev/integration_tests/flutter_gallery README.md

* ✒ Spell Check dev/integration_tests/gradle_deprecated_settings README.md

* ✒ Spell Check dev/integration_tests/ios_add2app_life_cycle README.md

* ✒ Spell Check dev/integration_tests/ios_host_app README.md

* ✒ Spell Check dev/integration_tests/ios_platform_view_tests README.md

* ✒ Spell Check dev/automated_tests/flutter_test README.md

* ✒ Spell Check .github/PULL_REQUEST_TEMPLATE.md

* ✒ Spell Check .hithub/ISSUE_TEMPLATE/ACTIVATION.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/BUG.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/feature_request.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_others.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_speed.md

* ✒ Spell Check packages/flutter_tools/doc/daemon.md

* ✒ Spell Check packages/flutter_tools/fuchsia_enrtypoint_shim/README.md

* ✒ Minimize line to 80 columns

* ✒ Minimize line to 80 columns

* ✒ Fix Typo

* ✒ Chnaged numbers to 1 for testing purposes

* ✒ Changed numbers to 1 for testing purposes

*  Remove 'a' which is a typo

* ✒ Change a sentence to be better

* ✒ Remove 'a' which is a typo

* ✒ Fix small issue

* ✒ Fix small typo

* ✒ Fix some typos

*  Remove trailing space

*  Remove trailing space

* 🐛 Fix small typo

* ✒ Fix Typo

* 🐛 Fix small bug
2020-07-22 18:23:47 -07:00
Jonah Williams
9f040865c9
[flutter_tools] macOS cleanups, attach to log reader in release mode (#61913) 2020-07-22 18:23:20 -07:00
Jenn Magder
fe670c04cc
Only try to get build settings if the Xcode project exists (#61979) 2020-07-22 18:22:38 -07:00
Ben Konyi
adc9dde3ba
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61975)" (#61993)
This reverts commit f7a1c87ffdb9476c25cda487cb7232617be31b33.
2020-07-21 16:17:23 -07:00
Ben Konyi
f7a1c87ffd
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61975)
This reverts commit 4867f5931ff87a88fd3e89e7cf1b3cd9bd427670.
2020-07-21 15:44:38 -07:00
chunhtai
c44e5a32b5
Revert "InkDecoration do not paint if it's part of the tree doesn't get painted (#61216)" (#61963)
This reverts commit fdf87edd2fadb3ba3219d23792f0210384533e1b.
2020-07-21 09:35:40 -07:00
Pierre-Louis
5d854f63a0
Implement customizable cursor height (#61714) 2020-07-21 07:36:03 -07:00
Ming Lyu (CareF)
3e7fe378e3
Reland "LiveTestWidgetsFlutterBinding support for non-touch event" (#61901) 2020-07-21 02:36:03 -07:00
includecmath
aa9119e53b
[flutter_tools] Concise dart2js commands outputKernel & outputJavaScript (#61881) 2020-07-21 02:31:03 -07:00
Jonah Williams
8be1c9ef25
[flutter_tools] turn off fuchsia support by default (#61634) 2020-07-21 02:26:04 -07:00
Otokaze
a821bdbfd0
Add more tips for androidLicensesUnknown (#61312) 2020-07-21 02:21:03 -07:00
Jason Simmons
b3f0f092ec
Disable the deferred loading variant of gen_l10n_test (#61912) 2020-07-21 02:18:29 -07:00
Alexandre Ardhuin
9e658bc3d5
migrate scheduler to nullsafety (#61570) 2020-07-20 18:56:07 -07:00
xubaolin
fdf87edd2f
InkDecoration do not paint if it's part of the tree doesn't get painted (#61216) 2020-07-20 18:56:04 -07:00
Ben Konyi
4867f5931f
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61882)" (#61909)
This reverts commit 895b7ef6faf4e9c6ad641ad556855ff38fbd04bb.
2020-07-20 16:41:01 -07:00
Ben Konyi
895b7ef6fa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61882)
This reverts commit 38fe887342f6c6bf40dd2c25442b892644e11a39.
2020-07-20 16:01:58 -07:00
Ming Lyu (CareF)
f98a00c750
Revert "LiveTestWidgetsFlutterBinding support for non-touch event (#61872)" (#61900)
This reverts commit aa4b4d35e1187483fec4ec71fc278e724257cd77.
2020-07-20 17:20:30 -04:00
Jonah Williams
07caa0fbfe
[flutter_tools] Add plumbing for widget cache (#61766)
To support #61407 , the tool needs to check if a single widget reload is feasible, and then conditionally perform a fast reassemble.

To accomplish this, the FlutterDevice class will have a WidgetCache injected. This will eventually contain the logic for parsing the invalidated dart script. Concurrent with the devFS update, the widget cache will be updated/checked if a single widget reload is feasible. If so, an expression evaluation with the target type is performed and the success is communicated through the devFS result. An integration test which demonstrates that this works is already present in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/hot_reload_test.dart#L86

Finally, when actually performing the reassemble the tool simply checks if this flag has been set and calls the alternative reassemble method.

Cleanups:

Remove modules, as this is unused now.
2020-07-20 14:03:44 -07:00
Ming Lyu (CareF)
aa4b4d35e1
LiveTestWidgetsFlutterBinding support for non-touch event (#61872) 2020-07-20 17:02:59 -04:00
chunhtai
3577da53ff
Revert "fix intrinsic height and width for widget span (#61485)" (#61876)
This reverts commit fc09119d0af589ade9c7e0609777a46ed773f5d7.
2020-07-20 09:54:50 -07:00
Alexandre Ardhuin
3f79310204
restore nullability of FlutterError.onError (#61844) 2020-07-20 18:45:04 +02:00
Helin Shiah
5b9ce492f3
Skip printing rendered error text in machine mode (#61684) 2020-07-20 09:41:03 -07:00
Jenn Magder
c4bfa4c7ab
Inject iproxy into context (#61762) 2020-07-20 07:46:05 -07:00
Jonah Williams
78a975444a
[flutter_tools] revert dart format changes (#61760) 2020-07-20 07:41:05 -07:00
Michael Goderbauer
13ac541a00
Remove TODO arround deprecation (#61672) 2020-07-20 07:31:04 -07:00
Jason Simmons
27b306a3da
Track used Android pointer IDs and reuse IDs after a pointer is released (#61668) 2020-07-20 07:26:05 -07:00