Jenn Magder
9b442b2749
Print warning and exit when iOS device is unpaired ( #144551 )
...
Explicitly handle the case where the iOS device is not paired. On `flutter run` show an error and bail instead of trying and failing to launch on the device.
On this PR:
```
$ flutter run -d 00008110-0009588C2651401E
'iPhone' is not paired. Open Xcode and trust this computer when prompted.
$
```
Fixes https://github.com/flutter/flutter/issues/144447
Closes https://github.com/flutter/flutter/pull/144095
2024-03-04 23:01:11 +00:00
engine-flutter-autoroll
d9eea7963d
Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) ( #144558 )
...
a312091719...0d8588b1de30870216+gaaclarke@users.noreply.github.com [Impeller] implements blur styles inner and outer (flutter/engine#51018 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-04 22:20:18 +00:00
LongCatIsLooong
de0ccf39c6
Remove unnecessary (and the only) RenderObject.markParentNeedsLayout override ( #144466 )
...
Nobody calls it except for `markNeedsLayout`, and the render object is a guaranteed relayout boundary.
2024-03-04 21:58:17 +00:00
Bruno Leroux
16d122dbe2
Fix text color for default CupertinoContextMenuAction ( #144542 )
...
## Description
This PR fix the text color for the default action in a CupertiniContextMenu.
Previously the dynamic color was not resolved which leads to text being blacks when theme brightness was dark.
| Before | After |
|--------|--------|
|  |  |
## Related Issue
Fixes https://github.com/flutter/flutter/issues/144492 .
## Tests
Adds 1 test, updates 1.
2024-03-04 21:36:03 +00:00
Nate
1a0dc8f1e1
Add missing parameter to TableBorder.symmetric, and improve class constructors ( #144279 )
...
Originally, my aim was just to refactor (as per usual), but while messing around with the `TableBorder.symmetric` constructor, I realized that `borderRadius` was missing!
This pull request makes a few class constructors more efficient, and it fixes #144277 by adding the missing parameter.
<br>
2024-03-04 20:20:19 +00:00
Matej Knopp
1d7f4a9afa
Fix build mode not propagated in android native asset build ( #144550 )
...
This fixes bug where build mode is hardcoded to debug while building
native assets for Android.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-03-04 21:11:14 +01:00
engine-flutter-autoroll
6e7e4f3cf4
Roll Packages from a9c68b83356b to 06258277070f (3 revisions) ( #144556 )
...
a9c68b8335...0625827707engine-flutter-autoroll@skia.org Roll Flutter from ba719bc588ed to 65cd84b58885 (5 revisions) (flutter/packages#6239 )
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter from e92bca3ff5d2 to ba719bc588ed (37 revisions) (flutter/packages#6235 )
2024-03-01 sergeydesenko@gmail.com [camera_avfoundation] Set highest available resolution for ResolutionPreset.Max (flutter/packages#5245 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-04 19:13:26 +00:00
engine-flutter-autoroll
d3aa7aabdc
Roll Flutter Engine from afd2d9f9421d to a31209171949 (1 revision) ( #144554 )
...
afd2d9f942...a312091719skia-flutter-autoroll@skia.org Roll Skia from ff3199348aab to 9c7d13c05e77 (5 revisions) (flutter/engine#51168 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-04 19:02:07 +00:00
Qun Cheng
7c50267fa0
Doc fix for DropdownButtonFormField.value ( #144427 )
...
Fixes https://github.com/flutter/flutter/issues/144135
This PR is just a doc fix.
2024-03-04 18:52:20 +00:00
Tirth
35863b753f
Fix Small Typo in Skia_Client Doc Comment ( #144490 )
...
Fix Small Typo in Skia_Client Doc Comment.
2024-03-04 18:24:13 +00:00
engine-flutter-autoroll
a47548ba9d
Roll Flutter Engine from 2338a557e018 to afd2d9f9421d (1 revision) ( #144549 )
...
2338a557e0...afd2d9f942skia-flutter-autoroll@skia.org Roll Skia from 4b98d7b3ff2d to ff3199348aab (1 revision) (flutter/engine#51162 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-04 18:03:21 +00:00
Loïc Sharma
cc740eb503
[Windows] Update keyboard modifiers link ( #144426 )
...
Updates link to the new location. No tests as this only changes a comment.
2024-03-04 17:13:49 +00:00
engine-flutter-autoroll
9a957b3d5b
Roll Flutter Engine from 9cbca80e2196 to 2338a557e018 (2 revisions) ( #144545 )
...
9cbca80e21...2338a557e0skia-flutter-autoroll@skia.org Roll Skia from dfd933f9930c to 4b98d7b3ff2d (2 revisions) (flutter/engine#51160 )
2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from a57372ca2e66 to dfd933f9930c (1 revision) (flutter/engine#51158 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-04 17:12:26 +00:00
engine-flutter-autoroll
b7b289cddb
Roll Flutter Engine from c52b3033eca6 to 9cbca80e2196 (1 revision) ( #144523 )
...
c52b3033ec...9cbca80e21liama@google.com Experimental platform isolates API (flutter/engine#48551 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-04 16:29:12 +00:00
engine-flutter-autoroll
d3c274b255
Roll Flutter Engine from 024ea680ceed to c52b3033eca6 (1 revision) ( #144522 )
...
024ea680ce...c52b3033ecrobert.ancell@canonical.com Fix custom FlValue API not being exported (flutter/engine#51154 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-04 03:35:35 +00:00
engine-flutter-autoroll
dab0d18933
Roll Flutter Engine from 2706c732b22a to 024ea680ceed (1 revision) ( #144519 )
...
2706c732b2...024ea680cezanderso@users.noreply.github.com Fold the GN dart_pkg template into its only use (flutter/engine#51151 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-03 21:49:24 +00:00
engine-flutter-autoroll
65cd84b588
Roll Flutter Engine from 8ef8543d6001 to 2706c732b22a (1 revision) ( #144493 )
...
8ef8543d60...2706c732b2jason-simmons@users.noreply.github.com [Impeller] ASAN/LSAN fixes for the mock Vulkan implementation (flutter/engine#51115 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-02 02:06:15 +00:00
Xilai Zhang
09b7a1c7c8
[github actions] rewrite cherry pick template ( #144065 )
...
Context: @godofredoc pointed out that the fields in the PR template could be simplified and redesigned. Synced with @itsjustkevin and Kevin come up with [changes in this doc](https://docs.google.com/document/d/1Slppqq32toSwwxUyYTX1t6dGUQpyi0xEWxw4niGWspc/edit?resourcekey=0-v6U_9XVsMFSx0Fvx1rANhg&tab=t.0 ) which would improve the cherry pick template.
Github only supports a limited number of formatting options. This PR uses some workarounds and makes the following changes:
1. use divider to replace text area since Github markdown doesn't support text area
2. remove \<pre\> tags so texts can wrap around
3. use headings over bold
4. use task lists to identify the starting points of user answers
An example cherry pick template would [look like this](https://github.com/flutter/flutter/pull/143785 ) after the change.
2024-03-02 00:49:14 +00:00
engine-flutter-autoroll
18712edcf8
Roll Flutter Engine from 2a5a9a6dead0 to 8ef8543d6001 (1 revision) ( #144480 )
...
2a5a9a6dea...8ef8543d60skia-flutter-autoroll@skia.org Roll Skia from b44ad3d40f54 to a57372ca2e66 (1 revision) (flutter/engine#51122 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 17:12:25 +00:00
engine-flutter-autoroll
d93f5b7ea9
Roll Packages from 6d02f0359368 to a9c68b83356b (5 revisions) ( #144477 )
...
6d02f03593...a9c68b8335flutter/packages#6234 )
2024-02-29 stuartmorgan@google.com [various] Standardize Obj-C doc comment style (flutter/packages#6232 )
2024-02-29 joonas.kerttula@codemate.com [google_maps_flutter] Add support for marker clustering - platform interface (flutter/packages#6158 )
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from abb292a07e20 to 7482962148e8 (1 revision) (flutter/packages#6230 )
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter from d00bfe820eef to e92bca3ff5d2 (15 revisions) (flutter/packages#6227 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 15:45:08 +00:00
Taha Tesser
9a838455e2
Fix showDateRangePicker is missing dartpad tag and cleanup ( #144475 )
...
fixes [`showDateRangePicker` interactive sample not loading](https://github.com/flutter/flutter/issues/144474 )
### Description
This fixes `showDateRangePicker` example not loading in Dartpad.
Similar fix was made for `showDatePicker` in https://github.com/flutter/flutter/pull/99401
2024-03-01 15:36:24 +00:00
Taha Tesser
ba719bc588
Fix CalendarDatePicker day selection shape and overlay ( #144317 )
...
fixes [`DatePickerDialog` date entry hover background and ink splash have different radius](https://github.com/flutter/flutter/issues/141350 )
fixes [Ability to customize DatePicker day selection background and overlay shape](https://github.com/flutter/flutter/issues/144220 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: Center(
child: Builder(builder: (context) {
return FilledButton(
onPressed: () {
showDatePicker(
context: context,
initialDate: DateTime.now(),
firstDate: DateTime.utc(2010),
lastDate: DateTime.utc(2030),
);
},
child: const Text('Show Date picker'),
);
}),
),
),
);
}
}
```
</details>
### Material DatePicker states specs
### Day selection overlay
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/b529d38d-0232-494b-8bf2-55d28420a245 " /> | <img src="https://github.com/flutter/flutter/assets/48603081/c4799559-a7ef-45fd-aed9-aeb386370580 " /> |
### Hover, pressed, highlight preview
| Before | After |
| --------------- | --------------- |
| <video src="https://github.com/flutter/flutter/assets/48603081/8edde82a-7f39-4482-afab-183e1bce5991 " /> | <video src="https://github.com/flutter/flutter/assets/48603081/04e1502e-67a4-4b33-973d-463067d70151 " /> |
### Using `DatePickerThemeData.dayShape` to customize day selection background and overlay shape
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/a0c85f58-a69b-4e14-a45d-41e580ceedce " /> | <img src="https://github.com/flutter/flutter/assets/48603081/db67cee1-d28d-4168-98b8-fd7a9cb70cda " /> |
### Example preview
2024-03-01 12:44:29 +00:00
Taha Tesser
cfabdca9ca
Fix chips use square delete button InkWell shape instead of circular ( #144319 )
...
fixes [Chips delete button hover style is square, not circular](https://github.com/flutter/flutter/issues/141335 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: Center(
child: RawChip(
label: const Text('Test'),
onPressed: null,
deleteIcon: const Icon(Icons.clear, size: 18),
onDeleted: () {},
),
),
),
);
}
}
```
</details>
### Preview
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/c5d62c57-97b3-4f94-b83d-df13559ee3a8 " /> | <img src="https://github.com/flutter/flutter/assets/48603081/b76edaab-73e0-4aa9-8ca2-127eedd77814 " /> |
2024-03-01 12:02:07 +00:00
Bruno Leroux
e8f8a8dc17
InputDecorator M3 tests migration - Step4 - Hint tests ( #144169 )
...
## Description
This PR migrate hint related tests to M3 and adds some missing tests.
It is the fourth step for the M3 test migration for `InputDecorator`.
Step 1: https://github.com/flutter/flutter/pull/142981
Step 2: https://github.com/flutter/flutter/pull/143369
Step 3: https://github.com/flutter/flutter/pull/143520
## Related Issue
Related to https://github.com/flutter/flutter/issues/139076
2024-03-01 10:04:14 +00:00
engine-flutter-autoroll
f7f4c24285
Roll Flutter Engine from f0037d4fbd67 to 2a5a9a6dead0 (1 revision) ( #144468 )
...
f0037d4fbd...2a5a9a6deaskia-flutter-autoroll@skia.org Roll Skia from d672d0fe2f0d to b44ad3d40f54 (1 revision) (flutter/engine#51121 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 10:02:32 +00:00
engine-flutter-autoroll
ca2fb7e8af
Roll Flutter Engine from 16e04d264145 to f0037d4fbd67 (1 revision) ( #144464 )
...
16e04d2641...f0037d4fbdskia-flutter-autoroll@skia.org Roll Skia from 002f4366e473 to d672d0fe2f0d (2 revisions) (flutter/engine#51119 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 08:25:25 +00:00
engine-flutter-autoroll
d2a04ff37b
Roll Flutter Engine from 1dff89788b18 to 16e04d264145 (1 revision) ( #144459 )
...
1dff89788b...16e04d2641skia-flutter-autoroll@skia.org Roll Skia from 5961ed9c1d99 to 002f4366e473 (1 revision) (flutter/engine#51117 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 07:02:24 +00:00
Bruno Leroux
8a312cd01a
Horizontally expand text selection toolbar buttons in overflow menu ( #144391 )
...
## Description
This PR expands the items displayed in the overflow menu of a `TextSelectionToolbar` making buttons clickable in the blank area.
| Before | After |
|--------|--------|
| Each item has its own width | All items expand horizontally |
|  |  |
## Related Issue
Fixes https://github.com/flutter/flutter/issues/144089 .
## Tests
Adds 1 tests.
2024-03-01 06:40:47 +00:00
engine-flutter-autoroll
263ffe5f04
Roll Flutter Engine from f68cc57cbe12 to 1dff89788b18 (2 revisions) ( #144457 )
...
f68cc57cbe...1dff89788bjason-simmons@users.noreply.github.com [Impeller] Fix string search in CompilerTest.SkSLTextureLookUpOrderOfOperations (flutter/engine#51109 )
2024-03-01 jason-simmons@users.noreply.github.com [Impeller] Fix vertex counts in some display list tests (flutter/engine#51111 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 06:15:16 +00:00
engine-flutter-autoroll
ab10e2b1dd
Roll Flutter Engine from 76140bc9cec9 to f68cc57cbe12 (2 revisions) ( #144455 )
...
76140bc9ce...f68cc57cbejason-simmons@users.noreply.github.com [Impeller] Fix leak of rectangle packer in typographer tests (flutter/engine#51113 )
2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from 01d9566c4db8 to 5961ed9c1d99 (13 revisions) (flutter/engine#51106 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 05:21:09 +00:00
engine-flutter-autoroll
7d5dababd0
Roll Flutter Engine from f300ced56a4e to 76140bc9cec9 (1 revision) ( #144453 )
...
f300ced56a...76140bc9cezanderso@users.noreply.github.com Run apple SDK finders as gclient hooks (flutter/engine#50957 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 03:55:15 +00:00
engine-flutter-autoroll
af4d327a1f
Roll Flutter Engine from 34cf95c7bd82 to f300ced56a4e (1 revision) ( #144452 )
...
34cf95c7bd...f300ced56amatanlurey@users.noreply.github.com Add a basic e2e-test for `skia_gold_client`. (flutter/engine#51078 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 03:09:06 +00:00
engine-flutter-autoroll
a78a0d5934
Roll Flutter Engine from 0db468f7bae5 to 34cf95c7bd82 (1 revision) ( #144450 )
...
0db468f7ba...34cf95c7bdjohn@johnmccutchan.com Add et run command (flutter/engine#51037 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 02:22:19 +00:00
engine-flutter-autoroll
e601f047ae
Roll Flutter Engine from 6f8044436eb3 to 0db468f7bae5 (3 revisions) ( #144448 )
...
6f8044436e...0db468f7ba34871572+gmackall@users.noreply.github.com Add instructions for getting code coverage in Android Studio (flutter/engine#51105 )
2024-02-29 skia-flutter-autoroll@skia.org Roll Skia from 139461270500 to 01d9566c4db8 (1 revision) (flutter/engine#51093 )
2024-02-29 skia-flutter-autoroll@skia.org Manual roll Dart SDK from fdf4a62bd07b to 728fcf0bcbca (3 revisions) (flutter/engine#51098 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 01:17:48 +00:00
Michael Goderbauer
52bb198fb2
Remove master from API docs ( #144425 )
2024-03-01 01:06:56 +00:00
Michael Goderbauer
6995275bba
Enable missing-code-block-language ( #144443 )
2024-03-01 01:06:53 +00:00
engine-flutter-autoroll
8e418d1818
Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) ( #144436 )
...
7e8fefe4a0...6f8044436ejonahwilliams@google.com [Impeller] use specific format for bootstrap texture. (flutter/engine#51082 )
2024-02-29 jonahwilliams@google.com [Impeller] remove warning about device transient depth+stencil. (flutter/engine#51033 )
2024-02-29 robert.ancell@canonical.com Refactor GL rendering to prepare for GTK4 (flutter/engine#50754 )
2024-02-29 jacksongardner@google.com Reland "[skwasm] Clip pictures if they go beyond the bounds of the window." (flutter/engine#51077 )
2024-02-29 matej.knopp@gmail.com Revert "[macOS] Use CVDisplayLink to drive repaint (#49159 )" (flutter/engine#51095 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-01 00:05:57 +00:00
dependabot[bot]
fe56a35602
Bump github/codeql-action from 3.24.5 to 3.24.6 ( #144424 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.24.5 to 3.24.6.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases ">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>3.24.6 - 29 Feb 2024</h2>
<p>No user facing changes.</p>
<h2>3.24.5 - 23 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.3. <a href="https://redirect.github.com/github/codeql-action/pull/2156 ">#2156</a></li>
</ul>
<h2>3.24.4 - 21 Feb 2024</h2>
<ul>
<li>Fix an issue where an existing, but empty, <code>/sys/fs/cgroup/cpuset.cpus</code> file always resulted in a single-threaded run. <a href="https://redirect.github.com/github/codeql-action/pull/2151 ">#2151</a></li>
</ul>
<h2>3.24.3 - 15 Feb 2024</h2>
<ul>
<li>Fix an issue where the CodeQL Action would fail to load a configuration specified by the <code>config</code> input to the <code>init</code> Action. <a href="https://redirect.github.com/github/codeql-action/pull/2147 ">#2147</a></li>
</ul>
<h2>3.24.2 - 15 Feb 2024</h2>
<ul>
<li>Enable improved multi-threaded performance on larger runners for GitHub Enterprise Server users. This feature is already available to GitHub.com users. <a href="https://redirect.github.com/github/codeql-action/pull/2141 ">#2141</a></li>
</ul>
<h2>3.24.1 - 13 Feb 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.2. <a href="https://redirect.github.com/github/codeql-action/pull/2124 ">#2124</a></li>
<li>The CodeQL action no longer fails if it can't write to the telemetry api endpoint. <a href="https://redirect.github.com/github/codeql-action/pull/2121 ">#2121</a></li>
</ul>
<h2>3.24.0 - 02 Feb 2024</h2>
<ul>
<li>CodeQL Python analysis will no longer install dependencies on GitHub Enterprise Server, as is already the case for GitHub.com. See <a href="https://github.com/github/codeql-action/blob/main/#3230---08-jan-2024 ">release notes for 3.23.0</a> for more details. <a href="https://redirect.github.com/github/codeql-action/pull/2106 ">#2106</a></li>
</ul>
<h2>3.23.2 - 26 Jan 2024</h2>
<ul>
<li>On Linux, the maximum possible value for the <code>--threads</code> option now respects the CPU count as specified in <code>cgroup</code> files to more accurately reflect the number of available cores when running in containers. <a href="https://redirect.github.com/github/codeql-action/pull/2083 ">#2083</a></li>
<li>Update default CodeQL bundle version to 2.16.1. <a href="https://redirect.github.com/github/codeql-action/pull/2096 ">#2096</a></li>
</ul>
<h2>3.23.1 - 17 Jan 2024</h2>
<ul>
<li>Update default CodeQL bundle version to 2.16.0. <a href="https://redirect.github.com/github/codeql-action/pull/2073 ">#2073</a></li>
<li>Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. <a href="https://redirect.github.com/github/codeql-action/pull/2079 ">#2079</a></li>
</ul>
<h2>3.23.0 - 08 Jan 2024</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="8a470fddafhttps://redirect.github.com/github/codeql-action/issues/2176 ">#2176</a> from github/update-v3.24.6-158d0780d</li>
<li><a href="d59eafb69b158d0780dchttps://redirect.github.com/github/codeql-action/issues/2175 ">#2175</a> from github/henrymercer/fix-languages-init-success</li>
<li><a href="2307ff547fccd3f02545https://redirect.github.com/github/codeql-action/issues/2173 ">#2173</a> from github/henrymercer/mark-third-party-limits-erro...</li>
<li><a href="c0917251d4e12a8cc5eb888ab31e3ebd56a051337bde9061b4https://redirect.github.com/github/codeql-action/issues/2172 ">#2172</a> from github/henrymercer/fix-readme-typos</li>
<li>Additional commits viewable in <a href="47b3d888fe...8a470fddafhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.24.5&new-version=3.24.6 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-02-29 23:28:52 +00:00
hangyu
14b914ab92
Reland [a11y] Fix date picker cannot focus on the edit field ( #144198 )
...
reland https://github.com/flutter/flutter/pull/143117
fixes: https://github.com/flutter/flutter/issues/143116
fixes: https://github.com/flutter/flutter/issues/141992
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-02-29 15:16:53 -08:00
Michael Goderbauer
e41ffcb742
Reland "Use dartpad's main channel for master/main docs ( #144329 )" ( #144431 )
...
Fix is in the second commit. The logic here went out of sync with the logic in the snippets generator from https://github.com/flutter/assets-for-api-docs , whose version was bumped as part of this change.
2024-02-29 23:10:53 +00:00
Lau Ching Jun
f3ce9d2fcb
Make daemon server work on ipv6-only machines. ( #144359 )
...
Retry binding on ipv6 if binding on ipv4 failed.
2024-02-29 23:10:50 +00:00
Qun Cheng
ee6111a7aa
Remove deprecated backgroundColor from ThemeData ( #144079 )
...
This PR is to remove deprecated ThemeData.backgroundColor.
These parameters are made obsolete in https://github.com/flutter/flutter/pull/110162 .
Part of https://github.com/flutter/flutter/issues/143956
2024-02-29 23:07:23 +00:00
Amir Panahandeh
6068891373
Add stateful reordering test for TwoDimensionalViewport ( #142375 )
...
Adds a test to validate state is preserved after reordering in `TwoDimensionalViewport` (reference: https://github.com/flutter/flutter/pull/141504#pullrequestreview-1837501775 ).
- Fixes #130754
2024-02-29 23:03:53 +00:00
Jackson Gardner
203ec8b837
Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. ( #144423 )
...
We should avoid hitting gstatic in the benchmarks and just use local canvaskit/skwasm instead.
2024-02-29 22:30:48 +00:00
engine-flutter-autoroll
90b956ce8c
Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) ( #144419 )
...
bb6c6a0100...7e8fefe4a0kevmoo@users.noreply.github.com [web] Drop noisy prints from bootstrapping logic (flutter/engine#51097 )
2024-02-29 jacksongardner@google.com Fix a few issues rendering text with Skwasm. (flutter/engine#51074 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-29 22:30:45 +00:00
Lau Ching Jun
cfa011dd9d
Fix a crash in remote device daemon. ( #144358 )
...
The daemon server is expecting the client to pass `deviceId` in `device.shutdownDartDevelopmentService` method.
24a792dae1/packages/flutter_tools/lib/src/commands/daemon.dart (L1239)
2024-02-29 22:29:08 +00:00
auto-submit[bot]
b099bf0b4c
Reverts "Use dartpad's main channel for master/main docs ( #144329 )" ( #144429 )
...
Reverts flutter/flutter#144329
Initiated by: goderbauer
Reason for reverting: broke postsubmit doc generation.
Original PR Author: goderbauer
Reviewed By: {devoncarew, HansMuller, gspencergoog}
This change reverts the following previous change:
Original Description:
Dartpad doesn't have a "master" channel anymore, it got renamed to "main". Sadly, specifying "master" is now falling back to "stable" which breaks some of our examples in the docs that require a more current Flutter version, e.g. https://main-api.flutter.dev/flutter/material/TextButton-class.html
2024-02-29 21:57:18 +00:00
Qun Cheng
1349c591cc
Remove toggleableActiveColor from ThemeData ( #144178 )
...
This PR is to remove deprecated ThemeData.toggleableActiveColor.
These parameters are made obsolete in https://github.com/flutter/flutter/pull/97972 .
Part of https://github.com/flutter/flutter/pull/111080
2024-02-29 20:58:11 +00:00
LongCatIsLooong
726e5d28c0
Add FocusNode.focusabilityListenable ( #144280 )
...
This is for https://github.com/flutter/flutter/issues/127803 : a text field should unregister from the scribble scope, when it becomes unfocusable.
When a `FocusNode` has listeners and its `_canRequestFocus` flag is set to true, it adds `+1` to `_focusabilityListeningDescendantCount` of all ancestors until it reaches the first ancestor with `descendantsAreFocusable = false`. When the a `FocusNode`'s `descendantsAreFocusable` changes, all listeners that contributed to its `_focusabilityListeningDescendantCount` will be notified.
2024-02-29 20:40:46 +00:00
engine-flutter-autoroll
1abc5cdfeb
Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) ( #144416 )
...
1f24eaa497...bb6c6a0100jonahwilliams@google.com [Impeller] test removal of submit batching. (flutter/engine#51094 )
2024-02-29 zanderso@users.noreply.github.com Use RBE for mac_clang_tidy (flutter/engine#51083 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-29 20:24:06 +00:00
