Eric Seidel
8f85f34d27
Fix 2 crashers found by Hixie's fuzzer.
...
The first one is that we weren't setting up a
FontCachePurgePreventer during drawText. It's not clear
that this is the correct fix, since Blink doesn't have
this FontCachePurgePreventer here either, but it's also
possible that they would hit this same ASSERT and just
not care (since ASSERTs are disabled on clusterfuzz).
The second fix is making ExceptionState actually track
whether it has thrown an exception or not. The c++ code
was depending on this working in order to return early
from dom functions and not crash!
R=abarth@google.com
2015-07-21 16:29:04 -07:00
Hixie
9da399b0e1
Rationalise usage of keys in navigator.dart.
...
Route (named routes) no longer have a key, and have their own storage for their names.
RouseState no longer has a key, and uses an owner field pointing to a StatefulComponent instead.
As such, RouteBase no longer has a key.
HistoryEntry no longer uses a global int to ensure uniqueness.
Propagated this to stocks app.
2015-07-21 14:58:48 -07:00
Adam Barth
ed82572205
Roll version to 20
2015-07-21 14:56:54 -07:00
Adam Barth
de717bafe9
Images don't appears in VariableHeightScrollables
...
When we build widgets during layout we weren't notifying those widgets that
they were mounted. Now we notify mount status changes when exiting build phases
inside layout.
Fixes #176
2015-07-21 14:42:21 -07:00
Adam Barth
6b748e653e
Fix more analyzer warnings
2015-07-21 13:59:18 -07:00
Adam Barth
53efc748e1
Merge pull request #191 from abarth/image_height_width
...
Separate width and height parameters for Image widgets
2015-07-21 13:54:56 -07:00
Adam Barth
d5f3168982
Merge pull request #192 from abarth/fix_warnings
...
Fix analyzer warnings
2015-07-21 13:52:37 -07:00
Adam Barth
3ac4c6c998
Fix analyzer warnings
2015-07-21 13:51:27 -07:00
Adam Barth
012b915704
Separate width and height parameters for Image widgets
...
This change makes it easier to defined only the width or the height of an image
and let the other value be filled in from the image's intrinsic aspect ratio.
Fixes #175
2015-07-21 13:46:10 -07:00
mpcomplete
4a0bdf1bba
Merge pull request #188 from mpcomplete/animated_value
...
Renamed AnimatedType to AnimatedValue
2015-07-21 13:45:50 -07:00
Viktor Lidholt
1eff5b8c94
Merge pull request #184 from vlidholt/master
...
Updates sprite widget to handle changes to renderbox
2015-07-21 13:32:22 -07:00
Viktor Lidholt
6c510fb558
Minor formatting fixes
2015-07-21 13:30:30 -07:00
Matt Perry
0fd3302ebe
Renamed AnimatedType to AnimatedValue
2015-07-21 12:55:16 -07:00
Hixie
310412fde5
Minor style changes around demo cards.
2015-07-21 12:18:10 -07:00
Hixie
f3e07210b0
Make typography.white and typography.black constants.
2015-07-21 12:13:10 -07:00
Viktor Lidholt
90363ee956
Merge branch 'master' of github.com:domokit/sky_engine into HEAD
2015-07-21 11:30:52 -07:00
Viktor Lidholt
1b4923a2a6
Adds main screen to game and graphics for game UI
2015-07-21 11:30:17 -07:00
Hans Muller
df88d38b29
Merge pull request #181 from HansMuller/cards-animate-back
...
Dismissable: animate "snap back", only call dismiss() once
2015-07-21 11:27:30 -07:00
Viktor Lidholt
88afaefbaf
Updates sprite widget to handle changes to renderbox
2015-07-21 11:26:57 -07:00
Hans Muller
d8a4a099e0
animate "snap back", only call dismiss() once
2015-07-21 11:20:01 -07:00
Hixie
ddef380875
This demo is a fuzzer of sorts, testing in particular our text layout system and painting.
2015-07-21 10:56:08 -07:00
Hans Muller
f72d61bf5f
manage listener with on,didMount
2015-07-21 08:42:14 -07:00
Hans Muller
3f70271d9b
manage listener with on,didMount
2015-07-21 08:41:58 -07:00
Hans Muller
b0e0e65c09
Fixed several typos
2015-07-21 08:25:49 -07:00
Ian Hickson
4d2e8de287
Update README.md
2015-07-20 22:48:47 -07:00
Ian Hickson
4af1d34c33
Update README.md
...
Try to clarify initial execution.
2015-07-20 22:48:12 -07:00
Adam Barth
7af81f208a
Fix typos in RenderImage
...
This function took innerConstraints as an argument but used constraints internally.
2015-07-20 20:04:03 -07:00
Collin Jackson
40b2a4e53f
Merge pull request #166 from collinjackson/fitness
...
Measurement tracking for fitness app.
There is an issue with the input control that prevents actually creating a measurement. Working on this with eseidel.
R=eseidel
2015-07-20 16:25:19 -07:00
Collin Jackson
d8cbbc68f3
Add basic measurement functionality to fitness app
2015-07-20 16:20:59 -07:00
Hans Muller
c3a8df1d68
Merge pull request #122 from HansMuller/shrinking-card
...
Card Collection dismiss animation
2015-07-20 15:52:09 -07:00
Hans Muller
b954e020c6
Make it possible to identify BlockViewport children whose size or type has changed
2015-07-20 15:41:21 -07:00
Hixie
94a4b97248
Fix typo "natvies" in the build system.
2015-07-20 15:25:59 -07:00
Collin Jackson
84da5238da
Merge pull request #137 from collinjackson/launcher
...
Tweaks to launcher
2015-07-20 14:28:16 -07:00
Collin Jackson
af7c5f8e5a
Tweaks to launcher
2015-07-20 11:20:47 -07:00
Collin Jackson
e90d0ec807
Merge remote-tracking branch 'upstream/master' into baseline5
...
Conflicts:
sky/sdk/lib/rendering/flex.dart
2015-07-20 10:26:06 -07:00
Collin Jackson
8bf1f86a24
abarth feedback
2015-07-20 10:24:52 -07:00
Collin Jackson
8e68805a72
Merge pull request #123 from collinjackson/baseline6
...
Support for non-alphabetic baselines
2015-07-20 10:18:15 -07:00
Adam Barth
41695fb1b5
More typos
2015-07-18 12:48:16 -07:00
Adam Barth
44e0d42c12
Another typo
2015-07-18 12:46:18 -07:00
Adam Barth
7094e17f65
Fix typos in README.md
2015-07-18 12:45:41 -07:00
Adam Barth
b5347ce556
Improve the READMEs further
2015-07-18 12:34:40 -07:00
Adam Barth
1b440cc68b
Improve developer-facing READMEs
...
Also, stop pushing the SDK to sky_sdk now that this repo exists.
2015-07-18 12:22:30 -07:00
Collin Jackson
4604021dd3
Support for non-alphabetic baselines
2015-07-17 17:06:08 -07:00
Collin Jackson
e3d5c2b25e
Draw debug rects when flex overflows
2015-07-17 17:04:59 -07:00
Collin Jackson
e1aa0431be
Merge pull request #110 from collinjackson/baseline2
...
Track overflow during flex layout and fix stocks row
R=hixie
2015-07-17 17:03:52 -07:00
Collin Jackson
62fc9d8515
Track overflow during flex layout
2015-07-17 16:13:15 -07:00
Collin Jackson
65d47af75c
Fix layout of stocks row
2015-07-17 16:10:10 -07:00
Adam Barth
87c56759cc
Merge pull request #99 from abarth/fix_symlink
...
Fix build issues related to symlink.py
2015-07-17 15:44:50 -07:00
Adam Barth
fbf9df582d
Fix build issues related to symlink.py
...
There are actually two uses cases for symlink.py. This CL restores
//build/symlink.py to match the version in Chromium and adds a new version in
////sky/build/symlink.py that works properly for the material-design-icons.
2015-07-17 15:41:40 -07:00
Collin Jackson
c80f1c7c31
Merge pull request #95 from collinjackson/baseline
...
Fix #57 Flex needs to understand baselines
2015-07-17 14:29:29 -07:00
