338 Commits

Author SHA1 Message Date
Ian Hickson
8fdd2066b3 DefaultTextStyle.merge and IconTheme.merge improvements (#9358)
I can't figure out if this is genius or a giant hack.

This lets you use DefaultTextStyle.merge and IconTheme.merge without
specifying a BuildContext. It automatically merges in at the
appropriate place in the tree using a Builder widget.
2017-04-13 10:26:40 -07:00
Ian Hickson
aaa0a1cfc3 Make test.dart support Emacs buffers better (#9353)
In particular, if stdout.supportsAnsiEscapes is false, don't output ANSI.

Also, output stdout/stderr of tests that are normally silenced, if they fail.

Also, update the output to be more convenient when debugging.

Also, expand some abbreviations.
2017-04-13 10:22:41 -07:00
Ian Hickson
bf017b79b3 Move Point to Offset (#9277)
* Manually fix every use of Point.x and Point.y

Some of these were moved to dx/dy, but not all.

* Manually convert uses of the old gradient API

* Remove old reference to Point.

* Mechanical changes

I applied the following at the root of the Flutter repository:

git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'

* Mechanical changes - dartdocs

I applied the following at the root of the Flutter repository:

git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'

* Further improvements and a test

* Fix minor errors from rebasing...

* Roll engine
2017-04-12 15:06:12 -07:00
Ian Hickson
2a54524337 Fix tests to use Ahem, and helpful changes around that (#9332)
* Fix tests to use Ahem, and helpful changes around that

- Fix fonts that had metric-specific behaviours.

- LiveTestWidgetsFlutterBinding.allowAllFrames has been renamed
  to LiveTestWidgetsFlutterBinding.framePolicy.

- LiveTestWidgetsFlutterBinding now defaults to using a frame policy
  that pumps slightly more frames, to animate the pointer crosshairs.

- Added "flutter run --use-test-fonts" to enable Ahem on devices.

- Changed how idle() works to be more effective in live mode.

- Display the test name in live mode (unless ahem fonts are enabled).

- Added a toString to TextSelectionPoint.

- Style nit fixes.

* Roll engine to get Ahem changes.

* Update tests for dartdoc changes.

* Fix flutter_tools tests
2017-04-12 13:33:02 -07:00
Yegor
9dfcc6ec79 Revert "temporarily mark iOS tests as flaky (#9314)" (#9333)
This reverts commit ff23a1ebfe5d01af8924761253cc574f23ac5295.

Our iOS lab hardware is back to normal.
2017-04-11 12:26:15 -07:00
xster
89a7fdfc56 Rename State.config to widget everywhere (#9273)
Rename State.config to State.widget
Rename State.didUpdateConfig to State.didUpdateWidget
Renamed all State subclasses' local variables named config to something else
2017-04-10 18:32:24 -07:00
Yegor
a5593b1678 fix analyzer warning: use const where possible (#9320) 2017-04-10 14:20:47 -07:00
Yegor
ff23a1ebfe temporarily mark iOS tests as flaky (#9314) 2017-04-10 10:51:31 -07:00
Alexandre Ardhuin
610955f81d upgrade to linter-0.1.30 (#9297)
* upgrade to linter-0.1.30

* add prefer_is_empty lint
* add directives_ordering lint
* add no_adjacent_strings_in_list lint
* add no_duplicate_case_values lint
* add prefer_collection_literals lint
* add prefer_const_constructors lint
* add prefer_contains lint
* add prefer_initializing_formals lint
* add unnecessary_null_aware_assignments lint
* add unnecessary_null_in_if_null_operators lint
2017-04-08 08:43:19 +02:00
Ian Hickson
ebe6da5b17 Rename BlockBody to ListBody. (#9291)
Nobody knew what a Block was.
2017-04-07 17:14:54 -07:00
Ian Hickson
3eb87830e9 Constants! Constants everywhere! (#9286)
Aggressively apply the const lint.
2017-04-07 12:24:32 -07:00
Yegor
d538c11486 update devicelab docs (#9274) 2017-04-06 16:27:29 -07:00
Yegor
57ca2b5ce8 obey custom timeout supplied by cocoon (#9260) 2017-04-06 10:48:45 -07:00
Michael Goderbauer
a559b8df5c [Regression] Re-enable ANSI color support on Windows (#9232)
Also adds a test to make sure we don't break it again.
2017-04-05 15:44:22 -07:00
Ian Hickson
86a490ffe8 Tracked skipped tests in technical debt benchmark (#9206) 2017-04-05 12:23:21 -07:00
Ian Hickson
896ffcdf17 Disable test that is turning the tree red. (#9204)
This issue is being tracked at: https://github.com/dart-lang/sdk/issues/29230
2017-04-04 17:01:38 -07:00
Alexandre Ardhuin
189028a958 Separate the 'if' expression from its statement (#9177) 2017-04-04 21:45:50 +02:00
Yegor
1182eb18c5 add "flaky" and "timeout_in_minutes" devicelab task options (#9168) 2017-04-04 10:46:07 -07:00
xster
4245bce545 Add full platform build speed instrumentations (#9162)
* Add new metric to size_tests instead

* Small lints
2017-04-04 01:05:53 -07:00
Adam Barth
ae8994860e Rationalize text input widgets (#9119)
After this patch, there are three major text input widgets:

 * EditableText. This widget is a low-level editing control that
   interacts with the IME and displays a blinking cursor.

 * TextField. This widget is a Material Design text field, with all the
   bells and whistles. It is highly configurable and can be reduced down
   to a fairly simple control by setting its `decoration` property to
   null.

 * TextFormField. This widget is a FormField that wraps a TextField.

This patch also replaces the InputValue data model for these widgets
with a Listenable TextEditingController, which is much more flexible.

Fixes #7031
2017-04-01 17:30:21 -07:00
Adam Barth
89aaaa9c32 Improve focus management (#9074)
We now have an explicit focus tree that we manage. Instead of using
GlobalKeys to manage focus, we use FocusNode and FocusScopeNode objects.
The FocusNode is Listenable and notifies when its focus state changes.

Focus notifications trigger by tree mutations are now delayed by one
frame, which is necessary to handle certain complex tree mutations. In
the common case of focus changes being triggered by user input, the
focus notificiation still arives in the same frame.
2017-03-31 13:10:37 -07:00
Chris Bracken
abfee824cd Re-enable iOS transitions test in devicelab (#9097)
This reverts commit 326355f0f913c954f92aa74612daa78be22755dd.
2017-03-29 19:19:57 -07:00
Yegor
e067041279 increase vmservice timeout; log stderr in microbenchmarks (#9088) 2017-03-29 15:40:17 -07:00
Ian Hickson
326355f0f9 Turn off this flaky test for now. (#9065)
cc @cbracken
2017-03-28 16:40:13 -07:00
Jason Simmons
f7d0aa03f8 Throw an exception if flutter run fails during a microbenchmark (#9061) 2017-03-28 15:46:53 -07:00
Yegor
0ec3ffb4bc increase total task timeout; decrease individual benchmark timeout (#9063) 2017-03-28 15:42:06 -07:00
Michael Goderbauer
506aea0316 enable windows tests with workaround (#9058) 2017-03-28 14:22:03 -07:00
Collin Jackson
e2b49d64d6 Revert "Revert "Revert "Include fragment support in Android build to allow use of FragmentActivity in FlutterActivity (#9036)"" (#9046)" (#9047)
Test is still failing with increased timeout.

This reverts commit 864b3c37c65a4294735bbdb041d17b112a2659cc.
2017-03-27 19:16:58 -07:00
Collin Jackson
864b3c37c6 Revert "Revert "Include fragment support in Android build to allow use of FragmentActivity in FlutterActivity (#9036)"" (#9046)
Increased the time limit slightly to allow the microbenchmark test time to finish.
2017-03-27 18:12:14 -07:00
Michael Goderbauer
cea7c66dfd Disable flaky WIndows test :( (#9029) 2017-03-27 14:04:50 -07:00
Sarah Zakarias
d274888be6 Rename platform_services to platform_channel (#9018)
* Rename platform_services to platform_channel

* rename in README

* renamed tests

* update modules.xml
2017-03-27 11:17:31 +02:00
Hans Muller
606f56221b Eliminated DrawerItem, use ListTile instead (#8992) 2017-03-24 15:34:43 -07:00
Yegor
71690343fb detailed error message re missing xcconfigs (#9001) 2017-03-24 10:35:21 -07:00
Sarah Zakarias
912279bf6f Patch Debug/Release.xcconfig files in devicelab tests (#9000) 2017-03-24 15:57:06 +01:00
Sarah Zakarias
47fc81f14d Revert "Remove flutter_view_ios__start_up.dart (#8978)" (#8996)
This reverts commit 38e4e48d06cd23cecc3168e9c89d686e88a683ef.
2017-03-24 11:45:57 +01:00
Yegor
bc8cc80b9f Xcode 8-compatible provisioning profiles in devicelab tests (#8987) 2017-03-23 17:35:04 -07:00
Sarah Zakarias
38e4e48d06 Remove flutter_view_ios__start_up.dart (#8978) 2017-03-23 16:06:09 +01:00
Sarah Zakarias
18db5a2e68 Add start-up test for flutter_view sample (#8892)
* Add start-up test for flutter_view sample

* add reportMetrics flag to startup test

* rewording in manifest.yaml
2017-03-23 13:20:00 +01:00
Mikkel Nygaard Ravn
e918ef5dbe Updated microbenchmark ios project according to #8971 (#8976) 2017-03-23 10:13:38 +01:00
Mikkel Nygaard Ravn
f9336e2bbd Updated complex_layout ios project according to #8971 (#8974) 2017-03-23 09:32:55 +01:00
Alexandre Ardhuin
578ca0a295 use color.shadeXxx instead of color[Xxx] (#8932)
* use color.shadeXxx instead of color[Xxx]

* remove calls to .shade500 on MaterialColor

* remove calls to .shade200 on MaterialAccentColor

* fix test
2017-03-21 23:14:55 +01:00
Adam Barth
97816e1571 Rename Dismissable to Dismissible (#8919)
The latter is the proper spelling.

Fixes #8883
2017-03-20 16:17:08 -07:00
Ian Hickson
11c2032a4e Run both regular and --watch analysis on Travis (#8913)
We keep breaking --watch because we don't test it.
2017-03-20 16:16:34 -07:00
Sarah Zakarias
d1f73fd0ad Add integration test for the Platform Services app (#8826) 2017-03-20 22:19:03 +01:00
Jakob Andersen
03f053a738 Update complex_layout and microbenchmarks to Gradle build. (#8890) 2017-03-20 16:15:02 +01:00
Hans Muller
031e042eee Now each Colors.foo constant is-a Color and a color swatch (#8833) 2017-03-17 15:24:54 -07:00
Michael Goderbauer
9781f1aff0 make hot_mode_dev_cycle benchmark run in verbose mode (#8862) 2017-03-17 12:16:19 -07:00
Devon Carew
9f770ec8a3 update IntelliJ metadata (#8844) 2017-03-17 09:39:18 -07:00
Alexandre Ardhuin
a0769f2488 apply the upcoming rule unnecessary_this (#8838) 2017-03-17 08:05:42 +01:00
Ian Hickson
2bbe82ef30 Increase timeout and verbosity to diagnose devicelab failure (#8832) 2017-03-16 15:02:43 -07:00