20361 Commits

Author SHA1 Message Date
Eilidh Southren
c5e8757fcb
Add M3 support for iconbuttons in error state in TextFields (#119925)
* add m3 iconbutton override

* changes

* spring cleaning

* whitespace fix

* sneaky whitespaces
2023-02-03 14:35:12 +00:00
Polina Cherkasova
e0b2138ba7
Dispose OverlayEntry in TooltipState. (#117291) 2023-02-03 06:31:47 -08:00
Jonah Williams
69421c1682
[framework] use shader tiling instead of repeated calls to drawImage (#119495)
* [framework] use shader tiling instead of repeated calls to drawImage

* ++

* ++

* review and test updates

* ++

* Update decoration_image.dart

* Update decoration_image.dart

* ++

* ++

* ++

* ++

* ++

* Update painting.dart

* Update decoration_test.dart
2023-02-03 07:28:57 +00:00
Kate Lovett
3570cce58e
Remove deprecated kind in GestureRecognizer et al (#119572)
* Remove deprecated kind in GestureRecognizer et al

* Fix null case
2023-02-03 01:34:17 +00:00
Kevin Moore
a27802e2db
flutter_tool: remove explicit length header in HTTP response (#119869)
This is already handled by pkg:shelf
There is some subtlety with String here, since String.length might not
align with the size in bytes over the wire, depending on the contents
and the encoding

Best to just let pkg:shelf handle it
2023-02-03 01:27:23 +00:00
Greg Spencer
c6264605d9
Make _focusDebug not interpolate in debug mode (#119680)
* Make _focusDebug not interpolate in debug mode

* Add test

* Revert undesired change

* Fix test to fail before too

* Remove accidental skips

* Switch to using a generating closure for arguments.

* Remove a word
2023-02-03 01:27:20 +00:00
Flutter GitHub Bot
cfdc35859e
roll packages (#119865) 2023-02-02 23:59:49 +00:00
Christopher Fujino
d820aec786
Manual pub roll with dwds fix (#119575)
* roll packages

* fix dwds

* empty

---------

Co-authored-by: fluttergithubbot <fluttergithubbot@gmail.com>
2023-02-02 21:38:08 +00:00
Danny Tuppeny
8387c2388b
[flutter_tools] Use base DAP detach and ensure correct output (#119076) 2023-02-02 13:28:12 -08:00
Mouad Debbar
d4b6898478
[web] Put all index.html operations in one place (#118188)
* [web] Put all index.html operations in one place

* review comments

* fix build

* change quotes

* fix test
2023-02-02 19:49:18 +00:00
Michael Goderbauer
b0f1714b7b
Make Flex,Row,Column const for real (#119673)
* Make Flex,Row,Column const for real

* dart fix --apply

* fix snippets

* fix integration test

* add comment
2023-02-02 19:33:57 +00:00
Pierre-Louis
07b51a0dbb
Add missing variants and *new* indicators to useMaterial3 docs (#119799)
* Add missing variants and *new* indicators to useMaterial3 docs

* add missing *new*
2023-02-02 18:27:33 +01:00
Eilidh Southren
1ee87990dc
Revert "[Re-land] Exposed tooltip longPress (#118796)" (#119832)
This reverts commit d27880801435109432dcada4a2245193af4ae1f2.
2023-02-02 17:11:19 +00:00
Sigurd Meldgaard
ca0596e41d
Fix pub get --unknown-flag (#119622) 2023-02-02 16:22:39 +01:00
Andrew Kolos
fd76ef0f26
Reland "Add API for discovering assets" (#119277)
* add asset manifest bin loading and asset manifest api

* use new api for image resolution

* remove upfront smc data casting

* fix typecasting issue

* remove unused import

* fix tests

* lints

* lints

* fix import

* revert image resolution changes

* Update image_resolution_test.dart

* Update decode_and_parse_asset_manifest.dart

* make targetDevicePixelRatio optional

* Update packages/flutter/lib/src/services/asset_manifest.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* Update packages/flutter/lib/src/services/asset_manifest.dart

Co-authored-by: Jonah Williams <jonahwilliams@google.com>

* fix immutable not being imported

* return List in AssetManifest methods, fix annotation import

* simplify onError callback

* make AssetManifest methods abstract instead of throwing UnimplementedError

* simplify AssetVariant.key docstring

* tweak _AssetManifestBin docstring

* make AssetManifest and AssetVariant doc strings more specific

* use List.of instead of List.from for type-safety

* adjust import

* change _AssetManifestBin comment from doc comment to normal comment

* revert to callback function for onError in loadStructuredBinaryData

* add more to the docstring of AssetManifest.listAssets and AssetVariant.key

* add tests for CachingAssetBundle caching behavior

* add simple test to ensure loadStructuredBinaryData correctly calls load

* Update asset_manifest.dart

* update docstring for AssetManifest.getAssetVariants

* rename getAssetVariants, have it include main asset

* rename isMainAsset field of AssetMetadata to main

* (slightly) shorten name of describeAssetAndVariants

* rename describeAssetVariants back to getAssetVariants

* add tests for TestAssetBundle

* nits

* fix typo in docstring

* remove no longer necessary non-null asserts

* update gallery and google_fonts versions

---------

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2023-02-02 15:17:15 +00:00
Jesús S Guerrero
f767f860eb
check if directory exists before listing content (#119748) 2023-02-02 03:02:11 +00:00
Greg Spencer
2ecf4ae962
Update the counter app to enable Material 3 (#118835)
* Update the counter app to enable Material 3

* Fix tools tests

* Update some wording

* Revert all but useMaterial3

* Update comments
2023-02-02 00:08:11 +00:00
Ian Hickson
4c99da6c56
Avoid printing blank lines between "Another exception was thrown:" messages. (#119587) 2023-02-01 23:57:54 +00:00
Alex Li
4ae2d3b6df
🔥 Do not format the messages file for gen-l10n (#119596)
* 🔥 Do not format the messages file

*  Add test

*  Add the link to the test

*  Respect the path separator from the file system

*  Add the untranslated messages file existence test
2023-02-01 23:45:38 +00:00
Jason Simmons
cd118dada9
Update a test expectation that depended on an SkParagraph fix (#119756)
This assertion had been disabled because a bug fix was pending in
SkParagraph.  This PR updates it to match the new behavior.

See https://github.com/flutter/flutter/pull/119653
2023-02-01 22:55:02 +00:00
Michael Goderbauer
7a926dcb03
Deprecate MediaQuery[Data].fromWindow (#119647)
* Deprecate MediaQuery[Data].fromWindow

* ++

* dart fix
2023-02-01 22:44:00 +00:00
Michael Goderbauer
8fd5d4ebb1
Remove deprecated SystemNavigator.routeUpdated method (#119187)
* Remove deprected SystemNavigator.routeUpdated

* test fix
2023-02-01 22:36:11 +00:00
Ian Hickson
578edfc856
Catch errors thrown while handling pointer events (#119577) 2023-02-01 22:25:57 +00:00
Taha Tesser
73124dcd38
Fix ListTileThemeData.copyWith doesn't override correct properties (#119738) 2023-02-01 22:07:02 +00:00
Phil Quitslund
5613ab010d
remove unnecessary parens (#119736) 2023-02-01 19:19:13 +00:00
Zachary Anderson
254a796bc3
Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (#119729)
This reverts commit 7477d7ac79debc06e92a72cec3f59178c74bc44d.
2023-02-01 09:19:48 -08:00
Eilidh Southren
d278808014
[Re-land] Exposed tooltip longPress (#118796)
* Check whether slider is mounted before interaction, no-op if unmounted (#113556)

* Check whether slider is unmounted before interaction

* Update slider.dart

* Update Slider

* Add test

* Update slider_test.dart

* Update packages/flutter/test/material/slider_test.dart

Co-authored-by: Taha Tesser <tessertaha@gmail.com>

Co-authored-by: Taha Tesser <tessertaha@gmail.com>

* exposed tooltip longPress action when available

* updated tooltip test

* updated date picker test

---------

Co-authored-by: Mingyu <lyming90@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Harper Liu <harperl0818@gmail.com>
2023-02-01 15:53:41 +00:00
Callum Moffat
97d273ce1f
CupertinoThemeData equality (#119480) 2023-02-01 07:13:18 +00:00
Callum Moffat
a752c2f154
Expose enableIMEPersonalizedLearning on CupertinoSearchTextField (#119439) 2023-02-01 05:41:16 +00:00
Alex Li
8d0af36798
🥅 Produce warning instead of error for storage base url overrides (#119595)
* 🥅 Only log warning for storage base url

*  Add test

*  Add the link to the test

*  Remove the test

*  Remove the extra import
2023-02-01 03:49:31 +00:00
Michael Goderbauer
82df23539f
Undo making Flex,Row,Column const (#119669) 2023-01-31 18:03:09 -08:00
Hans Muller
198a51ace9
Migrate the Material Date pickers to M3 Reprise (#119033) 2023-01-31 15:31:06 -08:00
Tae Hyung Kim
3884381415
Make gen-l10n error handling independent of logger state (#119644)
* init

* lint

* lint again
2023-01-31 15:28:27 -08:00
Jason Simmons
fbe9ff33e6
Disable an inaccurate test assertion that will be fixed by an engine roll (#119653)
https://skia-review.googlesource.com/c/skia/+/619838 fixes a bug in
SkParagraph.  One of the selectable region tests relies on the old
behavior.

After that Skia change rolls into the framework, the update to the test
in https://github.com/flutter/flutter/pull/118902 should be landed.
2023-01-31 22:17:43 +00:00
Ian Hickson
ff22813b77
separatorBuilder can't return null (#119566)
...so remove the assert
2023-01-31 20:23:02 +00:00
Tanay Neotia
0e22aca785
Add support for image insertion on Android (#110052)
* Add support for image insertion on Android

* Fix checks

* Use proper Dart syntax on snippet

* Specify type annotation on list

* Fix nits, add some asserts, and improve example code

* Add missing import

* Fix nullsafety error

* Fix nullsafety error

* Remove reference to contentCommitMimeTypes in docs

* Fix nits

* Fix warnings and import

* Add test for content commit in editable_text_test.dart

* Check that URIs are equal in test

* Fix nits and rename functions / classes to be more self-explanatory

* Fix failing debugFillProperties tests

* Add empty implementation to `insertContent` in TextInputClient

* Tweak documentation slightly

* Improve docs for contentInsertionMimeTypes and fix assert

* Rework contentInsertionMimeType asserts

* Add test for onContentInserted example

* Switch implementation to a configuration class for more granularity in setting mime types

* Fix nits

* Improve docs and fix doc tests

* Fix more nits (LongCatIsLooong)

* Fix failing tests

* Make parameters (guaranteed by platform to be non-nullable) non-nullable

* Fix analysis issues
2023-01-31 19:46:18 +00:00
Bruno Leroux
e2b3d89e7a
Fix CupertinoNavigationBar should create a backward compatible Annota… (#119515)
* Fix CupertinoNavigationBar should create a backward compatible AnnotatedRegion

* Remove extra space
2023-01-31 19:36:38 +00:00
Michael Goderbauer
6a5405925d
Make MultiChildRenderObjectWidget const (#119195) 2023-01-31 11:13:59 -08:00
Michael Goderbauer
2fccf4d471
Remove MediaQuery from WidgetsApp (#119377)
* Remove MediaQuery from WidgetsApp

* more

* fix test

* more deprecation notices.
2023-01-31 17:55:54 +00:00
Ian Hickson
d4c74858fd
Make Decoration.padding non-nullable (#119581)
The default implementation returns EdgeInsets.zero, the ShapeDecoration subclass already makes it non-nullable, and there isn't any benefit to returning null as far as I can tell.
2023-01-31 17:51:49 +00:00
Victoria Ashworth
f6b0c6ddef
Use first Dart VM Service found with mDNS if there are duplicates (#119545)
* fix when duplicate mdns results are found

* put mdns auth code in it's own function and update tests

* add comments, refactor auth code parsing, other small tweaks
2023-01-31 17:48:19 +00:00
Chris Bracken
d272a3ab80
Reland: [macos] add flavor options to tool commands (#119564)
* Reland: [macos] add flavor options to tool commands

Adds --flavor option to flutter run and flutter build. Running against
preexisting devicelab flavor tests for feature parity between macOS,
iOS, and Android.

This relands #118421 by alex-wallen which was reverted in #118858 due to
the following test failures:

The bail-out with "Host and target are the same. Nothing to install."
added in `packages/flutter_tools/lib/src/commands/install.dart`
triggered failures in the following tests, which unconditionally attempt
to install the built app, which is unsupported on desktop since the
host and target are the same:

* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout

Fixes #64088

* Partial revert: eliminate install check on desktop

The original flavour support patch included a check that triggered a
failure when flutter install is run on desktop OSes. This was
intentional, since the host and target devices are the same and
installation is unnecessary to launch the app on currently-supported
desktop OSes.

Note that Windows UWP apps *do* require installation to run, and we used
to have an install command for those apps, though UWP is no longer
supported.

Since that part of the change was orthogonal to flavour support itself,
I'm reverting that component of the change and we can deal with it
separately if so desired.
2023-01-31 17:37:46 +00:00
Danny Tuppeny
67d07a6de4
[flutter_tools] Fix parsing of existing DDS URIs from exceptions (#119506)
* [flutter_tools] Fix parsing of existing DDS URIs from exceptions

Fixes #118609.

* Fix formatting

Co-authored-by: Christopher Fujino <fujino@google.com>

* Fix formatting

Co-authored-by: Christopher Fujino <fujino@google.com>

---------

Co-authored-by: Christopher Fujino <fujino@google.com>
2023-01-31 17:36:44 +00:00
Casey Hillers
7ba440655a
Revert "[Re-land#2] Button padding M3 (#119498)" (#119597)
This reverts commit 530c3f2d13bae3c45510ae5e4a0d9a5cd987a5aa.
2023-01-30 20:37:21 -08:00
Michael Goderbauer
5b6572f96d
Add debug diagnostics to channels integration test (#119579) 2023-01-31 02:55:01 +00:00
Michael Goderbauer
65900b71b9
Remove deprecated AnimatedSize.vsync parameter (#119186)
* Remove deprecated AnimatedSize.vsync parameter

* add dartfix

* Update packages/flutter/lib/fix_data/fix_widgets/fix_widgets.yaml

* Update packages/flutter/lib/fix_data/fix_widgets/fix_widgets.yaml

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-01-31 02:52:49 +00:00
LongCatIsLooong
1148a2a8ba
Migrate EditableTextState from addPostFrameCallbacks to compositionCallbacks (#119359)
* PostFrameCallbacks -> compositionCallbacks

* review

* review
2023-01-31 01:39:09 +00:00
Renzo Olivares
1f0b6fbd7a
Remove deprecated AppBar/SliverAppBar/AppBarTheme.textTheme member (#119253)
* remove textTheme usage from AppBar SliverAppBar and AppBarTheme and migrate usages in the framework

* Fix test

* update _PackageLicensePageTitle to accept titleTextStyle

* Fix test

---------

Co-authored-by: Renzo Olivares <roliv@google.com>
2023-01-31 00:00:43 +00:00
LongCatIsLooong
329f86a907
Make a few values non-nullable in cupertino (#119478) 2023-01-30 22:51:21 +00:00
Loïc Sharma
18c7f8a278
Fix typo in --machine help text (#119563) 2023-01-30 22:46:48 +00:00