124 Commits

Author SHA1 Message Date
Justin McCandless
93b0042559
Handle dragging improvements (#114042)
Improves the feel of dragging text selection vertically between lines on mobile.
2022-11-01 12:36:51 -07:00
Justin McCandless
0b451b6dfd
Context Menus (#107193)
* Can show context menus anywhere in the app, not just on text.
* Unifies all desktop/mobile context menus to go through one class (ContextMenuController).
* All context menus are now just plain widgets that can be fully customized.
* Existing default context menus can be customized and reused.
2022-10-28 12:40:09 -07:00
Renzo Olivares
29397c2c7d
Fix selectWordsInRange when last word is located before the first word (#113224) 2022-10-24 17:53:48 +00:00
Anthony Oleinik
4ceeca0833
Added example for Magnifier and TextMagnifier (#110218) 2022-09-23 20:29:32 +00:00
Anthony Oleinik
f014c1e6dc
Loupe Android + iOS (#107477)
* added Magnifier for iOS and Android
2022-08-02 11:43:12 -07:00
xubaolin
c4df6b6d09
[SelectionOverlay]Move the debug statement to the scope of the assertion. (#108508) 2022-08-02 04:37:04 +00:00
xubaolin
09b6672e77
Do not crash when remove SelectableText during handle drag (#108369) 2022-07-27 05:22:05 +00:00
Taha Tesser
680a7bc8e8
SelectableText.rich: Fix TextSpan.style not merged into default text style (#101911)
Properly merges the TextSpan.style of SelectableText.rich.
2022-07-06 13:20:51 -07:00
Alexandre Ardhuin
526ca0d498
Export public API types from foundation/scheduler/gestures/semantics (#106409) 2022-06-24 21:21:05 +00:00
Zachary Anderson
d87b0dde05
Revert "Hide text selection toolbar when dragging handles on mobile (#104274)" (#105247)
This reverts commit 4ec4c249ea5d62d6ef06e6d2e6af48c4500decb2.
2022-06-02 12:37:13 -07:00
Markus Aksli
4ec4c249ea
Hide text selection toolbar when dragging handles on mobile (#104274) 2022-06-02 11:18:12 -07:00
Pierre-Louis
2aa348b940
Use curly_braces_in_flow_control_structures for widgets (#104609)
* Use `curly_braces_in_flow_control_structures` for `widgets`

* fix comments

* fix comments
2022-05-26 09:48:09 +02:00
Michael Goderbauer
d5fbc3750e
Remove unused code from tests (#104550) 2022-05-25 09:38:09 -07:00
Tong Mu
23bc3d64eb
[Mouse] Remove all pointers at the end of tests (#102694) 2022-05-19 17:48:10 -07:00
Justin McCandless
715fcaac72
Can't drag the cursor with the mouse (#103002) 2022-05-18 17:32:12 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
chunhtai
52fd2412f4
Reland "Add default selection style (#100719)" (#101954) 2022-04-15 16:44:07 -07:00
Justin McCandless
916b2aa76b
Linux and Windows right clicking text behavior (#101588) 2022-04-14 17:44:06 -07:00
chunhtai
95e52dac76
Revert "Add default selection style (#100719)" (#101921)
* Revert "Add default selection style (#100719)"

This reverts commit c8057bc5064f54c04cbe054f00904722a7233a63.

* update

* update
2022-04-14 11:31:39 -07:00
chunhtai
c8057bc506
Add default selection style (#100719) 2022-04-13 11:49:09 -07:00
chunhtai
93fc7f59a5
fix hidden TextSpan with recognizer does not auto scroll (#100494) 2022-03-24 13:39:55 -07:00
chunhtai
d486aa7040
Refactor TextSelectionOverlay (#98153)
* Refactor TextSelectionOverlay

* fix test

* remove print

* fix more tests

* update

* added tests

* fix comments

* fmt

* fix test

* addressing comment

* remove dispose

* remove new line
2022-02-11 13:06:05 -08:00
chunhtai
ac3189c341
Remove RenderEditable dependency from TextSelectionHandleOverlay (#97967) 2022-02-07 18:20:18 -08:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. (#89451) 2022-02-03 14:55:15 -08:00
Justin McCandless
e9553cd5df
SelectableText keep alive only when it has selection (#94493)
SelectableText defers to EditableText for wantKeepAlive, plus improved docs.
2021-12-03 13:33:55 -08:00
Kate Lovett
c7572150fa
Skip the right web golden file test (#93740) 2021-11-16 16:20:15 -06:00
Kate Lovett
e0e8d28e0b
Skip negative web image test (#93722) 2021-11-16 12:06:37 -06:00
LongCatIsLooong
ffcd32ebb6
Move text editing Actions to EditableTextState (#90684) 2021-11-03 11:11:32 -07:00
Gary Qian
1daae0b0ae
Remove assert that prevents WidgetSpans from being used in SelectableText (#92295) 2021-10-25 16:23:03 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be244244e14ff87fee9b6a721625f952cd.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Pierre-Louis
8d5d37d6df
Exclude semantics is semanticslabel is present (#90136) 2021-09-20 12:18:05 -07:00
Pierre-Louis
b129fffa23
Add semanticsLabel to SelectableText (#89369)
* add `semanticsLabel` to `SelectableText`

* remove unused vars

* Squashed commit of the following:

commit 3e687a9facfba751667529dd10194403c85e3d2f
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Sep 14 17:42:05 2021 -0400

    Roll Plugins from 4a98e239b131 to b85edebe7134 (2 revisions) (#90083)

commit ad936b4e4b778dde40b6adfea265b5f97f76f62d
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Tue Sep 14 14:39:17 2021 -0700

    [flutter_conductor] Support initial stable release version (#89775)

commit ff5dd54c6e2314e358d2e75d9c2c4fe24ed466d7
Author: Ian Hickson <ian@hixie.ch>
Date:   Tue Sep 14 13:02:04 2021 -0700

    Mention the ToS on our README (#89765)

commit 8587b609a6b2cd253c9718c61fdebf89a2039169
Author: Kate Lovett <katelovett@google.com>
Date:   Tue Sep 14 14:53:33 2021 -0500

    Update local gold api (#90072)

commit 7d368dcf0c00b45fef5b02c5cccb8aa5306234ba
Author: Justin McCandless <jmccandless@google.com>
Date:   Tue Sep 14 12:39:19 2021 -0700

    InteractiveViewer with a child of zero size (#90012)

    Asserts that the InteractiveViewer child can't have zero size.

commit 2b4ef184b7217bdc34e5b382398bc9077f748150
Author: Akira Aratani <developer.a.akira@gmail.com>
Date:   Wed Sep 15 03:30:50 2021 +0900

    Fix document of the switch. (#89641)

commit a2cd16ba826cb8708f5b2ded9c99c6aa200551d9
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Tue Sep 14 11:22:02 2021 -0700

    use test logger, which does not allow colors (#90010)

commit 0f0613c0aee159ff2089b4ce788744f8cbe46c3a
Author: Varun Sharma <varunsh@stepsecurity.io>
Date:   Tue Sep 14 11:17:03 2021 -0700

    Add specific permissions to .github/workflows/lock.yaml (#89820)

commit 2866f79c89e9540595727481b51c783dc65e8bbe
Author: Jason Simmons <jason-simmons@users.noreply.github.com>
Date:   Tue Sep 14 10:46:35 2021 -0700

    Initialize all bindings before starting the text_editing_action_target test suite (#90067)

    Fixes https://github.com/flutter/flutter/issues/90057

commit b889915997df2ad9f4329b7caba1eee6b2c53b31
Author: Michael Thomsen <mit@google.com>
Date:   Tue Sep 14 14:08:36 2021 +0200

    Change min Dart SDK constraint to track actual version (#88743)

commit 3b7adb989fc59fd6aa906ee642d749b26f1a4b29
Author: godofredoc <54371434+godofredoc@users.noreply.github.com>
Date:   Mon Sep 13 21:32:04 2021 -0700

    Lock only issues. (#90023)

commit 528f77dc99e43f3eb20698cb683c25705725ced0
Author: Dan Field <dnfield@google.com>
Date:   Mon Sep 13 19:10:15 2021 -0700

    Opacity fix (#90017)

    * Make sure Opacity widgets/layers do not drop the offset

commit 2470f63ebba59ebdd9a7127a7c51c22471f3b1d7
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Sep 13 22:07:02 2021 -0400

    4a98e239b [flutter_plugin_tools] Make no unit tests fatal for iOS/macOS (flutter/plugins#4341) (#90016)

commit a01e4733df822f641fb017f3d6d4c56de7427f5d
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Mon Sep 13 20:57:05 2021 -0400

    Re-enable plugin analysis test (#89856)

commit cdad35f2d87f2684d6b651d8db17e938d3570d8a
Author: Aneesh Rao <sidrao2006@gmail.com>
Date:   Tue Sep 14 05:17:04 2021 +0530

    Fix path in example (#84707)

commit 576aab08334e9f7989b32620cdc6b58d31162111
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Mon Sep 13 15:47:03 2021 -0700

    add analysis_options.yaml to dev/conductor (#90005)

commit fad5e4cf892bcf65ad3f1cde092cfb9671c3de99
Author: Jason Simmons <jason-simmons@users.noreply.github.com>
Date:   Mon Sep 13 13:37:07 2021 -0700

    Remove a redundant test case in the flutter_tools create_test (#89872)

commit 738430cad787543bd815beb256acf29161771d92
Author: Darren Austin <darrenaustin@google.com>
Date:   Mon Sep 13 13:33:48 2021 -0700

    Revert "Removed default page transitions for desktop and web platforms. (#82596)" (#89997)

    This reverts commit 43e31977

commit 9db9256b38ea33641b7bc02b537501ccde3a9957
Author: Dan Field <dnfield@google.com>
Date:   Mon Sep 13 13:15:19 2021 -0700

    Revert "Make sure Opacity widgets/layers do not drop the offset (#89264)" (#89999)

    This reverts commit 0d0f7a4fb065da5de8640f1d6757cd5b9bc5534b.

commit 00f78cf263066dedaa5cddfccb9e8c4d620abe13
Author: keyonghan <54558023+keyonghan@users.noreply.github.com>
Date:   Mon Sep 13 13:04:01 2021 -0700

    renew cirrus key (#89988)

commit 826da7f82665c37a10dd3281e66dd14a205dc42d
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Sep 13 15:52:03 2021 -0400

    cfc8a20a1 renew cirrus key (flutter/plugins#4340) (#89996)

commit cd112e551c6a49434e30bd375e28144ab739c7a3
Author: Anna Gringauze <annagrin@google.com>
Date:   Mon Sep 13 12:13:42 2021 -0700

    Update all packages (#89797)
2021-09-15 11:51:47 +02:00
Justin McCandless
2382b4c046
Text Editing Model Refactor (#86736)
Simplifying and refactoring parts of RenderEditable. Functionality is the same.
2021-09-07 14:12:38 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets (#86821) 2021-08-30 15:41:02 -07:00
Justin McCandless
91ef92d2b2
hasStrings support for eliminating clipboard notifications (#87678)
Use the hasStrings clipboard method when possible instead of reading the contents of the clipboard.
2021-08-26 17:10:18 -07:00
Darren Austin
e2fb5cc318
Updated skipped tests for widgets directory. (#87879) 2021-08-09 15:05:44 -07:00
LongCatIsLooong
d3bdbed498
[EditableText] preserve selection/composition range on unfocus (#86796) 2021-08-06 17:45:02 -07:00
Angjie Li
22436cca0e
Revert "Avoid passive clipboard read on Android (#86791)" (#87375) 2021-08-02 14:40:04 -07:00
chunhtai
67cee63087
Add string attribute api to text span (#86667) 2021-07-30 15:49:04 -07:00
Tong Mu
caf876cf40
Reland: Keyboard events (#87174) 2021-07-29 14:24:03 -07:00
Wyte Krongapiradee
221705b6e6
Avoid passive clipboard read on Android (#86791) 2021-07-28 20:44:02 -07:00
Tong Mu
2f4f170dd2
Revert "Keyboard events (#83752)" (#87171)
This reverts commit 5f792ba17088b356bf0d030844ab09fd7f2b812e.
2021-07-28 02:32:08 -07:00
Tong Mu
5f792ba170
Keyboard events (#83752) 2021-07-26 12:28:05 -07:00
Ren You
3dea9f0251
Revert "Clean up the bindings APIs (#86438)" (#86484)
This reverts commit d056500bfe6a712cdace450d06c4a8fb2290e63a.
2021-07-15 09:29:16 -07:00
Ian Hickson
d056500bfe
Clean up the bindings APIs (#86438) 2021-07-14 14:41:24 -07:00
Zachary Anderson
7f741e9181
Revert "Clean up the bindings APIs (#86388)" (#86404)
This reverts commit 31de052e3fddb4909ff88172a6937db7f3dc49db.
2021-07-13 21:32:29 -07:00
Ian Hickson
31de052e3f
Clean up the bindings APIs (#86388) 2021-07-13 18:31:11 -07:00
Ian Hickson
c800b9c3e4
Revert "Clean up the bindings APIs (#83843)" (#86386)
This reverts commit e2490f2906060d0aaecbbe34a9240ca3d54ef998.
2021-07-13 15:47:40 -07:00