7355 Commits

Author SHA1 Message Date
Michael Goderbauer
0efc8cde1f
Fix SemanticsData hashode and equals (#14079) 2018-01-16 09:44:56 -08:00
jcollins-g
a6e5de2176
Make artifact downloading more robust for flaky networks, take two (#14084)
* Revert "Revert "Make artifact downloading more robust for flaky networks" (#13995)"

This reverts commit 33d8a03545ebacd821aa9cd688156e792c9c6fff.

* Use subdirectories to organize cached files

* Fix unauthorized import
2018-01-16 08:07:37 -08:00
Vyacheslav Egorov
b47a25cea7
Strong mode fix in Table._updateRenderObjectChildren (#14108)
renderObject.setFlatChildren expects List<RenderBox>, not List<RenderObject>.
2018-01-16 16:46:32 +01:00
Vyacheslav Egorov
d9fd4d6f49
Make sure to pass strong mode options down to gen_snapshot (#14118) 2018-01-16 15:38:29 +01:00
Ian Hickson
299ddb4320
Add some color to the ShapeDecoration.shape docs (#14100)
...especially about TextDirection.
2018-01-15 12:43:43 -08:00
Alexander Aprelev
09a6df7461
Clean up output directory before copying over new files (#14085)
* Clean up output directory before copying over new files

* Use standard clean task command
2018-01-14 18:24:07 -08:00
Vyacheslav Egorov
6e38b42919
Fix a couple of strong mode issues. (#14070)
* JSON.decode produces Map<String, dynamic> and List<dynamic>
objects. If a more tight type is required then object needs to
be converted explicitly (see dart-lang/sdk#31876);
* Completer<dynamic> produces Future<dynamic>. In Dart 2 it is
runtime error to assign Future<dynamic> to variable of type Future<T>;
2018-01-13 09:18:12 +01:00
Jason Simmons
e11cf5c94c
Use a safe codec to read Skia SKP screenshot files when checking for errors (#14086)
If the downloaded file is an actual SKP and not an error report, then the
default UTF-8 codec will fail to decode the SKP content
2018-01-12 17:54:49 -08:00
Hans Muller
27eeb9722f
TextField splash integration (#14055) 2018-01-12 17:40:53 -08:00
Sam Rawlins
ce939564fa Bump json_rpc_2 dependency (#14051) 2018-01-12 16:23:51 -08:00
amirh
0230a87476
Add a PhysicalShape widget and a render object for it. (#13682)
This CL also refactors common logic for RenderPhysicalModel and
RenderPhysicalShape into a base class _RenderPhysicalModelBase.
2018-01-12 15:56:01 -08:00
Chris Bracken
6a42ed3f55
Decode syslog-encoded iOS logs (#14075)
Apple encodes syslog entries using a 7-bit encoding where input UTF-8 bytes
are encoded as follows:
1. 0x00 to 0x19: non-printing range. Some ignored, some encoded as <...>.
2. 0x20 to 0x7f: as-is, with the exception of 0x5c (backslash).
3. 0x5c (backslash): octal representation \134.
4. 0x80 to 0x9f: \M^x (using control-character notation for range 0x00 to 0x40).
5. 0xa0: octal representation \240.
6. 0xa1 to 0xf7: \M-x (where x is the input byte stripped of its high-order bit).
7. 0xf8 to 0xff: unused in 4-byte UTF-8.

As there doesn't appear to be a system tool to decode these strings, we
implement here in Dart. If we're unable to decode a string (e.g.
decoding results in an invalid UTF-8 string), we fall back to emitting
the log line as-is.
2018-01-12 15:12:26 -08:00
Ian Hickson
80d6095d98
Fix ShapeDecoration (#14009)
And add a test that catches these problems.
2018-01-12 15:03:51 -08:00
Sam Rawlins
e8b666249a Bump collection dependency to 1.14.5 (#14048) 2018-01-12 14:33:26 -08:00
Ian Hickson
8cf109d20f
Reland #14054 after having landed all the engine commits in between (#14064)
This gets us back to where we were a few minutes ago.
2018-01-11 23:21:53 -08:00
Ian Hickson
78dcc0e685
Revert "Revive "Push physical layers with paths instead of rects in RenderPhy… (#14054)" (#14063)
This reverts commit 592f297922270c0c338b0048d37a510c9c16db14.
2018-01-11 22:27:11 -08:00
amirh
592f297922
Revive "Push physical layers with paths instead of rects in RenderPhy… (#14054)
* Revive "Push physical layers with paths instead of rects in RenderPhysicalModel. (#13942)"

That commit was reverted due to a performance problem which has now been
fixed.

* Roll engine 05fe72d068e19c7886e8d27f9b004201d5ad1300
2018-01-11 18:54:12 -08:00
Alexander Aprelev
a48185a6ad
When targeting iOS sim in preview-dart-2, always compile. (#14059)
Fixes https://github.com/flutter/flutter/issues/14058.
2018-01-11 18:19:28 -08:00
Alexander Aprelev
e2e3c5df05
Reland 9534082fc097dadf075c1eda7938af48df59ce3e with fix for incremen… (#14040)
* Reland 9534082fc097dadf075c1eda7938af48df59ce3e with fix for incremental compilation.

When in incremental mode, awaiting exitCode won't work because compiler is not expected to exit after compilation.
Instead listen for stdout stream closing and report error if outputFilename has not been received.

* Fix lints
2018-01-11 14:33:50 -08:00
Alexander Aprelev
bedf987fc8
Pipe strong mode option for iOS simulator. (#14002) 2018-01-11 14:08:28 -08:00
Alexander Aprelev
991765780b
Fix handling --preview-dart-2 for ios (#14016)
* Fix handling --preview-dart-2 for ios

* final var
2018-01-11 13:24:51 -08:00
Devon Carew
ccc0d29454
send 'reloadRecommended' info to IDEs (#13996)
* send 'reloadRecommended' info to IDEs

* rename hint ==> hintMessage
2018-01-11 12:55:00 -08:00
Sebastiano Poggi
2a07f3f211 Fix typo in framework.dart private method name (#14046) 2018-01-11 21:15:34 +01:00
Michael Thomsen
62ea62a729
Remove enableAssertInitializer from analysis options as it's not needed in Dart 2 (#14042) 2018-01-11 16:52:34 +01:00
Mikkel Nygaard Ravn
aad36ab7dd
Remove large int support in standard message codec (#14011) 2018-01-11 08:47:16 +01:00
Alexandre Ardhuin
0fe1e5bf5b
apply upcoming lint prefer_const_literals_to_create_immutables (#14029) 2018-01-11 08:38:55 +01:00
Alexander Aprelev
5dc4ce85d9
Revert "Handle abnormal termination of frontend compiler. (#13982)" (#14037)
This reverts commit 9534082fc097dadf075c1eda7938af48df59ce3e.

Causes hot_mode_dev_cycle__preview_dart_2_benchmark test timeout.
2018-01-10 19:54:08 -08:00
Alexander Aprelev
9534082fc0
Handle abnormal termination of frontend compiler. (#13982)
* Check frontend_server exit code.

When frontend_server completes abnormally, flutter tools has to stop and let user know.

* Add tests
2018-01-10 17:51:08 -08:00
Ian Hickson
09270dcb0b
The Ink widget (#13900)
This provides a way to draw colors, images, and general decorations on Material widgets, without interfering with InkWells that are further descendants of the widget.

This thus provides a cleaner way to solve the issue of FlatButtons and InkWells not working when placed over Image widgets than the old hack of introducing a transparency Material.

Fixes #3782.

Also, some fixes to documentation, and remove a redundant property on the Image widget.
2018-01-10 16:42:45 -08:00
Leaf Petersen
ab874da7be
Roll Dart SDK to 2.0.0-dev.16.0, along with associated package updates (#13857)
Rolling the Dart SDK to 2.0, with associated package updates.  

https://groups.google.com/forum/#!topic/flutter-dev/E22RdKAYjs8
2018-01-10 14:31:28 -08:00
Michael Goderbauer
9e51a60299
Reland #13918 (#14023)
* Revert "Reverting package changes until I can figure out how to fix Windows. (#14007)"

This reverts commit 6fda8ee821dd2e63e7949e57b10efde84bb0a3cc.

* Make prepare_package run on Windows
2018-01-10 13:37:36 -08:00
Jason Simmons
77872cc560
libtxt: update paragraph_text for current libtxt behavior (#14004)
* libtxt now calculates selection rectangles reflecting the heights of
differently styled text spans within a line (matching Blink)
* libtxt does not round the coordinates of selection rectangles (unlike Blink)
2018-01-10 10:27:59 -08:00
Michael Goderbauer
46629b7187
Do not crash when toggling Semantics on, off, on (#13999)
* Do not crash when toggeling Semantics on, off, on

* review comments
2018-01-10 10:12:36 -08:00
Ian Hickson
316d8e1c2c
Make DecoratedBox repaint after being reparented (#13927)
Fixes https://github.com/flutter/flutter/issues/12553

The root cause of https://github.com/flutter/flutter/issues/12553 was that when the refresh indicator went away, which happened after the avatars had started their image loads but before the avatars had loaded, the DecoratedBoxes, along with the rest of the list, got GlobalKey-reparented, which caused the RenderDecoratedBox objects to unregister from the DecorationImagePainters, but they never re-registered since the whole subtree was in a RepaintBoundary and was therefore not explicitly repainted when the tree got reattached.

This fixes the bug by explicitly requiring any RenderDecoratedBox to repaint when it's reattached. This is probably a little more aggressive than required; we could probably expose a flag on Decoration that says whether or not the onChanged handler will ever be invoked, and only call markNeedsPaint if that's true, but we'll do that if it turns out that there's a performance issue here.

(This patch also introduces a bunch of improved debugging information that I used to track down the bug.)
2018-01-09 20:26:37 -08:00
Greg Spencer
6fda8ee821
Reverting package changes until I can figure out how to fix Windows. (#14007)
* Revert "Fixed output validation. (#14005)"

This reverts commit d84398db72807f8910833d5fe44a097be152c74a.

* Revert "Update package prep script to do async process execution and emit output as it happens. (#13918)"

This reverts commit b7169c1d951aa188c1cdc3b980e257e8a92f8abe.
2018-01-09 19:47:19 -08:00
Greg Spencer
b7169c1d95
Update package prep script to do async process execution and emit output as it happens. (#13918)
- Switches to async process execution, which now shows output as it happens instead of in chunks when the process completes
-  Now uses ProcessManager so that it may be mocked for the test.
- Adds in the download and install of mingit on Windows.
- Updated package dependencies because of added dependency on process package.
2018-01-09 17:42:42 -08:00
Hans Muller
03e8ab1f53
Add support for a new kind of InkSplash: the "ripple" (#13986) 2018-01-09 14:43:08 -08:00
xster
c5c63dfd47
Don't flush touch events during first launch frame pre-warm (#13990)
* Lock events during runApp's warm up frame

* move to scheduler binding

* let the one scheduleWarmUpFrame api always lock

* tweak test
2018-01-09 14:05:12 -08:00
Michael Goderbauer
8a6e973739
Remove semantics boundary from gesture detector AND MORE (#13983)
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly.

Fixes https://github.com/flutter/flutter/issues/12589.
Fixes https://github.com/flutter/flutter/issues/11991.
See also https://github.com/flutter/flutter/issues/11993.

This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand.

In addition, the following minor changes are included in this PR:
* Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`.
* Logic optimizations for `markNeedsSemanticsUpdate` .
* Fix for edge case where `MergeSemantics` failed to merge semantics.
* Use of emojis to better indicate leaf merging in the printed semantics tree.
* Better assert message for adding invisible child semantics nodes.
* Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries.

Fixes https://github.com/flutter/flutter/issues/13943.
2018-01-09 13:31:59 -08:00
jcollins-g
33d8a03545
Revert "Make artifact downloading more robust for flaky networks" (#13995)
* Revert "Change github readme links to be served by github (#13929)"

This reverts commit fd516d9538e23dcfebf48ddc0efd7041fe8068cd.

* Revert " Rename SemanticsFlags to SemanticsFlag (#13994)"

This reverts commit 24e3f7053671713e05ee6be29c5ba88ed8fce543.

* Revert "Make artifact downloading more robust for flaky networks (#13984)"

This reverts commit 4d37e03e1d93eb88ed47a43fe5b08a25dca86171.
2018-01-09 12:15:58 -08:00
Michael Goderbauer
24e3f70536
Rename SemanticsFlags to SemanticsFlag (#13994)
to align with `SemanticsAction` and other enum-like types.
2018-01-09 10:31:23 -08:00
jcollins-g
4d37e03e1d
Make artifact downloading more robust for flaky networks (#13984)
* First version

* Add a clarifying comment

* Add verify to ZipDecoder.decodeBytes call

* Review comments

* Need OS Error for missing files

* FileSystemException, not OSError.
2018-01-09 10:30:42 -08:00
Ian Hickson
9b92c919a0
Imply stops on LinearGradient and RadialGradient if they're missing (#13987) 2018-01-09 08:22:17 -08:00
Ian Hickson
7cf58702c1
Wrap _debug flag setting in asserts. (#13974)
Fixes the last bits of #5759.
2018-01-08 21:39:50 -08:00
Ian Hickson
3905d99109
Minor doc improvements. (#13969) 2018-01-08 21:39:40 -08:00
Ian Hickson
9114e2afd1
The dependency script wasn't catching quite all our transitive dependencies (#13954) 2018-01-08 21:39:33 -08:00
Ian Hickson
b50ccc49d5
Test for Transform in Padding (#13898) 2018-01-08 21:39:25 -08:00
Ian Hickson
ce83f4fbe2
Make updateUserScrollDirection protected (#13850) 2018-01-08 21:39:16 -08:00
amirh
61a8132ea9
Revert "Push physical layers with paths instead of rects in RenderPhysicalModel. (#13942)" (#13988)
This reverts commit 57b4a52555388a613d3e4d5378b5bdf761d5f8df.
2018-01-08 19:24:19 -08:00
amirh
57b4a52555
Push physical layers with paths instead of rects in RenderPhysicalModel. (#13942) 2018-01-08 18:41:16 -08:00