11381 Commits

Author SHA1 Message Date
Gary Miguel
032f8cdb8b Use runTests in fuchsia tester. (#19178)
This allows us to collect code coverage for Fuchsia tests.
2018-07-09 16:13:10 -07:00
Jonah Williams
7dd265ff18
Add getSemanticsId command to flutter_driver (#19047) 2018-07-09 15:22:59 -07:00
Jonah Williams
41646c9579
Add new matcher and utility methods for testing semanics (#19046) 2018-07-09 15:21:46 -07:00
stuartmorgan
32941a8cc0 Add Windows support to defaultTargetPlatform (#19176)
A significant amonut of code uses defaultTargetPlatform, so it's
currently impossible to run most apps on Windows. This adds a mapping
from Windows as a host to Android as a target, paralleling the
macOS->iOS and Linux->Android mappings.

This allows more use of Windows as a host platform (e.g., for testing,
as in issue #17768).
2018-07-09 14:04:23 -07:00
Gary Miguel
66091f9696 Move collectCoverageData into CoverageCollector so it can be re-used. (#19055)
This will let us re-use that code from fuchsia_tester.dart.
Tested by running the stocks example tests with coverage collection before and after.
.lcov files are identical.
2018-07-09 12:52:41 -07:00
xster
17123f5312
Refer to Navigator.of(rootNavigator) in Cupertino tab widgets (#19130) 2018-07-09 12:31:43 -07:00
xster
e08177155e
Put the nav bar padding inside the CustomMultiChildLayout for correct centering and allow custom padding (#19129) 2018-07-09 12:27:24 -07:00
xster
5c8d7e3421
Adjust Cupertino controls's APIs to match Material (#19127) 2018-07-09 12:27:06 -07:00
Devon Carew
d3ad0729b7
remove an unused analysis options file (#19010) 2018-07-09 12:22:55 -07:00
Devon Carew
9d9836f080
adjust declared types to work with dart 2 typing at runtime (#19007)
* adjust declared types to work with dart 2 typing at runtime

* review comments

* update packages/flutter_tools/lib/src/ios/simulators.dart
2018-07-09 12:22:46 -07:00
Jonah Williams
77a528c417
Re-land #18369 (#19082) 2018-07-09 12:05:15 -07:00
Ralph Bergmann
779eea681f make tests in xcodeproj_test.dart and gradle_test.dart hermetic (#18093) (#18548) 2018-07-09 10:36:17 -07:00
Sigurd Meldgaard
5cbbd2831c
Fix path of ios module template files (#19037)
* Fix path of ios module template files

* Fix more paths
2018-07-09 11:56:39 +02:00
Danny Tuppeny
4630fa8e60
Additional integration test driver functionality (#19085)
* Add additional functionality to integration test driver

* Typo

* Remove delays we shouldn't need + comments

* Fix typos
2018-07-09 10:41:16 +01:00
Sigurd Meldgaard
064e40d803
Fix typo (#19160) 2018-07-09 10:55:18 +02:00
Hans Muller
7ac183794b
Deferred ListView.separator cleanups (#18720) 2018-07-06 15:21:29 -07:00
abykov2
e5d9feb59d Adding a setup function for hot restart (#18921)
* Adding a setup function for hot restart that can be overwritten to perform any necessary initialization before a restart is started.

* Adding a test for setupHotRestart

* Removing local pubspec change

* Fixing some type annotation errors

* Responding to comments
2018-07-06 15:18:57 -07:00
Alexander Aprelev
d5d129803a
Revert engine roll that caused microbenchmarks failures (#19123)
* Merge

* Update goldens
2018-07-06 13:53:30 -07:00
Danny Tuppeny
5413560415 Revert "Add temporary debug prints to identify devicelab failures (#19093)" (#19095)
This reverts commit edc16473bfdafc0f5fe546610d3b0fe0eecdd080.
2018-07-05 18:58:26 +02:00
Danny Tuppeny
edc16473bf
Add temporary debug prints to identify devicelab failures (#19093) 2018-07-05 14:16:44 +01:00
Danny Tuppeny
e1d396d5ca
Attempt to fix race in microbenchmark error handling code (#19092)
Await stream cancellations before trying to complete
2018-07-05 13:06:43 +01:00
Mikkel Nygaard Ravn
c34daae2d6
Avoid repeating microbenchmark (#19087) 2018-07-05 11:11:17 +02:00
xster
06f63aaa5a
Create a CupertinoApp (#18469) 2018-07-04 16:55:22 -07:00
matthew-carroll
aad1bb4b59
Roll engine to 21c7d6a5da47165d076928fbe460badbbead24cd (#19008)
* Roll engine to 21c7d6a5da47165d076928fbe460badbbead24cd

flutter/engine@21c7d6a Revert "Add antiAlias and saveCount to clipPath and restore (#5638)"
flutter/engine@70dcbb5 Roll src/third_party/skia d818ebf4a317..9aa30c6ee0e5 (11 commits)
flutter/engine@ad42324 Roll src/third_party/skia a219419c9d76..d818ebf4a317 (2 commits)
flutter/engine@f2eb83a Roll src/third_party/skia 00d2e8ebcb13..a219419c9d76 (1 commits)
flutter/engine@0ec7669 Roll src/third_party/skia 8451daabb23d..00d2e8ebcb13 (1 commits)
flutter/engine@061e899 Support all keyboard actions. (#11344)
flutter/engine@bc6b250 Roll src/third_party/skia 34024a7c478c..8451daabb23d (1 commits)
flutter/engine@df4dffb Roll src/third_party/skia 75e69028956d..34024a7c478c (1 commits)
flutter/engine@d8770d4 Roll src/third_party/skia cf863fb9b446..75e69028956d (1 commits)
flutter/engine@b88a8b3 Roll src/third_party/skia b7b9d02ac020..cf863fb9b446 (1 commits)
flutter/engine@2261ccf [fuchsia] Update scenic lib path.
flutter/engine@4c4ef98 [fuchsia] Rename scenic_lib => scenic
flutter/engine@f0c21f3 Roll src/third_party/skia 184d408b646b..b7b9d02ac020 (7 commits)
flutter/engine@a2bf805 Add antiAlias and saveCount to clipPath and restore
flutter/engine@9e450d1 Roll src/third_party/skia c91fe3ab1c5d..184d408b646b (10 commits)
flutter/engine@e663996 Roll src/third_party/skia eb8f8106f38c..c91fe3ab1c5d (5 commits)
flutter/engine@fecd66f Roll src/third_party/skia 723b1f6ef941..eb8f8106f38c (1 commits)
flutter/engine@4466d61 Remove vmservice_io.main from entry points.
flutter/engine@f279dfe Roll src/third_party/skia 7e2327b133db..723b1f6ef941 (1 commits)
flutter/engine@a885bd4 Roll src/third_party/skia 24d18ced1ad7..7e2327b133db (6 commits)
flutter/engine@ad1bd47 Roll src/third_party/skia a1e5630183c1..24d18ced1ad7 (7 commits)
flutter/engine@ce06bba ensure a11y state is communicated back to flutter
flutter/engine@c54a57e Roll src/third_party/skia b1b87d9df81e..a1e5630183c1 (10 commits)
flutter/engine@a9e5354 Roll src/third_party/skia 385804514edf..b1b87d9df81e (6 commits)
flutter/engine@2006e7d Roll src/third_party/skia e97bb26893a1..385804514edf (1 commits)
flutter/engine@2942061 Roll src/third_party/skia e2e52e46ca63..e97bb26893a1 (1 commits)
flutter/engine@e378811 Roll src/third_party/skia 14de25dfc7c4..e2e52e46ca63 (2 commits)
flutter/engine@48cc8f2 Roll src/third_party/skia 551dc3e91143..14de25dfc7c4 (2 commits)
flutter/engine@00ddf13 libtxt: apply an offset to drawing operations instead of translating the canvas
flutter/engine@2c5647c Roll src/third_party/skia 059a9ab4bcd0..551dc3e91143 (5 commits)
flutter/engine@9e44004 Roll src/third_party/skia 45c9dab4c3ec..059a9ab4bcd0 (8 commits)
flutter/engine@fbb3436 Remove some unused code from the Android host
flutter/engine@36f3f95 Roll src/third_party/skia 37b7e4714558..45c9dab4c3ec (1 commits)
flutter/engine@57e2e0c Roll src/third_party/skia c421ca1d6e41..37b7e4714558 (2 commits)
flutter/engine@ce417e2 Roll src/third_party/skia 5b201e3b0ba8..c421ca1d6e41 (3 commits)
flutter/engine@05f5a18 Roll src/third_party/skia d47fe095cf88..5b201e3b0ba8 (6 commits)
flutter/engine@33b70e0 Roll src/third_party/skia 9c0ce41cf711..d47fe095cf88 (12 commits)
flutter/engine@7dab419 Roll src/third_party/skia d4b2adeaa929..9c0ce41cf711 (7 commits)
flutter/engine@d3fa01a Roll src/third_party/skia f46710802ad5..d4b2adeaa929 (1 commits)
2018-07-04 15:51:26 -07:00
Mikkel Nygaard Ravn
5faac99d92
Fix typos (#19073) 2018-07-04 14:03:01 +02:00
Mikkel Nygaard Ravn
9b3f50b7bc
Fix typos (#19067) 2018-07-04 11:07:14 +02:00
Mikkel Nygaard Ravn
84e77ed20a
Fix typos (#19065) 2018-07-04 09:31:05 +02:00
Yun
34238f54eb make edit in README.md (#18981) 2018-07-03 15:50:58 -07:00
Jonah Williams
cabe09a532
Revert "Add flag to ThemeData to expand tap targets of certain material widgets (#18369)" (#19053)
This reverts commit 989f5741da9e4e8a9ae40d2ec9fbe33f11aba177.
2018-07-03 15:26:35 -07:00
sandrasandeep
581df52a86
Make EditableText cursor configurable (#18888)
* fixed segmented control golden test

* fixed segmented control golden test

* added cursorWidth, cursorRadius

* added default value for cursorWidth based on Apple specs

* test default cursorWidth

* removed cursorHeight stuff

* added functionality to keep cursor from blinking

* cursor width and radius is configurable + tests

* changed goldens repo version in goldens.version

* working version of configurable cursor (erased debugKeepCursorOn)

* minor changes

* docs

* changed textfield test that was failing due to new default cursorwidth

* added default value of cursorwidth in RenderEditable

* only run golden file tests on Mac

* cursor tests

* the tests are actually there now

* weak warning fixed

* switching to Linux

* changed default cursorWidth: 2.0 -> 1.0

* assorted changes, including changing text field test

* re-paint -> re-layout when changing cursorWidth
2018-07-03 14:02:00 -07:00
Jonah Williams
989f5741da
Add flag to ThemeData to expand tap targets of certain material widgets (#18369) 2018-07-03 10:55:43 -07:00
Danny Tuppeny
6172e23c21
Upgrade node on travis (#18994)
* Upgrade to current LTS version of Node

The version of NPM with Node 6 is over a year old and frequently hangs trying to install Firebase tools.

* Temporarily comment out this condition so the install runs on Travis

* Revert "Temporarily comment out this condition so the install runs on Travis"

This reverts commit 74db9366b4b1b094369388ef50fb26f3b7fd3104.

* Pin to nodejs v8.1
2018-07-03 15:34:55 +01:00
Mikkel Nygaard Ravn
b1c6224590
flutter attach should handle non-singular device gracefully (#19036) 2018-07-03 16:18:06 +02:00
Danny Tuppeny
0329f0c179
Include stdout/stderr in failure messages for devicelab's tests (#18990)
* Include stdout/stderr in failure messages

Sometimes some of these tests unexpectedly fail with a non-zero exit code. This ensures stdout/stderr is included in the test failure message when this happens so that we can track down the issue.

* Remove redundant info about exit code

* Remove unnecessary indenting

The [markers] make it fairly clear so this just makes the test code noisy.
2018-07-03 07:37:34 +01:00
Danny Tuppeny
9cb3cd4cb0
Fix type for Dart 2 (#18998)
Fixes #18995.
2018-07-03 07:37:00 +01:00
Greg Price
84f5b1cb09 Round properly to nearest page in TabBarView. (#16868)
This logic is described in the test as looking for a scroll ending
very close to a new page, but in fact its behavior is more like
"very close to a page to the right": if we're not very, very close
to any page, it will pick the page to the left, not an old page.

There's no reason this should be left-right asymmetrical.
Instead, pick the nearest page.

In practice, the case where this makes a difference never arises when
the scroll runs undisturbed to completion; but when the user taps on
the page to hold or drag, the scroll will be interrupted before it
gets within tolerance of a particular page, and this case does arise.

This fixes a glitch that is hard to trigger without time dilation,
but is quite conspicuous with it:

 * Open a tab view with at least 4 tabs, e.g. the Buttons screen
   of the gallery (with "Animate Slowly" on.)
 * Starting at tab 0, tap tab 2.
 * When the animation is nearly complete, tap the page a couple
   of times, as if to drag it around to scroll.  Then let the
   page view settle ballistically toward page 2.
 * Before it finishes, tap tab 3.
 * Suddenly page 1 fills the view, replacing page 2, before we
   scroll from there to page 3.

With this fix, the animation in the last step moves smoothly from
where we are when it starts onward to page 3.
2018-07-02 17:20:26 -07:00
liyuqian
a4faa2e067
Nit: add space after for (#18954) 2018-07-02 16:35:43 -07:00
Michael Goderbauer
6636da40f9
Show Search Button on keyboard for search widget (#19011)
Also:
 * Export TextInputAction from `text_field.dart` to parallel `TextInputType`.
2018-07-03 00:38:16 +02:00
Andrew Davies
1cd09e54a9
[frdb] Change to warning log on timeout. (#19006)
Before a severe log would be raised when timeout happens. Now that
testing connections requires potentially running into a timeout, this
will cause failures when there shouldn't be any.
2018-07-02 13:52:14 -07:00
liyuqian
34da4a5ffd
Throw instead of return null if durations is empty (#18957)
See https://github.com/flutter/flutter/pull/18881#discussion_r199285256
2018-07-02 13:30:02 -07:00
Mikkel Nygaard Ravn
647076d767
Fix module_test (#18993) 2018-07-02 14:45:42 +02:00
Mikkel Nygaard Ravn
1eee14ca9c
Simplify Gradle magic (#18987) 2018-07-02 13:46:07 +02:00
matthew-carroll
2a65505e8a
Support all keyboard actions. (#11344) (#18855)
* Support all keyboard actions. (#11344)
2018-07-02 06:58:35 +00:00
Mark Fielbig
af5d4c6882 Fix type errors in iOS simulator discovery. (#18960) 2018-06-30 17:17:35 -07:00
Ian Hickson
7f7ea2d500
Fix intrinsics for ConstrainedBox (#18935) 2018-06-29 14:42:36 -07:00
sjindel-google
698e1016bb Let the Kernel FE know whether it's building for a release VM. (#18876)
Fixes #18829
2018-06-29 17:01:34 +02:00
Mikkel Nygaard Ravn
ca0e144f9f
Mark non-flaky tests as such (#18927) 2018-06-29 10:55:31 +02:00
Danny Tuppeny
9b9b3ae37a
Retry npm step 5 times with 5 second pause (#18918) 2018-06-29 09:43:45 +01:00
Danny Tuppeny
44924e5cf0
Set FLUTTER_TEST when spawning flutter_tester (#18907)
Otherwise on Windows these will fail as an unsupported platform when things try to read defaultTargetPlatform in flutter apps.
2018-06-29 09:43:25 +01:00
Mikkel Nygaard Ravn
ebd11970e2
Fix typo (#18941) 2018-06-29 10:01:52 +02:00