17831 Commits

Author SHA1 Message Date
Zachary Anderson
9de7787f25
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#51567) 2020-02-27 22:46:23 -08:00
engine-flutter-autoroll
ccaf65b770
7ef053e74 Roll src/third_party/skia 2536b7f974b6..0e29459cda65 (1 commits) (flutter/engine#16839) (#51613) 2020-02-27 22:06:02 -08:00
engine-flutter-autoroll
05bdce15bd
Roll engine e05e2988b2f1..50c263906a00 (3 commits) (#51610) 2020-02-27 20:51:02 -08:00
engine-flutter-autoroll
23e0175475
Roll engine 8ce165b31183..e05e2988b2f1 (2 commits) (#51609) 2020-02-27 19:46:02 -08:00
Jonah Williams
4e5cb2b299
[flake] attempt to de-flake hot reload test (#51608) 2020-02-27 18:30:42 -08:00
Jason Simmons
d499d61efe
Update Android activities because plugin registration is now done by FlutterActivity.configureFlutterEngine (#50841) 2020-02-27 18:16:04 -08:00
engine-flutter-autoroll
1c31ed2991
8ce165b31 Roll src/third_party/skia 93afe641d0be..7b3999edcb18 (2 commits) (flutter/engine#16830) (#51605) 2020-02-27 17:56:03 -08:00
engine-flutter-autoroll
72d2a8c5c1
Roll engine 2914e4ddf6c7..a16d97e507c8 (4 commits) (#51600) 2020-02-27 16:21:02 -08:00
engine-flutter-autoroll
d6029c788e
Roll engine c0e29b6000a4..2914e4ddf6c7 (3 commits) (#51586) 2020-02-27 15:16:02 -08:00
Jonah Williams
e00d424de5
[flutter_tools] clean-ups to linux doctor test (#51593) 2020-02-27 15:15:35 -08:00
Darren Austin
fef2d6ccd6
Pass RouteSettings into all callers of showGeneralDialog. (#51525) 2020-02-27 15:11:01 -08:00
Jenn Magder
4fb9ce8414
Clean App.framework, Generated.xcconfig, flutter_export_environment.sh (#51532) 2020-02-27 12:18:06 -08:00
Jonah Williams
080dfb5eb3
[flutter_tools] swap mustache dependency for mustache_template (#51578) 2020-02-27 11:23:41 -08:00
engine-flutter-autoroll
1cdf701eec
c0e29b600 Fix stale physicalSize on resize event (flutter/engine#16822) (#51570) 2020-02-27 11:18:59 -08:00
Christopher Fujino
2cb0aa05a2
re-land "Retry cURL downloads" (#51518) 2020-02-27 11:02:00 -08:00
chunhtai
52a5311924
remove isinitialroute from RouteSettings (#51435) 2020-02-27 10:41:08 -08:00
Jenn Magder
be97fdbdb4
Turn off reupload_on_changes for Cirrus caches (#51524) 2020-02-27 10:34:46 -08:00
stuartmorgan
dd2756c36a
Generate a makefile for Linux plugins (#51520)
When generating the plugin registrant for Linux, also generate a
makefile that can be included in the app-level Makefile to manage all of
the plugin targets and flags, exporting them in a few known variables
for use in the outer makefile.

Part of #32720
2020-02-27 09:45:22 -08:00
Jonah Williams
3b5668c996
[flutter_tools] hide usage of package:mustache behind interface (#51500) 2020-02-27 09:17:42 -08:00
Jonah Williams
08d079f6c2
[flutter_tools] wire up complete support for Dart obfuscation (#50509) 2020-02-27 08:58:33 -08:00
Kaushik Iska
baa4b78333
[fuchsia] Update the SDK version to match engine (#51569)
Working around https://github.com/flutter/flutter/issues/46173
2020-02-27 08:57:42 -08:00
Jonah Williams
fe1e8f3bb7
[flutter_tools] add logging to integration test (#51527) 2020-02-27 08:54:24 -08:00
Jonah Williams
611e5cb427
[flutter_tools] update chrome tests to remove globals, mock processmanager, mock process (#51533) 2020-02-27 08:47:11 -08:00
engine-flutter-autoroll
ee4b40a146
Roll engine ecabc1037652..060a7733a654 (2 commits) (#51523)
* 8af3b1b4d Roll src/third_party/skia f0a13d04c233..7f5e3c7e43c7 (6 commits) (flutter/engine#16810)

* 060a7733a Roll fuchsia/sdk/core/linux-amd64 from QU3ft... to 94el1... (flutter/engine#16821)
2020-02-27 07:59:09 -08:00
Zachary Anderson
483f49962c
Revert "[flutter_tool] Where possible, catch only subtypes of Exception (#51440)" (#51539)
This reverts commit f1cd47ef5cd9a365e968a83b84f4e893595accc2.
2020-02-26 23:42:19 -08:00
Zachary Anderson
f1cd47ef5c
[flutter_tool] Where possible, catch only subtypes of Exception (#51440) 2020-02-26 21:45:02 -08:00
Jonah Williams
80619f100f
[flutter_tools] remove globals from plist parser and update tests (#51444) 2020-02-26 18:31:42 -08:00
Greg Spencer
d4226566d4
Change Focus.unfocus to take a disposition for where the focus… (#50831)
When Focus.unfocus is called, the caller usually just thinks about wanting to remove focus from the node, but really, unfocus is a request to automatically pass the focus to another (hopefully useful) node.

This PR removes the focusPrevious flag from unfocus, and replaces it with a disposition enum that indicates where the focus should go from here.

The other value of the UnfocusDisposition enum is UnfocusDisposition.scope.

UnfocusDisposition.previouslyFocusedChild is closest to what focusPrevious used to do: focus the nearest enclosing scope and use its focusedChild field to walk down the tree, finding the leaf focusedChild. This PR modifies it slightly so that it walks up to the nearest focusable enclosing scope before trying to focus the children. This change addresses #48903

A new mode: UnfocusDisposition.scope will focus the nearest focusable enclosing scope of this node without trying to use the FocusScopeNode.focusedChild value to descend to the leaf focused child. This is useful as a default for both text field finalization and for what happens when canRequestFocus is set to false. It allows the scope to stay focused so that nextFocus/previousFocus still work as expected, but removes the focus from primary focus.

In addition to those changes, unfocus called on a FocuScope that wasn't the primary focus used to unfocus the primary focus instead. I removed that behavior, since it was buggy: if the primary focus was inside of a child scope, and you called unfocus on the parent scope, then the child scope could have focused another of its children instead, leaving the scope that you called unfocus on with hasFocus returning true still. If you want to remove the focus from the primary focus instead of the scope, that's easy enough to do: just call primaryFocus.unfocus().

Fixes #48903
2020-02-26 18:04:32 -08:00
Dan Field
444b13b895
Colored box and container optimization (#50979) 2020-02-26 16:04:35 -08:00
Dan Field
c75db98337
Live image cache (#51485)
* Reland "Live image cache" (#51441)

This reverts commit 419a2853a8e4ac846524afeb49b866d4cdaa7d9d.

* Make evict safer
2020-02-26 16:01:56 -08:00
Ferhat
1a79592b4a
Reduce closure allocation in RenderObject.cleanRelayoutBoundary (#51439) 2020-02-26 15:53:19 -08:00
Ferhat
2132a0c7a3
Revert "[Perf/codesize] Reduce constraint member reads during layout (#51418)" (#51489)
This reverts commit 69080e07e6bb178332bf546cf83054a85b91b2fe.
2020-02-26 15:51:30 -08:00
Jenn Magder
e31521eab5
Validate empty pubspec plugin section (#51503) 2020-02-26 15:44:35 -08:00
Christopher Fujino
f794091e1d
don't do a version check when testing (#51507) 2020-02-26 15:36:02 -08:00
Jenn Magder
0407a318c6
Replace clean command test functions with test groups (#51508) 2020-02-26 15:13:43 -08:00
Jonah Williams
cd97f23a93
ensure dart defines work on web and not web (#51505) 2020-02-26 14:59:49 -08:00
Alexander Aprelev
0a9b358e3d
Fix expression evaluation test leaking flutter_tester processes. (#51496)
* Fix expression evaluation test leaking flutter_tester processes.

Let flutter_tester process complete, wait for it completion, kill the test only if didn't complete on time.

* Type annotation
2020-02-26 13:42:40 -08:00
Lynn
2243c42ebc
Fix flutter doctor (pluginsPath) check for Mac (#50324) 2020-02-26 13:41:03 -08:00
Greg Spencer
9e744c5710
Implement VisualDensity for text fields. (#51438)
This implements VisualDensity changes for text fields*. By default, the layout of the text field does not change.

If the ThemeData.visualDensity is set to a value other than zero, then the density of the UI will increase or decrease. See the VisualDensity docs for more information.

(*In reality, the changes are on the InputDecorator class, not on the text field.)

I also fixed a problem that I think I found with _Decoration where it doesn't compare isDense or isCollapsed as part of its operator==.
2020-02-26 13:38:28 -08:00
Miguel Beltran
7ff3a50fe7
Set highContrast value from AccessibilityFeatures into MediaQueryData (#48811) 2020-02-26 13:36:02 -08:00
engine-flutter-autoroll
9da15d8f2e
Roll engine ecdfc91d1618..ecabc1037652 (20 commits) (#51480)
* 05dd02368 Roll src/third_party/dart 73f6d15665a3..7aa824076c34 (11 commits) (flutter/engine#16780)

* 9f439d9ef Roll src/third_party/skia 19304d88c8be..6d927b63a311 (3 commits) (flutter/engine#16782)

* effd8a069 Roll src/third_party/skia 6d927b63a311..a6572f78d084 (3 commits) (flutter/engine#16783)

* af90e8b11 Manually add third_party/dart/pkg/stagehand to DEPS (flutter/engine#16785)

* ae999f090 Roll fuchsia/sdk/core/mac-amd64 from O6w2L... to 8gjOI... (flutter/engine#16787)

* d0897c321 Roll src/third_party/dart 7aa824076c34..2ce1df76309d (11 commits) (flutter/engine#16788)

* 7af8d3ee9 Roll src/third_party/skia a6572f78d084..c8d092a060ad (1 commits) (flutter/engine#16789)

* fb3dc8603 Roll src/third_party/dart 2ce1df76309d..85f6d51c3fd1 (6 commits) (flutter/engine#16792)

* 468b371ff Roll src/third_party/skia c8d092a060ad..7a6db4cbf48b (2 commits) (flutter/engine#16795)

* ff921cd60 fuchsia: remove use of replace_as_executable (flutter/engine#16690)

* d590e9841 Evict BitmapCanvas(s) from cache when canvas allocation fails (flutter/engine#16793)

* 52070e3df Fix handler unregistration in C++ channels  (flutter/engine#16794)

* 592b3ff21 Roll src/third_party/skia 7a6db4cbf48b..d8575452ebf3 (3 commits) (flutter/engine#16799)

* 9ac76ad5a [web] changing user limits for macos (flutter/engine#16797)

* 7685e080b [web] Guard the remaining calls to window.onPlatformMessage (flutter/engine#16791)

* 328654311 Roll src/third_party/skia d8575452ebf3..adc9bbb2aaca (2 commits) (flutter/engine#16801)

* 29cff9eb5 Roll fuchsia/sdk/core/mac-amd64 from 8gjOI... to 3B3a6... (flutter/engine#16803)

* fc3a15e7f Roll src/third_party/skia adc9bbb2aaca..7b96793ccc5b (3 commits) (flutter/engine#16804)

* f1a9dc1c9 Roll src/third_party/skia 7b96793ccc5b..f0a13d04c233 (1 commits) (flutter/engine#16805)

* ecabc1037 Roll src/third_party/dart 85f6d51c3fd1..418923733006 (30 commits) (flutter/engine#16813)
2020-02-26 12:43:39 -08:00
Jonah Williams
65a7941228
[flutter_tools] reduce globals in web validator and chrome launcher (#51443) 2020-02-26 10:37:52 -08:00
engine-flutter-autoroll
64c5a434d0
Roll engine 888a62cf2298..ecdfc91d1618 (2 commits) (#51394)
* 858185cd5 Roll src/third_party/skia 659cc1c90705..19304d88c8be (5 commits) (flutter/engine#16778)

* ecdfc91d1 Roll fuchsia/sdk/core/linux-amd64 from PGfiE... to QU3ft... (flutter/engine#16779)
2020-02-26 08:45:41 -08:00
Jonah Williams
55072246d0
[flutter_tools] remove build script from tool package (#50690) 2020-02-26 08:25:04 -08:00
Jonah Williams
53457c2241
[flutter_tools] Reland initialize frontend_sever with build (#51477) 2020-02-26 08:06:03 -08:00
Jonah Williams
421056ee54
Revert "[flutter_tools] initialize frontend server with build (#49405)" (#51476)
This reverts commit 59cc3cdf0167740b51236f5eb5571c6bf3345d6f.
2020-02-26 07:24:18 -08:00
Vyacheslav Egorov
c0565c417b
Revert "Retry cURL downloads (#50731)" (#51466)
This reverts commit 492fb6381ef589fc36e0371ad3af87cc689c4926.

Reason for revert: Dart HHH infrastructure including Golem builders are using older images which have older curl which does not support these flags. Upgrading images takes long time - so in the interim we are forced to revert to avoid accumulating gap in coverage.
2020-02-26 12:10:41 +01:00
Fedor Korotkov
492fb6381e
Retry cURL downloads (#50731)
Retry downloading Dart SDK at least 3 times with a 5 seconds wait in between retries
2020-02-25 22:29:16 -05:00
Christopher Fujino
23757c28e3
Run verify-binaries-signed on pre-submit when merging to release branches (#51221) 2020-02-25 18:12:29 -08:00
Alexandre Ardhuin
a4054938ce
unnecessary multiline strings (#50806) 2020-02-25 18:12:17 -08:00