13701 Commits

Author SHA1 Message Date
Jonah Williams
485034cab3
[flutter_tools] update fastReassemble method for single widget reloads (#61413)
For #61407 , we need to be able to find all widgets that of a given type. Previously I experimented with using the type name, but of course this does not handles subtypes. The actual check needs to be an is check.

Since there is no way to convert a String to a Type at runtime for use in this check, we can instead evaluate an expression which assigns a closure to a field. The idea for this was inspired by how the dart devtools adds debug functionality to older versions of flutter.

Since the reload feature is not complete yet, adds an integration test which simulates how it will eventually behave
2020-07-14 12:25:13 -07:00
Jonah Williams
d22d65c6e7
[flutter_tools] add the feature for single widget reloads (#61411)
Implements the flutter config feature for #61407 , but does not implement any of the functionality.
2020-07-14 12:24:58 -07:00
Todd Volkert
74f3e6dd63
Add assert to Table to check for rows with null children (#61457) 2020-07-14 12:20:22 -07:00
Andre
06a35b3322
Improve error reporting for RenderObject visitChildren errors (#61455)
* Improve error reporting for RenderObject visitChildren errors

* Nits and fixes
2020-07-14 14:21:14 -04:00
Todd Volkert
b58c3f0852
Update documentation (#61424) 2020-07-14 10:25:24 -07:00
Jason C.H
c047769487
Implement new activity indicator for iOS14 (#60179)
Updates the activity indicator style to iOS14, but places it behind a flag, to be deprecated when iOS 14 is released.
2020-07-14 09:21:27 -07:00
Ayush Bherwani
9cb7ac1353
[ListTile] adds new properties to customize the tile color (#61347) 2020-07-14 03:41:03 -07:00
Pasindu De Silva
5c9d09f05a
Add the ability to ignore lines from coverage depending on comments (#61408) 2020-07-14 01:46:02 -07:00
Jason Simmons
af47958eff
Update the golden image comparator to handle read-only image ByteData views (#61406) 2020-07-14 01:41:02 -07:00
Fabusuyi Ayodeji
1c96479760
expose route settings for showModalBottomSheet (#60640) 2020-07-14 01:36:02 -07:00
Hans Muller
bb3280885c
Update the Scaffold examples; use the new button classes (#61394) 2020-07-13 16:28:27 -07:00
chunhtai
88a78d660e
reland "Adds semantics information for the popup menu item (#61258)" (#61385) 2020-07-13 16:16:02 -07:00
chunhtai
f7688c5001
issue 61346 route can be added and disposed in the same frame (#61375) 2020-07-13 16:11:03 -07:00
Hans Muller
82666ef19e
Update Card example and shadowColor default (#61392) 2020-07-13 16:01:09 -07:00
Jonah Williams
e666ea8de4
[flutter_tools] cleanups to web runner functionality (#61178)
Skip unnecessary parsing of chrome URI. Ensure stack traces are initialized in web server. Disclaimer on web server that it does not support debugging and remove help message. Fix generated entrypoint to check for main(List<String> args)

- Fixes #59643
- Fixes #55084
- Fixes #60417
2020-07-13 15:12:46 -07:00
Dan Field
eadc35f62b
Optionally invert oversized images (#61209)
* Optionally invert oversized images
2020-07-13 14:03:23 -07:00
Justin McCandless
8048c0332d
Document the addition of LRM and RLM characters (#61104) 2020-07-13 14:01:02 -07:00
Todd Volkert
b635d97674
Add widget of the week videos to documentation (#61368) 2020-07-13 13:51:03 -07:00
Darren Austin
e2acc6503a
Remove the default shortcut mapping for GameButtonB. (#61370) 2020-07-13 13:46:02 -07:00
Hans Muller
0f57cd26f8
Make ThemeData.shadowColor the default shadowColor in TextButton et al. (#61371) 2020-07-13 13:34:54 -07:00
Danny Tuppeny
f8135add8e
Add a flag for using WS for debug backend (#61359) 2020-07-13 13:31:04 -07:00
Tong Mu
da8695d389
Mouse events report correct local positions (#61190) 2020-07-13 13:26:03 -07:00
chunhtai
067d3da827
Revert "Adds semantics information for the popup menu item (#61258)" (#61377)
This reverts commit c6058df9ca8e871772c4a0444cff43690e33cb0d.
2020-07-13 12:24:42 -07:00
chunhtai
c6058df9ca
Adds semantics information for the popup menu item (#61258) 2020-07-13 11:21:03 -07:00
rami-a
b79efb8da3
[Material] Allow for customizing Snack bar margin, padding, and width (#61180) 2020-07-13 14:19:45 -04:00
Jenn Magder
cda6c27ff7
Add spaces between sentences in help text (#61135) 2020-07-13 11:16:03 -07:00
xster
8bd2e6585b
Remove v1 Android create templates (#61203) 2020-07-11 12:15:19 -07:00
Hans Muller
eac1747169
Renamed ContainedButton et al. to ElevatedButton et al. (#61262) 2020-07-11 08:50:43 -07:00
Greg Spencer
b267e7bd9b
This fixes a compile error in the form field example, and switches to using space instead of enter as the example for moving to the next field, since the text field on web unfocuses automatically when enter is pressed. (#61123) 2020-07-10 18:06:02 -07:00
Anna Gringauze
9cbe1dccf3
Added web compiler debug metadata (#61265)
Made flutter tools serve metadata produced by the frontend server:

pass --experimental-emit-metadata flag to flutter engine
store and serve metadata from web asset server
store and serve merged metadata from web asset server
add tests to verify that metadata is served from memory
update dwds version so it can read metadata
configure dwds to read metadata from file
Prerequisite changes (landed):

sdk: https://dart-review.googlesource.com/c/sdk/+/150181
flutter engine: flutter/engine#19168
webdev:dart-lang/webdev#1064
2020-07-10 16:36:43 -07:00
Dan Field
cd80ed3009
Fix bold not getting cleared on new line (#61256)
* Fix bold not getting cleared on new line
2020-07-10 16:09:49 -07:00
Dan Field
5b9c6e2b0e
Revert "Add support for Dart Development Service (DDS) in Flutter Tools (#59114)" (#61276)
This reverts commit fe7bbf722689cbf3769eb82059294bcff50c3939.
2020-07-10 15:53:35 -07:00
Ben Konyi
fe7bbf7226
Add support for Dart Development Service (DDS) in Flutter Tools (#59114) 2020-07-10 15:35:21 -07:00
Nolan Scobie
dc0f122881
Revert "Revert "Tweaking Material Chip a11y semantics to match buttons (#60141)" (#60645)" (#61048) 2020-07-10 14:21:03 -07:00
Ming Lyu (CareF)
a76b5eb79f
Add support in WidgetTester for an array of inputs (#60796)
* Add input event array support

* Add a tap test

* remove unused import

* remove extra assert
2020-07-10 17:03:12 -04:00
Jonah Williams
66556faef7
[flutter_tools] deflake integration test with tryToDelete (#61253) 2020-07-10 13:29:49 -07:00
Kaushik Iska
afd745e893
Filter profiling events by names not category (#61185)
Category isn't preserved by timeline events as `Dart_TimelineEvent`
specifies the category as `embedder`.

Fixes: https://github.com/flutter/flutter/issues/60008
2020-07-10 12:13:56 -07:00
Jonah Williams
1c1ef133ee
[flutter_tools] remove globals from device manager, flutter tester (#61139)
Remove global variables from device manager, flutter tester devices and update tests
2020-07-10 11:52:09 -07:00
Jonah Williams
fbca40add2
[flutter_tools] abstract logger construction (why can't I hold all these loggers) (#61201)
We have too many loggers, and the logger construction rules are too complicated to be untested. Capture these in a LoggerFactory and test that construction is correct.
2020-07-10 11:51:47 -07:00
Jonah Williams
d14a898f69
remove LICENSE/NOTICES work around (#61199)
Now that google3 has been updated, remove the LICENSE loading fallback. This was done in cl/320506032

#16723
2020-07-10 11:37:48 -07:00
Ayush Bherwani
fd80503fd3
[Api docs] Updates ListTile.subtitle docs to address how TextStyle is decided (#61071) 2020-07-10 02:11:02 -07:00
Jonah Williams
6eaaf1650e
[flutter_tools] switch order of injection (#61191)
Inject loggers in the right order, test WIP. Otherwise verbose machine would not get the AppRunLogger
2020-07-09 18:04:37 -07:00
Jenn Magder
20fe2f88c5
Prefer tear offs to lambdas in test expects (#61196) 2020-07-09 17:58:51 -07:00
Jonah Williams
ed9a705ec2
[flutter_tools] allow unmuting of command logging (#61198)
Running flutter doctor -v prints out extra details instead of running in verbose mode. Allow disabling this with -vv so it can be debugged.
2020-07-09 17:55:53 -07:00
Kate Lovett
01ac509620
Skip Audit - Last Leftovers (#60940) 2020-07-09 17:01:01 -07:00
Jenn Magder
e110ca7209
Case insensitive check flavor names against Xcode schemes (#61140) 2020-07-09 16:56:02 -07:00
Max Weber
c29009b3e8
Added the materialTapTargetSize to the OutlineButton Constructor (#61086) 2020-07-09 14:56:01 -07:00
Kate Lovett
e3079a3339
Add additional float location case (#61171) 2020-07-09 14:06:03 -07:00
Alexandre Ardhuin
f32a73711a
use nnbd deps (#61177) 2020-07-09 23:01:22 +02:00
Tong Mu
d4b4eeed7d
Add all system cursors (framework) (#60931) 2020-07-09 14:01:03 -07:00