Todd Volkert
8d6673dcf0
Revert "Make sure flutter update-packages --verify-only has a non-zero exit code ( #15962 )" ( #16089 )
...
This reverts commit cfda7a65487dbad44bbeeca1516f84b7166bded6.
2018-03-29 21:34:31 -07:00
Jonah Williams
cfda7a6548
Make sure flutter update-packages --verify-only has a non-zero exit code ( #15962 )
...
* make sure --verify-only logs error messages and fix typo
* ensure non zero exit code
* undo random pubspec change
2018-03-29 20:34:49 -07:00
Jason Simmons
b4274ef685
URL encode asset paths to support reserved characters in paths ( #16046 )
...
Fixes https://github.com/flutter/flutter/issues/14864
2018-03-29 13:47:35 -07:00
Todd Volkert
f69d125954
Move Cache.flutterRoot initialization up sooner ( #16057 )
...
It's required to be set before we detect local engine.
Was broken by #15984
2018-03-29 09:16:34 -07:00
Ralph Bergmann
895707324d
improve Flutter build commands ( #15788 )
...
add --buildNumber and --buildName to flutter build like
flutter build apk --buildNumber=42 --buildName=1.0.42
2018-03-29 05:58:31 -07:00
xster
4565395693
Let iOS auto-signing tool handle Googler scenario ( #16010 )
...
* Let iOS auto-signing tool handle Googler scenario
* Forgot to update tests
2018-03-28 18:58:06 -07:00
Todd Volkert
f8058d7fb2
Make AppContext API not be prone to Future oddities ( #16034 )
...
Follow-up comments to #15984
2018-03-28 15:17:29 -07:00
Alexander Aprelev
bffae21571
Again move mockito to 300plus2 ( #15981 )
...
* Revert "Revert "Move mockito to 3.0.0-alpha. (#15949 )" (#15979 )"
This reverts commit e59651f925917ed44a9bf27c37e80fc9992c0890.
* More thenReturn to thenAnswer when mocking Futures
* Revert "More thenReturn to thenAnswer when mocking Futures"
This reverts commit 194d2cf41754ad171efd6bb5898cf73bce5a75ab as we are reverting engine roll.
* Revert "Revert "More thenReturn to thenAnswer when mocking Futures""
This reverts commit 52c9e96b304b220f66d78a252fccea0c8e0ef24c.
* Add dependency override
* Fix issue
2018-03-28 12:07:12 -07:00
Todd Volkert
8d11f5c763
Make AppContext immutable and race-free ( #15984 )
...
This updates AppContext per the recommendations in #15352
Fixes #15352
2018-03-28 10:58:28 -07:00
Alexander Aprelev
af74a7253b
Send relative uri when target physical file path is specified. ( #15887 )
2018-03-23 19:18:39 -07:00
Alexandre Ardhuin
217b2bdaa1
add new lints of linter-0.1.44 and enable unnecessary_parenthesis ( #15585 )
2018-03-21 07:10:14 +01:00
Jonah Williams
ad9506d25a
Traverse dependencies and dev dependencies separately ( #15581 )
...
* traverse dependencies and dev dependencies separately
* separate dev and reg deps
* update pubspecs
* add checksum string and update transitive dep string. Add additional verify command to check checksum
* cleanup comments
* add missing space, quote, run verify-onlu from bot script
* rerun tool with fixed string
* ensure correct working directory and bump versions
* flutter not flutterRoot
2018-03-20 20:03:32 -07:00
Mikkel Nygaard Ravn
8b25d4eadb
Add missing awaits ( #15595 )
2018-03-21 00:44:19 +01:00
Vyacheslav Egorov
3352a3fb48
Report an error if compilation during testing times out. ( #15745 )
...
* Report an error if compilation times out instead of waiting forever.
* Remove braces
2018-03-20 11:30:06 -07:00
Siva
821c9b35a1
Roll engine to version 6280adbfb1f9f63cdc6179b9b78634add1e4f2e3 ( #15729 )
...
* roll engine version to 6280adbfb1f9f63cdc6179b9b78634add1e4f2e3
* Correctly handle previewDart : false setting in AnalysisServer and
AnalyzeOnce classes.
2018-03-20 11:15:05 -07:00
Alexandre Ardhuin
cc1cf9e12a
apply upcomming lint avoid_renaming_method_parameters ( #15526 )
2018-03-20 12:53:41 +01:00
Vilk
568ce697b4
add Samsung SM-J730F to isLocalEmulator ( #15517 )
...
Add another rel device to isLocalEmulator to make working flutter run --release
2018-03-19 21:40:34 -07:00
Jason Simmons
1c04f951c8
Warn about missing host build binaries when compiling with a local engine ( #15626 )
...
Fixes https://github.com/flutter/flutter/issues/15361
2018-03-19 11:29:20 -07:00
Alexander Aprelev
6acf76f7be
Use uris for hot reload invalidation. ( #15698 )
...
* Use uris for hot reload invalidation.
* Clean up unneccessary conversions
* add final.
* Revert sample change
2018-03-19 11:17:16 -07:00
Jonah Williams
91dcfc5dd2
stderr can be null or empty string ( #15701 )
2018-03-19 10:53:04 -07:00
Alexander Aprelev
43284d70d9
Reland filesystem options support with fix for Windows test. ( #15655 )
...
* Revert "Revert "Reland pass filesystem options (#15622 )" (#15651 )"
This reverts commit 0f3eada0664e208bb8c65a5aa02daec38997e8b9.
* Fix for windows failing test
* !isEmpty -> isNotEmpty
2018-03-17 12:47:40 -07:00
Jonah Williams
298f4efc54
Fail ios workflow when simctl does not work ( #15628 )
...
* fail ios workflow when simctl does not work
* missed rename commit
* address comments
2018-03-17 10:57:51 -07:00
Alexander Aprelev
0f3eada066
Revert "Reland pass filesystem options ( #15622 )" ( #15651 )
...
This reverts commit bbcf55a5b086559dc992c0657bcde0d95c1bc26e as it breaks hot reload on Windows.
2018-03-17 08:11:52 -07:00
Alexander Aprelev
bbcf55a5b0
Reland pass filesystem options ( #15622 )
...
* Revert "Revert "Pass filesystem-root, filesystem-scheme options through `flutter run, build` and gradle. (#15592 )" (#15621 )"
This reverts commit c663e3367da7c6b8b6571e7fcbf3b1050c805c78.
* Check whether filesystem-root is emtpy.
* Restore broken merge
* Fix windows test
* Adjust regex in test. Invalidate files by file path.
2018-03-17 06:49:15 -07:00
Vyacheslav Egorov
71b2cfb2a0
Turn Dart 2 mode by default. ( #15565 )
2018-03-16 20:29:38 +01:00
Alexander Aprelev
c663e3367d
Revert "Pass filesystem-root, filesystem-scheme options through flutter run, build and gradle. ( #15592 )" ( #15621 )
...
This reverts commit 0f659fb10b84fc0192c06ce351b00f6900b3408a as it
breaks bin/tasks/gradle_plugin_test.dart.
2018-03-16 12:28:30 -07:00
Alexander Aprelev
0f659fb10b
Pass filesystem-root, filesystem-scheme options through flutter run, build and gradle. ( #15592 )
...
* Pass filesystem-root, filesystem-scheme options through flutter run/build/gradle.
2018-03-16 11:16:54 -07:00
Keerti Parthasarathy
50190d2810
Do not encode the server port in the test file ( #15535 )
...
* Do not encode the server port in the test file
* revert formatting
* add back ignore
* add a default value to serverPort
* address comments
2018-03-15 10:56:10 -07:00
Alexandre Ardhuin
7667db6362
apply upcomming prefer_const_declarations ( #15498 )
2018-03-14 06:24:49 +01:00
Jonah Williams
d682259eab
Use a set to remove duplicate channel names ( #15392 )
...
* Use a set to remove duplicate channel names
* Add test for git command
2018-03-12 17:04:02 -07:00
Jason Simmons
466d15433f
Use Dart 2 camel case constants ( #15360 )
2018-03-12 11:06:32 -07:00
Alexandre Ardhuin
3961306bad
enable lints prefer_const_declarations and prefer_const_literals_to_create_immutables ( #14848 )
2018-03-09 14:37:06 -08:00
Jason Simmons
96ce9d64ac
Add more package names to the flutter create conflict list ( #15350 )
...
Fixes https://github.com/flutter/flutter/issues/12445
2018-03-09 13:11:33 -08:00
Todd Volkert
2e970008ad
Pass --verbose to pub instead of --trace when in verbose mode ( #15314 )
2018-03-09 12:55:06 -08:00
Yegor
2e429bfbdd
[tools] add Stdio to AppContext created by daemon AppInstance ( #15268 )
2018-03-09 12:25:30 -08:00
Alexander Aprelev
ded538a1bb
Update dependencies with forced upgrade. ( #15344 )
...
* Update dependencies with forced upgrade.
Now that https://github.com/flutter/flutter/issues/15261 is fixed, do the update with upgrade.
* Update test package use following upgrade
* Replace addOption(allowMultiple) with addMultiOption
2018-03-09 10:38:54 -08:00
Jonah Williams
4ace88bfc0
fix spacing issue and add test for supportsHardwareRendering ( #15305 )
...
* fix spacing issue and add test for supportsHardwareRendering
* remove extra async tag
* move spacing to prev line
2018-03-09 09:30:13 -08:00
Jacob Richman
046c6d5f7f
Track which Widget objects were created by the local project. ( #15041 )
...
Make flutter test support the --track-widget-creation flag.
Add widget creation location tests. Tests are skipped when
--track-widget-creation flag is not passed.
2018-03-09 08:09:49 -08:00
Alexander Aprelev
2890e18bcb
Return copied kernel filename for flutter test execution. ( #15298 )
...
* Return copied kernel filename.
This fixes 'flutter test --preview-dart-2' crash.
2018-03-08 16:02:21 -08:00
Alexander Aprelev
1087279a4d
Create frontend compiler in flutter test lazily. ( #15251 )
...
* Create frontend compiler in `flutter test` lazily.
This is needed to avoid unwarranted runtime dependencies on Artifacts,
for example when in non-preview-dart-2 mode.
Refactor the compilation-related code into _Compiler class.
2018-03-08 11:21:40 -08:00
Jonah Williams
afabdfecf9
Display a message if hardware rendering is supported ( #15266 )
...
* add device.supportsHardwareRendering and display a message if true
* Address some comments
2018-03-08 10:41:29 -08:00
Alexander Aprelev
69c33a321a
Fix path to uri conversion. ( #15264 )
2018-03-08 10:25:27 -08:00
Todd Volkert
fffb7630c1
Give file system recording serialization a timeout. ( #15217 )
...
Some file I/O is piped from OS processes and never completes,
so without havign a timeout on the recording serialzation, we
end up waiting forever on that I/O to complete.
2018-03-07 11:39:59 -08:00
shrike69
f3c806c9f2
Remove _checkPort() when getting flutter views ( #15184 )
2018-03-07 10:35:24 -08:00
Alexander Markov
7d0536b87a
Enable global type flow analysis in Dart 2 AOT ( #15221 )
2018-03-07 09:35:22 -08:00
Alexander Aprelev
c01cad3491
Fix flutter test --preview-dart-2 following last dart roll. ( #15233 )
...
* Fix `flutter test --preview-dart-2` following last dart roll.
Incremental compiler maintains single incremental dill file, so for every test compilation that dill file has to be copied away for execution.
* Fix lints
2018-03-07 06:27:58 -08:00
Mikkel Nygaard Ravn
0d59679624
Make Flutter tooling work on Android without Xcode being installed ( #15161 )
2018-03-07 08:41:23 +01:00
Josh Soref
c5a5945e92
Spelling ( #15229 )
...
* spelling: accommodate
* spelling: allotted
* spelling: anonymous
* spelling: artificial
* spelling: associated
* spelling: asset
* spelling: button
* spelling: canvas
* spelling: compatibility
* spelling: coverage
* spelling: condition
* spelling: decoration
* spelling: deferring
* spelling: diameter
* spelling: direction
* spelling: displacement
* spelling: dropdown
* spelling: needing
* spelling: environment
* spelling: exited
* spelling: expansion
* spelling: explore
* spelling: families
* spelling: horizontal
* spelling: increment
* spelling: indices
* spelling: internationalization
* spelling: labrador
* spelling: localizations
* spelling: midflight
* spelling: milliseconds
* spelling: minimum
* spelling: multiple
* spelling: multiplication
* spelling: navigator
* spelling: overridden
* spelling: package
* spelling: performance
* spelling: platform
* spelling: porsche
* spelling: position
* spelling: preceded
* spelling: precede
* spelling: precedence
* spelling: print
* spelling: property
* spelling: readily
* spelling: reproducibility
* spelling: rounded
* spelling: scroll
* spelling: separate
* spelling: separator
* spelling: services
* spelling: specific
* spelling: specify
* spelling: synchronously
* spelling: through
* spelling: timeout
* spelling: triangle
* spelling: trivial
* spelling: unusual
* spelling: then
* spelling: vertically
* spelling: visible
* spelling: visited
* spelling: voice
2018-03-06 21:36:03 -08:00
Todd Volkert
d0cbbd5394
Fail if precompiled test entry point is specified, but more than one test suite is run ( #15208 )
2018-03-06 21:28:52 -08:00
Alexander Markov
602e6d74b5
Pass entry points JSON files to front-end server, take 2 ( #15227 )
...
* Pass entry points JSON files to front-end server (#15180 )
* Fix ios/debug build which uses 'flutter build aot': do not require entry points files and disable AOT transformations in this mode
2018-03-06 18:45:45 -08:00
