11238 Commits

Author SHA1 Message Date
Jonah Williams
a1852a1993
Exit resident web runner on initial compilation failure (#41441) 2019-09-27 10:32:38 -07:00
Zachary Anderson
716a672bc8
[flutter_tools] Adds tests of mdns analytics events (#41410) 2019-09-27 08:07:26 -07:00
Alexandre Ardhuin
f11c34109c
fix bad indentations(mainly around collection literals) (#41355) 2019-09-27 10:46:45 +02:00
Greg Spencer
957d839775
Revert "Address previous comments, fix Intent.doNothing. (#41417)" (#41449)
This reverts commit eb3e2f559f2563a0878d19bd997629ce07becd3c because of a suspected analyzer bug.  Reverting to investigate.
2019-09-26 22:45:21 -07:00
Greg Spencer
eb3e2f559f
Address previous comments, fix Intent.doNothing. (#41417)
This addresses comments in the original PR (#41245) that introduced Intent.doNothing, adds tests, and fixes an issue with it.
2019-09-26 19:54:28 -07:00
Devon Carew
1044457225
add tests to ensure the sdk is well-formed (#41408)
add tests to ensure the sdk is well-formed
2019-09-26 18:22:25 -07:00
Hans Muller
ecc4764fe2
Revert "Dropdown Menu layout respects menu items intrinsic sizes (#41120)" (#41422)
This reverts commit e47a1dc21613d67a2e2e13c4b81f98c98ee5d4f3.
2019-09-26 17:57:08 -07:00
Jonah Williams
efd2ba296b
Flutter build bundle without --precompiled should always perform a debug build. (#41401) 2019-09-26 15:57:57 -07:00
Greg Spencer
a085635899
Change the way ActionDispatcher is found. (#41245)
This changes the way ActionDispatchers are found by the Actions widget, so that by default it will look for dispatchers of the parent Actions widgets instead of just creating a default ActionDispatcher. This allows overriding of the ActionDispatcher at the top level: before, the custom action dispatcher would only be invoked if explicitly set on all the Actions widgets.

This is not a breaking change because there was a default value to the dispatcher parameter before that performed this function, and not specifying the dispatcher anywhere will still result in a default dispatcher being created.
2019-09-26 14:31:08 -07:00
Greg Spencer
1a7bb1f583
Added proper focus handling when pushing and popping routes (#40166)
The proposed change will change focus handling when pushing and popping routes so that the FocusScopeNode for the route receives focus when pushed, and that the FocusScopeNode in the navigator receives focus when the route is popped.

This means that the last setFirstFocus call on the scope is used to determine which control actually receives focus. When the focus scope receives focus, it traverses its children, trying to find a non-scope node that is the "first focus" of itself or a child node.

This is a breaking change, because the focus behavior has changed. If you push a route after this change, and had a 'first focus' set on a widget via FocusScopeNode.setFirstFocus, it won't currently receive focus immediately, but after this change it will. Similarly, if you pop a route after this change, the focus will go back to where it was before the route was pushed, which is correct, but different from what happens now.
2019-09-26 14:30:39 -07:00
Jonah Williams
c93839131c
Fix timing issues in initialization of web resident runner (#41347) 2019-09-26 14:23:19 -07:00
stuartmorgan
56d68a9071
Add the beginnings of plugin support for Windows and Linux (#41015)
Adds very preliminary support for Windows and Linux plugins:
- Adds those platforms to the new plugin schema, initially supporting just a plugin class.
- Adds C++ plugin registrant generation for any Windows or Linux plugins found.

This doesn't have yet have any build tooling for either platform, so anyone using the generated registrant still needs to do manual build configuration. This reduces the manual work, however, and creates a starting point for future tooling work.

As with all Windows and Linux work at this time, this is not final, and subject to change without warning in the future (e.g., Windows could potentially switch to a C# interface, or
'linux' may change to 'gtk' or 'linux_gtk' in pubspec.yaml).
2019-09-26 14:01:57 -07:00
Kristin Ho
034358e341 Prevent PointerEnter[or Exit]Event from erasing event.down value (#40637) (#41332)
* MouseRegion documentation claimed that onEnter and onExit
  would track entry and exit regardless of whether the pointer was
  down or up
* It did such, but when grabbing the value of `event.down` from
  the passed event, the value was always `false`
* PointerEnterEvent and PointerExitEvent were overriding the value
  passed from PointerEvent in constructors, even if the value was true
  e.g. in invocations of .fromMouseEvent((PointerMoveEvent...))
* This change now passes the value along to PointerEnter/ExitEvents
  while providing it a default of false, and updates documentation

Fixes #40637
2019-09-26 13:48:40 -07:00
Zachary Anderson
bb7e3f6045
[flutter_tools] Report iOS mDNS lookup failures to analytics (#41384) 2019-09-26 13:41:11 -07:00
Jonah Williams
0980fa2ddd
Serve every html file under web (#41386) 2019-09-26 13:24:05 -07:00
Greg Spencer
0509791663
Fix mouse hover to not schedule a frame for every mouse move. (#41014)
This fixes the mouse hover code to not schedule frames with every mouse move.

Before this, it would schedule a post frame callback, and then schedule a frame immediately, even if there was nothing that needed to be updated. Now it will schedule checks for mouse position updates synchronously, unless there's a new annotation, and skip scheduling a new frame in all cases. It has to be async in the case of a new annotation (i.e. a new MouseRegion is added), since when the annotation is added, it hasn't yet painted, and it can't hit test against the new layer until after the paint, so in that case it schedules a post frame callback, but since it's already building a frame when it does that, it doesn't need to schedule a frame.

The code also used to do mouse position checks for all mice if only one mouse changed position. I fixed this part too, so that it will only check position for the mouse that changed.
2019-09-26 13:13:42 -07:00
Zachary Anderson
7fa5dd7454
[flutter_tools] Allows adding multiple signal handlers (#41304) 2019-09-26 08:12:48 -07:00
Hans Muller
e47a1dc216
Dropdown Menu layout respects menu items intrinsic sizes (#41120) 2019-09-26 07:18:25 -07:00
Emmanuel Garcia
975e770e13
Add embedding as API dependency instead of compile only dependency (#41142) 2019-09-25 17:59:17 -07:00
Jonah Williams
89ebd700f2
Support deferred imports on profile/release builds of Flutter Web (#41222) 2019-09-25 15:12:58 -07:00
Jonah Williams
7065e43306
Allow skipping chrome launch with --no-web-browser-launch (#40627) 2019-09-25 13:55:54 -07:00
Jonah Williams
9bd02a1787
Re-Re-Re-land implement flutter build bundle with assemble (#41302) 2019-09-25 13:55:29 -07:00
Francisco Magdaleno
d2a95ee344
Fix crash on vswhere query on missing installations (#40786) 2019-09-25 13:38:53 -07:00
Nurhan Turgut
ae529d8be0
Fixing the editable_text unit tests by clearing the log. Add a modification for also testing cached size. (#41300) 2019-09-25 13:14:59 -07:00
Zachary Anderson
5142238c85
[flutter_tool] Report rss high watermark in command analytics events (#40988) 2019-09-25 11:26:06 -07:00
Alexandre Ardhuin
9c6f11d5d1
fix bad indentation (#41263) 2019-09-25 20:24:57 +02:00
LongCatIsLooong
deb4184f63
Remove CupertinoSystemColors in favor of CupertinoColors (#40566) 2019-09-25 10:17:37 -07:00
Jonah Williams
cc3ca9a916
Revert "Re-Re-land Implement flutter build bundle with assemble (#41230)" (#41295) 2019-09-25 10:57:58 -04:00
Jonah Williams
84a476a4db
Re-Re-land Implement flutter build bundle with assemble (#41230) 2019-09-25 10:17:04 -04:00
LongCatIsLooong
7bf9aea254
Fix user gesture in CupertinoPageRoute (#39590) 2019-09-25 00:37:12 -07:00
LongCatIsLooong
d8ca42e211
CupertinoPageScaffold dark mode (#40690) 2019-09-25 00:31:36 -07:00
Emmanuel Garcia
48ce60824a
Revert "Revert "Use AndroidX in new projects by default (#40925)" (#40995)" (#41001)
This reverts commit 8e231796272f7f14391ca9c6b40392bc20f96aeb.
2019-09-24 16:55:09 -07:00
imzyy
964dc1fc30 Add fullscreenDialog argument in PageRouteBuilder (#40161) 2019-09-24 16:54:44 -07:00
Mehmet Fidanboylu
c19e553d64 Allow test beds to override defaultTestTimeout (#40806) 2019-09-24 16:53:40 -07:00
Tong Wu
28bd51f998
Force upgrade packages again. (#40997) 2019-09-24 16:51:31 -07:00
Emmanuel Garcia
16d408a7a0
Reland #40810: Re-enable AAR plugins when an AndroidX failure occurred (#41160) 2019-09-24 16:16:22 -07:00
Hans Muller
09073a08b8
Rebuild modal routes when the value of userGestureInProgress changes (#41150) 2019-09-24 16:03:31 -07:00
Michael Goderbauer
81e693a7fe
Add Sample code to SlideTransition (#41009) 2019-09-24 12:38:45 -07:00
chunhtai
0ca5e71f28
Implement system fonts system channel listener (#38930)
* Implement system fonts system channel listener
2019-09-24 12:29:03 -07:00
Jenn Magder
9a66018f0d
Make module pod headers public (#40927) 2019-09-24 12:20:00 -07:00
Todd Volkert
8699d24d42
Bump version of just package:multicast_dns (#41207) 2019-09-24 12:06:42 -07:00
Alexandre Ardhuin
b873162194
fix some bad indentations (#41172) 2019-09-24 21:03:37 +02:00
Francisco Magdaleno
1ea760096a
Update toolchain description to request the latest version (#40795) 2019-09-24 12:00:05 -07:00
Nurhan Turgut
f6e77a9ee5
Fixing a text editing bug happening when text field changes. (#41108)
* Carrying last size and transform information to TextInputConnection. Doing this we are making sure that the size/transform information from the previous connection will be removed, when connection changes.

* remove unused lastsize and lasttransform values

* Adding unit tests. Adressing comments.
2019-09-24 09:25:39 -07:00
Greg Spencer
0e6cb28dbe
Add fake keyboard key generation to the testing framework (#40706)
There were four or five different implementations in various tests for sendFakeKeyEvent, which roughly all did the same thing. I was going to add yet another one, and decided that it needed to be generalized and centralized. This replaces those instances with something that just takes a LogicalKeyboardKey so that it's self-documenting, and can be used with multiple platforms.

This adds two functions to widget tester: sendKeyDownEvent and sendKeyUpEvent which simulate key up/down from a physical keyboard. It also adds global functions simulateKeyDownEvent and simulateKeyUpEvent that can be called without a widget tester. All are async functions protected by the async guard.
2019-09-24 08:14:38 -07:00
LongCatIsLooong
4815b26d71
Dark mode for CupertinoSwitch and CupertinoScrollbar, Fidelity updates (#40636) 2019-09-24 00:21:44 -07:00
Alexandre Ardhuin
89427d672d
add missing trailing commas in flutter_tools (#40968) 2019-09-24 08:06:09 +02:00
Alexandre Ardhuin
e9965f5636
add missing trailing commas in packages/flutter (#41076) 2019-09-24 08:05:41 +02:00
Michael Goderbauer
961f1b746d
AnimatedBuilder API Doc improvements (#40917) 2019-09-23 10:09:38 -07:00
Liam Appelbe
b0563e1a3d
Unit test for build.dart::GenSnapshot (#37642)
* Unit test for build.dart::GenSnapshot

* Fix analysis errors

* Switch to testLogger
2019-09-23 10:09:22 -07:00