11537 Commits

Author SHA1 Message Date
Greg Spencer
a1c5e3354b
Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43657)
This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213), with fixes for the web tests that weren't enabled in the master that it was synced to when I first landed it.
2019-10-29 17:09:26 -07:00
Jonah Williams
b1aff28593
pass --no-gen-bytecode to aot kernel compiler invocations (#43753) 2019-10-29 16:05:54 -07:00
Emmanuel Garcia
7e60a65ff0
Don't read AndroidManifest.xml if it doesn't exit (#43669) 2019-10-29 16:05:13 -07:00
gaaclarke
53dcf92f7d
Fixed bug where we could accidently call a callback twice. (#43467) 2019-10-29 16:04:38 -07:00
LongCatIsLooong
3352b91f2c
CupertinoPicker doc update (#43736) 2019-10-29 14:31:27 -07:00
Christopher Fujino
261594e785
add libzip cache artifact (#43677) 2019-10-29 14:29:00 -07:00
Taufiq Rahman
13c4ba2a25 Adjust and refactor all MaterialButton tests into its respective file (#43528)
* Adjust and refactor all MaterialButton tests into its respective file
2019-10-29 14:27:07 -07:00
Kaushik Iska
e091d724f6
[flutter_runner] Use sky_engine from the topaz tree (#43684)
This is to account for the flutter_runner migration.
fxb/fl-250 has more context. This change specifically uses
the build rules that were added as a part of: fxr/333681
2019-10-29 14:24:10 -07:00
liyuqian
c523149819
Reland "Enable dump-skp-on-shader-compilation in drive (#43022)" (#43455)
This reverts commit b9eb3f717a017ebe444e3074278788d8e0353147.

We fixed the issue by updating the constructors.
2019-10-29 14:20:22 -07:00
Jonah Williams
2637a6cbca
Update packages --force-upgrade (#43745) 2019-10-29 13:21:45 -07:00
Jonah Williams
331d19ff4b
Add reloadMethod RPC (#43725) 2019-10-29 13:21:06 -07:00
Jonah Williams
1d7afd9c1d
Don't indefinitely persist file hashes, handle more error conditions (#43602) 2019-10-29 13:20:51 -07:00
Yegor
5f6ca6838e
Enable heroes_test.dart on the web matrix (#43662) 2019-10-29 12:23:16 -07:00
Pieter van Loon
0120c414fb Improved ios 13 scrollbar fidelity (#41799)
Drag from the right is no more
Longpress is now only 100ms instead of 500
Added optional duration field to longpressgesturerecognizer
Added controller field to material scrollbar api
Haptic feedback only triggers when scrollbar is fully expanded
Added haptic feedback when releasing the scrollbar after dragging it
2019-10-29 08:46:21 -07:00
Jenn Magder
01dc19b93f
Pass environment variables through to xcodebuild (#43553) 2019-10-28 19:58:06 -07:00
Jonah Williams
19e551c7a6
Remove Poller class from flutter_tools (#43685) 2019-10-28 19:35:43 -07:00
Jonah Williams
e25cd84a06
Catch failed startup error from build_daemon (#43598) 2019-10-28 15:58:14 -07:00
LongCatIsLooong
4ac2daf337
CupertinoTheme & CupertinoTextTheme dark mode updates (#41859) 2019-10-28 15:50:08 -07:00
knaeckeKami
ccfdf95c4a Use PRODUCT_BUNDLE_IDENTIFIER from buildSettings to find correct bundle id on iOS when using flavors (#42964) 2019-10-28 15:33:27 -07:00
Jenn Magder
f7d78d5baa
Alias upgrade-packages => update-packages (#43546)
* Alias upgrade-packages => update-packages

* Trailing whitespace
2019-10-28 15:32:39 -07:00
Justin McCandless
6e888dac24
Add enableSuggestions flag to TextField and TextFormField (#42550)
This flag controls Android's keyboard suggestions on/off
2019-10-28 15:31:52 -07:00
creativecreatorormaybenot
e903485de2 Change PopupMenuButton.icon type to Widget (#43526) 2019-10-28 13:46:14 -07:00
Shi-Hao Hong
c461ff9d4a
Implement AlertDialog title/content overflow scroll (#43226)
* Wrap alert dialog title and content in single child scroll view

* Scrollable alert dialog title and content tests

* Remove unnecessary comment

* Fix mainAxisSize and crossAxisAlignment issue
2019-10-28 13:45:05 -07:00
Shi-Hao Hong
036c102c34
Improve DropdownButton assert message (#43511)
- Adds an assert message checking for exactly one unique value for `DropdownItem`s
2019-10-28 13:44:21 -07:00
Greg Spencer
38f2d27685
Revert "Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43384)" (#43647)
This reverts commit 8017f63b083474d0ba28457e48acbb35d15a727a, since it breaks web tests.
2019-10-28 11:28:09 -07:00
Albertus Angga Raharja
b31ca1aaca
Add more structure to errors (continuation of #34684) (#42640)
* Add structured errors in Animations, TabView, ChangeNotifier

* Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan

* Add structured errors in Debug

* Fix test errors

* Add structured errors in Scaffold and Stepper

* Add structured errors in part of Rendering Layer

* Fix failing test due to FloatingPoint precision

* Fix failing tests due to precision error and not using final

* Fix failing test due to floating precision error with RegEx instead

* Add structured error in CustomLayout and increase test coverage

* Add structured error & its test in ListBody

* Add structured error in ProxyBox and increase test coverage

* Add structured error message in Viewport

* Fix styles and add more assertions on ErrorHint and DiagnosticProperty

* Add structured error in scheduler/binding and scheduler/ticker

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in AssetBundle and TextInput

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured errors in several widgets #1

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove unused import

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add assertions on hint messages

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix catch spacing

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in several widgets part 2 and increase code coverage

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in flutter_test/widget_tester

* Fix floating precision accuracy by using RegExp

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove todo to add tests in Scaffold showBottomSheet

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix reviews by indenting lines and fixing the assertion orders

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix failing tests due to renaming class

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Try skipping the NetworkBundleTest

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove leading space in material/debug error hint

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>
2019-10-28 11:00:49 -07:00
Shi-Hao Hong
734ddd3103
Make DropdownButton's disabledHint and hint behavior consistent (#42479)
* Fix DropdownButton disabledHint behavior

* Fix hint behavior when selectedItemBuilder is null

* Improve variable names, some formatting updates

* Create _DropdownMenuItemContainer widget

* Improve API docs to be consistent with hint/disabledHint actual behavior
2019-10-28 11:00:33 -07:00
Justin McCandless
109f25588d
No multiline password fields (#42470)
Use assertions to prevent multiline password fields from being created
2019-10-28 10:59:26 -07:00
Greg Spencer
8017f63b08
Re-Land: Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43384)
This re-lands the change that adds focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. (#43213)

No changes from original, except for finding the right RenderBox in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart.
2019-10-28 10:55:11 -07:00
Jonah Williams
b142c9bbdb
catch failure to parse FLUTTER_STORAGE_BASE_URL (#43599) 2019-10-28 10:54:03 -07:00
Jonah Williams
450a72488d
set trace to true for desktop builds (#43577) 2019-10-28 10:27:11 -07:00
Jonah Williams
36d50a48f4
Catch MissingPortFile exception (#43573) 2019-10-28 10:26:43 -07:00
Jonah Williams
d983c1d1ae
Ensure Chrome is closed on tab close (#43586) 2019-10-28 10:26:18 -07:00
Zachary Anderson
0dfabb2ae1
[flutter_tool] Use engine flutter_runner prebuilts (#43381)
* [flutter_tool] Use engine flutter_runner prebuilts

* Update packages/flutter_tools/lib/src/fuchsia/fuchsia_build.dart

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>
2019-10-28 09:38:08 -07:00
Jonah Williams
ab260bacd2
Refactor BuildMode into class, add jit_release configuration (#42476) 2019-10-28 09:37:29 -07:00
Jonah Williams
553662d101
Catch AppConnectionException from dwds (#43544) 2019-10-25 20:35:19 -07:00
Gary Qian
652fb975c1
FadeInImage cacheWidth and cacheHeight support (#43286) 2019-10-25 17:33:50 -07:00
Kate Lovett
7bc02037e3
Re-land Local & Pre-Submit Support for Skia Gold (#43371) 2019-10-25 15:05:21 -07:00
Jonah Williams
4bd5eb5915
Enable track widget creation on by default (#43471) 2019-10-25 15:04:06 -07:00
Yegor
02abd00e93
Cupertino web tests (#43529)
* enable more tests after material fixes
* enable some of the Cupertino tests
2019-10-25 15:03:25 -07:00
Jonah Williams
4c47fdadd4
Add devfs for incremental compiler JavaScript bundle (#43219) 2019-10-25 15:03:13 -07:00
Jonah Williams
ed931e7941
initial bootstrap script for incremental compiler support (#43292)
* initial bootstrap script for incremental compiler support

* add more comments

* update to two scripts
2019-10-25 15:03:00 -07:00
Jonah Williams
ae207b5e42
Handle permission error during flutter clean (#43401) 2019-10-25 15:02:38 -07:00
Harry Terkelsen
eba69caf97
Don't html-escape in the plugin registrant templates. (#43448)
* Don't html-escape in the plugin registrant templates.

Fixes #43382

* Add test
2019-10-25 15:00:05 -07:00
Yegor
903ebd714d
Fix and enable most of material tests for Web (#43019) 2019-10-24 21:35:14 -07:00
Jenn Magder
41c02d717a
Turn off bitcode for integration tests and add-to-app templates (#42958) 2019-10-24 18:16:36 -07:00
Jonah Williams
b9eb3f717a
Revert "Enable dump-skp-on-shader-compilation in drive (#43022)" (#43438)
This reverts commit 4f385c8fb7dea36ce0bc45e2ebd79d538fe104b6.
2019-10-24 11:18:55 -07:00
Jacek Fedoryński
e458fd08d9 Add repeatCount to RawKeyEventDataAndroid (#42861)
* Add repeatCount to RawKeyEventDataAndroid

Adds a new field to RawKeyEventDataAndroid and sets it to the value
passed from the engine. It is the value returned by
KeyEvent.getRepeatCount(). This allows us to differentiate between
events generated by a new keypress and repeated events when a key is
held down.

* Add test for RawKeyEventDataAndroid.repeatCount
2019-10-24 11:06:03 -07:00
Stefano Rodriguez
bcab851b8f Set default borderRadius to zero in ClipRRect (as documented) (#43006)
* Set default borderRadius to none in ClipRRect

* add tests
2019-10-24 11:05:29 -07:00
liyuqian
4f385c8fb7 Enable dump-skp-on-shader-compilation in drive (#43022) 2019-10-24 11:04:59 -07:00