7163 Commits

Author SHA1 Message Date
Ian Hickson
a34ae0f99d Talk about how to resize IconButtons more. (#7595)
Answers http://stackoverflow.com/questions/41729278/why-is-this-icon-being-clipped
2017-01-23 14:42:30 -08:00
James Robinson
6c5974fd5f [gn] Update flutter_tools GN build (#7592)
This package depends on package:process now.
2017-01-23 13:46:37 -08:00
Ian Hickson
84c0b34782 Test some of the sliver helper classes (#7574) 2017-01-23 13:36:44 -08:00
Ryan Macnak
76460967e6 Adapt to refactoring of snapshot APIs in the Dart VM. (#7589) 2017-01-23 13:28:35 -08:00
Adam Barth
bf296f715e Test DataTable (#7591)
This patch adds a basic test for the DataTable widget.
2017-01-23 12:40:51 -08:00
Ian Hickson
94cac1a69c flutter test --start-paused (#7584)
Make debugging tests in a debugger easier.

Fixes https://github.com/flutter/flutter/issues/163
2017-01-23 11:31:59 -08:00
Michael Thomsen
ef1d7a1929 Update gradle versions in hello_services to those currently shipped in Android Studio (#7587) 2017-01-23 19:00:09 +01:00
Todd Volkert
03d163ce88 Update tools to use package:process (#7590) 2017-01-23 09:46:38 -08:00
Michael Thomsen
24f1b2ee09 Update IntelliJ template for new projects and existing samples (#7501)
* Disable 'Show Excluded' by default

* Move .iml file inside .idea dir

* Remove pub and build excludions as they are automatically set by the Dart plugin

* Exclude .idea folder (new users will edit it through the IJ UI, not the file)

* Move .iml files into .idea dir to be consistent with template changes

* Add workspace.xml from new template to existing samples

* Update current examples to match template changes for excluding folders

* Add missing flutter.yaml to make sure there are no analysis errors

* Add back .pub and build excludeFolder tags per https://github.com/flutter/flutter-intellij/issues/630#issuecomment-272887230

* Remove workspace.xml from example per review feedback
2017-01-23 16:33:18 +01:00
Ian Hickson
63aa1397a3 Increase the strictness of our requiring explicit types (#7585)
...now that we have generic methods, their types need to be specified too.
2017-01-23 01:04:31 -08:00
Adam Barth
99822088a7 Add operator== and hashCode to TextTheme (#7586)
Teach `paints` matches about `drawRect` and how to `paintChild`.

Also, improve test coverage.
2017-01-23 00:06:58 -08:00
Ian Hickson
cbda208b4b Reduce the amount of spam from analyze watch. (#7582)
See https://github.com/dart-lang/sdk/issues/28463, which I think is a
regression.

This also fixes the regression introduced by
https://codereview.chromium.org/2559773002 whereby we were no longer
checking any of the lints.
2017-01-22 16:43:24 -08:00
Chris Bracken
1e1463216a Roll engine to 858e401c4d83f44634341a0e1fe2b01428fe6746 (#7576) 2017-01-22 09:34:12 -08:00
Dan Rubel
0295def2a9 Refactor DevFS for kernel code (#7529)
Refactor DevFS so that it's easier to add new types of content such as kernel code
* add tests for DevFS package scanning
* add tests for DevFS over VMService protocol
* which covers _DevFSHttpWriter and ServiceProtocolDevFSOperations
* replace AssetBundleEntry and DevFSEntry with DevFSContent
* refactor to cleanup common code and replace some fields with locals
* rework .package file generation refactor away DevFSOperations.writeSource
* only update .package file if it has changed
* only write/delete/evict assets that have been changed/removed
2017-01-22 10:37:10 -05:00
Ian Hickson
9573bc14e0 Avoid double negatives in text editing APIs (#7577)
hideText -> obscureText
hideDivider -> !showDivider
2017-01-21 23:34:54 -08:00
Ian Hickson
15a7eb3b6c Move to real generic method syntax (#7235) 2017-01-21 20:58:44 -08:00
Ian Hickson
2e196037f5 Improve the order of members in the mock_canvas file. (#7573)
This will make it easier to understand what this file does.
2017-01-20 22:31:41 -08:00
Ian Hickson
2bb800a2e4 Explain the -15 magic number. (#7571) 2017-01-20 16:44:26 -08:00
Ian Hickson
36464ca659 About box should default to the executable name. (#7572)
Removes some TODOs now that https://github.com/flutter/flutter/issues/3648 is fixed.
2017-01-20 16:44:19 -08:00
Ian Hickson
63160b3dab Scrolling Refactor (#7420) 2017-01-20 16:18:56 -08:00
Adam Barth
e52bda2cd0 Document the value that Navigator.push completes to (#7569)
Also, synchronize the docs between Navigator.push and NavigatorState.push (and
friends).
2017-01-20 15:39:06 -08:00
Adam Barth
0f1d97756d Strengthen animation listener iteration patterns (#7566)
This patch aligns the iteration patterns used by animations and
ChangeNotifier. They now both respect re-entrant removal of listeners
and coalesce duplication registrations. (Also, ChangeNotifier
notification is no longer N^2).

This patch introduces ObserverList to avoid the performance regression that the
previous version of this patch caused.

Fixes #7533
2017-01-20 15:38:53 -08:00
Ian Hickson
c5fcaf6dea Introduce a paints matcher, and convert the previous customers of (#7567)
MockCanvas to use it instead.

Currently it only supports a very limited set of drawing features, but
adding new ones is easy.

Once the feature set is more complete, and we've used this a bunch, if
it feels right, this API will get promoted to flutter_test.
2017-01-20 15:28:00 -08:00
Adam Barth
3b104a813f Improve test coverage (#7564)
Also, fix some minor bugs with SynchronousFuture.
2017-01-20 15:15:27 -08:00
Ian Hickson
86f5c78f2c Document that the default text color is white. (#7565)
Answers http://stackoverflow.com/questions/41371449/how-do-you-use-a-textpainter-to-draw-text
2017-01-20 14:57:52 -08:00
Todd Volkert
5a3bae9eed Catch another ignorable errno in setting stdin.lineMode (#7563) 2017-01-20 14:00:12 -08:00
Adam Barth
61760f63e9 Rename RawInput to EditableText (#7556)
This patch is part of a series to rationalize our text input classes.

See #7031
2017-01-20 11:39:36 -08:00
Michael Goderbauer
ab1cd3f816 Fix doc comment about onPressed for various buttons (#7555) 2017-01-20 09:35:35 -08:00
Devon Carew
34b9ce859a proxy service extension calls through the daemon protocol (#7554)
* proxy service extension calls through the daemon protocol

* add test for app.callServiceExtension
2017-01-20 08:51:57 -08:00
Ian Hickson
47de51557a Provide a feature to set the ports when running tests. (#7558)
This brings the feature back, since removing it broke one of our more
exotic sets of customers.
2017-01-19 17:57:47 -08:00
Ian Hickson
3f1d6d3bca Remove randomness from port assignment during coverage collection. (#7548)
Also, defer to test package for throttling (this will require a test
package update as well).

Also, add a lot more instrumentation to --verbose mode for tests, and
fix minor trivial things here and there, and add error handling in
more places.

Also, refactor how coverage works to be simpler and not use statics.
2017-01-19 15:31:11 -08:00
Adam Barth
b2a2ee72f9 Migrate from Input to TextField
We expect TextField to be used much more often than Input. This patch updates
our old example code to use TextField instead.

See #7031
2017-01-19 14:53:08 -08:00
Adam Barth
930b52a3e5 Rename InputFormField to TextField
This patch is the first of a series to rationalize the names of the text-input
related widgets.

See #7031
2017-01-19 14:53:08 -08:00
Adam Barth
32fea4db82 Remove gallery dependency on flutter_markdown (#7534)
The gallery doesn't actually use `package:flutter_markdown`.
2017-01-19 14:47:48 -08:00
Adam Barth
aa82b741e2 Revert "Strengthen animation listener iteration patterns" (#7552) 2017-01-19 14:36:25 -08:00
Todd Volkert
4e8628c146 Fix sky_shell test flakiness caused by CPU throttling (#7543)
When a machine is heavily loaded, it can severely delay the time it
takes for the OS to start a process once it's asked to do so. Our
5 second timeout that we were giving the test process to connect
to the test harness seemed like plenty of time, were it not for the
fact that the test process itself was not being started in time when
CPU throttling was in effect.

This change updates the test timeout to begin counting only once the
test process has been started. We keep the original timeout in play
in the event that the test process *never* starts up for some reason,
but we up that timeout value to 5 minutes.
2017-01-19 13:03:31 -08:00
Michael Goderbauer
8b1121851e Fix icon color in dark theme of gallery (#7544)
Previously, the icon in the tooltip demo was black on black background
in the dark theme. Now it is white on black background in the dark theme
and black on white background in the light theme.

fixes #7018
2017-01-19 11:20:55 -08:00
Yegor
d18b500840 remove the no longer needed ignore: cancel_subscriptions (#7542)
This has been fixed: https://github.com/dart-lang/linter/issues/317
2017-01-19 10:59:43 -08:00
Phil Quitslund
8dc1634be5 Stop building unlinked summaries for packages. (#7538)
Stop building (unused) unlinked summaries for packages.

Improves update speed considerably (for `n` packages it saves us `n` needless calls to `pub get`).
2017-01-19 09:11:41 -08:00
Adam Barth
3312af7da5 Strengthen animation listener iteration patterns (#7537)
This patch aligns the iteration patterns used by animations and
ChangeNotifier. They now both respect re-entrant removal of listeners
and coalesce duplication registrations. (Also, ChangeNotifier
notification is no longer N^2).

Fixes #7533
2017-01-18 22:17:13 -08:00
Adam Barth
9f36737f3a InkSplash and InkHighlight shouldn't be special (#7531)
Previously, these classes where in material.dart, which meant they could
access private interfaces in that library. This patch moves them out
into their own files so that they need to play by the rules of the
public API.

Fixes #5969
2017-01-18 16:40:00 -08:00
Adam Barth
712eb969ea CustomSingleChildLayout should be able to resize (#7528)
It's not correct to set sizedByParent for
RenderCustomSingleChildLayoutBox because the delegate's size function
might depend on information other than the incoming constraints.
2017-01-18 16:33:42 -08:00
Adam Barth
23361d5ab6 Improve Route lifecycle (#7526)
Previously the navigator wouldn't always call Route.dispose when it was
removed from the tree. After this patch, the navigator remembers popped
routes so that it can call dispose on them when it is removed from the
tree.

Also, improve some error messages around calling dispose() more than
once on routes and AnimationControllers.

Fixes #7457
2017-01-18 16:32:44 -08:00
Adam Barth
7d5f172a26 Remove Force and SpringForce (#7532)
The only client of this machinery was AnimationController.fling, but
it's easier for that function to just create the simulation it needs
directly.

Fixes #7216
2017-01-18 16:32:00 -08:00
Jason Simmons
584dbe3d32 Fix the activity name in the Gallery back button memory metric (#7527) 2017-01-18 14:14:40 -08:00
Adam Barth
40e305dc2d Fix analyzer warnings (#7523)
I see these errors in Atom on my Mac. I'm not sure why they're not being
picked up by the bots.
2017-01-18 13:18:09 -08:00
Hans Muller
0ce9917fb2 Support for vetoing an attempt to pop the current route (#7488) 2017-01-18 11:04:18 -08:00
Adam Barth
17bc188803 Upgrade to dartdoc 0.9.10 (#7524) 2017-01-18 10:33:27 -08:00
Matt Perry
75f39789c7 Add support for specifying maxLines for Text. (#7493)
Overflow handling works with clipping, adding an ellipsis on the last
line, or fading the last line.

Fixes https://github.com/flutter/flutter/issues/7271
2017-01-18 12:34:34 -05:00
Hans Muller
60847a1ded Restore velocity tracker sample window duration (#7510) 2017-01-17 15:44:09 -08:00