firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,179 Commits 1 Branch 0 Tags
Commit Graph

16179 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ian Hickson
1196f91f71
Fix local test failures in flutter_tools (#42015) 
* Minor clean-up in terminal.dart

* Don't wrap text in tests (otherwise we'll be sensitive to the terminal width).
 2019-10-06 14:38:17 -07:00
Dan Field
f4b4616f87
Diagnose failure in CI, Mark III (#42037) 2019-10-04 20:01:04 -07:00
Ian Hickson
a22f4e9be5
trying to diagnose failure in CI, mark II (#42036) 
* remove prints

* Remove the setUpAll() to see if that changes the error message.
 2019-10-04 19:43:54 -07:00
Ian Hickson
4e6b77c087
trying to diagnose failure in CI (#42035) 2019-10-04 19:01:37 -07:00
Ian Hickson
142a8630ec
Revert "AOT support for Linux Desktop I: switch Linux builds to assemble (#41612)" (#42030) 
This reverts commit 3024053c8295ad01dba952fe6ca007679296c2a4.
 2019-10-04 17:51:51 -07:00
James D. Lin
fcbe8f44ea
Restructure ProjectFileInvalidator.findInvalidated a bit (#42008) 
Restructure ProjectFileInvalidator.findInvalidated a bit

I plan to modify `ProjectFileInvalidator.findInvalidated` to allow
it to use `FileStat.stat` instead of `FileStat.statSync`.
Restructure `findInvalidated` a bit so that `FileStat.statSync` is
called in only one place.

Note that this change now always counts the `.packages` file as one
of the files scanned, even if it does not exist.  I think that this
is okay since it more accurately reflects the number of times that we
hit the filesystem with `stat()`, and it is consistent with how other
files are counted.
 2019-10-04 17:22:35 -07:00
engine-flutter-autoroll
71497367ef
Roll engine 759d3dba259b..7d90779bb66f (5 commits) (#42004) 
git@github.com:flutter/engine.git/compare/759d3dba259b...7d90779bb66f

git log 759d3dba259b..7d90779bb66f --no-merges --oneline
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from VkAgX... to by2LL... (flutter/engine#12791)
2019-10-04 bkonyi@google.com Roll src/third_party/dart 28f21d4e99..d6c6d12ebf (3 commits)
2019-10-04 jonahwilliams@google.com Fix bug in package script and add dev_compiler to list of uploaded packages (flutter/engine#12785)
2019-10-04 bkonyi@google.com Roll src/third_party/dart 7a7dcd1ed9..28f21d4e99 (2 commits)
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from wYLiQ... to JyZWz... (flutter/engine#12788)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-04 16:13:43 -04:00
James D. Lin
14c5c6e161
Clean up ProjectFileInvalidator.findInvalidated a bit (#41889) 
In preparation for some refactoring that I will be doing to
`ProjectFileInvalidator.findInvalidated`, make its code a bit
clearer:
* Indicate which arguments may be null.
* Don't bother calling `FileStat.statSync` on the `.packages` file
  for the initial load.  This makes the checks for the `.packages`
  file consistent with those for other files.
* Use `DateTime.isAfter()` instead of comparing microseconds
  ourselves.

While I was touching this file, I also removed some unnecessary
comparisons to `false`. (`_ManifestAssetBundle.wasBuiltOnce()` is the
only implementation I can find of `AssetBundle.wasBuiltOnce()`, and
it never returns `null`.)
 2019-10-04 12:55:17 -07:00
Jonah Williams
3024053c82
AOT support for Linux Desktop I: switch Linux builds to assemble (#41612) 2019-10-04 12:13:36 -07:00
Ryan Macnak
cdb3578b14
Plumb --enable-asserts through to frontend_server invocation in debug mode. (#41832) 
Bytecode generation will otherwise omit assert code, causing --enable-asserts to have no effect in the VM.
 2019-10-04 12:07:23 -07:00
Rody Davis
b730a993c1 Fix CupertinoTextField and TextField ToolbarOptions not changing (#40665) 2019-10-04 11:22:57 -07:00
krisgiesing
0e605cc4dd Revert "Fix ReorderableListView's use of child keys (#41334) (#41338)" (#41931) 
This reverts commit 2b138fd7d20caa552a50e8f6dfdba0017099a7be.
 2019-10-04 07:52:15 -07:00
Erick Ghaumez
62ae5883a8 Fix 'popupTheme' variable name in a MaterialBannerTheme method (#41632) 2019-10-04 22:42:09 +08:00
Emmanuel Garcia
5961bcc505
Generate projects using the new Android embedding (#41666) 
* Generate projects using the new Android embedding

* Add comment about usesNewEmbedding:true

* Feedback

* Rework way to detect new embedding in new apps
 2019-10-04 06:23:03 -07:00
Alexandre Ardhuin
890b939401
indent formal parameters correctly (#41644) 2019-10-04 11:00:18 +02:00
engine-flutter-autoroll
dc03c44321
759d3dba2 Roll src/third_party/skia 35a60f622c58..fbdf48ecb204 (2 commits) (flutter/engine#12787) (#41965) 
git@github.com:flutter/engine.git/compare/ec9d487b0599...759d3dba259b

git log ec9d487b0599..759d3dba259b --no-merges --oneline
2019-10-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia 35a60f622c58..fbdf48ecb204 (2 commits) (flutter/engine#12787)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-04 04:01:43 -04:00
Jonah Williams
ae18f07324
Ensure plugin registrants are generated in build_web (#41906) 2019-10-04 00:36:09 -07:00
engine-flutter-autoroll
ea305c5050
ec9d487b0 Roll src/third_party/dart b4688e9172..7a7dcd1ed9 (5 commits) (#41961) 
git@github.com:flutter/engine.git/compare/a0605af402ac...ec9d487b0599

git log a0605af402ac..ec9d487b0599 --no-merges --oneline
2019-10-04 bkonyi@google.com Roll src/third_party/dart b4688e9172..7a7dcd1ed9 (5 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-04 03:12:43 -04:00
engine-flutter-autoroll
3a728a9b5b
a0605af40 Roll src/third_party/skia d71344590a2f..35a60f622c58 (9 commits) (flutter/engine#12784) (#41958) 
git@github.com:flutter/engine.git/compare/9db06370490d...a0605af402ac

git log 9db06370490d..a0605af402ac --no-merges --oneline
2019-10-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia d71344590a2f..35a60f622c58 (9 commits) (flutter/engine#12784)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-04 01:37:43 -04:00
Jonah Williams
f25812bae5
Revert "replace package:vm_service_client with package:vm_service in the devicelab project (#41646)" (#41960) 2019-10-03 21:30:37 -07:00
engine-flutter-autoroll
96b4e8cf1a
9db063704 Roll src/third_party/dart 7376167b2a..b4688e9172 (4 commits) (#41957) 
git@github.com:flutter/engine.git/compare/2e163b27805b...9db06370490d

git log 2e163b27805b..9db06370490d --no-merges --oneline
2019-10-04 bkonyi@google.com Roll src/third_party/dart 7376167b2a..b4688e9172 (4 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-03 23:59:43 -04:00
Devon Carew
4de496a4e5 replace package:vm_service_client with package:vm_service in the devicelab project (#41646) 2019-10-03 20:43:34 -07:00
escamoteur
2713ee61f0 added questions on Platform / OS Version / Device (#41651) 
* added questions on Platform / OS Version / Design

* changed following the comments

* removed the host platform question
 2019-10-03 20:43:04 -07:00
Emmanuel Garcia
00f82d9021 Use mergeResourcesProvider instead of deprecated mergeResources (#41942) 2019-10-03 20:42:43 -07:00
Emmanuel Garcia
ed49a79516 Include embedding transitive dependencies in plugins (#41885) 2019-10-03 20:42:24 -07:00
stuartmorgan
18d6d9bc7b Add Profile entry to macOS Podfile (#41747) 2019-10-03 20:41:48 -07:00
Greg Spencer
3e2dc8ca7b Revert ActivateAction PR (#41945) 2019-10-03 20:27:37 -07:00
engine-flutter-autoroll
780bddcca5
Roll engine 62e58c5d9fc2..2e163b27805b (4 commits) (#41954) 
git@github.com:flutter/engine.git/compare/62e58c5d9fc2...2e163b27805b

git log 62e58c5d9fc2..2e163b27805b --no-merges --oneline
2019-10-04 dnfield@google.com Revert "Build AOT and test targets, generate FARs when building Fuchsia (#12761)" (flutter/engine#12781)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Enabled people to chose if SystemNavigator.pop is animated on iOS. (flutter/engine#12752)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Added some thread asserts to the code and made ios_surface_ safe since (flutter/engine#12775)
2019-10-03 dnfield@google.com Build AOT and test targets, generate FARs when building Fuchsia (flutter/engine#12761)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-03 23:11:43 -04:00
Jonah Williams
db9ad60bfe
Deflake web_fs_test.dart in flutter_tools (#41952) 2019-10-03 19:07:38 -07:00
Dan Field
6048b62e21
Update label applied for performance template bugs (#41717) 2019-10-03 18:56:25 -07:00
LongCatIsLooong
97d191de13
Fix CupertinoActivityIndicator radius (#41892) 2019-10-03 18:37:57 -07:00
engine-flutter-autoroll
d85d6eb44f
Roll engine 8aa47326ae73..62e58c5d9fc2 (3 commits) (#41949) 
git@github.com:flutter/engine.git/compare/8aa47326ae73...62e58c5d9fc2

git log 8aa47326ae73..62e58c5d9fc2 --no-merges --oneline
2019-10-03 bkonyi@google.com Roll src/third_party/dart 07a63a17a4..7376167b2a (8 commits)
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 35e0a58278a3..d71344590a2f (11 commits) (flutter/engine#12774)
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from p319_... to VkAgX... (flutter/engine#12778)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-03 21:37:43 -04:00
Jenn Magder
4331c172d7
Set DEFINES_MODULE=YES in plugin templates (#41828) 2019-10-03 18:35:20 -07:00
engine-flutter-autoroll
f8c75305ca
Roll engine 7d67e275ff82..8aa47326ae73 (7 commits) (#41944) 
git@github.com:flutter/engine.git/compare/7d67e275ff82...8aa47326ae73

git log 7d67e275ff82..8aa47326ae73 --no-merges --oneline
2019-10-03 chinmaygarde@google.com Fix Metal builds. (flutter/engine#12777)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#12277)" (flutter/engine#12773)
2019-10-03 bkonyi@google.com Roll src/third_party/dart afac6a3714..07a63a17a4 (6 commits)
2019-10-03 dnfield@google.com roll buildroot to 01e923507b28e5d1d3fe7597d2db2b30b0a543e9 (flutter/engine#12771)
2019-10-03 jonahwilliams@google.com Create a package-able incremental compiler (flutter/engine#12681)
2019-10-03 47866232+chunhtai@users.noreply.github.com add windows embedding test (flutter/engine#12423)
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from g-PD1... to wYLiQ... (flutter/engine#12770)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-03 20:12:44 -04:00
Tong Mu
297fe91f51
Refactor: Make MouseTracker test concise with some utility functions (#41791) 
* Extract pointerData and _equalToEventsOnCriticalFields for simplicity
 2019-10-03 16:33:31 -07:00
Jonah Williams
6edd79abab
Upload x64 android host release (#41933) 2019-10-03 16:23:53 -07:00
engine-flutter-autoroll
32ad3db8e8
7d67e275f Roll src/third_party/skia cb55010652b2..35e0a58278a3 (2 commits) (flutter/engine#12769) (#41929) 
git@github.com:flutter/engine.git/compare/623be87e65e6...7d67e275ff82

git log 623be87e65e6..7d67e275ff82 --no-merges --oneline
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia cb55010652b2..35e0a58278a3 (2 commits) (flutter/engine#12769)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-03 19:20:43 -04:00
engine-flutter-autoroll
2a7395ca46
Roll engine e9edb8e14f6d..623be87e65e6 (12 commits) (#41928) 
git@github.com:flutter/engine.git/compare/e9edb8e14f6d...623be87e65e6

git log e9edb8e14f6d..623be87e65e6 --no-merges --oneline
2019-10-03 bkonyi@google.com Roll src/third_party/dart 967673c005..afac6a3714 (2 commits)
2019-10-03 bkonyi@google.com Roll src/third_party/dart 97bb624cfe..967673c005 (16 commits)
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 087aa99a21ca..cb55010652b2 (1 commits) (flutter/engine#12766)
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia f070cbec0708..087aa99a21ca (2 commits) (flutter/engine#12765)
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from EeMsz... to p319_... (flutter/engine#12764)
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from AGoPT... to g-PD1... (flutter/engine#12763)
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 40d1246d0c80..f070cbec0708 (10 commits) (flutter/engine#12762)
2019-10-03 bkonyi@google.com Roll src/third_party/dart 2e99a418a0..97bb624cfe (5 commits)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Expanded channel buffer resize to method channels. (flutter/engine#12725)
2019-10-02 bkonyi@google.com Roll src/third_party/dart eaf1c308ab..2e99a418a0 (6 commits)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia ce240cc6fd8e..40d1246d0c80 (4 commits) (flutter/engine#12755)
2019-10-02 chinmaygarde@google.com Fix Metal builds by accounting for the updated SubmitFrame signature. (flutter/engine#12754)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-03 14:55:43 -04:00
Mouad Debbar
61d364f307
[web] Make it clear that lowercase "r" can also perform hot restart (#41815) 2019-10-03 11:53:41 -07:00
Mehmet Fidanboylu
6b09543e3a Allow customization of label styles for semantics debugger (#41730) 2019-10-03 11:11:13 -07:00
Zachary Anderson
c7c8a6c498
[flutter_tools] Add more info to pub get failure event (#41652) 2019-10-03 11:08:42 -07:00
Jonah Williams
517c08e801
Make output directory a build input (#41862) 2019-10-03 11:07:53 -07:00
engine-flutter-autoroll
439dc5cffe
Roll engine 73dd5a33d9d1..e9edb8e14f6d (3 commits) (#41860) 
git@github.com:flutter/engine.git/compare/73dd5a33d9d1...e9edb8e14f6d

git log 73dd5a33d9d1..e9edb8e14f6d --no-merges --oneline
2019-10-02 mouad.debbar@gmail.com Support correct keymap for web (flutter/engine#12712)
2019-10-02 garyq@google.com Explain vertical font metrics and refactor UpdateLineMetrics. (flutter/engine#11795)
2019-10-02 mouad.debbar@gmail.com [web] Don't require felt to be in PATH (flutter/engine#12753)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-03 14:05:43 -04:00
Gary Qian
fa7340a328
Return WidgetSpans from getSpanForPosition (#40635) 2019-10-02 19:04:50 -04:00
engine-flutter-autoroll
fe46eba67f
Roll engine aa8fcbb65283..73dd5a33d9d1 (4 commits) (#41856) 
git@github.com:flutter/engine.git/compare/aa8fcbb65283...73dd5a33d9d1

git log aa8fcbb65283..73dd5a33d9d1 --no-merges --oneline
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from LSKbP... to EeMsz... (flutter/engine#12751)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia a1ea0a96f490..ce240cc6fd8e (13 commits) (flutter/engine#12750)
2019-10-02 bkonyi@google.com Roll src/third_party/dart 98b286de21..eaf1c308ab (5 commits)
2019-10-02 yjbanov@google.com Add web implementation for channel_buffers.dart (flutter/engine#12747)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
 2019-10-02 18:52:24 -04:00
Shi-Hao Hong
27a12efabf
Update DefaultTabController to allow for zero tabs (#41625) 
* Update DefaultTabController to allow for zero tabs
 2019-10-03 06:42:22 +08:00
Shi-Hao Hong
913aca22b3
[Material] Fix Tooltip to respect ambient Directionality (#41629) 
* Fix Tooltip Directionality

* Add regression test comment for tooltip directionality fix
 2019-10-03 06:41:23 +08:00
Shi-Hao Hong
e7947c3e92
DropdownButton.style API doc example for differing button and menu item text styles (#41650) 
* Add dropdown button style doc example for unique text styles
 2019-10-03 06:41:00 +08:00
gaaclarke
75c07ef1a6
Updated the docstring for SystemNavigator.pop. 
It had an Android bias and was incorrect for iOS.
 2019-10-02 15:36:07 -07:00
Josh
8b9e144e6a Added notice to docs that setPreferredOrientations does not always work on iPad (#40743) 2019-10-02 15:32:52 -07:00