Alexandre Ardhuin
a6af422874
some spaces formatting ( #29452 )
...
* some space formattings
* always use blocks in if-else if a block is used
* format spaces in for and while
* allow multiline if conditions
* fix missing space
2019-03-20 23:23:31 +01:00
liyuqian
be5c83b9b8
Add dump-shader-skp flag to flutter tools ( #29258 )
...
This is the accompanying change for https://github.com/flutter/engine/pull/8148 and it needs the engine PR to land first.
For https://github.com/flutter/flutter/issues/813
2019-03-15 12:37:53 -07:00
liyuqian
3202d228b7
--verbose-logging to verbose-logging in android ( #29383 )
...
Sorry that I missed the typo during the review of https://github.com/flutter/flutter/pull/29321
2019-03-15 09:20:15 -07:00
Jonah Williams
25820ab2a4
add option for --verbose-system-logs ( #29321 )
2019-03-13 22:42:12 -07:00
Alexandre Ardhuin
387f885481
Add missing trailing commas ( #28673 )
...
* add trailing commas on list/map/parameters
* add trailing commas on Invocation with nb of arg>1
* add commas for widget containing widgets
* add trailing commas if instantiation contains trailing comma
* revert bad change
2019-03-01 08:17:55 +01:00
Dan Field
15f2119f2c
Reland "Allow for gradle downloading missing SDK assets" ( #28097 ) ( #28355 )
...
* Allow for gradle downloading missing SDK assets if SDK licenses are present.
* Improvements for windows testing
2019-02-23 09:56:57 -08:00
Dan Field
74a9086037
Revert "Allow for gradle downloading missing SDK assets ( #28097 )" ( #28295 )
...
This reverts commit 6f5e88a59f5ac01fd55b5c3a11b7c2ddc6c7402c.
2019-02-21 16:53:45 -08:00
Dan Field
6f5e88a59f
Allow for gradle downloading missing SDK assets ( #28097 )
...
* Allow for gradle downloading missing SDK assets if SDK licenses are present.
* Fix license path for missing sdkmanager
* Cirrus re-run...
* Fix condition check
* rename props, add docs, rename method
* fix tests after param changes
* Fix weird path for flutter run and add tests
* remove print, fix tests
2019-02-21 15:57:20 -08:00
Alexandre Ardhuin
5169ab5974
format parameter list ( #27261 )
2019-02-21 09:27:07 +01:00
sjindel-google
95b34d7a07
Pass --verify-entry-points in debug mode. ( #27032 )
2019-01-30 07:33:55 -08:00
Chinmay Garde
e38efc890b
Add a flag to enable tracing to systrace. ( #27208 )
2019-01-28 19:55:01 -08:00
Jonah Williams
91fd89e8b3
Wrap dart:convert to track utf8 decode failures ( #26650 )
2019-01-25 16:16:26 -08:00
tonyzhao1
e4df6b4efc
Change the required version of adb, as older versions break hot reload. ( #24746 )
2019-01-25 10:37:46 -08:00
Alexandre Ardhuin
66f424f0f8
fix some bad indentations ( #26921 )
...
* fix some bad indentations
* remove suspicious line
2019-01-23 15:43:27 +01:00
Ian Hickson
31a9626c48
[O] Removing all timeouts (mark II) ( #26736 )
...
These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
2019-01-19 00:31:05 -08:00
Stanislav Baranov
eb8219edd5
Emulator support for dynamic mode on Intel architecture ( #26565 )
2019-01-17 14:21:35 -08:00
Ian Hickson
8426910a19
Revert "[O] Remove many timeouts. ( #23531 )" ( #25646 )
...
This reverts commit 76f70810e457b7a3a39fd59f59a930b5e93c6066.
2018-12-20 18:46:36 -08:00
Ian Hickson
76f70810e4
[O] Remove many timeouts. ( #23531 )
...
* Remove many timeouts.
These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
* Get the attach tests to pass.
* Apply review comments from Todd
* More review comment fixes
* Put back the extended timeouts here now that I know why we have them...
2018-12-20 17:10:40 -08:00
Victor Florintsev
16b9a80ccd
added definition for hardware ( #24502 )
...
This is the hardware used in the Samsung Galaxy J7
2018-11-19 14:18:01 -08:00
Jonah Williams
c11633e84e
Separate hot reload and hot restart capabilities. ( #24122 )
2018-11-09 10:33:22 -08:00
Ian Hickson
f9374fe071
Update the URL to the recommend bug report ( #23708 )
...
We have templates now.
2018-11-07 17:12:35 -08:00
Greg Spencer
4559ae1a6b
Stop wrapping adb, gradle and ios logger output, and update terminal wrapping column dynamically. ( #23592 )
...
Subcommand output (gradle, adb, etc) is no longer wrapped, and wrapping notices when the terminal column width changes dynamically now.
Fixes #23267 .
Fixes #23266 .
2018-10-30 16:00:50 -07:00
Alexandre Ardhuin
2d3ff10d62
apply lint prefer_void_to_null in packages/flutter_tools ( #22686 )
2018-10-05 07:54:56 +02:00
Greg Spencer
40a7a9cfc3
Fixes a common crash in getAdbDevices when adb executable isn't found. ( #22676 )
...
Apparently, this accounts for 13% of our crashes in Beta.
2018-10-04 15:57:15 -07:00
Alexandre Ardhuin
f62afdcf57
add missing type parameter on methods ( #22096 )
2018-10-01 21:29:08 +02:00
Danny Tuppeny
ff9dc22e44
Run logcat through shell ( #21977 )
...
This should fix #18889 which may be related to `adb logcat` not working correctly in non-terminals on some LG devices. See https://github.com/flutter/flutter/issues/18889#issuecomment-422217761 .
2018-09-18 17:57:31 +01:00
Alexandre Ardhuin
d927c93310
Unnecessary new ( #20138 )
...
* enable lint unnecessary_new
* fix tests
* fix tests
* fix tests
2018-09-12 08:29:29 +02:00
Ian Hickson
b7261586e5
Audit TODO syntax ( #20837 )
...
Fixes the pattern for some TODOs to match our style guide.
(Also, a couple of minor code order fixes.)
2018-08-21 14:02:11 -07:00
Ian Hickson
8c79f40d71
Fixes resulting from audit of issues links ( #20772 )
...
* Fixes resulting from audit of issues links
I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.
* Update run_test.dart
skip this test again since it failed on linux and macos bots
2018-08-18 16:44:39 -07:00
Mikkel Nygaard Ravn
8dd06a1190
Revert " Support flutter run on Android module project ( #19600 )" ( #20182 )
...
This reverts commit cacd291c5c8cf88125885846e392032d675a41f7.
2018-08-03 17:10:17 +02:00
Sarah Zakarias
cacd291c5c
Support flutter run on Android module project ( #19600 )
2018-08-03 15:13:28 +02:00
Mikkel Nygaard Ravn
b280074815
Move async from member access to construction ( #20035 )
2018-08-02 14:12:25 +02:00
Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const ( #20103 )
2018-08-02 12:02:32 +02:00
Todd Volkert
00aac68e2d
Revert flutter/flutter#19592 ( #19861 )
...
It was causing problems rolling Flutter into Fuchsia
2018-07-27 08:44:39 -07:00
Paweł Polański
da0e898da9
Added SM-G960F to the list of known physical devices ( #18966 )
...
Samsung Galaxy S9 is not an emulator and installation of
the release packages with 'flutter run --release' should be possible.
2018-07-24 16:39:23 -07:00
Alexandre Ardhuin
27018359d2
re-enable lint unnecessary_const ( #19592 )
...
* re-enable lint unnecessary_const
* remove trailling whitespaces
* remove unnecessary const (after merge)
2018-07-23 08:31:48 +02:00
Leaf Petersen
32f94443cc
Remove uses of deprecated constants and change int.parse to int.tryParse ( #19575 )
...
* Remove uses of deprecated constants
* Change int.parse to int.tryParse where appropriate
2018-07-20 15:07:24 -07:00
Sigurd Meldgaard
2d3a5c744d
Revert "Revert "Use FlutterProject to locate files ( #18913 )" ( #19409 )" ( #19456 )
...
With a fix of a path being printed relative instead of absolute.
2018-07-20 08:00:30 +02:00
Ian Hickson
f630f90d6d
Revert "enable lint unnecessary_const ( #19342 )" ( #19423 )
...
This reverts commit cc1cf13eec6752af992d3db0265cf04cc90bfd13.
2018-07-16 13:30:27 -07:00
Alexandre Ardhuin
cc1cf13eec
enable lint unnecessary_const ( #19342 )
2018-07-16 21:43:48 +02:00
Sigurd Meldgaard
6a8f904104
Revert "Use FlutterProject to locate files ( #18913 )" ( #19409 )
...
This reverts commit 57d78cc739a1d21a981886d424a6a104c8d48e33.
2018-07-16 16:21:20 +02:00
Sigurd Meldgaard
57d78cc739
Use FlutterProject to locate files ( #18913 )
2018-07-16 09:39:37 +02:00
Danny Tuppeny
108da01310
Remove the 'app' domain from flutter daemon ( #18873 )
...
* Remove the 'app' domain from flutter daemon
By default the daemon won't register the "app" domain, you need to opt-in (which the 'run' command does, as well as the tests for the app functionality).
Fixes #6658 .
* Tweak text
* Put restart/callServiceExtension/stop back into daemon mode
* Add a comment about removing discoverApps
2018-06-28 16:22:02 +01:00
Ian Hickson
35ad2a786d
Remove race conditions involving finding available ports ( #18698 )
...
This is an attempt to reland #18488 with less breakage on macOS.
2018-06-27 16:44:28 -07:00
Ian Hickson
0fa5ba43a1
Revert "Remove race conditions involving finding available ports ( #18488 )" ( #18521 )
...
This reverts commit 775087225141573d20224e3cda3cff9e56a6cd1e.
2018-06-15 15:37:20 -07:00
Ian Hickson
7750872251
Remove race conditions involving finding available ports ( #18488 )
2018-06-15 14:16:18 -07:00
Sarah Zakarias
8f9aca8558
Enable running with prebuilt test-only apk ( #18453 )
2018-06-15 13:25:19 +02:00
Keerti Parthasarathy
aecb7d9607
Fixes for Dart 2 failures in tests ( #18371 )
2018-06-12 09:30:10 -07:00
Alexandre Ardhuin
09276bea25
enable lint prefer_equal_for_default_values ( #18156 )
2018-06-05 08:50:40 +02:00
Hans Muller
0260642fc5
Revert some uses of Number.tryParse() ( #16546 )
...
Revert some uses of Number.tryParse(), ignore deprecation warnings for Number.parse()
2018-04-12 19:16:44 -07:00
