firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
83,367 Commits 1 Branch 0 Tags
Commit Graph

1222 Commits

Author SHA1 Message Date
Flutter GitHub Bot
6e46ee8d6d
Marks Linux build_tests_5_5 to be unflaky (#154995) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux build_tests_5_5"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_5_5%22).
This test can be marked as unflaky.
 2024-09-11 17:51:06 +00:00
Flutter GitHub Bot
d8de38f10d
Marks Linux build_tests_1_5 to be unflaky (#154991) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux build_tests_1_5"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_1_5%22).
This test can be marked as unflaky.
 2024-09-11 16:52:29 +00:00
Flutter GitHub Bot
e662a9bafe
Marks Linux build_tests_2_5 to be unflaky (#154992) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux build_tests_2_5"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_2_5%22).
This test can be marked as unflaky.
 2024-09-11 16:52:27 +00:00
Gray Mackall
fadbf44471
Fix java version used by build_aar_module_test (#154967) 
Used the wrong syntax, whoops

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Gray Mackall <mackall@google.com>
 2024-09-11 10:17:25 -04:00
Gray Mackall
6fd2b9f88b
Remove scheduler: luci from new build_aar_module_test (#154945) 
This option was deprecated (/removed?) in the time since the test was originally disabled.

See https://github.com/flutter/flutter/issues/109712, https://github.com/flutter/flutter/pull/109714
 2024-09-10 20:35:07 +00:00
Gray Mackall
f964f15dcb
Fix flutter build aar for modules that use a plugin (#154757) 
https://github.com/flutter/flutter/pull/151675 bumped module templates to AGP 8.1.

In doing so, I tried to work around a behavior change [that was new in AGP 8.0](https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes):
> AGP 8.0 creates no SoftwareComponent by default. Instead AGP creates SoftwareComponents only for variants that are configured to be published using the publishing DSL.

by using AGP's publishing DSL to define which variants to publish in the module's ephemeral gradle files:
```
android.buildTypes.all {buildType ->
    if (!android.productFlavors.isEmpty()) {
        android.productFlavors.all{productFlavor ->
            android.publishing.singleVariant(productFlavor.name + buildType.name.capitalize()) {
                withSourcesJar()
                withJavadocJar()
            }
        }
    } else {
        android.publishing.singleVariant(buildType.name) {
            withSourcesJar()
            withJavadocJar()
        }
    }
}
```

The problem is that this doesn't get applied to the plugin projects used by the module, so if a module uses any plugin it breaks. This PR fixes that by applying similar logic, but to each project (not just the module's project).

Tested manually with https://github.com/gmackall/GrayAddToApp, and also re-enabled an old test that tested this use case as a part of the PR.

Fixes: https://github.com/flutter/flutter/issues/154371
 2024-09-10 16:42:22 +00:00
Christopher Fujino
92697d3ecc
Improve tracing and fix packages_autoroller (#154841) 
Reverts flutter/flutter#154555
Re-lands of https://github.com/flutter/flutter/pull/154441 and https://github.com/flutter/flutter/pull/154369

New changes in this PR:

1. extend timeout of the `Linux packages_autoroller` shard (see step 14 in this example [LED build](https://ci.chromium.org/ui/p/flutter/builders/prod.shadow/Linux%20packages_autoroller/7/infra))
2. use the managed framework repo as the working directory in the `framework.streamDart()` helper function--we were generating gradle lockfiles in the wrong directory

A LED build with this code generated the following gradle lockfile update: d939981cd2
 2024-09-09 23:31:21 +00:00
Kate Lovett
132dc8f82d
Revert #154339, remove bringup on linux customer testing (#154372) 
Reverts increased timeouts on customer testing from #154339, also removes bringup state from https://github.com/flutter/flutter/issues/154293.
This was related to https://github.com/flutter/flutter/issues/154251, which will be fixed by https://github.com/flutter/tests/pull/406 (so we should land that first).
 2024-09-03 19:36:56 +00:00
Christopher Fujino
28a9124304
Add Android SDK to Linux packages_autoroller (#154462) 
Fixes https://github.com/flutter/flutter/issues/154151

This target now requires the Android toolchain because it may
re-generate gradle lockfiles.
 2024-09-03 11:23:49 -07:00
Yegor
9502cb1576
increase Linux build_test shard count from 3 to 5 (#154444) 
Fixes https://github.com/flutter/flutter/issues/154443
 2024-08-30 15:05:55 -07:00
Zachary Anderson
d01b9a4f8c
Increase timeout for customer_testing test step (#154339) 
Related: https://github.com/flutter/flutter/issues/154251

Successful runs are bumping right up against the timeout

See https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20customer_testing/84496/overview which succeeded in 29 minutes vs. https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20customer_testing/84497/overview which failed with a timeout at 30 minutes.
 2024-08-29 15:34:25 +00:00
Matan Lurey
32e29fc39b
Temporarily mark Linux customer_testing as bringup: true. (#154297) 
See https://github.com/flutter/flutter/issues/154293.
 2024-08-28 16:09:05 -07:00
Flutter GitHub Bot
4f37ef14ef
Marks Mac_mokey run_release_test to be flaky (#153831) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_mokey run_release_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/153830
 2024-08-21 19:37:11 +00:00
Zachary Anderson
88123277fc
Remove android stack_size_test (#153695) 
This test expects to run on 32-bit hardware, but the devicelab no longer
has 32-bit Android hardware. In particular, the test contains hand-coded
32-bit arm assembly for reading the stack pointer from Dart code via
`dart:ffi`.

This test was added in response to a framework change that caused stack
frames to be larger than expected while building widgets, leading apps
to crash with StackOverflow exceptions unexpectedly. Since then (>3
years ago) this test has not prevented any similar issue, so I believe
deleting it rather than fixing it is a better use of resources.
 2024-08-19 12:25:35 -07:00
Kate Lovett
6a28048935
Update goldctl git revision (#153710) 
This updates the version of goldctl we checkout for testing.
The recent update makes goldctl more resilient to I/O timeouts.
 2024-08-19 18:09:25 +00:00
Zachary Anderson
69ff9eae7b
Move Android API level 35 emulator tests to staging (#153568) 
These same tests but running against API level 34 emulators are remaining as presubmit tests. The API level 35 tests should stay in staging while the emulator stabilizes. So we can collect flake data and continue to debug. 

Related: https://github.com/flutter/flutter/issues/153445
 2024-08-16 15:43:13 +00:00
Matan Lurey
af815f0d9b
Roll avd_cipd_verison to latest to use the crashreport tool. (#153520) 
Work towards https://github.com/flutter/flutter/issues/153445.

I can do a similar set of PRs on flutter/packages and flutter/engine for consistency.

/cc @johnmccutchan @reidbaker @zanderso
 2024-08-15 21:58:31 +00:00
Zachary Anderson
cc13cd1f11
Retry Linux_android_emu tests in presubmit like they are in postsubmit (#153369) 
To help keep rolls unblocked while the flakiness of these tests is
investigated.
 2024-08-13 10:23:30 -07:00
Zachary Anderson
6200318586
Shift API level 34 emulator tests to prod (#153366) 
These are passing consistently
 2024-08-13 09:42:30 -07:00
Zachary Anderson
b12d86157e
Move windows mokey tests to prod (#153203) 
For https://github.com/flutter/flutter/issues/148085
 2024-08-10 04:08:08 +00:00
Zachary Anderson
f43ae3b1ff
Also run Linux_android_emu tests on API level 34 image (#153175) 
These VMs are relatively inexpensive, so there's no reason not to
continue running on the API level 34 image while we work out how to deal
with the apparent instability in the 35 images.

Related: https://github.com/flutter/flutter/issues/152684
 2024-08-09 15:23:12 -07:00
Zachary Anderson
857addcb31
Shift tests on moto g4 on Windows hosts to mokey in staging (#153167) 
For https://github.com/flutter/flutter/issues/148085
 2024-08-09 09:23:56 -07:00
Zachary Anderson
8b4b6ae91e
Shift Linux_android_emu tests from staging to prod (#153110) 
These tests were moved to staging when they were flaking at a high rate.
I landed a couple of changes to fix unrelated issues that were masking
the underlying cause. However, these tests are no longer flaking at the
same rate in staging as they were in prod. So, I am moving these back to
prod and will monitor the flake rate.

Related https://github.com/flutter/flutter/issues/152684
 2024-08-08 13:08:17 -07:00
Zachary Anderson
5eba89e5ed
Move Android tests with macOS host from staging to prod (#153113) 
Part of https://github.com/flutter/flutter/issues/148085
 2024-08-08 20:03:14 +00:00
Jenn Magder
ede2e27054
Revert "Marks Mac channels_integration_test to be flaky" (#153044) 
Reverts flutter/flutter#151882

Flake rate is back under the threshold https://github.com/flutter/flutter/issues/151881#issuecomment-2272996113

Closes https://github.com/flutter/flutter/issues/151881
 2024-08-07 19:49:51 +00:00
Flutter GitHub Bot
c4c84caf6e
Marks Linux android_java17_dependency_smoke_tests to be unflaky (#153011) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux android_java17_dependency_smoke_tests"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20android_java17_dependency_smoke_tests%22).
This test can be marked as unflaky.
 2024-08-07 18:53:57 +00:00
Flutter GitHub Bot
6945ec0a8c
Marks Linux android_java11_dependency_smoke_tests to be unflaky (#153010) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux android_java11_dependency_smoke_tests"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20android_java11_dependency_smoke_tests%22).
This test can be marked as unflaky.
 2024-08-07 18:50:06 +00:00
Flutter GitHub Bot
521b0b327c
Marks Mac integration_ui_test_test_macos to be flaky (#152213) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac integration_ui_test_test_macos"
}
-->
Issue link: https://github.com/flutter/flutter/issues/152212
 2024-08-06 21:24:53 +00:00
Zachary Anderson
a88e321c5b
Move Linux_build_test tests from staging to prod (#152877) 
These have been migrated to mokey and have been consistently passing in staging.
 2024-08-05 16:58:47 +00:00
Zachary Anderson
ae66107a5c
Mark Linux_android_emu tests bringup: true (#152867) 
Due to https://github.com/flutter/flutter/issues/152684

This PR is just eagerly doing what the flake bot would do on Wednesday.

FYI @matanlurey @reidbaker
 2024-08-05 09:28:00 -07:00
Zachary Anderson
8b93ab9d52
Fix device_os requested in linux_build_test tests (#152808) 
The MotoG4's had device_os=N, the mokey's have device_os=U.

Eventually I'll get this right...
 2024-08-03 17:26:31 +00:00
Zachary Anderson
355a4607f2
Fix misunderstanding of properties vs. drone_dimensions in Linux_build_tests (#152796) 
In "build tests", the `properties` of the build specify the
configuration of the coordinator, and the `drone_dimensions` specify the
configuration of the devicelab bot. This PR should therefore fix the
infra errors on the `Linux_build_test` tests caused by my last PR at
https://github.com/flutter/flutter/pull/152756. (Unfortunately, a simple
revert won't work since the MotoG4s have already been removed from the
Linux hosts.)
 2024-08-02 19:50:02 -07:00
Zachary Anderson
8d3d3ee4d0
Reland: Shift Linux_build_test tests from MotoG4 to mokey (#152756) 
Reland of https://github.com/flutter/flutter/pull/152750 with fixes to
hopefully make the test run in the devicelab. Also, shifts the tests to
`bringup: true` this time to avoid breaking the tree.

For For https://github.com/flutter/flutter/issues/148085
 2024-08-02 14:51:26 -07:00
auto-submit[bot]
f10a497e4a
Reverts "Shift Linux_build_test tests from MotoG4 to mokey (#152750)" (#152755) 
Reverts: flutter/flutter#152750
Initiated by: zanderso
Reason for reverting: infra failure
Original PR Author: zanderso

Reviewed By: {jason-simmons}

This change reverts the following previous change:
For https://github.com/flutter/flutter/issues/148085
 2024-08-02 17:38:46 +00:00
Zachary Anderson
9cc5d7f446
Shift Linux_build_test tests from MotoG4 to mokey (#152750) 
For https://github.com/flutter/flutter/issues/148085
 2024-08-02 16:59:07 +00:00
Matan Lurey
4ff9462be8
Fix local testing, gradle XML errors, and enable on CI. (#152383) 
TIL you cannot have XML comments before the initial `<?xml` declaration.

Follow-up to https://github.com/flutter/flutter/pull/152326.
 2024-08-01 09:10:45 -07:00
Camille Simon
c3fbf3dd98
[Android] Update integration test AVD dependency to use Android 35 emulators (#152498) 
Updates AVD dependency to use [latest available AVD dependency](https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64/+/I7SIawD0okHpiEe8fKvI5NQrMEWDibsvOduVbbK5pDEC) (actually I'm one behind by the time of publishing--I assume this is ok) so that engine integration tests run on emulators running Android 35, the current latest version of Android.

Updated docs to reflect this is the new way to update this dependency in https://github.com/flutter/flutter/pull/152503.

Kinda part of https://github.com/flutter/flutter/issues/150215 (the original instructions anyway).
 2024-07-31 20:44:56 +00:00
Gray Mackall
a1f03609f7
Set up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range (#151568) 
Sets up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range.

Post submit only, because the suite takes ~30 minutes to run, and I expect it to be _somewhat_ rare that we break only one of these versions (and therefore it doesn't get caught by existing presubmits).
 2024-07-31 19:14:46 +00:00
Andrew Kolos
118a015b65
remove bringup from Windows tool_integration_tests_* (#152599) 
Followup to https://github.com/flutter/flutter/pull/152582
 2024-07-31 19:12:37 +00:00
Andrew Kolos
7133a89c44
increase sharding on Windows tool_integration_tests (#152582) 
Resolves https://github.com/flutter/flutter/issues/152211

Will remove `bringup` status after this merges.
 2024-07-31 06:52:06 +00:00
Flutter GitHub Bot
9bf8a283aa
Marks Mac platform_channel_sample_test_macos to be flaky (#151884) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac platform_channel_sample_test_macos"
}
-->
Issue link: https://github.com/flutter/flutter/issues/151883
 2024-07-30 22:50:59 +00:00
Zachary Anderson
5f460e10fc
Shift macOS/Android tests from Pixel 7 to mokey in staging (#152571) 
Part of https://github.com/flutter/flutter/issues/148085
 2024-07-30 12:48:34 -07:00
Zachary Anderson
53c732f484
Shift some mac Android tests to Mokey devices in staging (#152499) 
Following https://github.com/flutter/flutter/issues/152406

For https://github.com/flutter/flutter/issues/148085
 2024-07-29 13:24:41 -07:00
Andrew Kolos
e2e43987c4
mark Mac tool_integration_tests_* as non-bringup (#152412) 
Follow-up to https://github.com/flutter/flutter/pull/152399
 2024-07-29 04:34:20 +00:00
Andrew Kolos
4d12197ca6
further shard Mac tool_integration_tests from 4 to 5 shards (#152399) 
Resolves https://github.com/flutter/flutter/issues/152397
 2024-07-26 23:12:17 +00:00
Flutter GitHub Bot
e7f39c1516
Marks Mac channels_integration_test to be flaky (#151882) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac channels_integration_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/151881
 2024-07-24 15:45:10 -07:00
Matan Lurey
09461925a3
Scaffolding for NativeDriver and AndroidNativeDriver for taking screenshots using adb. (#152194) 
Closes https://github.com/flutter/flutter/issues/152189.

I have next to no clue how to configure this to run on CI, so bear with me as I rediscover the wheel.
 2024-07-24 20:12:19 +00:00
Flutter GitHub Bot
5e3ca708b7
Marks Mac_x64 plugin_lint_mac to be unflaky (#152216) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_x64 plugin_lint_mac"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20plugin_lint_mac%22).
This test can be marked as unflaky.
 2024-07-24 14:14:15 +00:00
Zachary Anderson
1962e7fd1a
Stop running flaky mac tests in presubmit (#151870) 
For currently unknown reasons, this test is failing at a rate >10% but only in presubmit. This is blocking many engine -> framework rolls, requiring a lot of manual intervention from the sheriff.

https://github.com/flutter/flutter/issues/150642
 2024-07-17 18:02:11 +00:00
Flutter GitHub Bot
dcdcdb070f
Marks Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark to be unflaky (#148392) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64_ios%20hot_mode_dev_cycle_ios__benchmark%22).
This test can be marked as unflaky.
 2024-07-16 11:24:31 +00:00