engine-flutter-autoroll
3dad107b35
Roll Fuchsia Linux SDK from Btjuc6db5cj3okKa5... to Skjlz6df4TA2nmfI2... ( #165772 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-24 05:58:25 +00:00
engine-flutter-autoroll
f8c1f3cccc
Roll Fuchsia Linux SDK from zb7ddt_3LqBcDg5_U... to Btjuc6db5cj3okKa5... ( #165760 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-23 03:48:24 +00:00
engine-flutter-autoroll
6f6cc0a0fb
Roll Skia from 47c46a0a97c9 to d13c2682e1d8 (1 revision) ( #165746 )
...
https://skia.googlesource.com/skia.git/+log/47c46a0a97c9..d13c2682e1d8
2025-03-22 bungeman@google.com Ensure cmap glyph in range in
getGlyphToUnicodeMap
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-22 16:52:27 +00:00
engine-flutter-autoroll
bb81a93d75
Roll Dart SDK from 41a60009ed5c to 13e950e67c2a (2 revisions) ( #165738 )
...
https://dart.googlesource.com/sdk.git/+log/41a60009ed5c..13e950e67c2a
2025-03-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-219.0.dev
2025-03-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-218.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-22 11:00:01 +00:00
Hannah Jin
efa81a7af6
Reland #163662 [web][a11y]Delete _childContainerElement ( #165434 )
...
Reland #163662 with some changes
1. when a node's role changes and reparenting it, append children to it
2. Merge optimization from /pull/165352
fix: https://github.com/flutter/flutter/issues/45205
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-22 03:38:20 +00:00
engine-flutter-autoroll
66df85a254
Roll Dart SDK from c929e6d3d08f to 41a60009ed5c (7 revisions) ( #165730 )
...
https://dart.googlesource.com/sdk.git/+log/c929e6d3d08f..41a60009ed5c
2025-03-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-217.0.dev
2025-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-216.0.dev
2025-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-215.0.dev
2025-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-214.0.dev
2025-03-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-213.0.dev
2025-03-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-212.0.dev
2025-03-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-211.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-22 02:52:07 +00:00
Jonah Williams
31ff6497f1
Reland: [Impeller] add a configuration option that allows defering all PSO construction until needed. ( #165622 )
...
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.
---------
Co-authored-by: Aaron Clarke <aaclarke@google.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
2025-03-22 01:34:05 +00:00
engine-flutter-autoroll
a4b982738e
Roll Skia from e1f426dad46d to d54c36d6edd7 (15 revisions) ( #165721 )
...
https://skia.googlesource.com/skia.git/+log/e1f426dad46d..d54c36d6edd7
2025-03-21 egdaniel@google.com Revert "Reland "Fix need query for
copyOnWrite for dual-proxies Ganesh images.""
2025-03-21 kjlubick@google.com Clarify RasterPipeline API for stages
2025-03-21 michaelludwig@google.com [graphite] Fix swapchain creation
for BGRA_SRGB
2025-03-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from eaa43b73e162 to 331cd868767f (13 revisions)
2025-03-21 michaelludwig@google.com Fix GPU_TEST_UTILS regex in
PRESUBMIT.py
2025-03-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 687c1fb080fa to eaa43b73e162 (8 revisions)
2025-03-20 jvanverth@google.com [graphite] Pull ClipAtlas's DrawAtlas
management into private class.
2025-03-20 jlavrova@google.com Fixes for Bidi API in CanvasKit
2025-03-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1bec8a448930 to 687c1fb080fa (5 revisions)
2025-03-20 lukasza@chromium.org [rust png] Reland: Tweak mapping Skia
`CompressionLevel` to `png` API.
2025-03-20 jvanverth@google.com [graphite] Restore compute SkSL tests.
2025-03-20 kjlubick@google.com Move Mac11 jobs onto Mac14 machines
2025-03-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 27b44046a577 to 76ce2c6def3d (1 revision)
2025-03-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from dfc82bb1097a to b9b83d3a1dc7 (16 revisions)
2025-03-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 6737c973130b to 1bec8a448930 (12 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-22 01:34:05 +00:00
engine-flutter-autoroll
8c5bbf2931
Roll Fuchsia Linux SDK from y-WmESARBN4BZF0gs... to zb7ddt_3LqBcDg5_U... ( #165711 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-22 01:32:10 +00:00
auto-submit[bot]
9164e2332e
Reverts "Moving Linux linux_unopt for tree greeness ( #165694 )" ( #165705 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165694
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: bot is green (no, really, this specific bot is
green).
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jtmcdole
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Unknown how many more changes are needed to make the tree go green and
close out #163012 .
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-03-21 21:44:25 +00:00
John "codefu" McDole
97bdde5f74
Moving Linux linux_unopt for tree greeness ( #165694 )
...
Unknown how many more changes are needed to make the tree go green and
close out #163012 .
2025-03-21 20:01:59 +00:00
Jason Simmons
bfe880363e
Fix pylint warning in run_tests.py ( #165692 )
2025-03-21 19:35:49 +00:00
Jason Simmons
d3571a28a1
Remove the path_ops library test from the run_tests script ( #165675 )
...
This test was not running previously on the Linux builder, but it
started running again when ASAN was disabled due to the Ubuntu 24
upgrade on LUCI. The test is not currently functioning as intended and
needs to be disabled until the Ubuntu upgrade is stable.
See https://github.com/flutter/flutter/pull/165661
2025-03-21 17:36:44 +00:00
John "codefu" McDole
b6921e1895
Mark Linux linux_web_engine as bringup ( #165665 )
...
After upgrading Ubuntu to 24.04, these tests started flaking.
2025-03-21 15:38:08 +00:00
Jason Simmons
5a8d4032e9
Disable the address sanitizer in the linux_unopt build ( #165661 )
...
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.
See https://github.com/flutter/flutter/issues/165594
See https://github.com/flutter/flutter/pull/165620
2025-03-21 15:02:51 +00:00
Jonah Williams
8b49f4d4f0
disable linux lsan. ( #165620 )
...
With the ubuntu upgrade, everything is leaking now.
2025-03-21 01:36:47 +00:00
auto-submit[bot]
0158281d6e
Reverts "[Impeller] add a configuration option that allows defering all PSO construction until needed. ( #165261 )" ( #165619 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165261
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: bork the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {gaaclarke}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-03-21 00:17:47 +00:00
Jonah Williams
cab4fe33c3
[Impeller] add a configuration option that allows defering all PSO construction until needed. ( #165261 )
...
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.
---------
Co-authored-by: Aaron Clarke <aaclarke@google.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
2025-03-20 21:06:09 +00:00
Chinmay Garde
2db84b20f9
[Impeller] libImpeller: Expose APIs to draw shadows. ( #165517 )
...
Fixes https://github.com/flutter/flutter/issues/165146
2025-03-20 17:28:00 +00:00
Matthew Kosarek
554c814ada
( #112207 ) Adding view_id parameter to DispatchSemanticsAction and UpdateSemantics ( #164577 )
...
fixes #112207
## What's new?
- Added a `view_id` on `UpdateSemantics`
- Added a `view_id` on `DispatchSemanticsAction`
- Piped the `view_id` all over creation
- Updated tests for these actions across the different platforms
- Added `FlutterEngineSendSemanticsAction` to the embedder API in order
to not break `FlutterEngineDispatchSemanticsAction`
- Using this view ID properly on the Windows platform (see
`engine/src/flutter/shell/platform/windows/flutter_windows_engine.cc`)
## How to test
1. Checkout
[foundation-plus-framework](https://github.com/canonical/flutter/pull/36 )
from canonical/flutter
2. Merge this branch into it
3. Enable the "Narrator" screen reader on windows
4. Run the Multi window reference app (see
[PR](https://github.com/canonical/flutter/pull/36 ) for details)
5. Open up another window, and note that the right buttons and things
are being highlighted, as the screenreader would expect 🎉
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-03-20 16:30:07 +00:00
engine-flutter-autoroll
7f2064cda1
Roll Dart SDK from 6cece361df65 to c929e6d3d08f (2 revisions) ( #165568 )
...
https://dart.googlesource.com/sdk.git/+log/6cece361df65..c929e6d3d08f
2025-03-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-210.0.dev
2025-03-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-209.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-20 15:54:32 +00:00
Jim Graham
e6fbc63d37
[Impeller][DisplayList] Consolidate BlendMode definitions ( #165450 )
...
The 2 enum classes `impeller::BlendMode` and `flutter::DlBlendMode` were
essentially identical so they were merged.
The names were consolidated to the ui.BlendMode/DlBlendMode versions and
the implementation is shared from Impeller to DisplayList via a `using`
directive. No conversion is needed any more to describe blend modes
between DisplayList and Impeller.
2025-03-20 05:34:06 +00:00
engine-flutter-autoroll
75b9a25fc2
Roll Fuchsia Linux SDK from nvix6F7GN9Q4nLH2Z... to y-WmESARBN4BZF0gs... ( #165534 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-20 02:40:35 +00:00
engine-flutter-autoroll
57bde858cd
Roll Dart SDK from fab994cca421 to 6cece361df65 (1 revision) ( #165532 )
...
https://dart.googlesource.com/sdk.git/+log/fab994cca421..6cece361df65
2025-03-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-208.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-20 02:12:34 +00:00
ash2moon
ecbb115ae3
deprecate Android announcement events and add deprecation warning. ( #165195 )
...
Due to this [Android
deprecation](https://developer.android.com/reference/android/view/View#announceForAccessibility(java.lang.CharSequence) )
Flutter needs to show deprecation warnings to developers when using
announce on Android.
Unfortunately testing this log statement is impossible since robolectric
currently does not support API >=36.
https://github.com/flutter/flutter/issues/165220 will add the test code
in once robolectric supports 36.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-19 23:42:18 +00:00
Jonah Williams
125a2b749e
[Impeller] fix barriers on PowerVR hardware / ensure Render pass cached on non-MSAA. ( #165497 )
...
Work towards https://github.com/flutter/flutter/issues/162033
- barriers for render pass are not correct, but only causes a problem on
powervr/imagination. Added new external subpass dependencies that have
better descriptions for what they do. We now use the subpass to
transition images that are sampled to the final shaderReadOnlylayout,
while keeping swapchain images in eGeneral.
- missing cache for render pass objects when using non-msaa passes. This
mostly impacts powervr hardware because render pass construction is much
slower there.
2025-03-19 23:31:04 +00:00
engine-flutter-autoroll
a7a3f55ccd
Roll Skia from dbfd72770bdd to e1f426dad46d (1 revision) ( #165518 )
...
https://skia.googlesource.com/skia.git/+log/dbfd72770bdd..e1f426dad46d
2025-03-19 bungeman@google.com Do not create nullptr SkTypeface_proxy
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-19 21:09:16 +00:00
engine-flutter-autoroll
ff6ce3fb9b
Roll Dart SDK from cef5d9bd7616 to fab994cca421 (1 revision) ( #165516 )
...
https://dart.googlesource.com/sdk.git/+log/cef5d9bd7616..fab994cca421
2025-03-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-207.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-19 20:49:07 +00:00
Qun Cheng
32b34ff99e
Add aria menu roles to menu-related widgets ( #164741 )
...
Related to https://github.com/flutter/flutter/issues/157177
This PR is to add the following changes:
* Implement `SemanticsRole.menu`, `SemanticsRole.menuItem`,
`SemanticsRole.menuBar`, `SemanticsRole.menuItemCheckbox`, and
`SemanticsRole.menuItemRadio`.
* Add `SemanticsRole.menu` role in ~`MenuAnchor`~, `DropdownButton`, and
`PopupMenuButton`
~* Add `SemanticsRole.menuBar` role to `MenuBar`~
* Add `SemanticsRole.menuItem` to ~`MenuItemButton`~, `DropdownMenuItem`
and `PopupMenuItem`
~* Add `SemanticsRole.menuItemCheckbox` to `CheckboxMenuButton`~
~* Add `SemanticsRole.menuItemRadio` to `RadioMenuButton`~
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-19 20:33:15 +00:00
engine-flutter-autoroll
bf3826d2ce
Roll Skia from 38a5185e01f1 to dbfd72770bdd (3 revisions) ( #165503 )
...
https://skia.googlesource.com/skia.git/+log/38a5185e01f1..dbfd72770bdd
2025-03-19 drott@chromium.org [Fontations] Harmonize "slight"
autohinting behavior with FreeType
2025-03-19 kjlubick@google.com Remove slow path for
SkBitmapDevice::drawRRect
2025-03-19 thomsmit@google.com this is my first commit
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-19 18:43:38 +00:00
engine-flutter-autoroll
3705758a18
Roll Dart SDK from 30a676454f03 to cef5d9bd7616 (1 revision) ( #165487 )
...
https://dart.googlesource.com/sdk.git/+log/30a676454f03..cef5d9bd7616
2025-03-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-206.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-19 15:22:09 +00:00
engine-flutter-autoroll
ca21baed15
Roll Dart SDK from 382211559d5e to 30a676454f03 (1 revision) ( #165460 )
...
https://dart.googlesource.com/sdk.git/+log/382211559d5e..30a676454f03
2025-03-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-205.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-19 06:26:21 +00:00
engine-flutter-autoroll
466d13db0e
Roll Dart SDK from 2a13e6c0b088 to 382211559d5e (3 revisions) ( #165438 )
...
https://dart.googlesource.com/sdk.git/+log/2a13e6c0b088..382211559d5e
2025-03-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-204.0.dev
2025-03-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-203.0.dev
2025-03-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-202.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-18 23:20:08 +00:00
engine-flutter-autoroll
b0edb3de6f
Roll Fuchsia Linux SDK from mPniqXmPpXqMMpM8z... to nvix6F7GN9Q4nLH2Z... ( #165429 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-18 21:46:13 +00:00
engine-flutter-autoroll
3f2fc32e8d
Roll Skia from cebb097bf651 to 5e37e525459d (1 revision) ( #165426 )
...
https://skia.googlesource.com/skia.git/+log/cebb097bf651..5e37e525459d
2025-03-18 kjlubick@google.com Make raster pipeline gradient code more
readable
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-18 21:20:49 +00:00
Jim Graham
e407d879d8
[Impeller] Move skia_conversions towards retirement ( #165408 )
...
The skia_conversions sources and namespace have been filled with methods
that are no longer used now that the DisplayList has its own complete
set of APIs and is now mostly obsolete.
2025-03-18 21:19:08 +00:00
Jim Graham
c4d8870f50
[DisplayList] DlPath supports generic path dispatching ( #164753 )
...
There are different ways to iterate over an SkPath or an impeller::Path
and various points in the engine source tree we have boilerplate
duplicates of this code to transfer the contents of the DlPath wrapper
object into some platform-specific path. This PR adds a
dispatch/receiver mechanism to read back the contents of a DlPath -
independent of whether it is backed by an SkPath or an impeller::Path -
in a simpler form that avoids potential mistakes in the various
conversion methods.
See DlPathReceiver and DlPath::Dispatch in the dl_path.h file
2025-03-18 20:42:06 +00:00
Jonah Williams
05c868e744
[Impeller] tear down swapchain when backgrounding. ( #165259 )
...
When we return to the foreground the swapchain is reconstructed anyway.
Eagerly tearing the old one down releases memory faster. Highlighted by
a regression in a customer: money benchmark.
2025-03-18 19:26:11 +00:00
Jason Simmons
6912a06f35
Add checks for disposed images in FragmentShader.setImageSampler ( #165214 )
2025-03-18 19:05:20 +00:00
Jason Simmons
5f0b94f50d
[Impeller] Return an empty contents in Paint::CreateContents if a runtime effect sampler is invalid ( #165165 )
...
Callers of Paint::CreateContents expect that the result is not null.
See https://github.com/flutter/flutter/issues/165119
2025-03-18 19:03:30 +00:00
engine-flutter-autoroll
25a0d9ab74
Roll Skia from 5907e2cfe986 to cebb097bf651 (6 revisions) ( #165411 )
...
https://skia.googlesource.com/skia.git/+log/5907e2cfe986..cebb097bf651
2025-03-18 jvanverth@google.com [graphite] Another attempt to fix
VkDeps.
2025-03-18 michaelludwig@google.com [graphite] UniquePaintParamsID is
constexpr
2025-03-18 michaelludwig@google.com [graphite] Move DstReadStrategy out
of Caps, make uint8_t
2025-03-18 jvanverth@google.com [graphite] Clean up DrawAtlas code.
2025-03-18 kjlubick@google.com Remove unnecessary consts from virtual
method declarations
2025-03-18 jvanverth@google.com [graphite] Try again to disable compute
tests with Vulkan
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-18 18:52:20 +00:00
Jason Simmons
44036a53cd
Roll Dart SDK from 725172afbc42 to 2a13e6c0b088 (3 revisions) ( #165403 )
...
https://dart.googlesource.com/sdk.git/+log/725172afbc42..2a13e6c0b088
2025-03-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-201.0.dev 2025-03-17
dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version
3.8.0-200.0.dev 2025-03-17
dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version
3.8.0-199.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
2025-03-18 18:50:07 +00:00
auto-submit[bot]
4e5a2dbf1a
Reverts "[web][a11y]Delete _childContainerElement ( #163662 )" ( #165416 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#163662
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: hannah-hyj
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: google 3 failure
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: hannah-hyj
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {yjbanov}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
delete _childContainerElement , add the rect compensate and scrolling
adjustment to the children
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-03-18 18:18:47 +00:00
engine-flutter-autoroll
155f6dc7f9
Roll Skia from 8c4c06605277 to 5907e2cfe986 (3 revisions) ( #165399 )
...
https://skia.googlesource.com/skia.git/+log/8c4c06605277..5907e2cfe986
2025-03-18 danieldilan@google.com Revert "Remove transform_scanline
functions from SkPngEncoder"
2025-03-18 drott@chromium.org [Fontations-backend] Roll Fontations,
Skrifa to 0.29
2025-03-18 danieldilan@google.com Remove transform_scanline functions
from SkPngEncoder
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,jvanverth@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-18 16:30:21 +00:00
Jonah Williams
6328b7ea08
[Impeller] limit mipmap generation ( #165357 )
...
Fixes https://github.com/flutter/flutter/issues/161283
When generating mipmaps, as soon as we hit a dimension (x,y) of 1, stop
generating mipmaps. This is done by changing the mip computation to use
min instead of max - but also adds a short circuit too.
2025-03-18 15:41:11 +00:00
Victoria Ashworth
425d1bd258
Update tests to use Xcode 16.2 and iOS 18.2 Simulator ( #165318 )
...
Runs tests on Xcode 16.2 and iOS 18.2. Also updates engine scenario
golden files to iOS 18.2 and removes non-impeller (Skia) test files that
we no longer use.
All framework tests passing:
https://github.com/flutter/flutter/issues/148899#issuecomment-2701465612
All engine tests passing:
https://github.com/flutter/flutter/issues/148906#issuecomment-2702112378
Fixes https://github.com/flutter/flutter/issues/148907 and
https://github.com/flutter/flutter/issues/148957 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-18 14:13:26 +00:00
Bruno Leroux
d0ef1c1f86
[Android] Fix crash on some key repeat events ( #165307 )
...
## Description
This PR fixes a crash on Android related to specific keyboard events.
It is very similar to http://github.com/flutter/engine/issues/35924
which was related to down events. This PR fixes the similar logic
related to repeat events.
## Related Issue
Fixes [Flutter 3.29 Fatal crash with
java.lang.AssertionError](https://github.com/flutter/flutter/issues/164626 )
## Tests
Adds 1 test.
2025-03-18 06:48:21 +00:00
engine-flutter-autoroll
4b2c79a0e0
Roll Skia from 52130e5c3b34 to c777fdc55adc (1 revision) ( #165360 )
...
https://skia.googlesource.com/skia.git/+log/52130e5c3b34..c777fdc55adc
2025-03-17 jvanverth@google.com Revert "Reland "[graphite] Convert
drawPath to drawPoints for lines""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,jvanverth@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-03-18 01:46:36 +00:00
Jim Graham
c5d4edfe9c
[DisplayList] Use internal conversion for opacity->alpha ( #165349 )
...
Removing an unnecessary dependence on an external library for doing
opacity->alpha conversions in DlPaint.
2025-03-18 01:09:13 +00:00
Jackson Gardner
1d954f4e96
Revert "[skwasm] Dynamic Threading ( #164748 )" ( #165350 )
...
This reverts commit b2a4a05683b95e9c08efafb3a0f17193915897d5.
This has been causing issues when rolling to flutter/packages repo. See
https://github.com/flutter/flutter/issues/165347 .
2025-03-17 23:40:59 +00:00
