fzyzcjy
4b176a716c
Tiny remove outdated comments ( #130387 )
...
I get confused when reading this comment. It seems that this code never calls `AnimationController.fling` (but only things like `animateTo`). Therefore, I do not think discussing the duration of `AnimationController.fling` is helpful - maybe it is just an outdated comment?
2023-08-02 16:21:54 +00:00
dependabot[bot]
6cf50ef942
Bump ubuntu from f8f6584 to c9820a4 in /dev/ci/docker_linux ( #130292 )
...
Bumps ubuntu from `f8f6584` to `c9820a4`.
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-08-02 16:12:31 +00:00
Daniel Chevalier
f80ff55a76
Fix for endless recursion for getLayoutExplorerNode on a Tooltip ( #131486 )
...
Fixes https://github.com/flutter/devtools/issues/5946
While preparing DevTools for the Multi View changes, I noticed that
inspecting a Tooltip causes an stack overflow.
This PR addresses that issue by fixing the scope of the subtreeDepth variable and adding some other idiomatic fixes
2023-08-02 09:23:57 -04:00
dependabot[bot]
dc4ab0f5df
Bump google/mirror-branch-action from 1.0 to 2.0 ( #126600 )
...
Bumps [google/mirror-branch-action](https://github.com/google/mirror-branch-action ) from 1.0 to 2.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="30c52ee21f4544d8a090884625cd18d9fb13d47a4083f5d474394f8d4604https://redirect.github.com/google/mirror-branch-action/issues/3 ">#3</a>)</li>
<li><a href="5d7016e8e9https://github.com/v1 "><code>@âv1</code></a>.0 (<a href="https://redirect.github.com/google/mirror-branch-action/issues/1 ">#1</a>)</li>
<li>See full diff in <a href="c6b07e441a...30c52ee21fhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=google/mirror-branch-action&package-manager=github_actions&previous-version=1.0&new-version=2.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
> **Note**
> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
2023-08-02 07:40:14 +00:00
dependabot[bot]
e8ebbfa2a8
Bump dessant/lock-threads from 4.0.0 to 4.0.1 ( #128741 )
...
Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads ) from 4.0.0 to 4.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/releases ">dessant/lock-threads's releases</a>.</em></p>
<blockquote>
<h2>v4.0.1</h2>
<p>Learn more about this release from the <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md#changelog ">changelog</a>.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md ">dessant/lock-threads's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<p>All notable changes to this project will be documented in this file. See <a href="https://github.com/conventional-changelog/standard-version ">standard-version</a> for commit guidelines.</p>
<h3><a href="https://github.com/dessant/lock-threads/compare/v4.0.0...v4.0.1 ">4.0.1</a> (2023-06-12)</h3>
<h3>Bug Fixes</h3>
<ul>
<li>retry and throttle GitHub API requests (<a href="1618e91da6https://redirect.github.com/dessant/lock-threads/issues/35 ">#35</a></li>
</ul>
<h2><a href="https://github.com/dessant/lock-threads/compare/v3.0.0...v4.0.0 ">4.0.0</a> (2022-12-04)</h2>
<h3>â BREAKING CHANGES</h3>
<ul>
<li>the action now requires Node.js 16</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>update dependencies (<a href="38e918558132986e2696https://github.com/dessant/lock-threads/compare/v2.1.2...v3.0.0 ">3.0.0</a> (2021-09-27)</h2>
<h3>â BREAKING CHANGES</h3>
<ul>
<li>
<p>input parameter names have changed</p>
<p>Rename the following input parameters when upgrading from v2 to v3:</p>
<ul>
<li><code>issue-lock-inactive-days</code> --> <code>issue-inactive-days</code></li>
<li><code>issue-exclude-created-before</code> --> <code>exclude-issue-created-before</code></li>
<li><code>issue-exclude-labels</code> --> <code>exclude-any-issue-labels</code></li>
<li><code>issue-lock-labels</code> --> <code>add-issue-labels</code></li>
<li><code>issue-lock-comment</code> --> <code>issue-comment</code></li>
<li><code>pr-lock-inactive-days</code> --> <code>pr-inactive-days</code></li>
<li><code>pr-exclude-created-before</code> --> <code>exclude-pr-created-before</code></li>
<li><code>pr-exclude-labels</code> --> <code>exclude-any-pr-labels</code></li>
<li><code>pr-lock-labels</code> --> <code>add-pr-labels</code></li>
<li><code>pr-lock-comment</code> --> <code>pr-comment</code></li>
</ul>
</li>
</ul>
<h3>Features</h3>
<ul>
<li>add new filtering and labeling options, update input parameter names (<a href="26fd836f96a0c7da3065https://github.com/dessant/lock-threads/compare/v2.1.1...v2.1.2 ">2.1.2</a> (2021-08-17)</h3>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="be8aa5be9452f040d1951618e91da6bec0993a5620ec7bbb28b1f967d833c1b35aecc5...be8aa5be94https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=dessant/lock-threads&package-manager=github_actions&previous-version=4.0.0&new-version=4.0.1 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
> **Note**
> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
2023-08-02 07:29:08 +00:00
dependabot[bot]
9c184d475b
Bump codecov/codecov-action from 3.1.3 to 3.1.4 ( #126885 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.1.3 to 3.1.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>3.1.4</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.15.12 to 18.16.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/970 ">codecov/codecov-action#970</a></li>
<li>Fix typo in README.md by <a href="https://github.com/hisaac "><code>@âhisaac</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/967 ">codecov/codecov-action#967</a></li>
<li>fix: add back in working dir by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/971 ">codecov/codecov-action#971</a></li>
<li>fix: CLI option names for uploader by <a href="https://github.com/kleisauke "><code>@âkleisauke</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/969 ">codecov/codecov-action#969</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 18.16.3 to 20.1.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/975 ">codecov/codecov-action#975</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 20.1.0 to 20.1.2 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/979 ">codecov/codecov-action#979</a></li>
<li>build(deps-dev): bump <code>@âtypes/node</code> from 20.1.2 to 20.1.4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/981 ">codecov/codecov-action#981</a></li>
<li>release: 3.1.4 by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/983 ">codecov/codecov-action#983</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/hisaac "><code>@âhisaac</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/967 ">codecov/codecov-action#967</a></li>
<li><a href="https://github.com/kleisauke "><code>@âkleisauke</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/969 ">codecov/codecov-action#969</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v3.1.3...v3.1.4 ">https://github.com/codecov/codecov-action/compare/v3.1.3...v3.1.4 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md ">codecov/codecov-action's changelog</a>.</em></p>
<blockquote>
<h2>3.1.4</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/967 ">#967</a> Fix typo in README.md</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/971 ">#971</a> fix: add back in working dir</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/969 ">#969</a> fix: CLI option names for uploader</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/970 ">#970</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.12 to 18.16.3</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/979 ">#979</a> build(deps-dev): bump <code>@âtypes/node</code> from 20.1.0 to 20.1.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/981 ">#981</a> build(deps-dev): bump <code>@âtypes/node</code> from 20.1.2 to 20.1.4</li>
</ul>
<h2>3.1.3</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/960 ">#960</a> fix: allow for aarch64 build</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/957 ">#957</a> build(deps-dev): bump jest-junit from 15.0.0 to 16.0.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/958 ">#958</a> build(deps): bump openpgp from 5.7.0 to 5.8.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/959 ">#959</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.10 to 18.15.12</li>
</ul>
<h2>3.1.2</h2>
<h3>Fixes</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/718 ">#718</a> Update README.md</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/851 ">#851</a> Remove unsupported path_to_write_report argument</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/898 ">#898</a> codeql-analysis.yml</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/901 ">#901</a> Update README to contain correct information - inputs and negate feature</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/955 ">#955</a> fix: add in all the extra arguments for uploader</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/819 ">#819</a> build(deps): bump openpgp from 5.4.0 to 5.5.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/835 ">#835</a> build(deps): bump node-fetch from 3.2.4 to 3.2.10</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/840 ">#840</a> build(deps): bump ossf/scorecard-action from 1.1.1 to 2.0.4</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/841 ">#841</a> build(deps): bump <code>@âactions/core</code> from 1.9.1 to 1.10.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/843 ">#843</a> build(deps): bump <code>@âactions/github</code> from 5.0.3 to 5.1.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/869 ">#869</a> build(deps): bump node-fetch from 3.2.10 to 3.3.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/872 ">#872</a> build(deps-dev): bump jest-junit from 13.2.0 to 15.0.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/879 ">#879</a> build(deps): bump decode-uri-component from 0.2.0 to 0.2.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/889 ">#889</a> build(deps): bump ossf/scorecard-action from 1.1.1 to 2.1.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/895 ">#895</a> build(deps): bump json5 from 2.2.1 to 2.2.3</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/896 ">#896</a> build(deps): bump actions/upload-artifact from 3.1.0 to 3.1.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/900 ">#900</a> build(deps-dev): bump <code>@âvercel/ncc</code> from 0.34.0 to 0.36.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/905 ">#905</a> build(deps-dev): bump typescript from 4.7.4 to 4.9.5</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/911 ">#911</a> build(deps-dev): bump <code>@âtypes/node</code> from 16.11.40 to 18.13.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/922 ">#922</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.13.0 to 18.14.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/924 ">#924</a> build(deps): bump openpgp from 5.5.0 to 5.7.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/927 ">#927</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.14.0 to 18.14.2</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/933 ">#933</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.14.2 to 18.14.6</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/937 ">#937</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.14.6 to 18.15.0</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/938 ">#938</a> build(deps): bump node-fetch from 3.3.0 to 3.3.1</li>
<li><a href="https://redirect.github.com/codecov/codecov-action/issues/945 ">#945</a> build(deps-dev): bump <code>@âtypes/node</code> from 18.15.0 to 18.15.5</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="eaaf4bedf3https://redirect.github.com/codecov/codecov-action/issues/983 ">#983</a>)</li>
<li><a href="c2ab9ab2e1https://redirect.github.com/codecov/codecov-action/issues/981 ">#981</a>)</li>
<li><a href="49c20db375https://redirect.github.com/codecov/codecov-action/issues/979 ">#979</a>)</li>
<li><a href="cf8e3e4262https://redirect.github.com/codecov/codecov-action/issues/975 ">#975</a>)</li>
<li><a href="1c34415a06https://redirect.github.com/codecov/codecov-action/issues/969 ">#969</a>)</li>
<li><a href="b4dfea724fhttps://redirect.github.com/codecov/codecov-action/issues/971 ">#971</a>)</li>
<li><a href="5bf250470ehttps://redirect.github.com/codecov/codecov-action/issues/967 ">#967</a>)</li>
<li><a href="1dd0ce34behttps://redirect.github.com/codecov/codecov-action/issues/970 ">#970</a>)</li>
<li>See full diff in <a href="894ff025c7...eaaf4bedf3https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=3.1.3&new-version=3.1.4 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
> **Note**
> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
2023-08-02 06:57:35 +00:00
LiangXiang Shen
c51aa3d2de
Update ThemeData's factory method documents ( #123984 )
...
Catch up document. As Material 3 actually use a purple theme.
d8cbaf6261/packages/flutter/lib/src/material/theme_data.dart (L2777-L2856)
2023-08-02 03:42:06 +00:00
Taha Tesser
2c71881f50
Fix Scrollable TabBar for Material 3 ( #131409 )
...
fixes [Material 3 `TabBar` does not take full width when `isScrollable: true`](https://github.com/flutter/flutter/issues/117722 )
### Description
1. Fixed the divider doesn't stretch to take all the available width in the scrollable tab bar in M3
2. Added `dividerHeight` property.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
/// Flutter code sample for [TabBar].
void main() => runApp(const TabBarApp());
class TabBarApp extends StatelessWidget {
const TabBarApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
debugShowCheckedModeBanner: false,
home: TabBarExample(),
);
}
}
class TabBarExample extends StatefulWidget {
const TabBarExample({super.key});
@override
State<TabBarExample> createState() => _TabBarExampleState();
}
class _TabBarExampleState extends State<TabBarExample> {
bool rtl = false;
bool customColors = false;
bool removeDivider = false;
Color dividerColor = Colors.amber;
Color indicatorColor = Colors.red;
@override
Widget build(BuildContext context) {
return DefaultTabController(
initialIndex: 1,
length: 3,
child: Directionality(
textDirection: rtl ? TextDirection.rtl : TextDirection.ltr,
child: Scaffold(
appBar: AppBar(
title: const Text('TabBar Sample'),
actions: <Widget>[
IconButton.filledTonal(
tooltip: 'Switch direction',
icon: const Icon(Icons.swap_horiz),
onPressed: () {
setState(() {
rtl = !rtl;
});
},
),
IconButton.filledTonal(
tooltip: 'Use custom colors',
icon: const Icon(Icons.color_lens),
onPressed: () {
setState(() {
customColors = !customColors;
});
},
),
IconButton.filledTonal(
tooltip: 'Show/hide divider',
icon: const Icon(Icons.remove_rounded),
onPressed: () {
setState(() {
removeDivider = !removeDivider;
});
},
),
],
),
body: Column(
children: <Widget>[
const Spacer(),
const Text('Scrollable - TabAlignment.start'),
TabBar(
isScrollable: true,
tabAlignment: TabAlignment.start,
dividerColor: customColors ? dividerColor : null,
indicatorColor: customColors ? indicatorColor : null,
dividerHeight: removeDivider ? 0 : null,
tabs: const <Widget>[
Tab(
icon: Icon(Icons.cloud_outlined),
),
Tab(
icon: Icon(Icons.beach_access_sharp),
),
Tab(
icon: Icon(Icons.brightness_5_sharp),
),
],
),
const Text('Scrollable - TabAlignment.startOffset'),
TabBar(
isScrollable: true,
tabAlignment: TabAlignment.startOffset,
dividerColor: customColors ? dividerColor : null,
indicatorColor: customColors ? indicatorColor : null,
dividerHeight: removeDivider ? 0 : null,
tabs: const <Widget>[
Tab(
icon: Icon(Icons.cloud_outlined),
),
Tab(
icon: Icon(Icons.beach_access_sharp),
),
Tab(
icon: Icon(Icons.brightness_5_sharp),
),
],
),
const Text('Scrollable - TabAlignment.center'),
TabBar(
isScrollable: true,
tabAlignment: TabAlignment.center,
dividerColor: customColors ? dividerColor : null,
indicatorColor: customColors ? indicatorColor : null,
dividerHeight: removeDivider ? 0 : null,
tabs: const <Widget>[
Tab(
icon: Icon(Icons.cloud_outlined),
),
Tab(
icon: Icon(Icons.beach_access_sharp),
),
Tab(
icon: Icon(Icons.brightness_5_sharp),
),
],
),
const Spacer(),
const Text('Non-scrollable - TabAlignment.fill'),
TabBar(
tabAlignment: TabAlignment.fill,
dividerColor: customColors ? dividerColor : null,
indicatorColor: customColors ? indicatorColor : null,
dividerHeight: removeDivider ? 0 : null,
tabs: const <Widget>[
Tab(
icon: Icon(Icons.cloud_outlined),
),
Tab(
icon: Icon(Icons.beach_access_sharp),
),
Tab(
icon: Icon(Icons.brightness_5_sharp),
),
],
),
const Text('Non-scrollable - TabAlignment.center'),
TabBar(
tabAlignment: TabAlignment.center,
dividerColor: customColors ? dividerColor : null,
indicatorColor: customColors ? indicatorColor : null,
dividerHeight: removeDivider ? 0 : null,
tabs: const <Widget>[
Tab(
icon: Icon(Icons.cloud_outlined),
),
Tab(
icon: Icon(Icons.beach_access_sharp),
),
Tab(
icon: Icon(Icons.brightness_5_sharp),
),
],
),
const Spacer(),
const Text('Secondary - TabAlignment.fill'),
TabBar.secondary(
tabAlignment: TabAlignment.fill,
dividerColor: customColors ? dividerColor : null,
indicatorColor: customColors ? indicatorColor : null,
dividerHeight: removeDivider ? 0 : null,
tabs: const <Widget>[
Tab(
icon: Icon(Icons.cloud_outlined),
),
Tab(
icon: Icon(Icons.beach_access_sharp),
),
Tab(
icon: Icon(Icons.brightness_5_sharp),
),
],
),
const Text('Secondary - TabAlignment.center'),
TabBar.secondary(
tabAlignment: TabAlignment.center,
dividerColor: customColors ? dividerColor : null,
indicatorColor: customColors ? indicatorColor : null,
dividerHeight: removeDivider ? 0 : null,
tabs: const <Widget>[
Tab(
icon: Icon(Icons.cloud_outlined),
),
Tab(
icon: Icon(Icons.beach_access_sharp),
),
Tab(
icon: Icon(Icons.brightness_5_sharp),
),
],
),
const Spacer(),
],
),
),
),
);
}
}
```
</details>
### Before
### After
This also contains regression test for https://github.com/flutter/flutter/pull/125974#discussion_r1239089151
```dart
// This is a regression test for https://github.com/flutter/flutter/pull/125974#discussion_r1239089151 .
testWidgets('Divider can be constrained', (WidgetTester tester) async {
```
2023-08-02 00:48:06 +00:00
Ian Hickson
9c471a9499
ImageProvider.toString uses double.toStringAsFixed ( #131348 )
...
This provides consistency for web vs VM (and is more consistent with how we do doubles everywhere else in toStrings).
2023-08-02 00:38:06 +00:00
engine-flutter-autoroll
f5f36ec05d
Roll Flutter Engine from 10a1f9cb74c9 to 9dae7b708bda (4 revisions) ( #131706 )
...
10a1f9cb74...9dae7b708b30870216+gaaclarke@users.noreply.github.com Made the licenses script output all problems (flutter/engine#44223 )
2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from a7a3646c2c8a to d53f7b880651 (6 revisions) (flutter/engine#44226 )
2023-08-01 skia-flutter-autoroll@skia.org Roll Clang from ebd0b8a0472b to 07c592048780 (flutter/engine#44224 )
2023-08-01 ychris@google.com [iOS] Add darwin_extension_safe flag and use UIScene api when building for extensions (flutter/engine#43449 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-02 00:31:51 +00:00
Polina Cherkasova
35213ceabd
Upgrade Flutter libraries. ( #131700 )
2023-08-01 12:59:47 -07:00
engine-flutter-autoroll
5c424aa87f
Roll Flutter Engine from 1aadc75dd5a7 to 10a1f9cb74c9 (1 revision) ( #131696 )
...
1aadc75dd5...10a1f9cb7430870216+gaaclarke@users.noreply.github.com [Impeller] Started using a pool for HostBuffers. (flutter/engine#44081 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 19:31:50 +00:00
engine-flutter-autoroll
de004293d8
Roll Flutter Engine from e3f817ce9953 to 1aadc75dd5a7 (2 revisions) ( #131691 )
...
e3f817ce99...1aadc75dd5zanderso@users.noreply.github.com Manual clang roll to ebd0b8a0472b865b7eb6e1a32af97ae31d829033 (flutter/engine#44220 )
2023-08-01 30870216+gaaclarke@users.noreply.github.com [Impeller] Made the clear optimization handle backdrop filters. (flutter/engine#44192 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 18:38:43 +00:00
engine-flutter-autoroll
abb1e4c76c
Roll Packages from 60e9a542f94e to 3dc00c1a32f6 (5 revisions) ( #131692 )
...
60e9a542f9...3dc00c1a32engine-flutter-autoroll@skia.org Manual roll Flutter from 1d44fbd8b906 to 1d59196bafdb (18 revisions) (flutter/packages#4621 )
2023-07-31 32242716+ricardoamador@users.noreply.github.com Update the cirrus key jul-31-2023 (flutter/packages#4618 )
2023-07-31 jpnurmi@gmail.com [path_provider_platform_interface] Add getApplicationCachePath() (flutter/packages#4614 )
2023-07-31 elitree@gmail.com [google_maps_flutter_web] Initial support for custom overlays (flutter/packages#3538 )
2023-07-31 34410554+maciejbrzezinski@users.noreply.github.com [camera] Removed the microphone permission request from availableCameras on Web (flutter/packages#4263 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 18:38:42 +00:00
Dan Field
c57169835a
Avoid concurrent modification of persistent frame callbacks ( #131677 )
...
Fixes https://github.com/flutter/flutter/issues/131415
We should do an audit of all such cases though, filed https://github.com/flutter/flutter/issues/131678
2023-08-01 18:38:40 +00:00
engine-flutter-autoroll
b9c3f1f74c
Roll Flutter Engine from ae535c024146 to e3f817ce9953 (1 revision) ( #131687 )
...
ae535c0241...e3f817ce9930870216+gaaclarke@users.noreply.github.com [Impeller] moved to one staging buffer pool (flutter/engine#44172 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 17:42:41 +00:00
engine-flutter-autoroll
5d2c9d0933
Roll Flutter Engine from 703d45539059 to ae535c024146 (4 revisions) ( #131679 )
...
703d455390...ae535c0241skia-flutter-autoroll@skia.org Roll Dart SDK from 45405dd4ea87 to 197fc0d7fea2 (1 revision) (flutter/engine#44217 )
2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from 45290179e017 to a7a3646c2c8a (1 revision) (flutter/engine#44216 )
2023-08-01 skia-flutter-autoroll@skia.org Roll Skia from bddb07184f88 to 45290179e017 (1 revision) (flutter/engine#44215 )
2023-08-01 skia-flutter-autoroll@skia.org Manual roll Dart SDK from aca45d2e133c to 45405dd4ea87 (2 revisions) (flutter/engine#44204 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 16:31:10 +00:00
engine-flutter-autoroll
bd64bf5f92
Roll Flutter Engine from f1c80ce98499 to 703d45539059 (1 revision) ( #131668 )
...
f1c80ce984...703d455390skia-flutter-autoroll@skia.org Roll Skia from c74c10128334 to bddb07184f88 (1 revision) (flutter/engine#44214 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 14:43:06 +00:00
engine-flutter-autoroll
de5b9670dd
Roll Flutter Engine from 2583c07f6a69 to f1c80ce98499 (1 revision) ( #131663 )
...
2583c07f6a...f1c80ce984skia-flutter-autoroll@skia.org Roll Skia from 177897b13a89 to c74c10128334 (4 revisions) (flutter/engine#44213 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 13:18:27 +00:00
engine-flutter-autoroll
3ec088c129
Roll Flutter Engine from 25b9d1088d09 to 2583c07f6a69 (1 revision) ( #131661 )
...
25b9d1088d...2583c07f6askia-flutter-autoroll@skia.org Roll ICU from e8c3bc9ea97d to de4ce0071eb4 (3 revisions) (flutter/engine#44212 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 11:56:24 +00:00
engine-flutter-autoroll
fcd5a6c478
Roll Flutter Engine from 7651b3cba6ba to 25b9d1088d09 (4 revisions) ( #131655 )
...
7651b3cba6...25b9d1088dskia-flutter-autoroll@skia.org Roll ANGLE from 6dc0c9d62755 to b53d99d87e6a (1 revision) (flutter/engine#44211 )
2023-08-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Dd4To9QyMtoPGPIpl... to g0dgOL2IlZQJCK4El... (flutter/engine#44210 )
2023-08-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wIpcCOc0TtDYasQbl... to lwCo6le6r0X-Srvx3... (flutter/engine#44208 )
2023-08-01 skia-flutter-autoroll@skia.org Manual roll Dart SDK from a58ca112af1c to aca45d2e133c (2 revisions) (flutter/engine#44203 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from wIpcCOc0TtDY to lwCo6le6r0X-
fuchsia/sdk/core/mac-amd64 from Dd4To9QyMtoP to g0dgOL2IlZQJ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 10:06:40 +00:00
engine-flutter-autoroll
8bd985f139
Roll Flutter Engine from 1433e23c8a3d to 7651b3cba6ba (2 revisions) ( #131648 )
...
1433e23c8a...7651b3cba6skia-flutter-autoroll@skia.org Manual roll Dart SDK from 0e02245635ea to a58ca112af1c (1 revision) (flutter/engine#44197 )
2023-08-01 dworsham@google.com [fuchsia] Only use upstream vulkan headers (flutter/engine#44157 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 05:49:06 +00:00
engine-flutter-autoroll
5d028a2851
Roll Flutter Engine from 791f505c8c6e to 1433e23c8a3d (1 revision) ( #131647 )
...
791f505c8c...1433e23c8amatanlurey@users.noreply.github.com [Impeller] Implement, non user-facing, dithering for LinearGradients. (flutter/engine#44181 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 04:43:51 +00:00
engine-flutter-autoroll
c851efaa3a
Roll Flutter Engine from bb2a903c934c to 791f505c8c6e (4 revisions) ( #131645 )
...
bb2a903c93...791f505c8cskia-flutter-autoroll@skia.org Roll Skia from 2e5f08012a92 to 177897b13a89 (1 revision) (flutter/engine#44199 )
2023-08-01 skia-flutter-autoroll@skia.org Roll ANGLE from cb4b1f3641ae to 6dc0c9d62755 (2 revisions) (flutter/engine#44198 )
2023-08-01 chinmaygarde@google.com [Impeller] Document the fiddly bits about setting up Metal shader source debugging. (flutter/engine#44195 )
2023-07-31 chinmaygarde@google.com [Impeller] Add documentation on how to enable Metal Profiling HUD without Xcode. (flutter/engine#44196 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 02:40:26 +00:00
Alex Li
f2db93df01
🐛 Treat empty ARB content as empty map when decoding ( #131242 )
...
Fixes #128932 .
2023-08-01 01:27:54 +00:00
engine-flutter-autoroll
d250fa62a1
Roll Flutter Engine from fe2369565f59 to bb2a903c934c (3 revisions) ( #131639 )
...
fe2369565f...bb2a903c93skia-flutter-autoroll@skia.org Roll ANGLE from 196713767078 to cb4b1f3641ae (1 revision) (flutter/engine#44193 )
2023-07-31 a-siva@users.noreply.github.com Manual roll of Dart with fixups to zircon system.dart (flutter/engine#44185 )
2023-07-31 chinmaygarde@google.com [Impeller] Update guidance on how to run with Metal validation without Xcode. (flutter/engine#44190 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-01 01:01:05 +00:00
engine-flutter-autoroll
40a9d3f1db
Roll Flutter Engine from b83172a4e995 to fe2369565f59 (12 revisions) ( #131638 )
...
b83172a4e9...fe2369565fskia-flutter-autoroll@skia.org Roll ANGLE from faca95f7e81b to 196713767078 (7 revisions) (flutter/engine#44191 )
2023-07-31 ian@hixie.ch Mention the point of BlendMode.plus and advise on using it. (flutter/engine#44189 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from db813f4043fe to 2e5f08012a92 (1 revision) (flutter/engine#44187 )
2023-07-31 chinmaygarde@google.com [Impeller] Update guidance on how to try Impeller on macOS Desktop. (flutter/engine#44186 )
2023-07-31 chinmaygarde@google.com [Impeller] Add a descriptive blurb about newer Impeller components and fix links. (flutter/engine#44183 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 06174bc8f4d5 to db813f4043fe (1 revision) (flutter/engine#44182 )
2023-07-31 jason-simmons@users.noreply.github.com [Impeller] Create a wrapper Impeller context for each Vulkan surface and its swapchain (flutter/engine#44171 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from ea0c9c0935ae to 06174bc8f4d5 (2 revisions) (flutter/engine#44179 )
2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from 2755f73a3461 to faca95f7e81b (1 revision) (flutter/engine#44178 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 9c12eb0e158a to ea0c9c0935ae (4 revisions) (flutter/engine#44177 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 685e29df6704 to 9c12eb0e158a (2 revisions) (flutter/engine#44173 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from cb61dd4af8a5 to 685e29df6704 (2 revisions) (flutter/engine#44170 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-31 23:54:41 +00:00
Sumit Bikram Maity
1d59196baf
Appended period remove & Uri parsing fix. ( #131293 )
...
Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously.
As for example:
```
A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log.
```
Many terminals are unable to follow the link because it includes the period in the end as part of it. This PR simply removes the period in the end so that it is clickable in many systems (e.g. by `alt` -clicking on it in an embedded bash terminal, VSCode).
```
A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log
```
Fixes: #131166
2023-07-31 20:42:11 +00:00
Jay Mehta
efc9e16ea3
Fixed regex to show missing assets file error ( #131160 )
...
Added Regex to match error message from verbos build as suggested by @stuartmorgan [here](https://github.com/flutter/flutter/pull/98137#discussion_r810559589 ).
Modified Windows Build Test
Fixes #97065
2023-07-31 20:42:09 +00:00
Qun Cheng
3cf206ba2c
Update CheckboxListTile and CalendarDatePicker tests for M2/M3 ( #131363 )
2023-07-31 13:24:48 -07:00
Jackson Gardner
b928b3c1c3
Reland --omit-type-checks for benchmarks. ( #131493 )
...
Because the cost of type checks dominate our dart2wasm benchmarks, we've
decided to pass `--omit-type-checks` for now.
This was previously reverted because the skwasm benchmarks were broken
in general for a separate reason, and my getting rid of `bringup: true`
broke the tree. I ended up fixing the benchmarks and getting rid of
`bringup: true` in a separate commit, so this just adds the flag only.
2023-07-31 13:17:34 -07:00
Ricardo Amador
d5ebf53950
Update the cirrus key jul-31-2023 ( #131624 )
...
Updating the cirrus key.
*List which issues are fixed by this PR. You must list at least one issue.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-07-31 19:57:20 +00:00
Qun Cheng
71d96ddf9c
Add Expanded/Collapsed State for Semantics ( #131233 )
2023-07-31 12:09:27 -07:00
Qun Cheng
e0b6b6c451
Reland - "Update Unit Tests for M2/M3" ( #131504 )
...
Reverts flutter/flutter#131368
Original PR: https://github.com/flutter/flutter/pull/131292 . The
flutter mirror was out of date and tree was closed, so the original PR
was reverted. Now should be safe to have a reland.
2023-07-31 11:51:27 -07:00
engine-flutter-autoroll
544c040896
Roll Flutter Engine from ae6d1d60df95 to b83172a4e995 (4 revisions) ( #131614 )
...
ae6d1d60df...b83172a4e9skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from c0Pr9uG-46yC83ZVy... to Dd4To9QyMtoPGPIpl... (flutter/engine#44168 )
2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from fb37e0542c7c to 2755f73a3461 (1 revision) (flutter/engine#44167 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SqCbKBft29XeD2Qvw... to wIpcCOc0TtDYasQbl... (flutter/engine#44166 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 6ee21fa70879 to cb61dd4af8a5 (1 revision) (flutter/engine#44165 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SqCbKBft29Xe to wIpcCOc0TtDY
fuchsia/sdk/core/mac-amd64 from c0Pr9uG-46yC to Dd4To9QyMtoP
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-31 18:14:21 +00:00
gmackall
ae750e57f5
Upgrade compile and target sdk versions in tests and benchmarks ( #131428 )
...
Partially fixes/related to: https://github.com/flutter/flutter/issues/131425
2023-07-31 18:10:24 +00:00
engine-flutter-autoroll
972d36c4ef
Roll Flutter Engine from b11a832ea7d4 to ae6d1d60df95 (1 revision) ( #131611 )
...
b11a832ea7...ae6d1d60dfskia-flutter-autoroll@skia.org Roll ANGLE from 143fa68f50b7 to fb37e0542c7c (1 revision) (flutter/engine#44161 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-31 17:03:04 +00:00
engine-flutter-autoroll
0881d07e13
Roll Packages from 10aab445d985 to 60e9a542f94e (6 revisions) ( #131607 )
...
10aab445d9...60e9a542f9engine-flutter-autoroll@skia.org Manual roll Flutter from c2b40ca7013b to 1d44fbd8b906 (7 revisions) (flutter/packages#4592 )
2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter from e81907e07a38 to c2b40ca7013b (24 revisions) (flutter/packages#4588 )
2023-07-28 stuartmorgan@google.com [ci] Switch FTL to LUCI (flutter/packages#4583 )
2023-07-28 jhy03261997@gmail.com [go_router_builder] support v10.0.0 go_router (flutter/packages#4578 )
2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter from dd9764ec3447 to e81907e07a38 (21 revisions) (flutter/packages#4582 )
2023-07-28 stuartmorgan@google.com [ci] Add LUCI version of Android FTL tests in bringup mode (flutter/packages#4571 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-31 15:54:51 +00:00
Pierre-Louis
28ee558178
Fix dartdoc for ButtonSegment constructor ( #131400 )
...
https://github.com/flutter/flutter/issues/103529
2023-07-31 12:26:11 +00:00
Danny Tuppeny
0386f910d1
[flutter_tools/dap] Improve rendering of structured errors via DAP ( #131251 )
...
In the legacy VS Code DAP, we would deserialise the Flutter.Error event
and provide some basic colouring (eg. stack frames are faded if not from
user code and the text is split between stdout/stderr to allow the
client to colour it).
In the new DAPs we originally used `renderedErrorText` which didn't
support either of these. This change adds changes to use the structured
data (with some basic parsing because the source classes are in
package:flutter and not accessible here) to provide a similar
experience.
It would be nicer if we could use the real underlying Flutter classes
for this deserialisation, but extracting them from `package:flutter` and
removing all dependencies on Flutter is a much larger job and I don't
think should hold up providing improved error formatting for the new
DAPs.
Some comparisons:
2023-07-31 13:03:26 +01:00
Daco Harkes
fceaa005cd
[doc] Fix module_test_ios comments ( #131470 )
2023-07-31 11:05:11 +00:00
Donghyun Kim
c05c3d3930
Use Flutter app project's NDK version from FFI plugin ( #131141 )
...
<img width="1119" alt="image" src="https://github.com/flutter/flutter/assets/66480156/e2e8eed1-3bef-436c-b21f-3891bdbe05bb ">
In most cases, a FFI plugin doesn't need its own specific Android NDK version. Just following the Flutter app project's NDK version is enough.
If a Flutter app project depends on multiple FFI plugins that use different Android NDK versions, it can be quite wasteful and use excessive disk space due to multiple NDK installations.
Using Flutter app project's NDK version is also less error-prone because upgrading the Flutter SDK would be enough when upgrading FFI plugins(If project's `ndkVersion` is `flutter.ndkVersion`), without messing with Android NDK installations.
This problem was discussed in some actual FFI plugin repositories, and they are striving to find their own solutions:
- https://github.com/superlistapp/super_native_extensions/issues/143#issuecomment-1646207706
- https://github.com/cunarist/rust-in-flutter/discussions/60#discussioncomment-6484218
- https://github.com/rive-app/rive-flutter/issues/320
- https://github.com/juicycleff/flutter-unity-view-widget/issues/832
2023-07-31 10:09:24 +00:00
engine-flutter-autoroll
f43755d321
Roll Flutter Engine from 22f9aad5aba5 to b11a832ea7d4 (2 revisions) ( #131597 )
...
22f9aad5ab...b11a832ea7skia-flutter-autoroll@skia.org Roll Skia from 91b838fe533d to 6ee21fa70879 (1 revision) (flutter/engine#44160 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 1146dd2212ba to 91b838fe533d (1 revision) (flutter/engine#44159 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-31 08:41:25 +00:00
engine-flutter-autoroll
af5d9c198b
Roll Flutter Engine from b84c93601684 to 22f9aad5aba5 (3 revisions) ( #131592 )
...
b84c936016...22f9aad5abskia-flutter-autoroll@skia.org Roll Skia from 3febb7d97cb0 to 1146dd2212ba (1 revision) (flutter/engine#44158 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 0e62d11175aa to 3febb7d97cb0 (1 revision) (flutter/engine#44156 )
2023-07-31 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 5tPeR3pmLZVAbR1iy... to SqCbKBft29XeD2Qvw... (flutter/engine#44155 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 5tPeR3pmLZVA to SqCbKBft29Xe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-31 07:05:27 +00:00
engine-flutter-autoroll
46f83ce636
Roll Flutter Engine from d95adb9c8bc6 to b84c93601684 (1 revision) ( #131585 )
...
d95adb9c8b...b84c936016skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 17au0GOALWDVfQnwu... to c0Pr9uG-46yC83ZVy... (flutter/engine#44154 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 17au0GOALWDV to c0Pr9uG-46yC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-31 02:31:35 +00:00
engine-flutter-autoroll
1d44fbd8b9
Roll Flutter Engine from 0ccff9a2bad3 to d95adb9c8bc6 (1 revision) ( #131578 )
...
0ccff9a2ba...d95adb9c8bskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 38hspwoyzrqU6GbsM... to 5tPeR3pmLZVAbR1iy... (flutter/engine#44152 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 38hspwoyzrqU to 5tPeR3pmLZVA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-30 18:43:24 +00:00
engine-flutter-autoroll
063d68b173
Roll Flutter Engine from f3d1e004f7b1 to 0ccff9a2bad3 (1 revision) ( #131571 )
...
f3d1e004f7...0ccff9a2baskia-flutter-autoroll@skia.org Roll Skia from 01451297ae1b to 0e62d11175aa (1 revision) (flutter/engine#44151 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-30 13:55:20 +00:00
engine-flutter-autoroll
7d258cb4f5
Roll Flutter Engine from 9d4bf38f987f to f3d1e004f7b1 (1 revision) ( #131569 )
...
9d4bf38f98...f3d1e004f7skia-flutter-autoroll@skia.org Roll Skia from c33c0619b892 to 01451297ae1b (1 revision) (flutter/engine#44150 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-30 11:55:10 +00:00
engine-flutter-autoroll
9758d773c4
Roll Flutter Engine from 12ce9f013cef to 9d4bf38f987f (1 revision) ( #131564 )
...
12ce9f013c...9d4bf38f98skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VIjw2bdybUo-rgC0t... to 17au0GOALWDVfQnwu... (flutter/engine#44148 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from VIjw2bdybUo- to 17au0GOALWDV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-30 07:10:14 +00:00
engine-flutter-autoroll
4d245a8460
Roll Flutter Engine from 590ff28649eb to 12ce9f013cef (2 revisions) ( #131562 )
...
590ff28649...12ce9f013cskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -5L2wI7BjRNgnccfl... to 38hspwoyzrqU6GbsM... (flutter/engine#44145 )
2023-07-30 skia-flutter-autoroll@skia.org Roll ANGLE from 0abd6f549ff1 to 143fa68f50b7 (1 revision) (flutter/engine#44144 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from -5L2wI7BjRNg to 38hspwoyzrqU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-30 03:05:36 +00:00
