firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,673 Commits 1 Branch 0 Tags
Commit Graph

27967 Commits

Author SHA1 Message Date
skia-flutter-autoroll
aa5c147fc6 Roll Skia from b9b208f11c67 to 4e31906b6312 (1 revision) (flutter/engine#54226) 
https://skia.googlesource.com/skia.git/+log/b9b208f11c67..4e31906b6312

2024-07-30 johnstiles@google.com Add design doc links for go/sksl-rp.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 20:11:12 +00:00
Jonah Williams
9650917c7e [engine] Split encode and submit into two different surface frame callbacks. (flutter/engine#54200) 
This makes it much easier to implement the deferred submit required for https://github.com/flutter/engine/pull/53826
 2024-07-30 19:58:21 +00:00
Matej Knopp
e078967646 Do not disable partial repaint based on thread merging state (flutter/engine#54219) 
Currently we force full repaint when thread merging is detected, but
that is not a good way to determine whether platform view is in
hierarchy when thread merging is no longer needed. Alternative solution
here makes the PlatformViewLayer force full repaint when diffing.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-07-30 21:36:02 +02:00
skia-flutter-autoroll
1fe35315e0 Roll Dart SDK from 14b51d32e3a6 to e16dc217b1ac (1 revision) (flutter/engine#54221) 
https://dart.googlesource.com/sdk.git/+log/14b51d32e3a6..e16dc217b1ac

2024-07-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-95.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 19:04:24 +00:00
skia-flutter-autoroll
e66f26eb62 Roll Fuchsia Linux SDK from QsN_RyaTWxm-8AD47... to cYjTzxe0MskG7PtkB... (flutter/engine#54223) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 18:48:15 +00:00
skia-flutter-autoroll
495974ec1f Roll Skia from c1fcf8e5a55c to b9b208f11c67 (2 revisions) (flutter/engine#54222) 
https://skia.googlesource.com/skia.git/+log/c1fcf8e5a55c..b9b208f11c67

2024-07-30 nathanasanchez@google.com [SkSL][SPIR-V] Unsized array parameter support
2024-07-30 kjlubick@google.com [graphite] Remove SK_DAWN defines from TextureInfo and BackendTexture.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 18:25:29 +00:00
skia-flutter-autoroll
db8f154594 Roll Skia from a4d59988bde0 to c1fcf8e5a55c (1 revision) (flutter/engine#54220) 
https://skia.googlesource.com/skia.git/+log/a4d59988bde0..c1fcf8e5a55c

2024-07-30 kjlubick@google.com Change vello's #ifdef guards

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 17:07:09 +00:00
gaaclarke
179daffb5a Reland: [Impeller] Use downsample shader for blur instead of mip levels. (flutter/engine#54149) 
relands https://github.com/flutter/engine/pull/53760
reverted in https://github.com/flutter/engine/pull/54148

The fix for this was found with the help of Jonah.

Part of a series of gaussian blur changes:
1) https://github.com/flutter/engine/pull/54148
1) https://github.com/flutter/engine/pull/54116
1) https://github.com/flutter/engine/pull/54150
1) https://github.com/flutter/engine/pull/54149

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-30 16:44:08 +00:00
skia-flutter-autoroll
62eab65524 Roll Skia from 2cb7f5443a48 to a4d59988bde0 (1 revision) (flutter/engine#54218) 
https://skia.googlesource.com/skia.git/+log/2cb7f5443a48..a4d59988bde0

2024-07-30 johnstiles@google.com Revert "Move most KnownRuntimeEffects into the sksl_rt_shader module."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 15:47:21 +00:00
gaaclarke
c0908f857e [Impeller] makes the gaussian down sample scalar fixed by adjusting the downsample padding (flutter/engine#54150) 
This removes jitter in the gaussian blur.

Previous version of the shimmer test show this drops the average RMSE 30%.

testing:
  - positive change shown in average RMSE in ShimmerTest
  - existing golden tests

Part of a series of gaussian blur changes:
1) https://github.com/flutter/engine/pull/54148
1) https://github.com/flutter/engine/pull/54116
1) https://github.com/flutter/engine/pull/54150
1) https://github.com/flutter/engine/pull/54149

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-30 15:35:18 +00:00
skia-flutter-autoroll
412cf31283 Roll Dart SDK from ad4d2e8b2c65 to 14b51d32e3a6 (1 revision) (flutter/engine#54216) 
https://dart.googlesource.com/sdk.git/+log/ad4d2e8b2c65..14b51d32e3a6

2024-07-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-94.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 14:00:25 +00:00
skia-flutter-autoroll
6709f14400 Roll Skia from 1339015537a3 to 2cb7f5443a48 (4 revisions) (flutter/engine#54212) 
https://skia.googlesource.com/skia.git/+log/1339015537a3..2cb7f5443a48

2024-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 572025841d09 to 0ef066874643 (9 revisions)
2024-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f3c1dcf83f79 to 0ce5411a16fa (6 revisions)
2024-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8ebaca0a412e to 0d7d76032f90 (7 revisions)
2024-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c4dfa69de7de to 01b188e56477 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 09:49:40 +00:00
skia-flutter-autoroll
c3a3ece966 Roll Dart SDK from 6ab9452297e0 to ad4d2e8b2c65 (1 revision) (flutter/engine#54211) 
https://dart.googlesource.com/sdk.git/+log/6ab9452297e0..ad4d2e8b2c65

2024-07-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-93.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 09:23:22 +00:00
dependabot[bot]
df41d3dac1 Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (flutter/engine#54208) 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.3 to 2.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p>
<blockquote>
<h2>v2.4.0</h2>
<h2>What's Changed</h2>
<p>This update bumps the Scorecard version to the v5 release. For a complete list of changes, please refer to the <a href="https://github.com/ossf/scorecard/releases/tag/v5.0.0">v5.0.0 release notes</a>. Of special note to Scorecard Action is the Maintainer Annotation feature, which can be used to suppress some Code Scanning false positives. Alerts will not be generated for any Scorecard Check with an annotation.</p>
<ul>
<li>🌱 Bump github.com/ossf/scorecard/v5 from v5.0.0-rc2 to v5.0.0 by <a href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1410">ossf/scorecard-action#1410</a></li>
<li>🐛 lower license sarif alert threshold to 9 by <a href="https://github.com/spencerschrock"><code>@​spencerschrock</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1411">ossf/scorecard-action#1411</a></li>
</ul>
<h3>Documentation</h3>
<ul>
<li>docs: dogfooding badge by <a href="https://github.com/jkowalleck"><code>@​jkowalleck</code></a> in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1399">ossf/scorecard-action#1399</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/jkowalleck"><code>@​jkowalleck</code></a> made their first contribution in <a href="https://redirect.github.com/ossf/scorecard-action/pull/1399">ossf/scorecard-action#1399</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/ossf/scorecard-action/compare/v2.3.3...v2.4.0">https://github.com/ossf/scorecard-action/compare/v2.3.3...v2.4.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="62b2cac7ed"><code>62b2cac</code></a> bump docker tag to v2.4.0 for release (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1414">#1414</a>)</li>
<li><a href="c09630c42e"><code>c09630c</code></a> lower license score alert threshold to 9 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1411">#1411</a>)</li>
<li><a href="cf8594c548"><code>cf8594c</code></a> 🌱 Bump github.com/sigstore/cosign/v2 from 2.2.4 to 2.3.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1413">#1413</a>)</li>
<li><a href="de5fcb95b9"><code>de5fcb9</code></a> 🌱 Bump the github-actions group with 2 updates (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1412">#1412</a>)</li>
<li><a href="a46b90b4ca"><code>a46b90b</code></a> bump scorecard to v5.0.0 release (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1410">#1410</a>)</li>
<li><a href="9fc518d524"><code>9fc518d</code></a> 🌱 Bump golang in the docker-images group (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1407">#1407</a>)</li>
<li><a href="a8eaa1b46e"><code>a8eaa1b</code></a> 🌱 Bump the github-actions group with 2 updates (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1408">#1408</a>)</li>
<li><a href="873d5fdf63"><code>873d5fd</code></a> 🌱 Bump the github-actions group across 1 directory with 2 updates (#...</li>
<li><a href="54cc1fe4e2"><code>54cc1fe</code></a> 🌱 Bump the docker-images group with 2 updates (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1401">#1401</a>)</li>
<li><a href="82bcb91c5d"><code>82bcb91</code></a> 🌱 Bump golang.org/x/net from 0.26.0 to 0.27.0 (<a href="https://redirect.github.com/ossf/scorecard-action/issues/1400">#1400</a>)</li>
<li>Additional commits viewable in <a href="dc50aa9510...62b2cac7ed">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.3.3&new-version=2.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-07-30 07:18:53 +00:00
skia-flutter-autoroll
108e25859e Roll Dart SDK from e8eca6f05494 to 6ab9452297e0 (1 revision) (flutter/engine#54206) 
https://dart.googlesource.com/sdk.git/+log/e8eca6f05494..6ab9452297e0

2024-07-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-92.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 05:15:24 +00:00
skia-flutter-autoroll
176e29d37c Roll Skia from 56de22c39d0e to 20e4dfabb6b2 (1 revision) (flutter/engine#54205) 
https://skia.googlesource.com/skia.git/+log/56de22c39d0e..20e4dfabb6b2

2024-07-30 bsheedy@chromium.org Revert "[graphite] Read aggregate SSBO once in main()"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 05:01:03 +00:00
skia-flutter-autoroll
6fc47afad1 Roll Skia from 946ca24d03ab to 56de22c39d0e (1 revision) (flutter/engine#54204) 
https://skia.googlesource.com/skia.git/+log/946ca24d03ab..56de22c39d0e

2024-07-30 johnstiles@google.com Revert "Add defensive check for unreachable specialized functions."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 03:39:22 +00:00
skia-flutter-autoroll
779d47408c Roll Skia from 8167ff71af2c to 946ca24d03ab (2 revisions) (flutter/engine#54202) 
https://skia.googlesource.com/skia.git/+log/8167ff71af2c..946ca24d03ab

2024-07-30 johnstiles@google.com Add defensive check for unreachable specialized functions.
2024-07-29 johnstiles@google.com Move most KnownRuntimeEffects into the sksl_rt_shader module.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 01:23:23 +00:00
skia-flutter-autoroll
42f3a30641 Roll Skia from 832023dc041a to 8167ff71af2c (1 revision) (flutter/engine#54199) 
https://skia.googlesource.com/skia.git/+log/832023dc041a..8167ff71af2c

2024-07-29 lehoangquyen@google.com GraphiteDawn: print correct error message in map callbacks for native.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-30 00:10:08 +00:00
Jonah Williams
f2c5ad0b1e [Impeller] delete rasterizer class. (flutter/engine#54196) 
The rasterizer class doesn't actually do anything besides call impeller::Surface to get the render target. lets just remove it. Simplifies refactores needed to make https://github.com/flutter/engine/pull/53826 work well.
 2024-07-29 22:59:11 +00:00
skia-flutter-autoroll
3f20f61fe7 Roll Skia from 62e955dbaef0 to 832023dc041a (1 revision) (flutter/engine#54198) 
https://skia.googlesource.com/skia.git/+log/62e955dbaef0..832023dc041a

2024-07-29 jlavrova@google.com Adding font instances support to Fontations

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-29 22:46:57 +00:00
Rafal Wachol
277967b295 [wiki] Fix link to engine dev setup (flutter/engine#54173) 
Link to engine setup was broken so here's the fix
 2024-07-29 22:39:16 +00:00
skia-flutter-autoroll
9317e20df4 Roll Dart SDK from 9a6e058303af to e8eca6f05494 (2 revisions) (flutter/engine#54197) 
https://dart.googlesource.com/sdk.git/+log/9a6e058303af..e8eca6f05494

2024-07-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-91.0.dev
2024-07-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-90.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-29 22:08:10 +00:00
skia-flutter-autoroll
4c0e60afc9 Roll Skia from efd1d5b127ae to 62e955dbaef0 (5 revisions) (flutter/engine#54194) 
https://skia.googlesource.com/skia.git/+log/efd1d5b127ae..62e955dbaef0

2024-07-29 johnstiles@google.com Allow child effect passing in PipelineStageCodeGenerator.
2024-07-29 gavinmak@google.com Specify recipes.cfg in infra_tests.py
2024-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 5084439cd9c3 to cb3395657dd9
2024-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from b7ecdc86a7b4 to 5262a9f62fa6
2024-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from ca44dd6ab7bf to 699f74900f78

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-29 21:24:54 +00:00
Jonah Williams
d6245bcd3a [iOS] leak a single overlay layer. (flutter/engine#54189) 
Leave at least one overlay layer, to work around cases where scrolling platform views under an app bar continually adds and removes an overlay layer. This logic could be removed if https://github.com/flutter/flutter/issues/150646 is fixed.

Fixes https://github.com/flutter/flutter/issues/152266
 2024-07-29 21:21:05 +00:00
Jonah Williams
9808dcbb8f [engine] remove raster stats feature. (flutter/engine#54187) 
This debugging tool does not give accurate measurements and we've decided to remove it.

See also: https://github.com/flutter/flutter/issues/131941
 2024-07-29 20:30:52 +00:00
Chris Bracken
853222c175 Revert "Set GLArea.has-alpha = true (#54053)" (flutter/engine#54190) 
Reason for revert: Regression + no tests. Must have been at the end of a long day, cause I missed the missing test and glaring warning about that.

This reverts commit 0325e590babb33963dc35283cd425b39290919e5.

Re-opens https://github.com/flutter/flutter/issues/152154

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-29 20:09:04 +00:00
skia-flutter-autoroll
4dd082a975 Roll Skia from c1de8c48c998 to efd1d5b127ae (2 revisions) (flutter/engine#54188) 
https://skia.googlesource.com/skia.git/+log/c1de8c48c998..efd1d5b127ae

2024-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from a6d9a7de5704 to eba2fc680652
2024-07-29 bungeman@google.com [dm] Fix misleading macro indentation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-29 20:03:08 +00:00
skia-flutter-autoroll
9841b532fc Roll Skia from 96b7575339b6 to c1de8c48c998 (3 revisions) (flutter/engine#54185) 
https://skia.googlesource.com/skia.git/+log/96b7575339b6..c1de8c48c998

2024-07-29 gavinmak@google.com Remove all git usage from PRESUBMIT.py
2024-07-29 michaelludwig@google.com [graphite] Add forcePathAA to subrun control
2024-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d96d6c161ed6 to f3c1dcf83f79 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-29 18:42:08 +00:00
skia-flutter-autoroll
fca7e30903 Roll Skia from 4a65e626ebbe to 96b7575339b6 (3 revisions) (flutter/engine#54183) 
https://skia.googlesource.com/skia.git/+log/4a65e626ebbe..96b7575339b6

2024-07-29 johnstiles@google.com Add documentation link for go/modules-in-sksl.
2024-07-29 kjlubick@google.com Remove unnecessary using statement
2024-07-29 michaelludwig@google.com Revert "Allow client arrays on ANGLE."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-29 17:22:31 +00:00
skia-flutter-autoroll
71cf396876 Roll Fuchsia Linux SDK from YAzbrQ4d60z1yXx9X... to QsN_RyaTWxm-8AD47... (flutter/engine#54182) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-29 17:21:17 +00:00
Alexander Aprelev
69692c0807 Remove obsolete dependency from few more targets. (flutter/engine#54181) 
Follow-up to 9cfb0f4947a23937fe5d88b105645e2c1942ba85 - remove obsolete
dependency from few more places that were missed.
 2024-07-29 09:37:43 -07:00
Jason Simmons
8165d2a54a [web] Fix scaledImageSize handling of a target width with no target height (flutter/engine#54122) 2024-07-29 16:27:37 +00:00
skia-flutter-autoroll
eae06f9678 Roll Skia from 940c71c61d11 to 4a65e626ebbe (4 revisions) (flutter/engine#54180) 
https://skia.googlesource.com/skia.git/+log/940c71c61d11..4a65e626ebbe

2024-07-29 kjlubick@google.com [graphite] Remove SK_VULKAN defines from TextureInfo, BackendTexture, and BackendSemaphore
2024-07-29 borenet@google.com [recreate-skps] Use a release build of Chromium, pass --disable-field-trial-config
2024-07-29 johnstiles@google.com Eliminate dead functions after inlining runtime effects.
2024-07-29 kjlubick@google.com Clean up skparagraph Bazel rules

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-29 15:54:54 +00:00
skia-flutter-autoroll
8dde4d39a3 Roll Dart SDK from ad35a6027648 to 9a6e058303af (1 revision) (flutter/engine#54178) 
https://dart.googlesource.com/sdk.git/+log/ad35a6027648..9a6e058303af

2024-07-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-89.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-29 14:04:21 +00:00
skia-flutter-autoroll
7422e118d5 Roll Skia from 11e9bb9dbd1b to e8348df56e4e (2 revisions) (flutter/engine#54174) 
https://skia.googlesource.com/skia.git/+log/11e9bb9dbd1b..e8348df56e4e

2024-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 821c531f7514 to 8ebaca0a412e (11 revisions)
2024-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c10e91977ac3 to 8409c8834075 (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,johnstiles@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-29 06:23:38 +00:00
Chinmay Garde
2160284af8 [Impeller] Enable on-by-default on Android. (flutter/engine#54156) 
Developers can control the backend in the following ways:

* **Do nothing**: Impeller with Vulkan is used where Vulkan is available with a fallback to Skia with OpenGL.
* **In `AndroidManifest.xml`, specify `io.flutter.embedding.android.EnableImpeller` as `false`**: Skia with OpenGL is used.
* **On the command line, specify `--no-enable-impeller`**: Skia with OpenGL is used.

Manifest options will take priority command line options when there is a conflict. This matches iOS behavior per https://github.com/flutter/flutter/issues/124049 (closed as WAI).

Fixes https://github.com/flutter/flutter/issues/149360
 2024-07-29 03:35:27 +00:00
Jason Simmons
0465c1d35a Fix a race in file I/O done by a BuildRunner test (flutter/engine#54167) 
This test failure had been seen in some recent auto-roller jobs on CI.
 2024-07-28 00:57:26 +00:00
Matan Lurey
498a31a6da Migrates the bulk of flutter/engine to pub workspaces. (flutter/engine#54157) 
Part of https://github.com/flutter/flutter/issues/147883.

Excluding Fuchsia and the Web SDK, the remaining scripts are:

```sh
$ ./tools/find_pubspecs_to_workspacify.sh

/Users/matanl/Developer/engine/src/flutter/impeller/tessellator/dart/pubspec.yaml
/Users/matanl/Developer/engine/src/flutter/sky/packages/sky_engine/pubspec.yaml
/Users/matanl/Developer/engine/src/flutter/shell/vmservice/pubspec.yaml
/Users/matanl/Developer/engine/src/flutter/lib/snapshot/pubspec.yaml
/Users/matanl/Developer/engine/src/flutter/lib/gpu/pubspec.yaml
/Users/matanl/Developer/engine/src/flutter/lib/web_ui/pubspec.yaml
/Users/matanl/Developer/engine/src/flutter/flutter_frontend_server/pubspec.yaml
```

These could be the trickiest, so I'm doing them separately.
 2024-07-27 09:58:40 -07:00
skia-flutter-autoroll
0a6c459b5d Roll Fuchsia Linux SDK from iuUKz0zFWsn54yP69... to UJOkCKt967UoXQxZS... (flutter/engine#54163) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-27 14:47:34 +00:00
Alexander Aprelev
9cfb0f4947 Remove obsolete dependency (flutter/engine#54161) 
The concurrent_api/concurrent_api_product targets were made obsolete by
95f5efc697
 2024-07-27 07:18:17 -07:00
skia-flutter-autoroll
242c5d27d7 Roll Dart SDK from 65bb9e8275bc to ad35a6027648 (1 revision) (flutter/engine#54159) 
https://dart.googlesource.com/sdk.git/+log/65bb9e8275bc..ad35a6027648

2024-07-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-88.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-27 02:31:39 +00:00
Zachary Anderson
b8ff0f4901 Split up mac_host_engine builds (flutter/engine#53571) 
This PR does a few things. Mainly it makes the builds in
mac_host_engine.json each build fewer targets to increase parallelism
for post-submit and release builds. To ensure that increasing
parallelism doesn't lead to capacity issues, this change also allows the
mac_host_engine.json builds to run on either intel or arm64 macOS hosts.
Finally, when building on an arm64 macOS host to target macOS, this PR
changes the `gn` script to ensure that the arm64 native clang toolchain
will be used.

To keep mac_host_engine.json focused on builds that produce artifacts,
this PR also moves tests from that file into the ill-named
mac_unopt.json. In a subsequent PR, I'll rename all the *_unopt.json
files to *_tests.json or something similar.

The artifacts produced by these builds are passing framework presubmit
checks in https://github.com/flutter/flutter/pull/152345.
 2024-07-26 15:39:46 -07:00
Chinmay Garde
f379c9ac3d [Impeller] Fix the operator used to build the condition to check for OpenGLES. (flutter/engine#54155) 2024-07-26 22:25:49 +00:00
skia-flutter-autoroll
cf8037de40 Roll Skia from 4a97d01dfedd to 9632ef8f18c1 (7 revisions) (flutter/engine#54154) 
https://skia.googlesource.com/skia.git/+log/4a97d01dfedd..9632ef8f18c1

2024-07-26 johnstiles@google.com Rework stable function calls.
2024-07-26 johnstiles@google.com Rename PipelineUtils to SkSLToBackend.
2024-07-26 johnstiles@google.com Add Analysis::GetParameterMappingsForFunction helper.
2024-07-26 jvanverth@google.com [ganesh] Check for null ThreadSafeProxy in GrImageContext::abandoned()
2024-07-26 johnstiles@google.com Fix bug with specialization of functions that are inlined.
2024-07-26 michaelludwig@google.com [graphite] Add AtlasProvider::freeGpuResources() take 2
2024-07-26 michaelludwig@google.com Reland "[skif] Use src blending when possible"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-26 22:16:17 +00:00
skia-flutter-autoroll
1bf3676912 Roll Dart SDK from de1925e18998 to 65bb9e8275bc (1 revision) (flutter/engine#54153) 
https://dart.googlesource.com/sdk.git/+log/de1925e18998..65bb9e8275bc

2024-07-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-87.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-26 22:07:08 +00:00
gaaclarke
1fde09711e [impeller] adds test for catching shimmer in gaussian blur (flutter/engine#54116) 
fixes https://github.com/flutter/flutter/issues/152195

Part of a series of gaussian blur changes:
1) https://github.com/flutter/engine/pull/54148
1) https://github.com/flutter/engine/pull/54116
1) https://github.com/flutter/engine/pull/54150
1) https://github.com/flutter/engine/pull/54149

Note: this test won't pass until
https://github.com/flutter/engine/pull/54148 lands.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-07-26 15:02:06 -07:00
gaaclarke
95df38e38b Revert "[Impeller] Use downsample shader for blur instead of mip levels. (#53760)" (flutter/engine#54148) 
This is reverted since it introduces shimmering when the downsample
scalar goes to 1/16th. It was reverted instead of fixed to allow the
test that should have blocked this to land in the meantime.

reverts https://github.com/flutter/engine/pull/53760
fixed and relanded in https://github.com/flutter/engine/pull/54149

Part of a series of gaussian blur changes:
1) https://github.com/flutter/engine/pull/54148
1) https://github.com/flutter/engine/pull/54116
1) https://github.com/flutter/engine/pull/54150
1) https://github.com/flutter/engine/pull/54149

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-07-26 14:16:51 -07:00
skia-flutter-autoroll
7793d39228 Roll Skia from 61ac357e8e33 to 4a97d01dfedd (2 revisions) (flutter/engine#54146) 
https://skia.googlesource.com/skia.git/+log/61ac357e8e33..4a97d01dfedd

2024-07-26 nathanasanchez@google.com [Graphite] Remove gradient buffer support flag
2024-07-26 nathanasanchez@google.com [Graphite] Reorder local matrix matrix inversion

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jamesgk@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-26 19:10:14 +00:00
skia-flutter-autoroll
ed26c0190d Roll Dart SDK from 1b29ac31628f to de1925e18998 (1 revision) (flutter/engine#54145) 
https://dart.googlesource.com/sdk.git/+log/1b29ac31628f..de1925e18998

2024-07-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-86.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-26 17:52:50 +00:00