1307 Commits

Author SHA1 Message Date
Adam Barth
e2744e9a30 Stop using a prebuilt APK
Instead, require an AndroidManifest.xml and always build an APK.

Fixes #2517
2016-03-14 13:32:00 -07:00
Hixie
74b117fe8b Update .analysis_options to link to blocking bugs
Also, some minor cleanup in activity.dart, though much more is
needed (see https://github.com/flutter/flutter/issues/2668).
2016-03-14 12:28:06 -07:00
Devon Carew
d44a70bc85 add more type annotations 2016-03-14 12:06:19 -07:00
Hixie
4e6b287881 Remove some more 'dynamic's 2016-03-14 11:11:41 -07:00
Ian Hickson
bedd8e9131 Merge pull request #2650 from Hixie/always_always_specify_types
Even more types
2016-03-14 10:44:05 -07:00
Devon Carew
5fb315141b Merge pull request #2658 from devoncarew/drive_command
change the description of the drive command
2016-03-14 10:27:01 -07:00
Devon Carew
d0afabc358 change the description of the drive command 2016-03-14 09:48:02 -07:00
Ian Hickson
d745e20853 Even more types 2016-03-14 09:41:54 -07:00
Devon Carew
4daee0cc0d misc tool ui cleanup 2016-03-14 09:41:00 -07:00
Adam Barth
ede5dfce30 [rename fixit] ToolBar -> AppBar
* left -> leading (Removes an LTR bias)
* center -> title (Widget was actually centered)
* right -> actions (Removes an LTR bias, asymmetric with leading)

Fixes #2348
2016-03-12 18:33:47 -08:00
Adam Barth
9b9ad3db17 [rename fixit] RouteBuilder -> BuildContext
Fixes #2353
2016-03-12 17:18:31 -08:00
Devon Carew
f13314867c Merge pull request #2645 from devoncarew/platform_constants
rename the platform constants
2016-03-12 12:46:55 -08:00
Adam Barth
bb0d11be38 Merge pull request #2646 from abarth/rename_fixit
Execute rename fixit
2016-03-12 12:41:14 -08:00
Adam Barth
95fc5ae070 [rename fixit] *Component* -> *Widget*
This patch renames StatelessComponent to StatelessWidget and
StatefulComponent to StatefulWidget.

Fixes #2308
2016-03-12 12:34:05 -08:00
Devon Carew
3ce1685d6d update comments for android abi 2016-03-12 11:47:50 -08:00
Devon Carew
79d6bf6d08 Merge pull request #2644 from devoncarew/project_creation
add an atom launch config to the starter app
2016-03-12 11:12:07 -08:00
Devon Carew
e939b152af rename the platform constants 2016-03-12 11:08:21 -08:00
Devon Carew
5b383a0353 Merge pull request #2643 from devoncarew/fix_adb_forward
fix a regression in adb forward
2016-03-12 11:00:08 -08:00
Devon Carew
ce9111b591 fix a regression in adb forward 2016-03-12 10:41:34 -08:00
Devon Carew
e67b67680b Merge pull request #2631 from devoncarew/fix_app_delete
fix a launch issue when the user has deleted the app
2016-03-12 10:34:56 -08:00
Devon Carew
6d19fd1fce add an atom launch config to the starter app 2016-03-12 07:09:07 -08:00
Hixie
6795efacab Enable always_specify_types lint
And fix the zillion issues that uncovered.
2016-03-12 00:37:31 -08:00
Ian Hickson
43b0104114 Revert "Merge pull request #2639 from Hixie/always_specify_types"
This reverts commit f41b3411da35929b09009e47cb52474389e42874, reversing
changes made to e33d8d96212f3e337a6660f1eb1118bffc945bf5.

This was a bad check-in due to my mangling uploading a new version of the branch from a different machine.

This reverts https://github.com/flutter/flutter/pull/2639 and will be replaced by https://github.com/flutter/flutter/pull/2640
2016-03-12 00:34:37 -08:00
Ian Hickson
f41b3411da Merge pull request #2639 from Hixie/always_specify_types
Almost enable always_specify_types lint
2016-03-12 00:20:51 -08:00
Hixie
d162d98c79 Enable always_specify_types lint
And fix the zillion issues that uncovered.
2016-03-11 18:27:32 -08:00
Hixie
bb3874dc7f Enable strong mode again. 2016-03-11 16:34:47 -08:00
Devon Carew
f3dc82abda Merge pull request #2616 from devoncarew/show_error_code
show the error codes in flutter analyze --watch
2016-03-11 16:01:41 -08:00
Ian Hickson
1d8117e2d0 Merge pull request #2625 from Hixie/conflictingNamePattern
flutter analyze test
2016-03-11 15:59:25 -08:00
Devon Carew
29df9f5582 show the error code in flutter analyze --watch 2016-03-11 15:59:20 -08:00
Devon Carew
ad7a666a3e fix a launch issue when the user has deleted the app 2016-03-11 15:44:24 -08:00
pq
0aa07baf70 Migrate flutter analyze config to options.
More groundwork to get `analyze` and IDE output to agree.

See: https://github.com/dart-lang/sdk/issues/25723
2016-03-11 14:52:07 -08:00
Hixie
e6b82b6fa9 flutter analyze test
Test that flutter analyze catches no error if two imported libraries
have the same name.

Also, make tests know how to find the flutter root and fix style in one
test to be consistent with the rest of the file.
2016-03-11 14:26:38 -08:00
Phil Quitslund
b9f28e6f75 Merge pull request #2615 from pq/analyze_cleanup
Analyze command cleanup.
2016-03-11 14:25:24 -08:00
Jason Simmons
68e71146a7 Run "pub get" if needed in the flutter build command 2016-03-11 14:10:42 -08:00
pq
a2dac85f87 Re-added conflictingNamesPattern. 2016-03-11 13:12:07 -08:00
Devon Carew
5ad6a57007 remove some references to DeviceStore 2016-03-11 11:25:03 -08:00
Devon Carew
94157c91e9 regenerate the i18n files 2016-03-11 10:58:30 -08:00
pq
aedef5139b Analyze command cleanup.
Removing some special-casing in pursuit of aligning `flutter analyze` output with that provided by server/IDEs.  Specifically:
  * strong-hints (stale, no longer supported)
  * "analyzer says" comment handling in favor of `//ignore`s
  * `conflictingNamePattern` --- no longer needed

Next up some of the error filter regexps...
2016-03-11 10:35:17 -08:00
John McCutchan
5e140b7533 Add DevicePortForwarder with adb fix 2016-03-11 09:26:17 -08:00
Ian Hickson
1b9cd52081 Enable ALL THE LINTS
Well, all the easy ones, anyway.

For some reason `// ignore:` isn't working for me so I've disabled
lints that need that. Also disabled those that require a ton of work
(which I'm doing, but not in this PR, to keep it reviewable).

This adds:
- avoid_init_to_null
- library_names
- package_api_docs
- package_names
- package_prefixed_library_names
- prefer_is_not_empty
- sort_constructors_first
- sort_unnamed_constructors_first
- unnecessary_getters_setters
2016-03-10 23:15:31 -08:00
Hixie
1d03522857 Remove the _EquationMember.hashCode override
Since we removed our operator== overload, we can now allow people to put
these in collections again.

Also, turn on two more analyzer lints: avoid_empty_else and hash_and_equals.
2016-03-10 17:27:02 -08:00
Devon Carew
83caeb35ed Merge pull request #2584 from devoncarew/redux_analysis_options
move the analysis_options to a file
2016-03-10 14:37:58 -08:00
Eric Seidel
37f0b5dd98 Revert "Add DevicePortForwarder" 2016-03-10 14:23:39 -08:00
Devon Carew
b9fafc1765 adjust a regex for intl files 2016-03-10 14:21:23 -08:00
Yegor
96db7c0a5a Merge pull request #2580 from yjbanov/lower-xcode-version-requirement
[ios] reduce xcode version requirement to 7.0
2016-03-10 14:08:48 -08:00
Devon Carew
780e4e6212 move the analysis_options to a file 2016-03-10 13:47:20 -08:00
John McCutchan
5fcaebbf51 Merge pull request #2506 from johnmccutchan/device_port_forward
Add DevicePortForwarder
2016-03-10 13:23:40 -08:00
Yegor Jbanov
23e634a613 [ios] reduce xcode version requirement to 7.0
Build bots only have 7.0.
2016-03-10 13:08:58 -08:00
John McCutchan
131359f4bc Add DevicePortForwarder 2016-03-10 12:49:07 -08:00
Jason Simmons
3b5fba4022 Merge pull request #2578 from jason-simmons/flx_working_dir
Add an option to specify a working directory for the FLX builder
2016-03-10 12:43:35 -08:00