2085 Commits

Author SHA1 Message Date
Jonah Williams
d0b7f0cd4e
Revert "Animated placeholder perf (#50851)" (#50984)
This reverts commit e4fbb1aba6b3d7a5a66e1c3245faee0072e9fd41.
2020-02-18 12:32:46 -08:00
Dan Field
e4fbb1aba6
Animated placeholder perf (#50851) 2020-02-18 11:29:22 -08:00
Jonah Williams
67362ce5e0
[flutter_tools] fix debug stack traces (#50872) 2020-02-18 11:28:02 -08:00
Jonah Williams
dfcf9beb6b
[versions] update sync http dependency (#50981) 2020-02-18 11:26:17 -08:00
Jonah Williams
9b4cb4da72
[versions] reland update test to 1.12.0 (#50879) 2020-02-18 10:38:54 -08:00
shihchanghsiungsonos
ec9813a500
Fix the issue of Android add2app build fails on Android when assets are read-only (#50047) 2020-02-16 19:15:52 -08:00
Jonah Williams
e481fcae52
Revert "[version] update to package:test 1.12.0 (#50818)" (#50853)
This reverts commit d3387bc916da209506db3f07976208bb2f81f911.
2020-02-14 22:34:30 -08:00
Jonah Williams
d3387bc916
[version] update to package:test 1.12.0 (#50818) 2020-02-14 21:51:47 -08:00
Dan Field
1602be6ab6
Live image cache (#50318)
Track images available on screen
2020-02-14 15:03:05 -08:00
Alexandre Ardhuin
85ab331c82
fix unnecessary_string_interpolations lint (#50790) 2020-02-14 10:41:23 +01:00
Alexandre Ardhuin
0bd45bc222
update lint list + enable unnecessary_string_interpolations (#50593) 2020-02-14 09:43:52 +01:00
Yegor
b34046903b
Fix stack trace parsing on non-debug builds; add e2e tests (#50652)
* Fix stack trace parsing on non-debug builds; add e2e tests
2020-02-13 18:34:08 -08:00
Dan Field
766bd70598
Image tracing (#50648) 2020-02-13 14:04:02 -08:00
Yegor
97a5336a34
Clear flaky flag on web benchmarks (#50693) 2020-02-13 07:39:19 -08:00
Dan Field
3d812c1b96
Reduce gradle deps (#50691)
* drop unnecessary test deps

* bump to junit 4.13
2020-02-12 21:14:54 -08:00
Greg Spencer
d57d493507
Reland: Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50672)
This re-lands #49235 with the addition of includeSemantics flag on the Focus widget so that the FocusTraversalGroup can create a Focus widget without affecting the semantics tree.

The FocusTraversalGroup uses the Focus widget to create a grouping of descendants for traversal, but doesn't actually participate in focus (canRequestFocus is always false), so we don't want it to add a Semantics widget in that case, since that can cause semantics changes. The canRequestFocus attribute can also be used when a widget is disabled, so we do sometimes want to include Semantics even if that is false, but not in the case where it is always false, as for FocusTraversalGroup.

- Added a test to make sure that FocusTraversalGroup doesn't add any semantics information.
2020-02-12 16:22:01 -08:00
Dan Field
58a4122b97
update packages (#50666) 2020-02-12 14:51:38 -08:00
Greg Spencer
c132c0faa9
Revert "Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50660)
This reverts commit 8ef5e2f046ed18ca32827e1a715ca5e405c646ac because it breaks some semantics tests.
2020-02-12 13:37:36 -08:00
Casey Hillers
781cd4d87c
Update Devicelab README with new dashboard information (#48908) 2020-02-11 18:25:17 -08:00
Jenn Magder
bfbb347682
Use BUILD_LIBRARY_FOR_DISTRIBUTION build setting for generating add-to-app frameworks (#50536) 2020-02-11 15:53:02 -08:00
Jonah Williams
18f38cd45b
Switch flutter_tools to use frontend_server for web compilation (#50365) 2020-02-11 15:43:46 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Greg Spencer
c6e45ffa30
Updating snippets documentation README.md (#50483)
Updates the README file for snippets.
2020-02-11 09:19:23 -08:00
Greg Spencer
8ef5e2f046
Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235)
This change adds a way to provide explicit focus order for a part of the widget tree.

It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.

It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.

As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.

I was able to do this without breaking the API (AFAICT).
2020-02-11 09:18:39 -08:00
Christopher Fujino
1f498e2471
Set bundle config rather than deprecated --system flag (#50497) 2020-02-10 17:41:37 -08:00
Dan Field
ffc85591c8
more gradle upgrades (#50388) 2020-02-10 14:16:49 -08:00
Greg Spencer
9fb781a54a
Update samples to work with Dartpad, and convert all that make… (#50377)
This PR modifies the existing API docs samples to use DartPad so that all of the samples are now interactive apps on the API docs site.

It also removes the restriction for the max width of the description area so that the dartpad region can expand horizontally.

I updated the first paragraph on the API docs to indicate that Flutter is more than just mobile now (same text as the README.md at the top level).

I modified a few of the examples so that they looked nicer, and fit better on the page.

I added the sample description text above each DartPad instance, since that often defines the context of the example.

I removed animations and images when they were redundant with the sample content. There were a few that made sense to keep, so I did.
2020-02-10 10:00:20 -08:00
keyonghan
0ffecc6807
change capability for test tiles_scroll_perf_iphonexs__timeline_summary (#50385) 2020-02-07 17:24:56 -08:00
Jenn Magder
082ae838bd
Fall back to global cache and platform if null when injected into constructor (#50370) 2020-02-07 15:28:45 -08:00
Christopher Fujino
b65f4211cf
Make codesign.dart integration test easier to run locally (#50289) 2020-02-07 14:34:16 -08:00
Shi-Hao Hong
5dfa8e9c05
Remove redundant gen_l10n tests (#50301) 2020-02-07 13:59:45 -08:00
Dan Field
9348aea016
Disable tests using gauge (#50367) 2020-02-07 13:51:24 -08:00
Greg Spencer
f118b638ed
Add channel-specific dartpad URL to snippet generation (#49845)
Adds the channel to docs generation for dartpad samples, since the new query parameter was added in dart-lang/dart-pad#1462
2020-02-07 08:45:57 -08:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping (#50322) 2020-02-07 16:35:55 +01:00
Jonah Williams
7b074468a4
Update compile size benchmarks to include --split-debug-info and --tree-shake-icons (#50313) 2020-02-06 23:28:41 -08:00
Alexandre Ardhuin
5c28e3eeea
unnecessary escapes fixes (#50178)
* unnecessary escapes fixes

* replace some strings with raw strings

* update regexp

* address review comments
2020-02-07 06:35:50 +01:00
Emmanuel Garcia
8c398a8ddd
Reland: Skia gold driver test (#50160) 2020-02-06 17:14:50 -08:00
Jonah Williams
181cdec079
[flutter_tools] remove automatic multiroot scheme (#50284) 2020-02-06 17:05:41 -08:00
Kaushik Iska
b16fd13f89
[fuchsia] Pass device name to the drive comand. (#50290) 2020-02-06 12:04:08 -08:00
Jenn Magder
13e30aaec6
Remove android directory from platform_channel_swift example project (#50213) 2020-02-06 11:39:55 -08:00
Jonah Williams
4896c85ede
[versions] update packages (#50251) 2020-02-06 08:44:00 -08:00
Jonah Williams
de7908f9e9
[flutter_tools] Reland flutter assemble for iOS (#50229) 2020-02-05 17:44:06 -08:00
Yegor
e4014a55c8
Web benchmarks: make headless mode opt-out (#50166) 2020-02-05 13:21:33 -08:00
Dan Field
ed73f94ebf
Reland "install goldctl in docker build" (#50124)
* Revert "Revert "install goldctl in docker build (#46640)" (#50088)"

This reverts commit 0299398d59027a51fcf2f159cfd894a11d1c9ff2.
2020-02-05 13:18:46 -08:00
Christopher Fujino
105582ed42
add test to verify binaries are signed on release branches (#50074) 2020-02-05 12:36:07 -08:00
godofredoc
374b55cc60
Run microbenchmarks_ios only on ios/12 testbeds. (#50134)
This is to remove the flakiness associated with running those tests on
ios/13 when they always fail.

Context:
https://github.com/flutter/flutter/issues/49635
2020-02-05 09:17:12 -08:00
Hans Muller
82c00c915c
Move the localization_utils camelCase function to LocaleInfo (#50152) 2020-02-05 06:35:49 -08:00
Hans Muller
c3e0f2d462
Add Message.isPlural, Message.getCountPlaceholder() to gen_l10n_types (#50132) 2020-02-05 06:35:29 -08:00
Alexandre Ardhuin
94c7e823be
remove unnecessary string escapes (#50096) 2020-02-05 08:00:32 +01:00
Dan Field
4b8efad99b
Font subset in the tool (#49737) 2020-02-04 20:34:24 -08:00