12555 Commits

Author SHA1 Message Date
Jonah Williams
18f38cd45b
Switch flutter_tools to use frontend_server for web compilation (#50365) 2020-02-11 15:43:46 -08:00
Jason Simmons
324e20de09
Update TextStyle.hashCode to handle list fields (#50520) 2020-02-11 14:38:03 -08:00
LongCatIsLooong
48d5fcabbd
evict _SliverFractionalPadding cache on constraint change (#50523) 2020-02-11 12:52:53 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Lamonte
fd1062debd
Exposed optional scrollController property in ReorderableListView (#49148) 2020-02-11 10:58:02 -08:00
Jenn Magder
e002698c35
Turn back on macOS shard Cirrus caching (#50496) 2020-02-11 10:37:53 -08:00
Jonah Williams
fa44a1cf37
[flutter_tools] fix path escaping on in depfile generation (#50538) 2020-02-11 09:31:58 -08:00
Greg Spencer
8ef5e2f046
Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235)
This change adds a way to provide explicit focus order for a part of the widget tree.

It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.

It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.

As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.

I was able to do this without breaking the API (AFAICT).
2020-02-11 09:18:39 -08:00
Gary Qian
f769bcc5c4
Reland "Track lastKnownRemoteTextEditingValue separately from received data" (#50307) 2020-02-10 20:55:48 -05:00
Amir Hardon
bcef4edfc8
Make the template plugin example depend on the plugin as a real dependency (#50485) 2020-02-10 16:03:02 -08:00
Mouad Debbar
bf551a31fe
EditableText's autofocus:true should not crash (#50372) 2020-02-10 15:58:02 -08:00
Shi-Hao Hong
67826bdce5
Revert "Fix SnackBar clipping when it is floating due to FloatingActionButton positioning (#47616)" (#50516)
This reverts commit 801a6a7e5e2c16525d3c2856a43ed34b5ff536a3.
2020-02-10 14:59:32 -08:00
Greg Spencer
18f8002ec8
Make FocusManager a ChangeNotifier that notifies when the prim… (#50392)
This makes FocusManager a ChangeNotifier that notifies when the primaryFocus changes so that an app can track the current focus.

Fixes #50501
2020-02-10 14:33:31 -08:00
Dan Field
9cb2953e10
Fix image tests that make faulty assumptions about lifecycle of image provider (#50297) 2020-02-10 14:23:01 -08:00
Jonah Williams
568172793c
Add "flutter symbolize" command (#49465) 2020-02-10 14:18:03 -08:00
Dan Field
ffc85591c8
more gradle upgrades (#50388) 2020-02-10 14:16:49 -08:00
Michael Goderbauer
6d87337f51
Remove some obsolete // ignore: (#50481) 2020-02-10 14:08:09 -08:00
Jonah Williams
9bc0e6a991
Revert "Reduced code duplication in ink_splash.dart, ink_ripple.dart (#49480)" (#50502)
This reverts commit 902064277265daced4a79bcdaae157a310cc13c8.
2020-02-10 13:26:59 -08:00
Zachary Anderson
c23d9cd4ce
[flutter_tools] Print emojis in Windows Terminal (#50446) 2020-02-10 10:23:35 -08:00
Per Classon
5f4658973b
Update RefreshIndicator documentation to clarify the need for the child for be scrollable (#50345) 2020-02-10 10:08:02 -08:00
liyuqian
b277534026
Assert cache hints are not set for null painters (#49771) 2020-02-10 10:03:03 -08:00
Greg Spencer
9fb781a54a
Update samples to work with Dartpad, and convert all that make… (#50377)
This PR modifies the existing API docs samples to use DartPad so that all of the samples are now interactive apps on the API docs site.

It also removes the restriction for the max width of the description area so that the dartpad region can expand horizontally.

I updated the first paragraph on the API docs to indicate that Flutter is more than just mobile now (same text as the README.md at the top level).

I modified a few of the examples so that they looked nicer, and fit better on the page.

I added the sample description text above each DartPad instance, since that often defines the context of the example.

I removed animations and images when they were redundant with the sample content. There were a few that made sense to keep, so I did.
2020-02-10 10:00:20 -08:00
Jonah Williams
2a6bc617b8
[framework] minimize performance effect of stateless/stateful swap (#50394) 2020-02-10 10:00:11 -08:00
Jonah Williams
6146cd72e4
[flutter_tools] add missing vm_service dep to BUILD.gn (#50454) 2020-02-10 09:59:48 -08:00
Jonah Williams
a8cc85331a
[flutter-tools] replace mock with FakeProcessmanager (#50456) 2020-02-10 09:59:40 -08:00
Prerak Mann
9020642772
Reduced code duplication in ink_splash.dart, ink_ripple.dart (#49480) 2020-02-10 09:58:04 -08:00
Shi-Hao Hong
6dc3bfaa98
Fix Dropdown 'itemHeights' was called on null crash (#50366) 2020-02-07 18:28:02 -08:00
Michael Goderbauer
95d6ef741c
Nested TickerMode cannot turn tickers back on (#50355) 2020-02-07 18:23:02 -08:00
filaps
801a6a7e5e
Fix SnackBar clipping when it is floating due to FloatingActionButton positioning (#47616) 2020-02-07 16:08:02 -08:00
jimshepherd
92a335e465
Use state value in DropdownButtonFieldForm (#37145)
The current implementation of DropdownButtonFormField does not pass the initial value to _DropdownButtonFormFieldState. As a result changes made through the child DropdownButton are not made to the FormFieldState and the widget is not updated unless a onChanged function is provided to the DropdownButtomFormField constructor.

This change modifies DropdownButtonFormField to behave more consistently with other FormField widgets in how the Form state is handled.
2020-02-07 15:50:37 -08:00
Jenn Magder
082ae838bd
Fall back to global cache and platform if null when injected into constructor (#50370) 2020-02-07 15:28:45 -08:00
Jenn Magder
4411d8e64e
Update minimum version to Xcode 11.0 (#50371) 2020-02-07 14:35:01 -08:00
Jenn Magder
48a9bd56b1
Revert "Update minimum version to Xcode 11.0 (#50315)" (#50369)
This reverts commit 2b7582ef61dff05a31f558c095aec8f8794d5a42.
2020-02-07 13:59:21 -08:00
Jenn Magder
2b7582ef61
Update minimum version to Xcode 11.0 (#50315) 2020-02-07 13:57:24 -08:00
Tong Mu
324a2168cd
Change definition of offset to object (#50157) 2020-02-07 13:08:02 -08:00
Dan Field
2627122324
Throw when trying to load an empty file (#50325) 2020-02-07 10:08:02 -08:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping (#50322) 2020-02-07 16:35:55 +01:00
Dan Field
8735ab1e35
Make onImage re-entrant safe (#50316) 2020-02-06 23:36:59 -08:00
Alexandre Ardhuin
5c28e3eeea
unnecessary escapes fixes (#50178)
* unnecessary escapes fixes

* replace some strings with raw strings

* update regexp

* address review comments
2020-02-07 06:35:50 +01:00
David Iglesias
b8199abd15
[flutter_tools] Prevent web ServiceWorker from modifying fetch requests. (#50312) 2020-02-06 18:43:03 -08:00
Jonah Williams
82410a5ae7
[flutter_tools] support iOS and macOS with split-debug-info and tree-shake-icons (#50296) 2020-02-06 18:39:34 -08:00
Emmanuel Garcia
8c398a8ddd
Reland: Skia gold driver test (#50160) 2020-02-06 17:14:50 -08:00
Harry Terkelsen
0fc1c6f6d7
[flutter_tool] Make the registrant import relative to the entrypoint (#50302) 2020-02-06 17:08:02 -08:00
Jonah Williams
181cdec079
[flutter_tools] remove automatic multiroot scheme (#50284) 2020-02-06 17:05:41 -08:00
Zachary Anderson
6bfff984de
[flutter_tools] Handle AndroidStudio validator crash (#50282) 2020-02-06 16:03:02 -08:00
David Shuckerow
2032760509
Explain how the scroll controller behaves under tests (#50129) 2020-02-06 15:58:02 -08:00
YizhePKU
f8b286dce0
Updated documentation for CupertinoPicker (#50264) 2020-02-06 15:53:07 -08:00
Levi Lesches
149e06232b
Add option to clear the terminal by pressing "c" (#50034) 2020-02-06 15:53:04 -08:00
Jenn Magder
a9b8d360cf
Remove ideviceinfo, idevice_id artifacts (#50248) 2020-02-06 15:50:26 -08:00
Jenn Magder
2512163ebe
Allow Android to be missing from multi-platform manifest (#50304) 2020-02-06 15:50:03 -08:00