12984 Commits

Author SHA1 Message Date
Janice Collins
acec78cffe
Update dartdoc to 0.27.0 (#26041) 2019-01-03 16:32:57 -08:00
Amir Hardon
3782b6abf2
Workaround the Gradle crash due to non ASCII chars. (#26024)
Cirrus puts the PR description and commit message in environment
variables.
These messages tend to have non ASCII characters sometimes (like
emojis), which triggers a Gradle bug (gradle/gradle#3117) resulting
in Gradle crashing without a helpful error message.

The real solution to this problem should be fixing the Gradle bug.
The better workaround on the Flutter side would be to set a UTF8 locale
on the Cirrus machine, but I have yet figured out how to do it.
For now to avoid more people from hitting this I'm working around by
temporarily unsetting the Cirrus environment variables with the PR
description and commit message.

A non ASCII character to make sure it works: 😄
2019-01-03 16:27:47 -08:00
Stanislav Baranov
b57499e704
Friendlier messages when using dynamic patching (#25863) 2019-01-03 16:18:36 -08:00
engine-flutter-autoroll
e4515824a1
Roll engine 134b65ec6034..e52287a1b557 (3 commits) (#26027)
134b65ec60...e52287a1b5

git log 134b65ec6034cdd9823ed5631df248d27870306e..e52287a1b5572c73b19d085ccbe404f0aeddb5f6 --no-merges --oneline
e52287a1b Fix typo clas -> class (flutter/engine#7360)
80c19b6b1 Roll src/third_party/skia 8966b55644c2..3b7e65107f67 (3 commits) (flutter/engine#7361)
beed0c455 Roll src/third_party/skia fdde2926df92..8966b55644c2 (1 commits) (flutter/engine#7359)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@chromium.org), and stop
the roller if necessary.
2019-01-03 16:23:28 -05:00
Jonah Williams
d84879d910
Ensure all errors thrown by image providers can be caught by developers. (#25980)
* Ensure all errors thrown by image providers can be caught by developers.

Add an `onError` parameter to the ImageCache.putIfAbsent method.
In the event that an error is thrown when resolving an image, catch if
this parameter is provided. Use the onError parameter to ensure that all
errors thrown are forwarded to the ImageStream error channel instead of
directly into the void.
2019-01-03 12:55:16 -08:00
Phil Quitslund
919f457ae9 Fix spelling typo (#25514) 2019-01-03 15:51:45 -05:00
engine-flutter-autoroll
b5723ecf16
Roll engine 2940812ab26a..134b65ec6034 (9 commits) (#26022)
2940812ab2...134b65ec60

git log 2940812ab26a9dac772459888f1e79389bedb977..134b65ec6034cdd9823ed5631df248d27870306e --no-merges --oneline
134b65ec6 Roll src/third_party/skia aae6ae39a356..fdde2926df92 (1 commits) (flutter/engine#7358)
f97edf2ac Roll src/third_party/skia 96345a23dfa9..aae6ae39a356 (1 commits) (flutter/engine#7357)
d051c47e5 Roll src/third_party/skia bc84adceaada..96345a23dfa9 (2 commits) (flutter/engine#7356)
15fcba4d8 Roll src/third_party/skia d0d5bb8c8500..bc84adceaada (6 commits) (flutter/engine#7355)
4d353de49 Preparing to remove SK_SUPPORT_LEGACY_PAINT_TEXTMEASURE (flutter/engine#7354)
54d7c4256 Paint all backgrounds first to prevent overlap (flutter/engine#7287)
0ad16dd10 Roll src/third_party/skia 279b65ddb5a3..d0d5bb8c8500 (12 commits) (flutter/engine#7353)
8cca33aea Give more control over when dynamic patches get downloaded and installed. (flutter/engine#7327)
2d291c7ff Roll src/third_party/skia 8f37ce5b9f2c..279b65ddb5a3 (6 commits) (flutter/engine#7350)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@chromium.org), and stop
the roller if necessary.
2019-01-03 14:55:29 -05:00
Siva
b1109226d8
Address code review comment. (#25995) 2019-01-03 10:55:50 -08:00
Kenzie Schmoll
52e5cd24dc
Add didSendFirstFrameEvent service extension. (#25977)
* Add didSendFirstFrameEvent service extension.
2019-01-03 10:38:06 -08:00
engine-flutter-autoroll
71be92e68e 2940812ab Roll src/third_party/skia 1409ac718693..8f37ce5b9f2c (2 commits) (flutter/engine#7349) (#25978) 2019-01-03 13:05:14 -05:00
Gary Qian
7de513dec3
Add docs to TextStyle for fontFamilyFallback/Custom font fallback (#25992) 2019-01-03 13:03:14 -05:00
Zachary Anderson
eb236da5ea
[fuchsia] Fix flutter_gallery BUILD.gn (#26015) 2019-01-03 09:15:53 -08:00
TruongSinh Tran-Nguyen
53727866e6 fix #25143 Successive calls to precacheImage() throw an exception (#25159) 2019-01-02 21:05:53 -08:00
KyleWong
85ded44139 Optimize cocoapods logic in flutter doctor. (#25872) 2019-01-02 19:57:03 -08:00
Chema Molins
4b87e334d7 Setting icon color to first ListTile in ExpansionTile. Fixes #23053 (#23118) 2019-01-02 10:49:59 -08:00
Michael Goderbauer
94aab29ec1
fix flutter run in dev/manual_tests (#25817) 2019-01-02 10:09:26 -08:00
Michael Goderbauer
28907c7950
Make LicensePage respect the notch (#25799) 2019-01-02 10:01:39 -08:00
engine-flutter-autoroll
9d477f3050
Roll engine b1a9a6e79474..844c3274e6a1 (6 commits) (#25966)
b1a9a6e794...844c3274e6

git log b1a9a6e7947492b27c21688104d2d006d583094e..844c3274e6a1cd5a4651c46d26761b76ea837b34 --no-merges --oneline
844c3274e Roll src/third_party/skia 22451ccae544..1409ac718693 (2 commits) (flutter/engine#7348)
8ae205ccf Roll src/third_party/skia db0fdfbf107d..22451ccae544 (1 commits) (flutter/engine#7347)
e04cb414c Roll src/third_party/skia 247f03baeed9..db0fdfbf107d (1 commits) (flutter/engine#7345)
5f5316871 Roll src/third_party/skia 4f050fb81955..247f03baeed9 (1 commits) (flutter/engine#7344)
0e4a1afc3 Roll src/third_party/skia 8f42e2467cd9..4f050fb81955 (1 commits) (flutter/engine#7343)
a19b78ab6 Roll src/third_party/skia 9bc33b963844..8f42e2467cd9 (1 commits) (flutter/engine#7342)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2019-01-02 12:12:30 -05:00
engine-flutter-autoroll
b9f9e384cb
Roll engine 995e3247fe50..b1a9a6e79474 (9 commits) (#25943)
995e3247fe...b1a9a6e794

git log 995e3247fe500ff6e9981bd6e2409191c4f9a32a..b1a9a6e7947492b27c21688104d2d006d583094e --no-merges --oneline
b1a9a6e79 Roll src/third_party/skia 61b3d1d00057..9bc33b963844 (1 commits) (flutter/engine#7341)
571bf5c1e Roll src/third_party/skia 7b0f0149474a..61b3d1d00057 (1 commits) (flutter/engine#7340)
193cf3792 Roll src/third_party/skia 197b1f7900a2..7b0f0149474a (1 commits) (flutter/engine#7334)
8b35c97c1 Roll src/third_party/skia 0c1592291580..197b1f7900a2 (2 commits) (flutter/engine#7333)
544e5bcd2 Roll src/third_party/skia 3b0a332fd970..0c1592291580 (1 commits) (flutter/engine#7332)
d2eb6efeb Roll src/third_party/skia a5d2a9486fed..3b0a332fd970 (1 commits) (flutter/engine#7331)
e2ca868c3 Roll src/third_party/skia 3dc21675b05a..a5d2a9486fed (1 commits) (flutter/engine#7330)
cdc7cc8d3 Roll src/third_party/skia 739b760deaa6..3dc21675b05a (1 commits) (flutter/engine#7329)
e548f12e4 Roll src/third_party/skia aec8c7e280cb..739b760deaa6 (1 commits) (flutter/engine#7328)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2019-01-01 11:47:29 -05:00
engine-flutter-autoroll
faae8bde78
Roll engine 1bd9d41f8990..995e3247fe50 (3 commits) (#25858)
1bd9d41f89...995e3247fe

git log 1bd9d41f8990..995e3247fe50 --no-merges --oneline
995e3247f Roll src/third_party/skia f3e6b90461e4..aec8c7e280cb (1 commits) (flutter/engine#7326)
6f763fbad Minor refactoring of dynamic patching code. (flutter/engine#7325)
868dc047b Support loading flutter assets from dynamic patch (flutter/engine#7308)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-28 23:03:40 -05:00
Amir Hardon
ff9f7236e6
Mark flutter_gallery__back_button_memory as flaky. (#25857)
See https://github.com/flutter/flutter/issues/25855
2018-12-28 15:34:15 -08:00
engine-flutter-autoroll
74e54236b7
Roll engine f0a1d6f91d93..1bd9d41f8990 (6 commits) (#25856)
f0a1d6f91d...1bd9d41f89

git log f0a1d6f91d93..1bd9d41f8990 --no-merges --oneline
1bd9d41f8 Roll src/third_party/skia 51eaa79d19b8..f3e6b90461e4 (5 commits) (flutter/engine#7323)
bf863786c Roll buildroot to pick up changes since the last roll: (flutter/engine#7322)
c716a21a2 Roll src/third_party/skia 7561dba7c145..51eaa79d19b8 (3 commits) (flutter/engine#7321)
189662feb Roll src/third_party/skia 3e7ba8fa7e7f..7561dba7c145 (1 commits) (flutter/engine#7320)
db5214d3d Roll src/third_party/skia acc763e8795c..3e7ba8fa7e7f (1 commits) (flutter/engine#7319)
0a0d61323 Changes since last dart roll: (flutter/engine#7316)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-28 18:05:40 -05:00
Amir Hardon
0220412c53
Fix analyzer "prefer const" warning. (#25854) 2018-12-28 14:05:19 -08:00
Amir Hardon
63b2daff7f
Roll engine to f0a1d6f91 (#25849)
```
f0a1d6f91 Roll src/third_party/skia 487132b82826..acc763e8795c (1 commits) (#7318)
f0dd6436c Recreate the overlay rendering surfaces if the GrContext was changed. (#7317)
245317a62  Reland "Only reject gestures to embedded UIViews when the framework sa (#7315)
be69b07cc Roll src/third_party/skia d2fa2eb59f2d..487132b82826 (1 commits) (#7314)
732ea7669 Allow dynamic patches without a patch number. (#7309)
20ee4e3e9 Revert "Only reject gestures to embedded UIViews when the framework says so. (#7307)" (#7313)
28e152f7e Roll src/third_party/skia cae020ae5f5f..d2fa2eb59f2d (3 commits) (#7312)
7c65290da Roll src/third_party/skia 31c1bf89657f..cae020ae5f5f (1 commits) (#7311)
180d8a7d9 Roll src/third_party/skia f6e963ef91c2..31c1bf89657f (1 commits) (#7310)
cc9c6702d Only reject gestures to embedded UIViews when the framework says so. (#7307)
2fb2b2729 Roll src/third_party/skia 3605fde88b2a..f6e963ef91c2 (1 commits) (#7306)
```
2018-12-28 10:43:06 -08:00
Alexander Aprelev
fe1a51ab89
Flutter engine roll with dart roll (#25815) 2018-12-27 14:55:07 -08:00
Michael Goderbauer
bb711b5d04
remove early-stage from Gallery's About screen (#25798) 2018-12-27 12:17:42 -08:00
Stanislav Baranov
bacaab9795
Allow dynamic patches without a patch number. (#25796)
Unique patch numbers are mainly useful for canary and A-B testing, but otherwise complicate things and can now be omitted.
2018-12-27 11:57:16 -08:00
Alexander Aprelev
52bd2ccb8b
Report devfs stats (#25586)
* Collect devfs stats for better analytics

* Fix fields initialization

* Fix lints
2018-12-27 09:53:24 -08:00
Amir Hardon
50f9b88395
Actively reject UiKitView gestures. (#25792)
flutter/engine#7307 changes the engine side of embedded UIView to only
reject gestures when the framework sends a `rejectGesture` message, so
that gesture resolution can done after a touch sequence has ended (see
PR description for flutter/engine#7307 for more details).

This change makes the framework send a `rejectGesture` message to the
engine when a UiKitView rejects a gesture.

I'm planning to land this PR before the engine side change, so right now
it swallows the exception thrown if there is no engine implementation
for `rejectGesture` (which keeps us with the current behavior). After
this change lands I'll land the engine PR, and then clean up the part
that swallows the exception.
2018-12-26 19:34:53 -08:00
engine-flutter-autoroll
c24923c79a
Roll engine e75fad7ccead..9daf5c8d213a (3 commits) (#25786)
e75fad7cce...9daf5c8d21

git log e75fad7ccead..9daf5c8d213a --no-merges --oneline
9daf5c8d2 Roll src/third_party/skia f78b7ea945e5..3605fde88b2a (1 commits) (flutter/engine#7305)
798e96d9b Roll src/third_party/skia 212e9060ed29..f78b7ea945e5 (1 commits) (flutter/engine#7304)
7b379da03 Roll src/third_party/skia 5d77c200a8d9..212e9060ed29 (1 commits) (flutter/engine#7303)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-26 17:58:40 -05:00
engine-flutter-autoroll
8b024a5fc6
Roll engine d8c5ec0e11b5..e75fad7ccead (5 commits) (#25757)
d8c5ec0e11...e75fad7cce

git log d8c5ec0e11b5..e75fad7ccead --no-merges --oneline
e75fad7cc Roll src/third_party/skia 2772ea397e04..5d77c200a8d9 (1 commits) (flutter/engine#7302)
a64dd4b97 Roll src/third_party/skia 088b74e51314..2772ea397e04 (1 commits) (flutter/engine#7301)
4e9fb504e Roll src/third_party/skia 8be4b02b4c72..088b74e51314 (1 commits) (flutter/engine#7300)
787caecc7 Roll src/third_party/skia 481dd46cc368..8be4b02b4c72 (1 commits) (flutter/engine#7299)
c39589de6 Roll src/third_party/skia dc5863c4d665..481dd46cc368 (1 commits) (flutter/engine#7298)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-26 12:53:40 -05:00
Justin McCandless
9161ec42cb
Include cursor in textfield intrinsic width measurement (#25055)
* Include cursor in textfield intrinsic width measurement

* Add cursorWidth assertion, add comment about assumed cursor width, and test null stepWidth
2018-12-26 08:56:02 -08:00
engine-flutter-autoroll
4d2d800d9e
Roll engine 215ca1560088..d8c5ec0e11b5 (12 commits) (#25728)
215ca15600...d8c5ec0e11

git log 215ca1560088..d8c5ec0e11b5 --no-merges --oneline
d8c5ec0e1 Roll src/third_party/skia f16825ed3c71..dc5863c4d665 (1 commits) (flutter/engine#7297)
efb8a3f07 Roll src/third_party/skia 945a56644728..f16825ed3c71 (1 commits) (flutter/engine#7296)
67150a535 Roll src/third_party/skia 28bd882a1e40..945a56644728 (2 commits) (flutter/engine#7295)
3705a1ed3 Roll src/third_party/skia ea8900e74ea7..28bd882a1e40 (1 commits) (flutter/engine#7294)
943ecfc75 Roll src/third_party/skia 13654b20ce5b..ea8900e74ea7 (1 commits) (flutter/engine#7293)
7b12ae241 Roll src/third_party/skia 12a6d452b126..13654b20ce5b (1 commits) (flutter/engine#7292)
1fe7e1fde Roll src/third_party/skia c983480b117f..12a6d452b126 (1 commits) (flutter/engine#7291)
a8b0d263c Roll src/third_party/skia 2e40d9886402..c983480b117f (1 commits) (flutter/engine#7290)
c64f971e3 Roll src/third_party/skia 98a4e4a4135b..2e40d9886402 (1 commits) (flutter/engine#7289)
65420c264 Roll src/third_party/skia 2a0967383087..98a4e4a4135b (1 commits) (flutter/engine#7288)
770536ab6 Only overflow the cache for one required frame (flutter/engine#7048)
b6880bbc9 Roll src/third_party/skia 9803b8f1d197..2a0967383087 (16 commits) (flutter/engine#7285)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-24 18:47:40 -05:00
Ian Hickson
1e78c47bc4
Provide some more locations for the FAB. (#24736)
Top left and top right for big FABs, and top left for mini FABs.
2018-12-24 15:22:13 -08:00
Ian Hickson
d05fa45fb2
Undeprecated BigInteger support, but document what it actually does. (#24511)
Also, some code cleanup.
2018-12-23 15:21:43 -08:00
Ian Hickson
e239872561
ClipPath.shape and related fixes (#24816) 2018-12-23 15:21:11 -08:00
Ian Hickson
c5ad1067b7
Handle errors in compute() by propagating them to the Future. (#24848) 2018-12-23 15:20:45 -08:00
Ian Hickson
273364e2bc
Fix merge conflict. (#25718) 2018-12-23 11:13:53 -08:00
Ian Hickson
c0b20a76de
Some minor tweaks to InputDecoration (mainly docs). (#24643) 2018-12-23 10:12:42 -08:00
Gary Qian
2e2f19d3e9
Expose font fallback API in TextStyle, Roll engine 54a3577c0139..215ca1560088 (8 commits) (#25585) 2018-12-21 19:07:01 -08:00
Hans Muller
4857267e65
Updated Shrine demo (#25674) 2018-12-21 17:47:25 -08:00
Amir Hardon
8d60ed04c9
Pin the goldens repo to a specific commit in the android_views test. (#25678) 2018-12-21 14:17:12 -08:00
Stanislav Baranov
6d6ada14a0
Friendlier flags for Dart compilation training. (#25645)
* Renamed --save-compilation-trace to flutter run --train.
* Renamed --precompile=<file> to --compilation-trace-file=<file>.
* In dynamic mode, made JIT snapshot the default, instead of kernel file.
2018-12-21 12:27:59 -08:00
Stanislav Baranov
10ce692089
Revert dependency upgrade to see if it helps with build times and APK size (#25642) 2018-12-21 10:55:04 -08:00
Amir Hardon
1d5833d99f
Depend on the goldens repo through git. (#25479)
It's easier to run the android_views integration test this way, without
needing to worry if we have a local clone of the goldens repo or not.
2018-12-21 10:38:39 -08:00
Alexandre Ardhuin
19ce65eec9
no period after an alone link in see also section (#25604) 2018-12-21 19:23:42 +01:00
Ian Hickson
fb88a7bfd1
Update links for China help (#25238)
We have a page on the Web page now.
2018-12-21 10:12:49 -08:00
engine-flutter-autoroll
273495b754
Roll engine 6a9041853c4b..54a3577c0139 (23 commits) (#25649)
6a9041853c...54a3577c01

git log 6a9041853c4b..54a3577c0139 --no-merges --oneline
54a3577c0 Roll src/third_party/skia b03e024a4034..bdfe3a3ee9c3 (14 commits) (flutter/engine#7277)
ead76a4db Remove unused native function dumpCopmpilationTrace(). (flutter/engine#7276)
eaffc462a [License] Enable avoid_positional_boolean_parameters lint (flutter/engine#7275)
b07753bad [License] Sync analysis_options.yaml from framework (flutter/engine#7273)
233c100b6 [License] Enable always_require_non_null_named_parameters
f4b348f77 [License] Enable flutter_style_todos lint
48be433ce [License] Enable prefer_is_empty lint
bd648bad6 [License] Enable prefer_const_constructors lint
2b207a51c [License] Enable unnecessary_parenthesis lint
97ae27164 [License] Enable prefer_initializing_formals lint
c8f83fbea [License] Enable prefer_collection_literals lint
d120e15af [License] Enable prefer_void_to_null lint
e2ab3780a [License] Enable directives_ordering lint
5f2e6cd41 [License] Enable unnecessary_overrides lint
bd955d78a [License] Enable avoid_function_literals_in_foreach_calls lint
392df65f6 [License] Enable prefer_const_declarations lint
06e35912d [License] Enable prefer_final_fields lint
32423ef38 [License] Enable prefer_asserts_in_initializer_lists lint
4703a7f10 [License] Enable prefer_equal_for_default_values lint
1d7285bea [License] Enable empty_catches lint
68fadca0e [License] Enable unnecessary_this lint
c6f5e67cb [License] Enable prefer_single_quotes lint
cc51731d8 Clarify TextAffinity docs (flutter/engine#7238)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-21 11:41:40 -05:00
engine-flutter-autoroll
6f0f0c4b60
Roll engine e859296b71de..6a9041853c4b (4 commits) (#25643)
e859296b71...6a9041853c

git log e859296b71de..6a9041853c4b --no-merges --oneline
6a9041853 [License] Assert license filename is non-null, non-empty (flutter/engine#7270)
72aa37842 [License] Eliminate duplicate case in switch (flutter/engine#7269)
74af4429a Mark all unreassigned locals final in license tool (flutter/engine#7267)
0310e910d Roll src/third_party/skia 44539be30ef8..b03e024a4034 (7 commits) (flutter/engine#7268)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-21 02:03:28 -05:00
Pranay Airan
368cd7da8b
Adding support for android app bundle - Issue #17829 (#24440)
* adding support for android app bundle.

* removing the debug statement.

* fixing formatting and code review changes.

* Revert "fixing formatting and code review changes."

This reverts commit 2041d459f335242555a0b75e445343134c245494.

* Fixing code formatting issues.

* updating review comments fixing comments and spacing.

* changing and to & to rerun the CI and tests.

* updating the comment to re-run the test

updating the comment to re-run the test

* fixing the formatting.

* updating comments to re-trigger build

updating comments to re-trigger build
2018-12-20 22:18:53 -08:00