466 Commits

Author SHA1 Message Date
xster
1a4bf9b66d Fix flutter view project's automated tests (#9712)
Remove checked in .lock, remove checked in cocoapods scripts in xcode project, let the automated test run pod install specifically for this test
2017-05-01 18:23:06 -07:00
Chris Bracken
ffa8483f3b Update hello_world_memory_test package name (#9704)
Broken by 89af5ec8c7c6012746482256b9b7459727526f32.
2017-05-01 14:18:00 -07:00
Ian Hickson
f2e89681d9 Mark microbenchmarks_ios as flaky (#9656)
...because it clearly is.
2017-04-27 19:55:54 -07:00
Ian Hickson
36052e68dd BoxDecoration API changes: backgroundColor -> color et al (#9648)
backgroundColor -> color
backgroundImage -> image
BackgroundImage -> DecorationImage
2017-04-27 14:19:01 -07:00
Jason Simmons
0439bf25d9 Fix an analyzer warning (#9643) 2017-04-27 11:16:00 -07:00
Michael Goderbauer
36f7a26641 Disable AAPT cruncher on Windows for channel integration test (#9639)
It causes the test to be flaky, see https://github.com/flutter/flutter/issues/8986.
2017-04-27 09:59:31 -07:00
Mikkel Nygaard Ravn
23b8e1f115 Make profile provisioning manual for channel_integration_test_ios (#9633) 2017-04-27 12:14:43 +02:00
Mikkel Nygaard Ravn
60bc1cfde7 Remove personal dev team from ios code sigining (#9631)
* Mark channels_integration_test_ios flaky

* Removed personal dev team from ios code siging

* Removed provisioning profile diffs against other samples
2017-04-27 11:07:52 +02:00
Mikkel Nygaard Ravn
70ff50f929 Integration test for channel communication (#9621) 2017-04-27 08:44:28 +02:00
Mehmet Fidanboylu
4e7a38b118 Add a tile scrolling test to complex_layout app (#9537)
* Add a tile scrolling test to complex_layout app

* - Review comments and fix analyzer failures.

* Use ListView.builder pattern.
2017-04-26 14:22:11 -07:00
Todd Volkert
db82f9ea7d Make travis script more verbose upon error (#9545)
This will help us know for sure exactly which sub-script erred.
2017-04-24 09:14:44 -07:00
Michael Thomsen
f6a7fe0925 Upgrade firebase tools version (#9548) 2017-04-24 11:14:54 +02:00
Alexandre Ardhuin
83fce211a3 More const immutable classes (#9544)
* more widget const constructors

* prefer const constructors

* address review comments
2017-04-23 22:37:29 +02:00
Adam Barth
0d0861b3ee The const will continue until morale improves (#9536) 2017-04-21 14:59:24 -07:00
Alexandre Ardhuin
9541848272 make @immutable const classes (#9532)
* make @immutable const

* fix build
2017-04-21 23:09:42 +02:00
jcollins-g
37fafeecb1 Dartdoc bot sanity flexibility (#9496)
* Have sanity check pass on old and new versions of flutter
2017-04-21 08:11:33 -07:00
Alexandre Ardhuin
35803c2297 comprehensive list of lints (#9330)
* comprehensive list of lints
* add comments to commented out lint
* fix unnecessary_this lints
* exclude prefer_final_fields
2017-04-20 09:38:57 +02:00
Ian Hickson
96d8a2a3ad Mark some tests as flaky (#9489)
These tests have recently been turning the build red incorrectly. Until they are reliable, let's mark them flaky.
2017-04-20 00:11:31 -07:00
Adam Barth
ab1aa07e8f Update engine (#9484) 2017-04-19 15:42:02 -07:00
Devon Carew
84a9ff7318 list which version of dartdoc we're using (#9466) 2017-04-19 10:00:18 -07:00
Adam Barth
7be9115a43 Deploy @immutable in more places (#9462)
Turns out we have many immutable classes.

Fixes #6892
2017-04-19 09:30:43 -07:00
Devon Carew
4631717f1b De-duplicate the dartanalyzer command output (#9441) 2017-04-18 14:02:06 -07:00
Phil Quitslund
fc58bd7679 IntelliJ metadata cleanup (flutter-intellij#914). (#9427)
Follow-up from #9422
2017-04-17 13:42:31 -07:00
Yegor
7e3bb94d5f Mark complex_layout_scroll_perf__timeline_summary as flaky (#9405) 2017-04-14 17:15:34 -07:00
Adam Barth
ea71bdca20 Start using @immutable annotations (#9152)
There are more places we can use this annotation, but this patch just gets us
started.
2017-04-14 10:38:58 -07:00
Devon Carew
9493df2da8 update the IntelliJ metadata files (#9388) 2017-04-14 08:55:26 -07:00
Devon Carew
668ae8bdda update the font used for docs.flutter.io (#9337)
* update the font used for docs.flutter.io

* update to use the flutter primary color

* update the header background color
2017-04-14 08:55:16 -07:00
Ian Hickson
00dfa224d1 Be more consistent about how stack traces are output from flutter_test (#9361) 2017-04-13 12:31:04 -07:00
Ian Hickson
8fdd2066b3 DefaultTextStyle.merge and IconTheme.merge improvements (#9358)
I can't figure out if this is genius or a giant hack.

This lets you use DefaultTextStyle.merge and IconTheme.merge without
specifying a BuildContext. It automatically merges in at the
appropriate place in the tree using a Builder widget.
2017-04-13 10:26:40 -07:00
Ian Hickson
aaa0a1cfc3 Make test.dart support Emacs buffers better (#9353)
In particular, if stdout.supportsAnsiEscapes is false, don't output ANSI.

Also, output stdout/stderr of tests that are normally silenced, if they fail.

Also, update the output to be more convenient when debugging.

Also, expand some abbreviations.
2017-04-13 10:22:41 -07:00
Ian Hickson
bf017b79b3 Move Point to Offset (#9277)
* Manually fix every use of Point.x and Point.y

Some of these were moved to dx/dy, but not all.

* Manually convert uses of the old gradient API

* Remove old reference to Point.

* Mechanical changes

I applied the following at the root of the Flutter repository:

git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'

* Mechanical changes - dartdocs

I applied the following at the root of the Flutter repository:

git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'

* Further improvements and a test

* Fix minor errors from rebasing...

* Roll engine
2017-04-12 15:06:12 -07:00
Ian Hickson
2a54524337 Fix tests to use Ahem, and helpful changes around that (#9332)
* Fix tests to use Ahem, and helpful changes around that

- Fix fonts that had metric-specific behaviours.

- LiveTestWidgetsFlutterBinding.allowAllFrames has been renamed
  to LiveTestWidgetsFlutterBinding.framePolicy.

- LiveTestWidgetsFlutterBinding now defaults to using a frame policy
  that pumps slightly more frames, to animate the pointer crosshairs.

- Added "flutter run --use-test-fonts" to enable Ahem on devices.

- Changed how idle() works to be more effective in live mode.

- Display the test name in live mode (unless ahem fonts are enabled).

- Added a toString to TextSelectionPoint.

- Style nit fixes.

* Roll engine to get Ahem changes.

* Update tests for dartdoc changes.

* Fix flutter_tools tests
2017-04-12 13:33:02 -07:00
Yegor
9dfcc6ec79 Revert "temporarily mark iOS tests as flaky (#9314)" (#9333)
This reverts commit ff23a1ebfe5d01af8924761253cc574f23ac5295.

Our iOS lab hardware is back to normal.
2017-04-11 12:26:15 -07:00
xster
89a7fdfc56 Rename State.config to widget everywhere (#9273)
Rename State.config to State.widget
Rename State.didUpdateConfig to State.didUpdateWidget
Renamed all State subclasses' local variables named config to something else
2017-04-10 18:32:24 -07:00
Yegor
a5593b1678 fix analyzer warning: use const where possible (#9320) 2017-04-10 14:20:47 -07:00
Yegor
ff23a1ebfe temporarily mark iOS tests as flaky (#9314) 2017-04-10 10:51:31 -07:00
Alexandre Ardhuin
610955f81d upgrade to linter-0.1.30 (#9297)
* upgrade to linter-0.1.30

* add prefer_is_empty lint
* add directives_ordering lint
* add no_adjacent_strings_in_list lint
* add no_duplicate_case_values lint
* add prefer_collection_literals lint
* add prefer_const_constructors lint
* add prefer_contains lint
* add prefer_initializing_formals lint
* add unnecessary_null_aware_assignments lint
* add unnecessary_null_in_if_null_operators lint
2017-04-08 08:43:19 +02:00
Ian Hickson
ebe6da5b17 Rename BlockBody to ListBody. (#9291)
Nobody knew what a Block was.
2017-04-07 17:14:54 -07:00
Ian Hickson
3eb87830e9 Constants! Constants everywhere! (#9286)
Aggressively apply the const lint.
2017-04-07 12:24:32 -07:00
Yegor
d538c11486 update devicelab docs (#9274) 2017-04-06 16:27:29 -07:00
Yegor
57ca2b5ce8 obey custom timeout supplied by cocoon (#9260) 2017-04-06 10:48:45 -07:00
Michael Goderbauer
a559b8df5c [Regression] Re-enable ANSI color support on Windows (#9232)
Also adds a test to make sure we don't break it again.
2017-04-05 15:44:22 -07:00
Ian Hickson
86a490ffe8 Tracked skipped tests in technical debt benchmark (#9206) 2017-04-05 12:23:21 -07:00
Ian Hickson
896ffcdf17 Disable test that is turning the tree red. (#9204)
This issue is being tracked at: https://github.com/dart-lang/sdk/issues/29230
2017-04-04 17:01:38 -07:00
Alexandre Ardhuin
189028a958 Separate the 'if' expression from its statement (#9177) 2017-04-04 21:45:50 +02:00
Yegor
1182eb18c5 add "flaky" and "timeout_in_minutes" devicelab task options (#9168) 2017-04-04 10:46:07 -07:00
xster
4245bce545 Add full platform build speed instrumentations (#9162)
* Add new metric to size_tests instead

* Small lints
2017-04-04 01:05:53 -07:00
Adam Barth
ae8994860e Rationalize text input widgets (#9119)
After this patch, there are three major text input widgets:

 * EditableText. This widget is a low-level editing control that
   interacts with the IME and displays a blinking cursor.

 * TextField. This widget is a Material Design text field, with all the
   bells and whistles. It is highly configurable and can be reduced down
   to a fairly simple control by setting its `decoration` property to
   null.

 * TextFormField. This widget is a FormField that wraps a TextField.

This patch also replaces the InputValue data model for these widgets
with a Listenable TextEditingController, which is much more flexible.

Fixes #7031
2017-04-01 17:30:21 -07:00
Adam Barth
89aaaa9c32 Improve focus management (#9074)
We now have an explicit focus tree that we manage. Instead of using
GlobalKeys to manage focus, we use FocusNode and FocusScopeNode objects.
The FocusNode is Listenable and notifies when its focus state changes.

Focus notifications trigger by tree mutations are now delayed by one
frame, which is necessary to handle certain complex tree mutations. In
the common case of focus changes being triggered by user input, the
focus notificiation still arives in the same frame.
2017-03-31 13:10:37 -07:00
Chris Bracken
abfee824cd Re-enable iOS transitions test in devicelab (#9097)
This reverts commit 326355f0f913c954f92aa74612daa78be22755dd.
2017-03-29 19:19:57 -07:00