skia-flutter-autoroll
b4172d92d6
Roll Skia from 9a6f8dfb9102 to 46e5bf98158a (1 revision) ( flutter/engine#53775 )
...
https://skia.googlesource.com/skia.git/+log/9a6f8dfb9102..46e5bf98158a
2024-07-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 56239a1e581e to 3ab5644b59e3 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-09 06:59:35 +00:00
dependabot[bot]
02a7e2536d
Bump actions/upload-artifact from 4.3.3 to 4.3.4 ( flutter/engine#53774 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.3 to 4.3.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.3.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Update <code>@âactions/artifact</code> version, bump dependencies by <a href="https://github.com/robherley "><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/584 ">actions/upload-artifact#584</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.3...v4.3.4 ">https://github.com/actions/upload-artifact/compare/v4.3.3...v4.3.4 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0b2256b8c0https://redirect.github.com/actions/upload-artifact/issues/584 ">#584</a> from actions/robherley/bump-pkgs</li>
<li><a href="488dcefb9b04c51f576632a9e276a8552bf3722c79616d2dedhttps://redirect.github.com/actions/upload-artifact/issues/565 ">#565</a> from actions/eggyhead/use-artifact-v2.1.6</li>
<li>See full diff in <a href="65462800fd...0b2256b8c0https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.3.3&new-version=4.3.4 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-07-09 06:49:27 +00:00
skia-flutter-autoroll
5bbc45ba60
Roll Dart SDK from 0ecada960645 to 33b65d2fe034 (2 revisions) ( flutter/engine#53772 )
...
https://dart.googlesource.com/sdk.git/+log/0ecada960645..33b65d2fe034
2024-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-18.0.dev
2024-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-17.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-09 05:49:34 +00:00
skia-flutter-autoroll
24dba5994f
Roll Skia from 9edafde22cb3 to ced941fdddc4 (2 revisions) ( flutter/engine#53769 )
...
https://skia.googlesource.com/skia.git/+log/9edafde22cb3..ced941fdddc4
2024-07-08 kjlubick@google.com Remove exports_files_legacy
2024-07-08 johnstiles@google.com Use powr(x, y) in Metal instead of pow(x, y).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-09 00:15:17 +00:00
skia-flutter-autoroll
0585cb610e
Roll Dart SDK from 1679aba20a03 to 0ecada960645 (1 revision) ( flutter/engine#53767 )
...
https://dart.googlesource.com/sdk.git/+log/1679aba20a03..0ecada960645
2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-16.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-08 23:23:29 +00:00
Dustin Green
6d2812b3fe
[fuchsia][sysmem2] move to sysmem2 protocols ( flutter/engine#53138 )
...
Switch flutter from sysmem(1) protocols to sysmem2 protocols.
This is part of the overall sysmem(1) to sysmem2 migration.
fixes flutter/flutter#151154
2024-07-08 16:22:16 -07:00
Chinmay Garde
580d14040d
[Impeller] Exploit dynamic state in OpenGL for fewer program links. ( flutter/engine#53764 )
...
Fixes https://github.com/flutter/flutter/issues/145125
2024-07-08 22:54:55 +00:00
Jonah Williams
6ba3e46d9a
[Impeller] fix incorrect padding/translation in drawVertices with texture coordinates. ( flutter/engine#53746 )
...
Fixes https://github.com/flutter/flutter/issues/151355
The coverage pad introduced by renderToSnapshot is being picked up by drawVertices with texture coordinates. The pad is showing up in the final results, which can appear to be a gap between elements.
Additionally: if the coverage computed from the texture coordinates does not include the origin, then make sure the coverage used for the snapshot is translated onscreen.
2024-07-08 20:12:49 +00:00
skia-flutter-autoroll
02b5e9bbc3
Roll Skia from c65710d00047 to 9edafde22cb3 (3 revisions) ( flutter/engine#53762 )
...
https://skia.googlesource.com/skia.git/+log/c65710d00047..9edafde22cb3
2024-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3ce1fd54c58a to 14b58abf4d15 (2 revisions)
2024-07-08 kjlubick@google.com Change anonymous enums to constexpr or enum classes where appropriate
2024-07-08 johnstiles@google.com Update SkSL docs to point to named Fiddles.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-08 20:11:05 +00:00
Jonah Williams
8c0ef89160
[Impeller] implement clear color opt for experimental canvas. ( flutter/engine#53749 )
...
Fixes https://github.com/flutter/flutter/issues/150995
Rather than using a separate state bit, we can use whether the current render pass is active as an indicator for whether or not it is safe to apply the clear color optimization.
2024-07-08 20:09:22 +00:00
Jonah Williams
c4258c8457
[Impeller] add experimental canvas support to screenshotter. ( flutter/engine#53751 )
...
Fixes https://github.com/flutter/flutter/issues/150993
This change allows testing the experimental canvas dispatcher in the playgrounds, which is important for golden testing. The plan to enable requires demonstrating that the goldens are the same.
2024-07-08 20:05:08 +00:00
Chinmay Garde
609d5e2bcb
Add a host_debug_unopt local engine config for Windows. ( flutter/engine#53734 )
...
We have these configs for Linux & macOS.
2024-07-08 19:10:06 +00:00
skia-flutter-autoroll
998d1fa855
Roll Dart SDK from ffc8bb004a64 to 1679aba20a03 (16 revisions) ( flutter/engine#53761 )
...
https://dart.googlesource.com/sdk.git/+log/ffc8bb004a64..1679aba20a03
2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-15.0.dev
2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-14.0.dev
2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-13.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-12.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-11.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-10.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-9.0.dev
2024-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-8.0.dev
2024-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-7.0.dev
2024-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-6.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-5.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-4.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-3.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-2.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-1.0.dev
2024-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-0.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-08 19:10:04 +00:00
skia-flutter-autoroll
502fe2211c
Roll Skia from 38b17b22312d to c65710d00047 (2 revisions) ( flutter/engine#53758 )
...
https://skia.googlesource.com/skia.git/+log/38b17b22312d..c65710d00047
2024-07-08 michaelludwig@google.com [graphite] Simplify FragSkSLInfo based on what's actually used
2024-07-08 johnstiles@google.com Replace hash-map with array in SkRP builder.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-08 18:07:10 +00:00
skia-flutter-autoroll
d5f02e5155
Roll Skia from 1f85fb9238aa to b2c51b2fe15f (3 revisions) ( flutter/engine#53756 )
...
https://skia.googlesource.com/skia.git/+log/1f85fb9238aa..b2c51b2fe15f
2024-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from e01ce27481d2 to 3ce1fd54c58a (11 revisions)
2024-07-08 kjlubick@google.com Enforce IWYU across src/gpu/ganesh subfolders
2024-07-08 johnstiles@google.com Move `} // END FIDDLE` onto a separate line.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-08 14:22:35 +00:00
skia-flutter-autoroll
a5d815e8e9
Roll Skia from f1d06de0ae87 to 1f85fb9238aa (2 revisions) ( flutter/engine#53753 )
...
https://skia.googlesource.com/skia.git/+log/f1d06de0ae87..1f85fb9238aa
2024-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 56239a1e581e to c8809f07361f
2024-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6c155414a139 to 56239a1e581e (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-08 07:40:20 +00:00
skia-flutter-autoroll
d5835792df
Roll Fuchsia Linux SDK from unavXf_l4lhu23MGg... to RSMFdOFyLxulsvY4_... ( flutter/engine#53743 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-06 15:01:25 +00:00
Yegor
b75d1ddcac
[web] use semantic tags for headings (h1, h2, etc), and fix missing secondary roles ( flutter/engine#53703 )
...
Switch to using semantic heading tags (h1, h2, etc).
Fix missing secondary roles: focus, live region, route name, and label.
Improves indexability (https://github.com/flutter/flutter/issues/46789 )
2024-07-05 17:59:22 +00:00
skia-flutter-autoroll
690f6f8331
Roll Fuchsia Linux SDK from 5WGhpr75y_pb6u2OO... to unavXf_l4lhu23MGg... ( flutter/engine#53739 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-05 13:49:23 +00:00
skia-flutter-autoroll
064d49d547
Roll Skia from 92861012bcc1 to 4a27ce0f92d4 (4 revisions) ( flutter/engine#53738 )
...
https://skia.googlesource.com/skia.git/+log/92861012bcc1..4a27ce0f92d4
2024-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6c155414a139 to aed65f2e3de8
2024-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d35ababad9bf to 6c155414a139 (2 revisions)
2024-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a0ec371d8331 to f23c77132e0b (1 revision)
2024-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b29e25b27eda to bbac3636580e (28 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-05 07:03:05 +00:00
skia-flutter-autoroll
12d1eba7d7
Roll Fuchsia Linux SDK from -VgqOfoW5sf04SuJh... to 5WGhpr75y_pb6u2OO... ( flutter/engine#53728 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-04 12:40:08 +00:00
skia-flutter-autoroll
45ee56c602
Roll Skia from 28ba3b1b0951 to a2d00a28c563 (2 revisions) ( flutter/engine#53726 )
...
https://skia.googlesource.com/skia.git/+log/28ba3b1b0951..a2d00a28c563
2024-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3a6c4fed7cdc to 6c155414a139
2024-07-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 20c36c70094f to d35ababad9bf (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-04 09:49:22 +00:00
auto-submit[bot]
a918c608b8
Reverts "fix: mask disappeared when having nested mask filter on Flutter web HTML ( #45166 )" ( flutter/engine#53725 )
...
Reverts: flutter/engine#45166
Initiated by: jiahaog
Reason for reverting: This commit seems to cause the debug banner of a material app to be unnecessarily blurred. For example, one of the tests runs the following flutter app:
<details>
<summary>Code</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Materia
Original PR Author: Kingtous
Reviewed By: {yjbanov, harryterkelsen}
This change reverts the following previous change:
Hi from [Dora team](https://www.dora.run/ ), which powers web developers to build their 3d websites in just a few seconds.
This PR fixes: https://github.com/flutter/flutter/issues/133443 , related: https://github.com/flutter/flutter/issues/58546
The original codes attempts to cache the css string but it causes bugs when encountering nested the same mask filter blur. We should also set `filter` properties when currentFilter == incoming mask filter using the cached css string, not just ignore it.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-07-04 07:04:25 +00:00
Jonah Williams
efbf7ddc57
[Impeller] mark the end of a frame boundary for system compositor interop. ( flutter/engine#53722 )
...
Fixes https://github.com/flutter/flutter/issues/151274
This is only an issue on iOS (so far) because of the platform view rendering strategy that involves submitting multiple impeller frames per compositor frame.
FYI @bdero
2024-07-04 03:48:17 +00:00
Jim Graham
b4a744f468
[Impeller] Re-enable fast blur path for elliptical rrects ( flutter/engine#53704 )
...
Fixes https://github.com/flutter/flutter/issues/151034
Fast round rects were recently restricted to circular corners, but elliptical round rects can also go through the fast path.
2024-07-04 00:01:24 +00:00
skia-flutter-autoroll
ae3d8a7529
Roll Skia from 9fd1dc779589 to d5f8dde714e4 (2 revisions) ( flutter/engine#53721 )
...
https://skia.googlesource.com/skia.git/+log/9fd1dc779589..d5f8dde714e4
2024-07-03 johnstiles@google.com Add reserve() API to THashSet/Map.
2024-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from acaa69d72c2d to e0bb763d4c49 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 22:24:22 +00:00
Yegor
a314952184
[web] ignore pointer events on plain text spans ( flutter/engine#53694 )
...
A semantic node may be tappable without having a more concrete role set on it, such as "button". It will just have a tap handler. This could lead to the sized span to be chosen as the label representation. However, when pointer events land on the span the DOM `target` becomes the span rather than the tappable element, and that breaks the debouncing logic in `pointer_binding.dart`.
This PR removes pointer event handling from inert text spans. This fixes the click debounce logic.
Fixes https://github.com/flutter/flutter/issues/151265
2024-07-03 22:00:05 +00:00
Mouad Debbar
5fb88851d5
Add Semantics Property linkUrl ( flutter/engine#53507 )
...
The new property allows the user to specify a URI for their semantics link node. It's plumbed through for both web and non-web engines, but it's only used in the web engine currently. It sets the `href` of the anchor element associated with semantics node.
This is going to unlock better semantics support in the Link widget on web ([PR](https://github.com/flutter/packages/pull/6711 )).
Framework counterpart: https://github.com/flutter/flutter/pull/150639
Part of https://github.com/flutter/flutter/issues/150263
2024-07-03 21:12:26 +00:00
Chinmay Garde
f20ab5e458
[Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. ( flutter/engine#53720 )
...
Doesn't rename the field to maintain API compatibility. But adds a bug annotation.
Fixes https://github.com/flutter/flutter/issues/148637
2024-07-03 20:38:09 +00:00
Chinmay Garde
b6fbffe976
[Impeller] Make storage sizes typed. ( flutter/engine#53700 )
...
This is similar to our handling of degrees and radians or really any of the stuff in chrono.
Storage is always in bytes. Before being displayed, it can be converted into any of unit that makes the most sense. Conversions are non-truncating and everything is constexpr safe.
2024-07-03 19:47:10 +00:00
Matan Lurey
0e6a951a57
Convert run_ios_tests.sh to run_ios_tests.dart. ( flutter/engine#53645 )
...
Part of https://github.com/flutter/flutter/issues/143953 .
Because there are so many boundary cases, i.e. tests failed uploading artifacts to LUCI, I was _not_ planning on atomically deleting and replacing `run_ios_tests.sh`, and want to give a chance for the iOS team to try the converted code and verify it works the way they expect.
I'm also happy to just slam it on, but defer to y'all. _It works on my machine_.
---
```sh
dart run testing/scenario_app/bin/run_ios_tests.dart
```
2024-07-03 19:01:31 +00:00
Matan Lurey
ee6b0f1b2d
Move //third_party/android_embedding_dependencies to //flutter/third_party. ( flutter/engine#53587 )
...
... as part of the buildmoot effort.
I'll rebase after @gmackall's definitely-will-work-this-time bump of the dependencies.
2024-07-03 18:40:23 +00:00
Chinmay Garde
68ae17c64b
[Impeller] Document how to debug/profile OpenGL ES on macOS. ( flutter/engine#53671 )
...
This was the workflow that worked best as I was bringing up the backend. Though, the bit about Angle is new since the OpenGL stuff is no longer shipped with Xcode. I've tried to recreate those workflows as best I could.
Fixes https://github.com/flutter/flutter/issues/136760
2024-07-03 18:29:11 +00:00
Kingtous
2ee4fd4317
[Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas ( flutter/engine#44998 )
...
Hi from [Dora team](https://www.dora.run/ ), which powers web developers to build their 3d websites in just a few seconds.
This PR fixes https://github.com/flutter/flutter/issues/133134 .
The size of the shared canvas should not only be updated if both width and height are not the same.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-07-03 18:22:59 +00:00
Kingtous
86642a856c
fix: mask disappeared when having nested mask filter on Flutter web HTML ( flutter/engine#45166 )
...
Hi from [Dora team](https://www.dora.run/ ), which powers web developers to build their 3d websites in just a few seconds.
This PR fixes: https://github.com/flutter/flutter/issues/133443 , related: https://github.com/flutter/flutter/issues/58546
The original codes attempts to cache the css string but it causes bugs when encountering nested the same mask filter blur. We should also set `filter` properties when currentFilter == incoming mask filter using the cached css string, not just ignore it.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-07-03 18:22:56 +00:00
skia-flutter-autoroll
911e2b729a
Roll Skia from 86ee8cc61508 to 9fd1dc779589 (3 revisions) ( flutter/engine#53715 )
...
https://skia.googlesource.com/skia.git/+log/86ee8cc61508..9fd1dc779589
2024-07-03 robertphillips@google.com [graphite] Add missing consts to PrecompileShader
2024-07-03 jvanverth@google.com [graphite] Change primitiveColor to use block class.
2024-07-03 johnstiles@google.com Reland "Ensure that hash-map capacity is a power of two."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 18:19:07 +00:00
skia-flutter-autoroll
8ab9611ddb
Roll Skia from c14cce59222b to 86ee8cc61508 (1 revision) ( flutter/engine#53713 )
...
https://skia.googlesource.com/skia.git/+log/c14cce59222b..86ee8cc61508
2024-07-03 johnstiles@google.com Revert "Use kCTFontVariationAxesAttribute"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 16:02:30 +00:00
skia-flutter-autoroll
dd1150d0f3
Roll Skia from 92f928d81a27 to c14cce59222b (1 revision) ( flutter/engine#53712 )
...
https://skia.googlesource.com/skia.git/+log/92f928d81a27..c14cce59222b
2024-07-03 johnstiles@google.com Revert "Ensure that hash-map capacity is a power of two."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 14:19:24 +00:00
skia-flutter-autoroll
bdc96d0053
Roll Fuchsia Linux SDK from x5Sccm0dUoMVbnyed... to -VgqOfoW5sf04SuJh... ( flutter/engine#53711 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 11:37:24 +00:00
auto-submit[bot]
607d1e1bb5
Reverts "Reland "Output .js files as ES6 modules. ( #52023 )" ( #53688 )" ( flutter/engine#53709 )
...
Reverts: flutter/engine#53688
Initiated by: jiahaog
Reason for reverting: canvaskit.js cannot be loaded in an internal end to end test - see b/350885206
Original PR Author: eyebrowsoffire
Reviewed By: {ditman}
This change reverts the following previous change:
This is an attempt to reland https://github.com/flutter/engine/pull/52023 . The issue previously is that if it was not specified by the user, the default CanvasKit base URL did not have a leading slash, which does not work when doing dynamic imports.
2024-07-03 08:39:47 +00:00
skia-flutter-autoroll
650123048d
Roll Skia from 62c7020b7b36 to d78676d54cb5 (2 revisions) ( flutter/engine#53707 )
...
https://skia.googlesource.com/skia.git/+log/62c7020b7b36..d78676d54cb5
2024-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from dec60c04e52d to d35ababad9bf
2024-07-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a06878f25d87 to 20c36c70094f (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 07:12:24 +00:00
Jia Hao
667bd9dd55
Revert "Reland [DisplayList] Add support for clipOval to leverage Impeller optimization" ( flutter/engine#53705 )
...
Reverts flutter/engine#53642
This change causes 10k golden updates internally and we need to land this out of band (go/lssc). There is also an existing issue with one particular client screenshot test - see b/350129213 for more details.
2024-07-03 04:25:18 +00:00
Jackson Gardner
18d37a44f5
Reland "Output .js files as ES6 modules. ( #52023 )" ( flutter/engine#53688 )
...
This is an attempt to reland https://github.com/flutter/engine/pull/52023 . The issue previously is that if it was not specified by the user, the default CanvasKit base URL did not have a leading slash, which does not work when doing dynamic imports.
2024-07-03 00:56:13 +00:00
skia-flutter-autoroll
992d964f6d
Roll Skia from c1f2dd0fc5f6 to d02998fba957 (2 revisions) ( flutter/engine#53699 )
...
https://skia.googlesource.com/skia.git/+log/c1f2dd0fc5f6..d02998fba957
2024-07-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5faad80a00af to 78e9bb7c88ab (5 revisions)
2024-07-02 michaelludwig@google.com [graphite] Remove ShaderSnippet expression generator function
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 22:10:58 +00:00
skia-flutter-autoroll
fe458a0bc5
Roll Skia from c0ee0e108900 to c1f2dd0fc5f6 (2 revisions) ( flutter/engine#53697 )
...
https://skia.googlesource.com/skia.git/+log/c0ee0e108900..c1f2dd0fc5f6
2024-07-02 bungeman@google.com Use kCTFontVariationAxesAttribute
2024-07-02 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 49474af63de0 to 1f63622eec4c (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 20:50:09 +00:00
Jim Graham
702c6cec66
[Impeller] fix typo in setup for fast elliptical rrect blurs ( flutter/engine#53673 )
...
This typo was discovered while converting the AIKS tests to DisplayList - the new test executes correctly, but the old test generated bad goldens due to this typo. Fixing the typo to fix the golden prior to landing the test conversion.
The fix should be covered by existing tests - in fact the change is correcting an already bad golden test to correct behavior.
2024-07-02 20:44:16 +00:00
gaaclarke
2f24c4214f
[Impeller] fixed units for memory measurement ( flutter/engine#53687 )
...
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-07-02 18:32:12 +00:00
hangyu
d6cff07930
[deep link][ios] Update openURL method to reflect the result from framework ( flutter/engine#52643 )
...
follow up on comments on https://github.com/flutter/engine/pull/52350
framework pr : https://github.com/flutter/flutter/pull/147901
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-07-02 11:25:39 -07:00
skia-flutter-autoroll
130975a768
Manual roll Dart SDK from c23e58143793 to ffc8bb004a64 (2 revisions) ( flutter/engine#53690 )
...
Manual roll requested by kevinjchisholm@google.com
https://dart.googlesource.com/sdk.git/+log/c23e58143793..ffc8bb004a64
2024-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-323.0.dev
2024-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-322.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com,kevinjchisholm@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 18:14:51 +00:00
skia-flutter-autoroll
8b26d815ae
Roll Skia from 42fad315c162 to c0ee0e108900 (1 revision) ( flutter/engine#53691 )
...
https://skia.googlesource.com/skia.git/+log/42fad315c162..c0ee0e108900
2024-07-02 johnstiles@google.com Ensure that hash-map capacity is a power of two.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 18:11:09 +00:00
