firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,334 Commits 1 Branch 0 Tags
Commit Graph

36334 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
f0e8927fff Roll Skia from 173ee0af82c9 to 55ada83438cd (3 revisions) (flutter/engine#53596) 
https://skia.googlesource.com/skia.git/+log/173ee0af82c9..55ada83438cd

2024-06-26 nscobie@google.com Add (CoGS) team ownership to Android.bp's CtsSkQPTestCases
2024-06-26 bungeman@google.com Roll gn
2024-06-26 lehoangquyen@google.com GraphiteDawn: increase number of cached UBO bindgroups

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 22:12:19 +00:00
Jason Simmons
0954220cbf Return a null image from ImageExternalTextureGL::CreateEGLImage if an EGL display is not available (flutter/engine#53594) 
Previously CreateEGLImage had been failing an assertion if an EGL display is not active on the calling thread.  CreateEGLImage should not assert here because it could be called from a deferred task that runs after the raster thread has lost its EGL state.

See https://github.com/flutter/flutter/issues/149396
 2024-06-26 22:10:18 +00:00
gaaclarke
4629bf49ff [Impeller] blur - cropped the downsample pass for backdrop filters (flutter/engine#53562) 
This should be no functional change, just makes the case of clipped backdrop filters take up less memory.

fixes: https://github.com/flutter/flutter/issues/150713

test coverage:
- the framework's "backdrop filter" test
- GaussianBlurAnimatedBackdrop

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-26 21:23:10 +00:00
skia-flutter-autoroll
a4e8769d78 Roll Skia from 0a979d9f3606 to 173ee0af82c9 (2 revisions) (flutter/engine#53593) 
https://skia.googlesource.com/skia.git/+log/0a979d9f3606..173ee0af82c9

2024-06-26 nathanasanchez@google.com [Graphite] Consolidate ssbo caps
2024-06-26 brianosman@google.com Fix asymmetry in lattice validation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 20:42:09 +00:00
Matan Lurey
75a2393b53 Remove otherwise unused third_party/web_dependencies. (flutter/engine#53588) 
There are no usages other than the reference in the LICENSE checker.
 2024-06-26 20:40:04 +00:00
Matan Lurey
af854d0c7b Copy flutter/flutter/docs/engine to flutter/engine/docs as-is (no changes) (flutter/engine#53595) 
See https://github.com/flutter/flutter/issues/150869.
 2024-06-26 13:35:07 -07:00
skia-flutter-autoroll
e0700b7c71 Roll Dart SDK from 38bb74f63829 to c01f907d34d8 (5 revisions) (flutter/engine#53585) 
https://dart.googlesource.com/sdk.git/+log/38bb74f63829..c01f907d34d8

2024-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-304.0.dev
2024-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-303.0.dev
2024-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-302.0.dev
2024-06-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-301.0.dev
2024-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-300.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 20:02:19 +00:00
Matan Lurey
df2c6daa5a Replace Log.w with Log.d, and tidy the file up a bit. (flutter/engine#53586) 
Closes https://github.com/flutter/flutter/issues/150849.

(Almost all of these are mechanical auto-fix changes from Android Studio/Best Practices).
 2024-06-26 19:31:02 +00:00
skia-flutter-autoroll
4d2d538709 Roll Skia from 695d35a0559e to 0a979d9f3606 (3 revisions) (flutter/engine#53591) 
https://skia.googlesource.com/skia.git/+log/695d35a0559e..0a979d9f3606

2024-06-26 lehoangquyen@google.com GraphiteDawn: Use larger static storage for bindgroup keys.
2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1c484942880c to 782b625ca1dc (3 revisions)
2024-06-26 bungeman@google.com Roll ninja

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 19:20:20 +00:00
Matan Lurey
0c9f812104 Move impeller-cmake-example to flutter/third_party. (flutter/engine#53589) 
... as part of buildmoot.

I _think_ this is all that is needed but am not confident.
 2024-06-26 18:59:18 +00:00
skia-flutter-autoroll
937568d312 Roll Skia from e836fa986829 to 695d35a0559e (1 revision) (flutter/engine#53584) 
https://skia.googlesource.com/skia.git/+log/e836fa986829..695d35a0559e

2024-06-26 michaelludwig@google.com [graphite] Use sk_FragCoord for dithering

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 18:08:08 +00:00
Jason Simmons
729599f786 Roll the archive package to version 3.6.1 (flutter/engine#53582) 
This version does not use the deprecated UnmodifiableInt32ListView API.
 2024-06-26 16:54:20 +00:00
skia-flutter-autoroll
ad34e76d60 Roll Skia from 354b30fe7ab5 to e836fa986829 (3 revisions) (flutter/engine#53583) 
https://skia.googlesource.com/skia.git/+log/354b30fe7ab5..e836fa986829

2024-06-26 nathanasanchez@google.com [Graphite] Remove hard-coded buffer indices
2024-06-26 michaelludwig@google.com [graphite] Consolidate built-in shader-snippet tables
2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 72fd79ddaace to 79660091faba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 16:48:23 +00:00
Srujan Gaddam
554e637a35 Ignore lints that will be triggered by ExternalDartReference changes (flutter/engine#53572) 
https://dart-review.googlesource.com/c/sdk/+/370663 makes
ExternalDartReference generic. By doing so, it triggers two
cast_nullable_to_non_nullable lints that need to be silenced for it to
land. Once the above SDK changes land, this can be refactored to utilize
the generic and avoid the manual cast altogether.
 2024-06-26 09:32:08 -07:00
skia-flutter-autoroll
1a21f12d44 Roll Skia from 79587650d153 to 354b30fe7ab5 (2 revisions) (flutter/engine#53580) 
https://skia.googlesource.com/skia.git/+log/79587650d153..354b30fe7ab5

2024-06-26 zhusida@bytedance.com Reland "Add 16bit BT2020, YCGCO color space support"
2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 720ace3b91cf to fa24f1553bec (16 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 14:55:23 +00:00
skia-flutter-autoroll
3fc934ad52 Roll Skia from 7e85023a57b7 to 79587650d153 (1 revision) (flutter/engine#53578) 
https://skia.googlesource.com/skia.git/+log/7e85023a57b7..79587650d153

2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 016ef60d5f12 to 046327343595 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 09:51:23 +00:00
skia-flutter-autoroll
bf5d10e4c7 Roll Skia from 0c9a66786ba1 to 7e85023a57b7 (3 revisions) (flutter/engine#53577) 
https://skia.googlesource.com/skia.git/+log/0c9a66786ba1..7e85023a57b7

2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from de870ac7518f to a0ec371d8331 (2 revisions)
2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from dc1551316ebe to 720ace3b91cf (13 revisions)
2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d6925c2a17cc to 72fd79ddaace (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 07:01:23 +00:00
skia-flutter-autoroll
c48ae84b8a Roll Skia from 7cbcb2f0e818 to 0c9a66786ba1 (1 revision) (flutter/engine#53576) 
https://skia.googlesource.com/skia.git/+log/7cbcb2f0e818..0c9a66786ba1

2024-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 465cc29f79bc to 1c484942880c (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 05:38:57 +00:00
skia-flutter-autoroll
89d213c19f Roll Fuchsia Linux SDK from WUN7NQK04NjF9fRmf... to n2dgSmMCaCO7ujvmr... (flutter/engine#53575) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-26 02:43:34 +00:00
Jenn Magder
53573f860f Remove FlutterUndoManagerPlugin handlers from undo manager on dealloc (flutter/engine#53553) 
When `FlutterUndoManagerPlugin` deallocated, it is supposed to deregister itself from the `NSUndoManager` stack.
However, during dealloc `_undoManagerDelegate.undoManager` is nil (`_undoManagerDelegate` = the engine, and `undoManager` was its view controller's `undoManager`, which was already gone).

Since `_undoManagerDelegate.undoManager` is nil, it doesn't actually call `-[NSUndoManager removeAllActionsWithTarget]`. In the add-to-app scenario, after the view controller pops back to the native view, and "undo" is invoked, the undo action for the `FlutterUndoManagerPlugin` is handled, but it already dealloced so crash.

Fixes https://github.com/flutter/flutter/issues/150408

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-25 23:54:26 +00:00
skia-flutter-autoroll
335e888cf5 Roll Skia from ea8ec1a618b0 to 7cbcb2f0e818 (4 revisions) (flutter/engine#53573) 
https://skia.googlesource.com/skia.git/+log/ea8ec1a618b0..7cbcb2f0e818

2024-06-25 bungeman@google.com Update CMake generator compile flags
2024-06-25 robertphillips@google.com [graphite] Make PrecompileMaskFilter part of the public Precompile API
2024-06-25 brianosman@google.com Remove SK_LEGACY_RECT_DASHING_BUG
2024-06-25 jvanverth@google.com Change wacky_yuv GMs to split full colorspaces from limited.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 23:22:13 +00:00
skia-flutter-autoroll
320cedb30b Roll Dart SDK from 65ab2f2cf0d3 to 38bb74f63829 (1 revision) (flutter/engine#53570) 
https://dart.googlesource.com/sdk.git/+log/65ab2f2cf0d3..38bb74f63829

2024-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-299.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 22:04:01 +00:00
skia-flutter-autoroll
955f256773 Roll Skia from 04133a5bf21f to ea8ec1a618b0 (3 revisions) (flutter/engine#53569) 
https://skia.googlesource.com/skia.git/+log/04133a5bf21f..ea8ec1a618b0

2024-06-25 gavinmak@google.com Support _RegenerateAllExamplesCPP on cog
2024-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 9365edbe34f5 to 465cc29f79bc (6 revisions)
2024-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from b1c855cdc6b7 to dc1551316ebe (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 21:54:14 +00:00
skia-flutter-autoroll
0e447eedb8 Roll Skia from da1ea4eb0270 to 04133a5bf21f (2 revisions) (flutter/engine#53566) 
https://skia.googlesource.com/skia.git/+log/da1ea4eb0270..04133a5bf21f

2024-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 3c472b45024a to 016ef60d5f12 (12 revisions)
2024-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from b6d4a58d3894 to b1c855cdc6b7 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 19:52:02 +00:00
Jackson Gardner
8ab7c5d6e9 [skwasm] Fixes for getting pixels from an image. (flutter/engine#53561) 
There were two issues here:

1) We have to stop using the emscripten thread scheduling APIs, as they can be invoked out of order from the rest of the messages that are posted. In some cases, out of order message handling can cause the request for reading pixels in an image to be serviced before some of the texture sources have been transfered to the web worker.

2) Skia's `readPixels` fails if there is is a lazy picture image made from a picture that contains a lazy texture image. The pertinent bug is here: https://g-issues.skia.org/issues/349201915

To work around the Skia bug, we just render the image itself onto our scratch canvas and pull the pixels out with `glReadPixels`.

This fixes https://github.com/flutter/flutter/issues/141326
 2024-06-25 18:11:11 +00:00
Jason Parrott
384f44cafc fix: web canvaskit fragment shaders were not using updated uniform values (flutter/engine#53246) 
This fixes an issue where in CanvasKit builds, uniforms set in setFloat function in the Paint class don't get updated after the initial render.
For example, like in the issue linked below, having a shader that animates a value over time and you want to reuse the Paint object that the shader is set to.

I'm no expert with CanvasKit nor with the Flutter Engine, but from what I could tell it seemed that the uniforms were only being sent to Skia on creation of the shader via _makeEffect.

However, any uniforms set afterwords were just stored in a local dart-side List<double> and forgotten about.

This PR changes the List<double> to use a WASM backed SkFloat32List to keep the references to the uniforms linked to dart-side.

fixes https://github.com/flutter/flutter/issues/149800
 2024-06-25 17:59:24 +00:00
skia-flutter-autoroll
7a5d676a11 Roll Dart SDK from b5fc85cfcf1b to 65ab2f2cf0d3 (1 revision) (flutter/engine#53565) 
https://dart.googlesource.com/sdk.git/+log/b5fc85cfcf1b..65ab2f2cf0d3

2024-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-298.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 17:47:48 +00:00
skia-flutter-autoroll
5225f96978 Roll Skia from e4e4feb97a54 to da1ea4eb0270 (4 revisions) (flutter/engine#53563) 
https://skia.googlesource.com/skia.git/+log/e4e4feb97a54..da1ea4eb0270

2024-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from b65ac9ea6f70 to b6d4a58d3894 (87 revisions)
2024-06-25 robertphillips@google.com [graphite] Expand CombinationBuilderTest for Precompile colorfilters
2024-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d6925c2a17cc to 6daad90c6420
2024-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ff63e67e4739 to 9365edbe34f5 (12 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 17:47:47 +00:00
Jim Graham
34bb05029e [DisplayList] Switch to recording DrawVertices objects by reference (flutter/engine#53548) 
The Vertices objects are already allocated in a shared object by default so copying them inline into the recording buffer is usually a waste of time rather than reusing the memory allocated for the shared object by recording a reference. Note that the shared DlVertices objects already inline all of their data so we have good data locality as it is without further copying the data into the buffer.

Might help with https://github.com/flutter/flutter/issues/150513
 2024-06-25 17:41:14 +00:00
skia-flutter-autoroll
af59a1f298 Roll Skia from 5f21260470cf to e4e4feb97a54 (1 revision) (flutter/engine#53559) 
https://skia.googlesource.com/skia.git/+log/5f21260470cf..e4e4feb97a54

2024-06-25 nicolettep@google.com Revert "Add 16bit BT2020, YCGCO color space support"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 16:24:02 +00:00
gaaclarke
956c30fbf3 [impeller] Cleanup blur (flutter/engine#53543) 
This is a refactor, no functional change.

We have a few issues in flight that talk about improving the blur. This
attempts to clean everything up a bit to make it easier for us to
change.


issues: 
- https://github.com/flutter/flutter/issues/150713
- https://github.com/flutter/flutter/issues/150722
- https://github.com/flutter/flutter/issues/150720

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-06-25 08:35:37 -07:00
skia-flutter-autoroll
712cb91027 Roll Skia from 3029f75db702 to 5f21260470cf (2 revisions) (flutter/engine#53557) 
https://skia.googlesource.com/skia.git/+log/3029f75db702..5f21260470cf

2024-06-25 lokokung@google.com Use spontaneous mode for device lost callback in Dawn.
2024-06-25 kjlubick@google.com Update cmake to v3.29.0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 15:02:05 +00:00
Mouad Debbar
2d762001d3 [web] Implement AppLifecycleState.detached as documented (flutter/engine#53506) 
Currently, we are transitioning to the `AppLifecycleState.detached` incorrectly. This is causing the framework to stop pumping frames when the app is still active and visible.

This PR re-implements the transition to `AppLifecycleState.detached` as documented [here](https://api.flutter.dev/flutter/dart-ui/AppLifecycleState.html#detached) (based on whether the app has any views or not).

Fixes https://github.com/flutter/flutter/issues/150636
Fixes https://github.com/flutter/flutter/issues/149417
 2024-06-25 14:14:17 +00:00
skia-flutter-autoroll
833ddf5993 Roll Skia from 335200e57c26 to 3029f75db702 (2 revisions) (flutter/engine#53554) 
https://skia.googlesource.com/skia.git/+log/335200e57c26..3029f75db702

2024-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e080995c5d21 to d6925c2a17cc (4 revisions)
2024-06-25 michaelludwig@google.com Fix NPE in Tagged Images slide

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 10:12:21 +00:00
skia-flutter-autoroll
52fd0b4db7 Roll Dart SDK from bb18127b2a8e to b5fc85cfcf1b (1 revision) (flutter/engine#53552) 
https://dart.googlesource.com/sdk.git/+log/bb18127b2a8e..b5fc85cfcf1b

2024-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-297.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 06:53:24 +00:00
skia-flutter-autoroll
3d334399ff Roll Skia from 5feca3095719 to 335200e57c26 (1 revision) (flutter/engine#53549) 
https://skia.googlesource.com/skia.git/+log/5feca3095719..335200e57c26

2024-06-25 michaelludwig@google.com [graphite] Fix conic_sk_conical_grad_buf_shader signature

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 03:49:08 +00:00
skia-flutter-autoroll
51f6668176 Roll Dart SDK from c187d4b3ec88 to bb18127b2a8e (1 revision) (flutter/engine#53547) 
https://dart.googlesource.com/sdk.git/+log/c187d4b3ec88..bb18127b2a8e

2024-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-296.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 02:15:27 +00:00
skia-flutter-autoroll
d767e405d3 Roll Fuchsia Linux SDK from _6HNhJ6G59VMceKoN... to WUN7NQK04NjF9fRmf... (flutter/engine#53545) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 01:41:05 +00:00
auto-submit[bot]
c352f44015 Reverts "Re-re-land "Upgrade all[most] androidx dependencies to latest" (#53532)" (flutter/engine#53546) 
Reverts: flutter/engine#53532
Initiated by: gmackall
Reason for reverting: This breaks apps that use plugins that use compileSdk 31, some of which we use in our postsubmit (so it blocks the tree).
Original PR Author: gmackall

Reviewed By: {reidbaker, matanlurey}

This change reverts the following previous change:
Re-re-land https://github.com/flutter/engine/pull/53001

(Reland attempt was at https://github.com/flutter/engine/pull/53462)

Unblocked by https://github.com/flutter/flutter/pull/150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles.

Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on https://github.com/flutter/flutter/issues/149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-25 01:20:29 +00:00
Brandon DeRosier
42a12876fa Bump impeller-cmake-example (flutter/engine#53538) 
- impeller-cmake: https://github.com/bdero/impeller-cmake/pull/25
- impeller-cmake-example: https://github.com/bdero/impeller-cmake-example/pull/23
 2024-06-25 00:13:06 +00:00
skia-flutter-autoroll
87ea39e626 Roll Skia from e20c8b0bac0c to 5feca3095719 (1 revision) (flutter/engine#53544) 
https://skia.googlesource.com/skia.git/+log/e20c8b0bac0c..5feca3095719

2024-06-24 zhusida@bytedance.com Add 16bit BT2020, YCGCO color space support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 23:25:23 +00:00
David Iglesias
0131b53f3c [web] Reland "Fix focus management for text fields (#51009)" (flutter/engine#53537) 
Relands: [**Fix focus management for text fields** (#51009)](https://github.com/flutter/engine/pull/51009) by:

* Reverting commit: 249de68438 (https://github.com/flutter/engine/pull/53502).
* Keeping the new `ViewFocusBinding` disabled, as [suggested](https://github.com/flutter/engine/pull/51009#discussion_r1649500122).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-24 22:15:11 +00:00
skia-flutter-autoroll
f3c89d8f97 Roll Dart SDK from 5df89347bddf to c187d4b3ec88 (1 revision) (flutter/engine#53542) 
https://dart.googlesource.com/sdk.git/+log/5df89347bddf..c187d4b3ec88

2024-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-295.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 22:05:38 +00:00
Chris Bracken
ab3c5ba987 [macOS] Generate universal gen_snapshots (flutter/engine#53524) 
This reverts commit b16181fe6adf18f448058fd4e68ceb4f78f601ab (#52913).
This relands commit f73900ba16ab3873c7f631ab321d4f0ac0194a8e (#52885).

Previously, the `gen_snapshot_arm64` and `gen_snapshot_x64` binaries used by the tool were all built for x64 architecture. As such, developers building apps with Flutter rely on Rosetta translation with every build.

This refactors the gen_snapshot build rules on macOS hosts to consistently produce `gen_snapshot_arm64` and `gen_snapshot_x64` binaries with the target architecture of the build but with as universal binaries with both host architectures.

## arm64 host build

Prior to this patch we emitted:
* gen_snapshot_arm64 (arch: x64, target_arch: simarm64)

After this patch, we emit:
* artifacts_x64/gen_snapshot_arm64 (arch: x64, target_arch: simarm64)
* artifacts_arm64/gen_snapshot_arm64 (arch: arm64, target_arch: arm64)
* gen_snapshot_arm64 (universal binary composed of both of the above)

## x64 host build

Prior to this patch we emitted:
* gen_snapshot_x64 (arch: x64, target_arch: x64)

After this patch, we emit:
* artifacts_x64/gen_snapshot_x64 (arch: x64, target_arch: x64)
* artifacts_arm64/gen_snapshot_x64 (arch: arm64, target_arch: simx64)
* gen_snapshot_x64 (universal binary composed of both of the above)

Note that host builds on macOS currently default to a host architecture of x64 (can be overridden via `--force-mac-arm64`) regardless of host architecture and thus, the build itself relies on Rosetta translation when invoked on Apple Silicon arm64 hardware. This is to ensure a consistent build in CI regardless of bot architecture. See: 0d2b0cd0ed/tools/gn (L502-L505)

Issue: https://github.com/flutter/flutter/issues/101138
Issue: https://github.com/flutter/flutter/issues/69157

Related issue: https://github.com/flutter/flutter/issues/103386

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-24 22:01:09 +00:00
Gray Mackall
f9b2f290ba Re-re-land "Upgrade all[most] androidx dependencies to latest" (flutter/engine#53532) 
Re-re-land https://github.com/flutter/engine/pull/53001

(Reland attempt was at https://github.com/flutter/engine/pull/53462)

Unblocked by https://github.com/flutter/flutter/pull/150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles.

Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on https://github.com/flutter/flutter/issues/149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-24 21:36:22 +00:00
skia-flutter-autoroll
38ce0e731f Roll Skia from 1948fd53e280 to e20c8b0bac0c (1 revision) (flutter/engine#53540) 
https://skia.googlesource.com/skia.git/+log/1948fd53e280..e20c8b0bac0c

2024-06-24 mike@reedtribe.org API to return a scaled version of an image

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 20:52:21 +00:00
skia-flutter-autoroll
a6aa2a974a Roll Skia from 0fa58b6ddba0 to 1948fd53e280 (2 revisions) (flutter/engine#53536) 
https://skia.googlesource.com/skia.git/+log/0fa58b6ddba0..1948fd53e280

2024-06-24 brianosman@google.com Remove asserts about "valid" premultiplied colors in SkPackARGB32
2024-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e53b3ad72322 to 3c472b45024a (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 19:33:23 +00:00
skia-flutter-autoroll
941a47b78c Roll Skia from ea84df425483 to 0fa58b6ddba0 (3 revisions) (flutter/engine#53535) 
https://skia.googlesource.com/skia.git/+log/ea84df425483..0fa58b6ddba0

2024-06-24 michaelludwig@google.com [graphite] Add validation for PaintParamsKeyBuilder::addData
2024-06-24 kjlubick@google.com Build skslc and sksl-minify from the modular Bazel build.
2024-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a8b46766c4e to ff63e67e4739 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 18:16:19 +00:00
gaaclarke
b6e6849f95 [Impeller] added a fallback that will make sure the blur fragment shader doesn't overflow (flutter/engine#53466) 
issue: https://github.com/flutter/flutter/issues/150462

This makes that usage never crash.  I would like to reevaluate for a better fix later though.  Something like:
1) Rework the downsample logic to make sure this gap doesn't exist.
1) Simply increase the kernel size.  We already did that before and technically we should be clamped to the 500 sigma so we won't have to do it forever.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-24 18:01:00 +00:00
Jonny Wang
c2f5afd59a [fuchsia] Update Fuchsia API level to 19 (flutter/engine#53494) 
Update Fuchsia API level to 19

b/347290402

Tests: cl/645133515

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-06-24 18:56:40 +01:00