This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.
It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.
I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.
For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
This stops reading from pipe-to-file log after the build is completed. Attempting to read from pipe-to-file keeps open blocked because nobody is going to write into that pipe.
It's not usual for this not to be set, but it affected at least one user (#23909) and there are a non-zero number of people online saying it's not set. It's better that we don't crash.
Fixes#23909.
`RenderEditable.paint` assumes that if the length of the text fits within the
visible region, then the text will be rendered at the start of the region and be
completely visible. This is not always true, since the text may still be
rendered at an offset if an animation is ongoing when the text begins to fit.
This fixes#22288 and #14121
d9c2b215ab...0ec3b7d437
git log d9c2b215abda..0ec3b7d437d4 --no-merges --oneline
0ec3b7d43 Apply changes to the embedded UIView tree when presenting a frame (flutter/engine#6712)
92944f72f Move FlutterPlatformViewsController into FlutterEngine. (flutter/engine#6709)
d34cb1757 Roll src/third_party/skia 9985a27c06ad..348a03729796 (15 commits) (flutter/engine#6710)
a27d2f2bc Check needs_painting in RasterCache::Prepare (flutter/engine#6708)
552fae60c Roll src/third_party/skia 83d923f38664..9985a27c06ad (2 commits) (flutter/engine#6707)
67ba69717 Roll src/third_party/skia 4d8f48db9ef5..83d923f38664 (2 commits) (flutter/engine#6706)
54882ef86 Roll src/third_party/skia 69a72945dcdd..4d8f48db9ef5 (1 commits) (flutter/engine#6705)
635e20498 Roll src/third_party/skia 1801b94e85b4..69a72945dcdd (1 commits) (flutter/engine#6704)
059876ea9 Delay embedded UIViews touch events until the framework says so. (flutter/engine#6665)
605ae5d88 Roll src/third_party/skia 4c169456061d..1801b94e85b4 (2 commits) (flutter/engine#6703)
d8672baaa Ensure Simulator publishes mDNS records (flutter/engine#6696)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
* Use Xcode build configurations to drive Flutter build mode
* Proper check wrt local_engine, print error if profile mode misisng
* Remove unused code, update tests, fix template problem, update warning
* fix up warning
* add explanatory dev comment
* fix whitespace
* missing words, change lambda arrow to function body
* error indentation
* Test early exits for xcode_backend.sh
* only on macOS, use right test
* Update error messages
* case insensitive compare for build config
* Update gallery podfile
* update projects to add profile configuration
* make compatible with flavors
* add missing plist files
* add FLUTTER_FRAMEWORK_DIR back, set swift version for profile, tell Podfile about profile
Re-landing #23412 with a fix to the PlatformLayer's addToScene signature.
#23412 was broken by the change to Layer done in #23434.
It seemed green as the presubmits were done before #23434 was landed, and when #23412 landed it broke the build.
Reverts #23779
This PR adds the full framework stack (layer->render object->widget, and
service) for embedding iOS views with minimal functionality.
I allowed myself to throw the entire framework stack in one PR since we're mostly
mirroring the structure we already established for embedded Android views, so this PR
is a little bigger than usual. I'm happy to break it down to the
different pieces of the stack if reviewers prefer.
Specifically this PR adds:
* A UiKitView widget for embedding a UIView in the widget tree.
* A RenderUiKitView which is the render object for showing a
UIView.
* A PlatformViewLayer which denotes the position of a UIView in the
layer tree.
* The iOS platform_views system channel client code in services/platform_views.dart
* Splits the fake platform views controller to an Android and iOS
controllers.
TBD in following PRs:
* Plumb the layout direction all the way to the platform view (currently
there is still no engine support for it).
* Integrate with gesture arenas (engine support is still missing as
well).
