14492 Commits

Author SHA1 Message Date
Jacob MacDonald
b95c3d7d56
update stack_trace dep (and others) (#67057) 2020-10-01 09:54:07 -07:00
Dan Field
a7954691da
Dispose of images after using them (#66688)
* Dispose of images after using them
Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf.
Makes all stateful holders of ui.Image objects properly clone and dispose of them.
Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created.
Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
2020-10-01 09:48:54 -07:00
Rami
79400b2462
[Material] Update some semantics for time picker controls (#66652) 2020-10-01 09:06:46 -04:00
Alexandre Ardhuin
9d41ddcbac
migrate some material files to nullsafety (#66985)
* migrate some material files to nullsafety

* fix test_private

* address review comments

* fix private test on windows

* use uri in include entry of analysis_options
2020-10-01 08:01:58 +02:00
Phil Quitslund
d3155658bc
API docs for typedefs. (#67003) 2020-09-30 19:32:02 -07:00
Dan Field
25f44bb271
test (#67021) 2020-09-30 18:02:04 -07:00
Michael Goderbauer
19e07d2beb
Migrate flutter_test (#66663) 2020-09-30 17:03:40 -07:00
Madhur Maurya
2de1c8da47
Nested Scaffolds Documentation Improvement (#66972) 2020-10-01 07:55:15 +08:00
Jenn Magder
36fca52c0d
Replace MockArtifacts with Artifacts.test() (#67012) 2020-09-30 16:25:29 -07:00
stuartmorgan
b92bb62d4d
Fix Windows and Linux plugin template filenames (#66997) 2020-09-30 16:07:03 -07:00
Jonah Williams
b6768ec7a6
[flutter_tools] dont let crash reporter crash tool (#66755)
package:http can throw a ClientException, which the crash reporter must catch or the tool will crash in the crash reporter. 3/4 crash on dev.
2020-09-30 15:26:25 -07:00
Jonah Williams
0f90747bb3
[flutter_tool] enable single widget reload optimization by default on dev (#66995)
Continued gradual rollout - dev is not that much riskier than master but will give much more data
2020-09-30 15:10:51 -07:00
Mehmet Fidanboylu
95d72bf9d8
Clarify the docs on what scrollUntilVisible does (#65817) 2020-09-30 14:58:13 -07:00
Anhad Singh
64a23504bb
Added transformAlignment for container (#66201) 2020-09-30 14:55:58 -07:00
Jenn Magder
becaf4913f
Replace MockCache with Cache.test() (#66946) 2020-09-30 14:53:57 -07:00
Pedro Massango
f800a67ee4
[fix] once errorBuilder is called Image widget stops loading images (#65180) 2020-09-30 14:53:05 -07:00
Jason Simmons
e5de2b08b8
Text test should check that a paragraph's longest line is not greater than the width constraint (#67000) 2020-09-30 14:52:08 -07:00
Jonah Williams
fe22d196fc
[flutter_tools] prevent running analyze-size with split-debug-info (#66983)
Running a build command with split debug info and analyze size causes a crash in the snapshot analysis library. Disable the combination of these two flags.

Fixes #66962
2020-09-30 11:15:49 -07:00
Helin Shiah
9ca15d0118
Set DDS port to requested observatory port for test (#66607)
* Set DDS port to requested observatory port for test

* Add test for DDS and observatory ports

* Use FakePlatform instead of mock, fix spacing

* Use FakeProcessManager instead of mock

* Fix analyze issue

* Make completer private and add fn for future
2020-09-30 10:14:13 -07:00
Jonah Williams
f8750b16bb
[flutter_tools] do not error doctor on missing vs code extension (#66780)
In cases where the VSCode plugins are not located, display links to where they can be downloaded but do not surface an error.
2020-09-30 08:41:31 -07:00
Jonah Williams
e819f292b3
[flutter_tools] do not require a dependency on devtools server (#66842)
Re-arrange the implementation of the devtools launcher so that google3 is not required to depend on any devtools packages. Also renames the build_runner folders to isolated to better clarify their intention.
2020-09-29 18:15:56 -07:00
Jenn Magder
e8fbb43aac
Replace MockFile with memory file system files (#66941) 2020-09-29 17:50:33 -07:00
Jonah Williams
9bc533c9e5
[flutter_tools] do not error flutter doctor on missing AS/intellij plugins (#66782)
In cases where the Intellij/AS plugins are not located, display links to where they can be downloaded but do not surface an error. This should generally reduce confusion about whether the plugins are required for every installed IDE. For example, frequently users may only install AS so that they can install the Android SDK - or they may have multiple copies of Intellij installed.

For example: #66762
2020-09-29 16:51:28 -07:00
Dan Field
e8812c409b
Revert "Improve the behavior of Scrollable.ensureVisible when Scrollable nested (#65226)" (#66918)
This reverts commit 73b6398932b3142a6e2f479327c50c5aa613a680.
2020-09-29 16:11:30 -07:00
Daniel Edrisian
6501f1b5cf
Allow modifying barrier color and barrier dismissible for Cupertino Modal Popup (#66692) 2020-09-29 15:37:04 -07:00
Ming Lyu (CareF)
3c321ac80f
cleanup (#66743) 2020-09-29 15:32:03 -07:00
Alexandre Ardhuin
e605b7c225
migrate some material files to nullsafty (#66858)
* migrate some material files to nullsafty

* address review comments
2020-09-29 22:51:21 +02:00
Jonah Williams
0e9c6a3d5f
[flutter_tools] do not crash if chrome preference save fails (#66705)
Crash reporting shows at least one occurrence of this due to a windows file lock. That could happen if there is another running chrome instance, or perhaps a virus scanner is running. Print out the error and do not crash.
2020-09-29 13:00:11 -07:00
Konstantin Scheglov
d227788a53
Move assert(s) that reference 'this' to the constructor bodies. (#66914) 2020-09-29 11:47:21 -07:00
Marcus Tomlinson
5f76bfb4af
Add the ability to inject a bootstrap script (#66897) 2020-09-29 19:24:21 +01:00
Ben Konyi
65a81c7cd3
Roll package:dds to 1.4.0 and update error handling (#66836) 2020-09-29 10:28:17 -07:00
Alexander Brusher
d693d2b9d2
Adds getter/setter for slider semantics flag. (#65766) 2020-09-29 09:29:36 -07:00
Justin McCandless
d2c47acdaa
GlobalKey docs improvement (#66834)
Improve GlobalKey docs by mentioning a pitfall that some users had where the instantiated it in the build method.
2020-09-29 08:40:26 -07:00
Jonah Williams
6f20c8a83f
[flutter_tools] handle missing zip/unzip argument errors (#66685)
it is possible for users that download the prebuilt SDKs to run the tool without unzip installed. Rather than crashing with an unclear argument error, exit the tool with a message on how to install that mirrors the message in the update_dart_sdk.sh script.

Also applied to zip for completeness
2020-09-29 07:58:09 -07:00
Yuqian Li
9d7bdb5903
Default FittedBox's clipBehavior to none (#66700)
This is a continuation of https://github.com/flutter/flutter/pull/61366
after cl/333620714

See also https://flutter.dev/go/clip-behavior
2020-09-28 22:46:21 -07:00
LongCatIsLooong
cd6279c1ec
fix _getPixelPerfectCursorOffset logic when infinite (#66845) 2020-09-28 20:37:04 -07:00
Jonah Williams
21caa8db33
Update flutter_tools README.md to document need for FLUTTER_ROOT (#66854) 2020-09-28 14:36:09 -07:00
Jonah Williams
2d37e086ca
[desktop] default to shrink wrap on desktop platforms (#66754) 2020-09-28 14:27:02 -07:00
Alexandre Ardhuin
a01113de88
migration of material files to nullsafety (#66633) 2020-09-28 13:57:04 -07:00
Jonah Williams
549de844ed
[flutter_tools] add a mechanism to turn off immediate tool exit (#66787)
Instead of always exiting the tool, provide a mechanism to turn off this behavior for non-critical functionality like configuration and analytics settings.

Fixes #66786 Fixes #4674
2020-09-28 13:04:38 -07:00
Pieter van Loon
fa109c49b1
Sliver padding overlap fix (#65323) 2020-09-28 12:22:07 -07:00
Jenn Magder
65159afb55
Force plugins to inherit minimum iOS version from Flutter app (#66590) 2020-09-28 10:14:47 -07:00
Pedro Massango
10f6284426
Add back the autovalidate class property (#66267)
* Add back autovalidate property

* Add autovalidate property back (include tests)

* Fix typos

* One more test :)
2020-09-28 09:27:16 -07:00
Ian Hickson
d95bff1ed8
Minor tool text typo (#66801) 2020-09-28 09:27:04 -07:00
Jose Alba
8db31a556b
Divider with subheader example update (#65944)
* Divider with subheader example update

* fixed issues

* Addressed comments

* fixed issues
2020-09-28 14:32:00 +02:00
xubaolin
73b6398932
Improve the behavior of Scrollable.ensureVisible when Scrollable nested (#65226) 2020-09-27 20:07:32 -07:00
Michael Goderbauer
062e469f1b
Page-subclasses to take children instead of builder (#66694) 2020-09-27 15:32:07 -07:00
Tim Sneath
b8397f69d3
Improve consistency of top-level help text (#66748) 2020-09-27 15:12:03 -07:00
Alexandre Ardhuin
eca0cf38ca
fix the tree (#66783) 2020-09-27 23:04:30 +02:00
Alexandre Ardhuin
c2e43403af
apply upcoming lint cast_nullable_to_non_nullable (#66455)
* apply upcoming lint cast_nullable_to_non_nullable

* make RenderObjectElement.renderObject non-nullable
2020-09-27 21:29:42 +02:00