Victoria Ashworth
b9e8b0a827
[iOS] Dispose of log readers and port forwarders if launch fails ( #127140 )
...
When tests run in our CI using `flutter drive`, if there is a failure it will loop and try again.
434b81f1a5/packages/flutter_tools/lib/src/drive/drive_service.dart (L177-L186)434b81f1a5/packages/flutter_tools/lib/src/ios/ios_deploy.dart (L486-L489)434b81f1a5/packages/flutter_tools/lib/src/ios/devices.dart (L585-L591)434b81f1a5/packages/flutter_tools/lib/src/ios/devices.dart (L627)434b81f1a5/packages/flutter_tools/lib/src/ios/ios_deploy.dart (L563-L576)https://github.com/flutter/flutter/issues/127141
2023-05-19 16:44:58 +00:00
Michael Goderbauer
5e1ba701ed
enable no_literal_bool_comparisons lint ( #126647 )
2023-05-16 16:14:23 +00:00
Victoria Ashworth
5d1132561f
Add debugging for Dart VM timeout flake ( #126437 )
...
Check what is available in the device's iOS DeviceSupport folder to check if symbols were properly fetched. Also, add some logging to track what status the debugger is in.
Debugging for https://github.com/flutter/flutter/issues/121231 .
2023-05-15 17:51:05 +00:00
chunhtai
b00f1c4599
Adding vmservice to get iOS app settings ( #123156 )
...
fixes https://github.com/flutter/flutter/issues/120405
2023-05-04 22:14:11 +00:00
Victoria Ashworth
48bb3c0bc9
Use term wireless instead of network ( #124232 )
...
Rename variables, update comments, etc from `network` to `wireless` to keep it more uniform.
Also, move non-overriden messages related to device selection into the file they're used.
Part 7 in breakdown of https://github.com/flutter/flutter/pull/121262 .
2023-04-19 19:59:11 +00:00
Victoria Ashworth
34d2c8d030
Better support for wireless devices in IDEs ( #123716 )
...
Better support for wireless devices in IDEs
2023-04-04 20:39:38 +00:00
Victoria Ashworth
fa01649a59
Update device selection to wait for wireless devices to load ( #122932 )
...
Update device selection to wait for wireless devices to load
2023-03-29 17:58:07 +00:00
Victoria Ashworth
27248d4b64
Separate attached and wireless devices ( #122615 )
...
Separate attached and wireless devices
2023-03-15 16:35:05 +00:00
Ben Konyi
ecd7518df5
Reland "Remove references to Observatory ( #118577 )" ( #121606 )
...
This reverts commit 275ab9c69bc15113003b77637ea90031df8ed348.
2023-02-28 11:57:04 -05:00
Michael Goderbauer
275ab9c69b
Revert "Reland "Remove references to Observatory ( #118577 )" ( #121215 )" ( #121555 )
...
Revert "Reland "Remove references to Observatory (#118577 )""
2023-02-27 23:46:53 +00:00
Ben Konyi
fbae472fc3
Reland "Remove references to Observatory ( #118577 )" ( #121215 )
...
This reverts commit 298d8c76ba78007deb5b96f320a11ccefe97a794.
2023-02-27 09:26:43 -05:00
Lioness100
26b6c1bedd
Fix typos ( #121171 )
...
* Fix typos
* lowercase animated & opacity
* Undo typo fix
---------
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
Casey Hillers
298d8c76ba
Revert "Remove references to Observatory ( #118577 )" ( #120929 )
...
This reverts commit 2df140f40d8c771ecef4f21cbdf635ec1235b4ac.
2023-02-16 21:28:30 -08:00
Ben Konyi
2df140f40d
Remove references to Observatory ( #118577 )
...
Observatory is being deprecated for Dart 3.0 so it should no longer be
referenced in tooling messaging / flags.
See https://github.com/dart-lang/sdk/issues/50233
2023-02-13 14:29:30 -05:00
Victoria Ashworth
a07e8a6ac4
[reland] Support wireless debugging ( #118895 )
...
* Reland "Support iOS wireless debugging (#118104 )"
This reverts commit cbf2e16892eaf0fe81c01c01263daf5b1f7c602f.
* Remove device loading status
2023-01-20 19:02:37 +00:00
Jenn Magder
cbf2e16892
Revert "Support iOS wireless debugging ( #118104 )" ( #118826 )
...
This reverts commit 5cd2d4c61eff43c4f8ca676b73eb342c49647c93.
2023-01-19 12:31:53 -08:00
Victoria Ashworth
5cd2d4c61e
Support iOS wireless debugging ( #118104 )
...
* setup wireless debugging to use device IP
* fix tests
* fix unused var and missing annotation
* remove unneeded try catch
* remove commented out line, change null to package id
* better way to get package id
* update mDNS lookup to continously check for server, add messaging if takes too long to find observatory url, update flutter drive to enable publish-port if using network device
* Refactor mDNS Discovery to poll for observatories and better handle multiple instances of the same app. Update drive command to make publish-port more stable. Update attach for iOS to only use Protocol Discovery if applicable, run mDNS and Protocol Discovery simultaneously, handle --debug-port/--debug-url/--device-vmservice-port, continously poll for obseravtories with mDNS, include port in error message when mutliple available
* add and update comments, use logger spinner intead of timer in flutter attach, other small improvements
* add newline to message so next log won't be on same line
* fix install/waiting for permission status progress so it doens't double print the time it took.
* only print backtrace if observatory times out on a physical usb connected device
* fix test
* Update related references from Observatory to Dart VM Service
* fix test
2023-01-19 20:00:21 +00:00
Jenn Magder
ada4460502
Audit covariant usage in tool ( #116930 )
2022-12-15 11:59:34 -08:00
Victoria Ashworth
3a656b16cb
Add more supported simulator debugging options and improve tests ( #114628 )
...
* add debugging options to simulator, test more debugging flags, add tests for other launch arguements
* refactor iOS launch arguments to use one function for both simulator and physical devices
* treat dart flags differently between physical and simulator
* Simplify some flags between devices.
Change --disable-service-auth-codes to not always be included for physical devices, only if disableServiceAuthCodes is true.
Change --disable-observatory-publication to be used for simulator devices too.
Change --enable-checked-mode & --verify-entry-points to be used if debuggingEnabled is true regardless of device type.
Chnage --trace-startup to be used for simulator devices too.
* fix ios release mode with buildable app startApp test
* determine observatory-port from deviceVmServicePort and hostVmServicePort
* add comments and remove hasObservatoryPort
2022-11-09 18:17:09 +00:00
Pierre-Louis
0c2f7bc2a2
Remove errant double spaces ( #110758 )
2022-09-02 04:00:58 +00:00
Jenn Magder
003f2b69d2
Pass run and drive --trace-systrace for iOS ( #105321 )
2022-06-03 16:48:11 -07:00
Christopher Fujino
09686a04c9
[flutter_tools] add --uninstall-first flag and pipe it through to ios-deploy ( #102948 )
2022-05-07 11:49:07 -07:00
Jenn Magder
c6ced845e3
Remove custom unawaited, prefer dart:async version ( #103212 )
2022-05-07 08:49:04 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Jenn Magder
888208c1f4
Disallow flutter run-ing on 32-bit development devices ( #97339 )
2022-04-12 14:39:07 -07:00
Christopher Fujino
d07ce92b15
[flutter_tools] Re-land Dump backtrace on ios app startup timeout ( #101763 )
2022-04-12 13:24:04 -07:00
Christopher Fujino
2a6582997d
Revert "[flutter_tools] Dump backtrace on ios app startup timeout ( #101610 )" ( #101761 )
...
This reverts commit 2978b59be70038dc5236d3d5120c9ec0df03ed0f.
2022-04-12 09:09:32 -07:00
Christopher Fujino
2978b59be7
[flutter_tools] Dump backtrace on ios app startup timeout ( #101610 )
2022-04-12 08:49:08 -07:00
Michael Goderbauer
dcde8163ce
migrate to super params ( #100509 )
2022-03-31 11:46:47 -07:00
Zachary Anderson
47f08a3fd6
[flutter_tool] Adds --enable-impeller flag to the run command ( #100835 )
2022-03-26 20:07:24 -07:00
Christopher Fujino
e99a66a47e
[flutter_tools] check if stream is open before sending message in ios device ( #99947 )
2022-03-17 15:55:24 -07:00
Jesús S Guerrero
fbbf3ec471
Support route on ios ( #99078 )
2022-03-07 11:31:21 -08:00
Jenn Magder
cef6823637
Dump backtrace when cannot attach to observatory ( #98550 )
2022-02-16 14:10:18 -08:00
Jenn Magder
9e88fe328e
Remove globals_null_migrated.dart, move into globals.dart ( #92861 )
2021-11-01 17:18:03 -07:00
Jenn Magder
8474f41e90
Migrate xcdevice and ios devices to null safety ( #92056 )
2021-10-19 12:23:03 -07:00
Jenn Magder
a82c50f1f6
Revert "Migrate xcdevice and ios devices to null safety ( #91704 )" ( #91912 )
...
This reverts commit 006587367045d7caf9c4789348b2a146800b58ac.
2021-10-15 09:48:08 -07:00
Jenn Magder
0065873670
Migrate xcdevice and ios devices to null safety ( #91704 )
2021-10-14 22:28:02 -07:00
Ian Hickson
989f864497
Enable avoid_setters_without_getters ( #91067 )
2021-10-01 00:58:05 -07:00
Jenn Magder
57efbd5310
Rename IOSDeviceInterface to IOSDeviceConnectionInterface ( #88144 )
2021-08-16 10:27:03 -07:00
Jenn Magder
89637e4e47
Replace iOS physical/simulator bools with enum ( #87138 )
2021-07-27 16:39:04 -07:00
Jonah Williams
88e756d19e
[flutter_tools] well known device ids ( #85184 )
2021-06-24 18:46:04 -07:00
Balvinder Singh Gambhir
604c59e522
adds build number of ios device in flutter devices command ( #84512 )
2021-06-23 11:31:03 -07:00
Jason Simmons
59f6cc7ac9
Add a trace-skia-allowlist flag for filtering Skia trace events ( #83507 )
2021-06-01 11:29:03 -07:00
Jonah Williams
001323a275
[flutter_tools] remove timeout from iOS device startup ( #81229 )
2021-04-29 22:49:02 -07:00
Jenn Magder
16c73829a6
Migrate reporting library to null safety ( #80320 )
2021-04-15 17:01:34 -07:00
Jenn Magder
ddc1c296a1
Pull XCDevice out of xcode.dart ( #80324 )
2021-04-13 18:10:21 -07:00
Jenn Magder
152af5aba7
Fix device_port_forwarder file name typo ( #79481 )
2021-03-31 18:14:03 -07:00
Jonah Williams
29207e4f78
[flutter_tools] split application package factory dependencies ( #79461 )
2021-03-31 15:11:58 -07:00
Jenn Magder
8893e89d11
Migrate device_port_forwarder to null safety ( #78949 )
2021-03-24 16:56:14 -07:00
Jenn Magder
08b225e03d
Implement iOS app install deltas ( #77756 )
2021-03-10 10:00:03 -08:00
