7123 Commits

Author SHA1 Message Date
Yegor
7a10ed9315 Revert "Bump to Dart SDK 1.22.0-dev.5.0 (#7382)" (#7435)
This reverts commit ef25a2033781a9ab3195bddd8572e9a449d1c7e4 to unbreak the build.
2017-01-10 18:14:58 -08:00
Todd Volkert
bba6bff66b Move forbidden dart:io import test from Bash to Dart (#7427) 2017-01-10 16:08:51 -08:00
Phil Quitslund
ef25a20337 Bump to Dart SDK 1.22.0-dev.5.0 (#7382)
* Bump Dart SDK to 1.22.0-dev.5.0.

* Suppress spurious `FutureOr` type warning.

* Fixed linter dep post merge.

* Formatting tweaks.
2017-01-10 14:55:31 -08:00
Todd Volkert
1ccbf8f00d Use FileSystem.pathSeparator instead of Platform.pathSeparator (#7417) 2017-01-10 13:17:20 -08:00
Adam Barth
03d1980733 Change Flexible's default FlexFit (#7404)
Change `Flexible`'s default `FlexFit`

Previously, `Flexible` defaulted to `FlexFit.tight`, which forced the child to
expand to fill the available space. Now, `Flexible` defaults to
`FlexFit.loose`, which does not force the child to expand to fill the available
space.

If you want the child to expand to fill the available space, consider using
`Expanded` instead.

Fixes #5169
2017-01-10 13:12:04 -08:00
Yegor
b6ac86435a export missed transition count to the dashboard (#7426) 2017-01-10 13:09:43 -08:00
Jason Simmons
90d18fa808 Fix the type of the default project root path (#7422) 2017-01-10 12:08:33 -08:00
Adam Barth
b9f49a40f7 Handle missing flutter_test dependency cleanly (#7421)
We now produce a more reasonable error message when we're missing the
flutter_test dependency in a test. Also, remove the flutter_tools stack traces
when the engine dies.

Fixes #6187
2017-01-10 11:31:24 -08:00
Hans Muller
2155fb74b6 Tweak the Navigator class doc (#7415) 2017-01-10 11:19:09 -08:00
Todd Volkert
e2847c7221 Fix type passed to printError() (#7416)
Fixes #7413
2017-01-10 10:38:12 -08:00
Jason Simmons
8af5520f56 Do not print stack traces for DevFS write request failures (#7405)
Each stack trace will yield many async task stacks for every write request
that is in flight.  If the device side is unresponsive and all writes are
failing, then this can generate an overwhelming amount of logs.
2017-01-10 10:30:22 -08:00
Adam Barth
5a2bf18488 Improve test coverage and fix bugs (#7410)
This patch improves test coverage for a number of files that had low
coverage. This patch also fixes a few minor bugs found by these tests.
2017-01-10 10:15:33 -08:00
Yegor
3c7122a797 devicelab: fix basic_material_app_ios__size; add microbenchmarks (#7408) 2017-01-10 09:30:00 -08:00
John McCutchan
6a63af4081 Rebuild Android apk when Dart source is modified (#7345)
- [x] Wire up dependency checker and plumb flags down to the right place

Fixes #7014
2017-01-10 07:59:55 -08:00
Adam Barth
684259794b Add CupertinoAlertDialog (#7395)
Fixes #7375
2017-01-09 21:35:43 -08:00
Adam Barth
cd34593ca8 Test print.dart (#7406) 2017-01-09 21:35:26 -08:00
Jason Simmons
fb8179bfed Remove a misfiring assert in the test framework plugin (#7397)
Fixes https://github.com/flutter/flutter/issues/7351

When a test runs to completion, the test harness closes the stream side of the
StreamChannel, causing the sink side to be closed as well.  So by the time we
receive a test result of completed/harnessBailed, the controller sink has been
closed.
2017-01-09 16:52:00 -08:00
Ian Hickson
2eecb8be37 Improve Notification API (#7403)
- better documentation

- verify (at run time) that onNotification doesn't return null, and
  report copious helpful information if it does.

- add a toString/debugFillDescription convention to Notification.

- actually test Notification
2017-01-09 16:44:22 -08:00
Ian Hickson
d3faada983 Trivial improvement of AbstractNode docs. (#7399)
This confused me briefly the other day.
2017-01-09 16:33:40 -08:00
Ian Hickson
cd92e11f17 Use the actual pipeline owner for this assert. (#7400) 2017-01-09 16:33:25 -08:00
Adam Barth
84cf54892d Improve test coverage (#7401)
This patch adds a number of tests for previously untested lines.
2017-01-09 16:19:24 -08:00
Devon Carew
258fc011f6 pass additional named params to daemon run (#7392)
* pass additional named params to daemon run

* add a trailing comma
2017-01-09 16:12:41 -08:00
Matt Perry
12d5b26c3a Add an onChanged callback to InputFormField. (#7398)
Fixes https://github.com/flutter/flutter/issues/7210
2017-01-09 15:43:16 -08:00
Michael Goderbauer
7c9f9be363 Add a timeout to every command (enforced on device and host) (#7391) 2017-01-09 14:57:25 -08:00
Yegor
1df639b432 add microbenchmarks to devicelab (fixes #7081) (#7396) 2017-01-09 14:57:14 -08:00
Hans Muller
b23aed7a86 New Tabs API (#7387) 2017-01-09 14:55:36 -08:00
Ian Hickson
e82b18d47b The core RenderSliver protocol. (#7370)
This implements a new RenderViewport2 class to replace the existing
RenderViewport class.
2017-01-09 14:49:14 -08:00
Todd Volkert
016b5ab0cc Force all dart:io usage to go through 'base/io.dart' (#7390)
This ensures that accidental usages of dart:io's
file API don't creep in over time.
2017-01-09 08:37:00 -08:00
Todd Volkert
8bb270342e Update flutter_tools to use package:file throughout (#7385)
This removes direct file access from within flutter_tools
in favor of using `package:file` via a `FileSystem` that's
accessed via the `ApplicationContext`.

This lays the groundwork for us to be able to easily swap
out the underlying file system when running Flutter tools,
which will be used to provide a record/replay file system,
analogous to what we have for process invocations.
2017-01-06 16:51:44 -08:00
Adam Barth
0c42c9b1b2 Add CupertinoActivityIndicator (#7380)
Fixes #7372
2017-01-06 15:58:26 -08:00
Adam Barth
b40f0cae9c Allow Expanded.flex to be null (#7384)
Some clients pass null, which was previously allowed by Flexible.

Fixes #7383
2017-01-06 13:59:40 -08:00
Michael Goderbauer
fd3e0b7e13 Add option to get Dart VM flags from flutter_driver. (#7378) 2017-01-06 10:56:09 -08:00
Adam Barth
5b1e7c0a37 Rename TransferMode to BlendMode (#7357)
Skia calls this BlendMode now and that's a better name.

Fixes #7200
2017-01-06 00:07:47 -08:00
Ian Hickson
b0e8520ae6 Make LayoutCallback generic and other minor changes (#7367)
LayoutCallback passes constraints to the callback, but the constraints
object has a different type for different subclasses. This lets you
call invokeLayoutCallback() with a specific type to verify that
everything is working as expected.

Other changes:

Slightly improve the error reporting in RenderObject.

Allow toStringShallow on RenderObject to have its separator configured.
2017-01-05 22:12:08 -08:00
Ian Hickson
ec9a6fbbdd Add an assert and remove a TODO (#7368)
The assert helped me debug an issue recently.

The TODO is obsolete.
2017-01-05 22:11:29 -08:00
Todd Volkert
1c43c4e24d Bump package:file version to 1.0.0 (#7371) 2017-01-05 18:42:57 -08:00
Todd Volkert
29a88cf817 Bump path to 1.4.0 and meta to 1.0.4 (#7369) 2017-01-05 16:44:27 -08:00
Ian Hickson
79c8e5c7c7 Add a toString to Simulation (#7364)
Also, make hasOneLineDescription more discerning.
Also, add a test for hasOneLineDescription.
Also, add a test for GravitySimulation, to test the toString.
2017-01-05 16:33:40 -08:00
Ian Hickson
11d1d54c8a Changes to the drag gesture detectors and the velocity tracker (#7363)
- more dartdocs for the drag typedefs

- more toStrings to aid debugging

- require the position for DragUpdateDetails since we were omitting it
  in some places

- add the primaryVelocity to DragEndDetails so that consumers don't
  have to themselves track the axis in question

- fix the velocity tracker so that it doesn't walk the null data.
  Previously, near time t=0 (which pretty much only matters in tests,
  but it does matter there) we would walk the velocity data and then
  also walk missing data, treating it as Point.zero with t=0.

- simplify some of the velocity tracker; e.g. instead of trying (and
  failing?) to clear the velocity tracker when the pointer stalls,
  just drop the data before a stall during the velocity estimation
  (where we redundantly had another bigger horizon anyway).
2017-01-05 16:19:14 -08:00
Ian Hickson
629255eb49 Fix SizeChangedLayoutNotifier and its test. (#7361)
Previously, SizeChangedLayoutNotifier fired a notification even for
the first layout.

Also, previously its test relied on that, and didn't actually change
size at all. This fixes the test as well.

Also, rename SizeChangedLayoutNotificaion to SizeChangedLayoutNotification.
2017-01-05 16:19:06 -08:00
Seth Ladd
86ad51f1ec Doc that SizedBox.expand can be used by Scaffold.body (#7141)
Closes https://github.com/flutter/flutter/issues/6907
2017-01-05 15:18:40 -08:00
Ian Hickson
207968ff79 Make SingleTickerProviderStateMixin more resilient (#7360)
It used to crash when the State never actually used the TickerProvider
interface.
2017-01-05 15:11:28 -08:00
Ian Hickson
e08c3c3bdc moreOrLessEquals matcher for floating point numbers (#7358)
```dart
expect(x, moreOrLessEquals(0.0));
```

...for those cases where `x` might be 1e-11 or whatever.

Also, be more resilient when dumping the tree from inside the test framework.
Also, add an assert that helped me debug something the other day.
2017-01-05 14:51:01 -08:00
Ian Hickson
7f3dc76b8d Minor improvement to Tween docs (#7354) 2017-01-05 14:39:23 -08:00
Adam Barth
30053f2f41 Deprecate HostMessages (#7352)
This class is just an alias for PlatformMessages. We'll remove it after a short
deprecation period.
2017-01-05 14:01:27 -08:00
Ian Hickson
5c360c8320 Minor tweaks to Curve documentation (#7353) 2017-01-05 13:10:41 -08:00
Ian Hickson
b2c244efe8 Allow nulls in Listenable.merge (#7355)
This lets you use `Listenable.merge` without having to sanitize your
incoming list of change notifiers, in case your semantics are that
they are optional.
2017-01-05 13:10:30 -08:00
Adam Barth
27970bd82d Remove package:flutter/cassowary.dart (#7350)
We didn't end up using this mechanism.
2017-01-05 13:08:43 -08:00
Adam Barth
cd09370c13 Update quiver (#7349) 2017-01-05 12:45:10 -08:00
Chinmay Garde
1fa8a254a3 Update engine revision. (#7348) 2017-01-05 12:30:01 -08:00