skia-flutter-autoroll
bad046bd6e
Roll Skia from 9168ad248c69 to a5e3b3556739 (1 revision) ( flutter/engine#56283 )
...
https://skia.googlesource.com/skia.git/+log/9168ad248c69..a5e3b3556739
2024-10-31 egdaniel@google.com [Graphite] Use PushConstants instead of VBO for load msaa draws.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 23:25:13 +00:00
auto-submit[bot]
528967bfae
Reverts "Allow BufferViews to have non-owning references to DeviceBuffers ( #56224 )" ( flutter/engine#56285 )
...
Reverts: flutter/engine#56224
Initiated by: jonahwilliams
Reason for reverting: merge issue.
Original PR Author: gaaclarke
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
issue: https://github.com/flutter/flutter/issues/157538
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-31 22:48:46 +00:00
Chris Bracken
e1c05b7dd8
macOS: migrate third_party/accessibility to ARC ( flutter/engine#56281 )
...
Migrates all Objective-C++ translation units under third_party/accessibility to ARC.
Issue: https://github.com/flutter/flutter/issues/137801
No test changes because this change introduces no semantic changes.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-31 22:32:22 +00:00
gaaclarke
1d90823917
Allow BufferViews to have non-owning references to DeviceBuffers ( flutter/engine#56224 )
...
issue: https://github.com/flutter/flutter/issues/157538
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-10-31 15:28:10 -07:00
Jim Graham
861a9a4ac8
[Impeller] Do not use fast mask blur for stroked shapes ( flutter/engine#56247 )
...
A compound test for whether to use the fast blur mechanism for shapes was failing to check for a stroked shape due to misplaced parentheses.
2024-10-31 21:33:18 +00:00
Jonah Williams
14df054f9c
[Impeller] make desktop GL render. ( flutter/engine#56274 )
...
Fixes https://github.com/flutter/flutter/issues/143387
Will be tested in https://github.com/flutter/flutter/pull/157888
2024-10-31 21:33:15 +00:00
Matan Lurey
018d53a74f
Vastly rewrite and expand et/README.md ( flutter/engine#56250 )
...
Closes https://github.com/flutter/flutter/issues/157876 .
/cc @dcharkes @jensjoha as well (documented `--gn-args`)
2024-10-31 21:27:54 +00:00
skia-flutter-autoroll
1d4bbcfd1f
Roll Fuchsia Linux SDK from dDWvmfG4AxSEs0BQA... to MjcuejuzYvYGobbFM... ( flutter/engine#56280 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 21:26:24 +00:00
skia-flutter-autoroll
cf02c21dc5
Roll Dart SDK from f3e3dc44b1dc to bd93105c4fb6 (2 revisions) ( flutter/engine#56278 )
...
https://dart.googlesource.com/sdk.git/+log/f3e3dc44b1dc..bd93105c4fb6
2024-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-88.0.dev
2024-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-87.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 21:14:17 +00:00
Chris Bracken
deb7a64a76
Embedder: migrate Metal surfaces to ARC ( flutter/engine#56279 )
...
Migrate Skia and Impeller surface translation units to ARC.
Issue: https://github.com/flutter/flutter/issues/137801
No changes to tests since no semantic changes.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-31 21:03:04 +00:00
Chris Bracken
8a97900ef4
iOS: migrate Metal testing types to ARC ( flutter/engine#56156 )
...
This migrates Flutter's TestMetalContext and TestMetalSurface to ARC.
Also migrates to using `sk_cfp::retain` (which retains the passed in pointer) rather than `sk_cfp::reset`, which only releases the previous pointer but doesn't retain the incoming pointer.
No changes to tests since no semantic changes.
Issue: https://github.com/flutter/flutter/issues/137801
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-31 20:50:03 +00:00
Chris Bracken
998761eb14
iOS,macOS: migrate shell/gpu to ARC ( flutter/engine#56157 )
...
Migrates Objective-C code in shell/gpu to ARC.
Migrate `sk_cfp::reset(__bridge_retained ptr)` to `sk_cfp::retain(__bridge ptr)`. `reset` `CFRelease`s the previously held pointer and sets the pointer to the new pointer. `retain` `CFRetain`s the new pointer prior to setting it.
No changes to tests since this makes no semantic changes.
Issue: https://github.com/flutter/flutter/issues/137801
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-31 18:55:48 +00:00
skia-flutter-autoroll
d98bd1ab81
Roll Skia from 3c628426f85f to 9168ad248c69 (3 revisions) ( flutter/engine#56272 )
...
https://skia.googlesource.com/skia.git/+log/3c628426f85f..9168ad248c69
2024-10-31 michaelludwig@google.com [mac] Update build target to for x86 to be 10.15
2024-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1d891d46a65c to 37d41da69cc4 (2 revisions)
2024-10-31 michaelludwig@google.com Revert "Add verb measurement utils to SkContourMeasure"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 17:54:09 +00:00
Jonah Williams
6eed502b8b
[Impeller] Reland: disable AHBs on devices that were upgraded to 29. ( flutter/engine#56221 )
...
Uses ro.product.first_api_level to disable AHBs on devices that began life pre 29.
Fixes https://github.com/flutter/flutter/issues/157113
2024-10-31 17:42:12 +00:00
Matan Lurey
c7df7b1cce
Add timeout to local_engine. ( flutter/engine#56271 )
...
See https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20local_engine_builds .
2024-10-31 17:00:50 +00:00
Matan Lurey
f89c4fd346
Refactor ArgParser.usage tests for BuildPlan to reduce duplication. ( flutter/engine#56254 )
...
Part of https://github.com/flutter/flutter/issues/157870 .
I figured I'd tackle a theme of tests at a time - easier for me to do in little spurts between other tasks.
2024-10-31 16:44:06 +00:00
auto-submit[bot]
38f7a81e37
Reverts "Skwasm single threaded ( #56206 )" ( flutter/engine#56264 )
...
Reverts: flutter/engine#56206
Initiated by: jonahwilliams
Reason for reverting: failing to roll into framework: https://github.com/flutter/flutter/pull/157919
Original PR Author: eyebrowsoffire
Reviewed By: {harryterkelsen}
This change reverts the following previous change:
This PR creates a single-threaded version of the skwasm renderer, appropriate for non-crossOriginIsolated browsing contexts.
* The single threaded renderer is essentially the same as the multi-threaded renderer, except instead of spawning a web worker and posting messages to it, it simply schedules microtasks on the main thread in their place.
* The new renderer is vended as `skwasm_st.js` and `skwasm_st.wasm` in the same location as multithreaded skwasm. In order to properly build and function, we needed some fixes I put into emscripten that landed in version 3.1.70. That version also changed some behavior that required a few fixes to the CanvasKit build files.
* The skwasm loader in flutter.js has been modified to use the skwasm_st variants when encountering a non-crossOriginIsolated context but a browser and configuration that otherwise would allow the use of skwasm. I also added a new `forceSingleThreadedSkwasm` option to the flutter configuration so that we can override this behavior, especially so that we can accurately benchmark the single threaded renderer in a crossOriginIsolated environment.
* I also consolidated a bunch of our shards that run tests to just have one per browser/platform combination, so four total. This will address https://github.com/flutter/flutter/issues/124682
2024-10-31 14:12:47 +00:00
skia-flutter-autoroll
85cce650a0
Roll Skia from 4f8f2ecadfb6 to 3c628426f85f (1 revision) ( flutter/engine#56261 )
...
https://skia.googlesource.com/skia.git/+log/4f8f2ecadfb6..3c628426f85f
2024-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 548705375403 to 65468f93b38c (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 10:47:12 +00:00
skia-flutter-autoroll
ac26403b3e
Roll Dart SDK from 6a8058eef22c to f3e3dc44b1dc (1 revision) ( flutter/engine#56253 )
...
https://dart.googlesource.com/sdk.git/+log/6a8058eef22c..f3e3dc44b1dc
2024-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-86.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-31 03:41:31 +00:00
Jonah Williams
8b0392d282
[Impeller] use primitive restart for faster tessellation: write directly into host buffer. ( flutter/engine#56173 )
...
Using primitive restart we can avoid tracking even odd or inserting degenerate triangles. Instead a special index value `0xFFFF` is used to signal a break. This can be combined with triangle fan on vulkan for a dramatically simpler tessellation.
Additionally, switches to a two pass system where we first estimate the storage required by the path so tha the host buffer can be written to directly.
2024-10-31 02:27:28 +00:00
Jackson Gardner
1a4f588e1f
Skwasm single threaded ( flutter/engine#56206 )
...
This PR creates a single-threaded version of the skwasm renderer, appropriate for non-crossOriginIsolated browsing contexts.
* The single threaded renderer is essentially the same as the multi-threaded renderer, except instead of spawning a web worker and posting messages to it, it simply schedules microtasks on the main thread in their place.
* The new renderer is vended as `skwasm_st.js` and `skwasm_st.wasm` in the same location as multithreaded skwasm. In order to properly build and function, we needed some fixes I put into emscripten that landed in version 3.1.70. That version also changed some behavior that required a few fixes to the CanvasKit build files.
* The skwasm loader in flutter.js has been modified to use the skwasm_st variants when encountering a non-crossOriginIsolated context but a browser and configuration that otherwise would allow the use of skwasm. I also added a new `forceSingleThreadedSkwasm` option to the flutter configuration so that we can override this behavior, especially so that we can accurately benchmark the single threaded renderer in a crossOriginIsolated environment.
* I also consolidated a bunch of our shards that run tests to just have one per browser/platform combination, so four total. This will address https://github.com/flutter/flutter/issues/124682
2024-10-31 00:42:07 +00:00
Jonah Williams
693f99ae00
[Impeller] expose reference to tessellator instead of shared_ptr. ( flutter/engine#56244 )
...
All geometries were incrementing the shared_ptr usage count which shows up in profiles. Instead expose a Tessellator reference like we do with HostBuffer.
2024-10-31 00:40:18 +00:00
Chris Bracken
a4bb83e6e8
iOS: Eliminate strong retain loop in Scenario tests ( flutter/engine#56249 )
...
`FlutterViewControllerTest testDrawLayer` created a callback which strongly referenced itself in its own body as part of an asynchronous recursive loop. The recursion was unnecessary and the test consistently passes, even if run on repeat > 100 times without it.
Now that there's only one call, eliminates the unnecessary local and inlines it into the `dispatch_after` call.
This was originally introduced in https://github.com/flutter/engine/pull/50072 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-31 00:37:26 +00:00
skia-flutter-autoroll
2bc2d9e328
Roll Skia from 85b77db25fa3 to 3c62d4a94d78 (1 revision) ( flutter/engine#56248 )
...
https://skia.googlesource.com/skia.git/+log/85b77db25fa3..3c62d4a94d78
2024-10-30 fmalita@google.com Add verb measurement utils to SkContourMeasure
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 23:08:07 +00:00
skia-flutter-autoroll
3c6aaffb34
Roll Dart SDK from 4566845d8e30 to 6a8058eef22c (1 revision) ( flutter/engine#56246 )
...
https://dart.googlesource.com/sdk.git/+log/4566845d8e30..6a8058eef22c
2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-85.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 23:04:05 +00:00
skia-flutter-autoroll
193c2511a9
Roll Skia from f334411b0a08 to 85b77db25fa3 (5 revisions) ( flutter/engine#56245 )
...
https://skia.googlesource.com/skia.git/+log/f334411b0a08..85b77db25fa3
2024-10-30 jvanverth@google.com [graphite] Add round cap support to CircularArcRenderStep.
2024-10-30 jlavrova@google.com Reland "Reland "Reland "Adding Fontations to FontConfig manager"""
2024-10-30 bungeman@google.com [pdf] Emit correct tag for marked-content items
2024-10-30 drott@chromium.org [Fontations] Fix bounding box calculation under transforms
2024-10-30 vigneshv@google.com SkCrabbyAvifCodec: Add support for gainmaps
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 21:50:06 +00:00
Matan Lurey
eb42dc7b9d
Add and use mergeGnArgs with --gn-args from et. ( flutter/engine#56228 )
...
Closes https://github.com/flutter/flutter/issues/156909 .
This PR adds (and implements) the `--gn-args` (extra command-line GN args) functionality by generalizing on the concept of "merged" GN args that @zanderso had special-cased for `--lto` and `--rbe`, and further testing it.
There is also a logical place for us to expand support of merged arguments at a future point in time.
2024-10-30 21:44:35 +00:00
skia-flutter-autoroll
85bf745fbc
Roll Skia from 77779dfed911 to f334411b0a08 (1 revision) ( flutter/engine#56243 )
...
https://skia.googlesource.com/skia.git/+log/77779dfed911..f334411b0a08
2024-10-30 jvanverth@google.com [graphite] Remove legacy rrect clip
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 20:08:18 +00:00
Jonah Williams
b1b224f8e8
[engine] add back opt out for merged thread mode. ( flutter/engine#56242 )
...
Leave an opt out in the engine for iOS as well. This will give developers an escape hatch in case there are problems we miss...
2024-10-30 20:00:22 +00:00
Jason Simmons
d24eb30b3d
[Impeller] Remove the use of a subpixel minimum stroke size for MSAA ( flutter/engine#56223 )
...
Based on https://github.com/flutter/engine/pull/55230
Fixes https://github.com/flutter/flutter/issues/156438
2024-10-30 18:45:45 +00:00
skia-flutter-autoroll
bbe385cf21
Roll Fuchsia Linux SDK from zuDYsDZHnJMZVvrc8... to dDWvmfG4AxSEs0BQA... ( flutter/engine#56241 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 18:40:23 +00:00
skia-flutter-autoroll
05e65b6663
Roll Dart SDK from 36aed3607108 to 4566845d8e30 (1 revision) ( flutter/engine#56240 )
...
https://dart.googlesource.com/sdk.git/+log/36aed3607108..4566845d8e30
2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-84.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 18:14:09 +00:00
skia-flutter-autoroll
788af1d0c1
Roll Skia from d022fe64116f to 77779dfed911 (1 revision) ( flutter/engine#56239 )
...
https://skia.googlesource.com/skia.git/+log/d022fe64116f..77779dfed911
2024-10-30 jlavrova@google.com Revert "Reland "Reland "Adding Fontations to FontConfig manager"""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 17:02:19 +00:00
skia-flutter-autoroll
ae6950d066
Roll Skia from 03600bc22ab8 to d022fe64116f (1 revision) ( flutter/engine#56237 )
...
https://skia.googlesource.com/skia.git/+log/03600bc22ab8..d022fe64116f
2024-10-30 jlavrova@google.com Reland "Reland "Adding Fontations to FontConfig manager""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 15:13:20 +00:00
skia-flutter-autoroll
4d7029a182
Roll Dart SDK from b319b2e53bfa to 36aed3607108 (2 revisions) ( flutter/engine#56235 )
...
https://dart.googlesource.com/sdk.git/+log/b319b2e53bfa..36aed3607108
2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-83.0.dev
2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-82.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 13:39:36 +00:00
skia-flutter-autoroll
1a555cf0ce
Roll Skia from 1a47627e627a to 948b01e28f48 (1 revision) ( flutter/engine#56231 )
...
https://skia.googlesource.com/skia.git/+log/1a47627e627a..948b01e28f48
2024-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e50eebfa6917 to 548705375403 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 08:18:24 +00:00
skia-flutter-autoroll
90f0a83511
Roll Dart SDK from 70eca740f23f to b319b2e53bfa (1 revision) ( flutter/engine#56229 )
...
https://dart.googlesource.com/sdk.git/+log/70eca740f23f..b319b2e53bfa
2024-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-81.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 05:20:21 +00:00
Chris Bracken
d6ad223584
iOS: make unopt debug builds unopt and debug ( flutter/engine#56226 )
...
The following iOS builds were named "unopt" and "debug" but did not have
the `--unoptimized` flag passed to `gn`, resulting in them not being
unopt, and having the gn `is_debug` setting set to `false`:
* ios_debug_unopt_sim
* ios_debug_unopt_sim_arm64
* ios_debug_unopt_sim_arm64_extension_safe
No test changes because this is a compile config change.
Issue: https://github.com/flutter/flutter/issues/156166
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-30 04:15:18 +00:00
skia-flutter-autoroll
c732984e6b
Roll Dart SDK from fcc2bc69db3e to 70eca740f23f (2 revisions) ( flutter/engine#56225 )
...
https://dart.googlesource.com/sdk.git/+log/fcc2bc69db3e..70eca740f23f
2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-80.0.dev
2024-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-79.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 00:56:41 +00:00
skia-flutter-autoroll
6b989d0e0c
Roll Skia from 6e0c0a255166 to 7385b2d99fe9 (5 revisions) ( flutter/engine#56222 )
...
https://skia.googlesource.com/skia.git/+log/6e0c0a255166..7385b2d99fe9
2024-10-29 lukasza@chromium.org Reapply "[rust png] Add a few extra `BlendOp`, regions, and `num_plays` tests."
2024-10-29 lukasza@chromium.org [rust png] Don't retry `parse...FrameInfos` if input didn't change.
2024-10-29 michaelludwig@google.com Revert "Reland "Adding Fontations to FontConfig manager""
2024-10-29 lukasza@chromium.org [rust png] Don't look for more `fcTL` chunks during incremental decode.
2024-10-29 lukasza@chromium.org [rust png] Account for `fFrameAtCurrentStreamPosition` inaccuracies.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-30 00:20:06 +00:00
David Iglesias
ba7deba7c5
[web] Prioritize split font fallbacks over monolythic ones. ( flutter/engine#56187 )
...
Moves "split" font fallbacks (woff2) over "monolythic" ones (ttf) when resolving fonts.
Fixes https://github.com/flutter/flutter/issues/157763
It makes flutter web prefer "Noto Color Emoji" over "Noto Sans Symbols" when rendering emoji, for example.
This also changes the methods that process the font lists so they *return* the fonts they processed, instead of causing a side effect on an incoming array.
---
CIPD Upload log
```
398 sets covering 22287 ranges
Uploading fallback fonts to CIPD with hash 0570a0ea824083da79de07b131fc5df7f55dad4d6cba2ee704912ce7e4ce812a
Enumerating files to zip...
Instance: flutter/flutter_font_fallbacks:6jWhR90elvOjT1bwCe57CrNWbsGrvOzMONf9_bS8w5IC
Setting new fallback fonts deps version to 0570a0ea824083da79de07b131fc5df7f55dad4d6cba2ee704912ce7e4ce812a
```
Link to uploaded bundle:
* https://chrome-infra-packages.appspot.com/p/flutter/flutter_font_fallbacks/+/6jWhR90elvOjT1bwCe57CrNWbsGrvOzMONf9_bS8w5IC
---
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-29 23:01:22 +00:00
skia-flutter-autoroll
621f137ec6
Roll Skia from 5758d9c344e3 to 6e0c0a255166 (3 revisions) ( flutter/engine#56215 )
...
https://skia.googlesource.com/skia.git/+log/5758d9c344e3..6e0c0a255166
2024-10-29 jlavrova@google.com Reland "Adding Fontations to FontConfig manager"
2024-10-29 bungeman@google.com [pdf] Expand content item scope
2024-10-29 jamesgk@google.com [graphite] Simplify ShaderInfo API
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,jamesgk@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-29 22:53:48 +00:00
Brandon DeRosier
3fed10bf0d
[Flutter GPU] Fix MSAA sample size and HostBuffer alignment. ( flutter/engine#56218 )
...
- Align HostBuffer emplacements properly (fix Metal validation failures).
- Correctly set the pipeline sample size.
- Throw an error when attempting to bind `deviceTransient` textures.
2024-10-29 22:52:21 +00:00
Jim Graham
80d757ef56
Change default TileMode for blur ImageFilter objects to null ( flutter/engine#55552 )
...
Fixes https://github.com/flutter/flutter/issues/154935
Historically ImageFilter.blur supported setting a TileMode and had a default mode of `clamp`, but few developers actually set the value and the default was not appropriate for some common uses like as a backdrop filter where the clamp mode produces flashing when scrolling high frequency pixel content underneath a blurred title bar.
This PR removes the default tile mode instead allowing a null value as the default which will allow the engine to use an appropriate context-dependent default tile mode depending on the action being performed. Typically:
- decal for rendering operations and saveLayers and ImageFilterLayer
- clamp for image operations
- mirror for backdrop filters
2024-10-29 22:47:32 +00:00
auto-submit[bot]
728997cd8f
Reverts "[Impeller] Reland: disable AHBs on devices that were upgraded to 29. ( #56213 )" ( flutter/engine#56220 )
...
Reverts: flutter/engine#56213
Initiated by: jtmcdole
Reason for reverting: breaks the tree. :'(
Original PR Author: jonahwilliams
Reviewed By: {chinmaygarde, jtmcdole}
This change reverts the following previous change:
Uses ro.product.first_api_level to disable AHBs on devices that began life pre 29.
Fixes https://github.com/flutter/flutter/issues/157113
2024-10-29 22:24:19 +00:00
gaaclarke
ae96943065
Made et compilation errors relative to the CWD ( flutter/engine#56177 )
...
fixes https://github.com/flutter/flutter/issues/157735
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-10-29 19:25:04 +00:00
Jonah Williams
103b3b7cf5
[Impeller] Reland: disable AHBs on devices that were upgraded to 29. ( flutter/engine#56213 )
...
Uses ro.product.first_api_level to disable AHBs on devices that began life pre 29.
Fixes https://github.com/flutter/flutter/issues/157113
2024-10-29 19:12:16 +00:00
Jonah Williams
1f229c58cf
[Impeller] disable Adreno 506. ( flutter/engine#56210 )
...
Fixes https://github.com/flutter/flutter/issues/155185
2024-10-29 18:43:22 +00:00
auto-submit[bot]
bc43093cdd
Reverts "[Impeller] disable AHBs on devices that were upgraded to 29. ( #56202 )" ( flutter/engine#56212 )
...
Reverts: flutter/engine#56202
Initiated by: jonahwilliams
Reason for reverting: tests didn't actually run.
Original PR Author: jonahwilliams
Reviewed By: {chinmaygarde, jtmcdole}
This change reverts the following previous change:
Uses `ro.product.first_api_level` to disable AHBs on devices that began life pre 29.
Fixes https://github.com/flutter/flutter/issues/157113
2024-10-29 17:45:47 +00:00
Alexander Aprelev
d0141e3ee3
Remove --time run of gen_snapshot. ( flutter/engine#56204 )
...
'--time'-runs were done to investigate https://github.com/flutter/flutter/issues/154437 , which was fixed.
2024-10-29 17:20:15 +00:00
