8795 Commits

Author SHA1 Message Date
Greg Spencer
efcd9a8001
Simplify Gradle compiler output. (#21760)
This changes the compiler output for gradle to be less verbose and more easily read.

This only applies to compilation error messages: other gradle messages will continue to print as before.

It also fixes a small problem with the performance measurement printing (see that "7.1s" on it's own line in the original?) so that if something is expected to have multiple lines of output, it prints an initial line, and a "Done" line with the elapsed time, so that it's possible to know what the time applies to.

It also updates the spinner to be fancier, at least on platforms other than Windows (which is missing a lot of symbols in its console font).

Addresses #17307
2018-09-20 15:45:48 -07:00
Alexander Markov
83cdb5738e
Cleanup uses of entry points files (#22098) 2018-09-20 15:10:41 -07:00
Greg Spencer
54236427dc
Fix flake in logger_test (#22095)
This fixes a flaky test where it included 0ms as part of an output check. Kind of a classic flaky test.
2018-09-20 14:45:24 -07:00
Stanislav Baranov
c799c2fd80
Use "product" mode VM snapshot when running dynamic "release" mode flutter with cached engine. (#22043)
Dynamic "release" mode requires "product" (not "release") mode VM, so we must point it to the correct cached snapshot.

Generation and caching of this snapshot happens the following corresponding change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1232134
2018-09-20 13:12:38 -07:00
tonyzhao1
8b5af14f24 Use grouped validator instead of categories (#21577)
This is a cleanup PR.
2018-09-19 15:42:51 -07:00
Michael Klimushyn
36b735eeb2
Fix WidgetApp.title documentation (#22011)
Closes #16031
2018-09-19 15:39:02 -07:00
Greg Spencer
7caa65943f
Added more extensive ANSI color printing support on terminals. (#20958)
This adds support to AnsiTerminal for colored output, and makes all tool output written to stderr (with the printError function) colored red.

No color codes are sent if the terminal doesn't support color (or isn't a terminal).

Also makes "progress" output print the elapsed time when not connected to a terminal, so that redirected output and terminal output match (redirected output doesn't print the spinner, however).

Addresses #17307
2018-09-19 15:22:43 -07:00
Jonah Williams
85b4670b2a
Revert "Implement Double Tap Handling in TextField and Editable" (#22051)
* Revert "Revert "Add RichText support to find.text" (#22046)"

This reverts commit 8e704219138147bc0a46e9547cbe6519cf0bb6c7.

* Revert "Implement Double Tap Handling in TextField and Editable (#21264)"

This reverts commit 02e87334ddb9f64a2ff12c0dc201f3e410e74be7.
2018-09-19 14:59:23 -07:00
Jonah Williams
8e70421913
Revert "Add RichText support to find.text" (#22046) 2018-09-19 13:51:35 -07:00
Niko Yuwono
02e87334dd Implement Double Tap Handling in TextField and Editable (#21264)
Thanks @NikoYuwono for getting this working! We appreciate your help!

* Implement Double Tap Handling in TextField and Editable

* Fix test broken by the change and add test for double tap

* Fix affected tests

* Remove unnecessary new

* Fix test
2018-09-19 13:35:33 -07:00
Renan
74e93e4c5c Make ScaleGestureRecognizer detect pointer rotation (#17345) 2018-09-19 11:48:41 -07:00
Jonah Williams
ff1f8dd143
Add RichText support to find.text (#21964) 2018-09-19 10:01:34 -07:00
Danny Tuppeny
7dd82813f2
Remove -j1 to run tools tests concurrently (#22038)
Fixes #21113.
2018-09-19 17:47:06 +01:00
matthew-carroll
18d5b9dc45
Renamed 'flutter materialize' to 'flutter make-host-app-editable'. The iOS version is still incomplete and will therefore require additional renaming. (#21771) (#22006) 2018-09-18 17:58:20 -07:00
sir-boformer
3c22d7b025 clarify how to display an image with a specific density (#21152)
Closes #18679
2018-09-18 16:29:52 -07:00
Jonah Williams
bf7c27095c
Make helper and error text separate widgets, make error and counter live region (#21752) 2018-09-18 13:39:21 -07:00
Chris Bracken
f8c50ea15f
Use Xcode legacy build system for iOS builds (#21901) (#21994)
Xcode 10 introduces a new build system which includes stricter checks on
duplicate build outputs.

When plugins are in use, there are two competing build actions that copy
Flutter.framework into the build application Frameworks directory:

  1. The Embed Frameworks build phase for the Runner project
  2. The [CP] Embed Pods Frameworks build phase that pod install creates
     in the project.

Item (1) is there to ensure the framework is copied into the built app
in the case where there are no plugins (and therefore no CocoaPods
integration in the Xcode project). Item (2) is there because Flutter's
podspec declares Flutter.framework as a vended_framework, and CocoaPods
automatically adds a copy step for each such vended_framework in the
transitive closure of CocoaPods dependencies.

As an immediate fix, we opt back into the build system used by Xcode 9
and earlier. Longer term, we need to update our templates and
flutter_tools to correctly handle this situation.

See: https://github.com/flutter/flutter/issues/20685
2018-09-18 10:05:46 -07:00
Danny Tuppeny
ff9dc22e44
Run logcat through shell (#21977)
This should fix #18889 which may be related to `adb logcat` not working correctly in non-terminals on some LG devices. See https://github.com/flutter/flutter/issues/18889#issuecomment-422217761.
2018-09-18 17:57:31 +01:00
Jacob Richman
ccd070a5b4
Add back screenshot extension that was temporarily disabled. (#21828)
Add back screenshot extension that was temporarily disabled.

Add matchesReferenceImage matcher to test that the screenshot extension
generates equivalent images to InspectorService.instance.screenshot.
2018-09-18 09:32:39 -04:00
Alexandre Ardhuin
e2d0b062d9
remove unnecessary ignore prefer_const_constructors (#21934) 2018-09-18 05:54:03 +02:00
Chris Bracken
4c045e79fb
Revert "Use Xcode legacy build system for iOS builds (#21901)" (#21966)
This caused issues for projects without an Xcode workspace. Almost all
Flutter projects in the wild will have a workspace, but this patch needs
to add a check to catch any that lack one.

This reverts commit 021f472efce2109e010d788319582a172b4be6c7.
2018-09-17 18:22:54 -07:00
Chris Bracken
021f472efc
Use Xcode legacy build system for iOS builds (#21901)
Xcode 10 introduces a new build system which includes stricter checks on
duplicate build outputs.

When plugins are in use, there are two competing build actions that copy
Flutter.framework into the build application Frameworks directory:

  1. The Embed Frameworks build phase for the Runner project
  2. The [CP] Embed Pods Frameworks build phase that pod install creates
     in the project.

Item (1) is there to ensure the framework is copied into the built app
in the case where there are no plugins (and therefore no CocoaPods
integration in the Xcode project). Item (2) is there because Flutter's
podspec declares Flutter.framework as a vended_framework, and CocoaPods
automatically adds a copy step for each such vended_framework in the
transitive closure of CocoaPods dependencies.

As an immediate fix, we opt back into the build system used by Xcode 9
and earlier. Longer term, we need to update our templates and
flutter_tools to correctly handle this situation.

See: https://github.com/flutter/flutter/issues/20685
2018-09-17 17:54:57 -07:00
Jason Simmons
6f435b286e
Stop the animation controller if a CircularProgressIndicator is determinate (#21832)
Fixes https://github.com/flutter/flutter/issues/21445
2018-09-17 10:08:27 -07:00
liyuqian
1ad538e454
Fix the @macro link in doc (#21890)
Is it possible to add a unit test to make sure that all links in our
Dart doc are valid?
2018-09-14 16:47:28 -07:00
liyuqian
872eba2d4c
Track 90th, 99th percentile instead of missed_frame_build_budget_count (#21754)
See https://github.com/flutter/flutter/pull/19121#issuecomment-419520765
2018-09-14 13:24:13 -07:00
Alexandre Ardhuin
a07d3719a1
enable lint prefer_generic_function_type_aliases (#21680) 2018-09-14 21:06:19 +02:00
Michael Goderbauer
dda7382e49
Fix the the (#21732) 2018-09-14 12:42:20 +02:00
Mehmet Fidanboylu
2895d71b79
Make Flutter repo Dart SDK 2.1-dev3.1 compatible (#21853)
This is a blocker for Google roll since we are not at dev4.0:
- Future is not yet part of dart:core.
- Future.sync().then<dynamic>... causes failure without the new keyword.
2018-09-13 18:50:21 -07:00
liyuqian
069cddaa67
Missing default hardEdge clip for ClipRectLayer (#21826)
In my local tests, this should finally fix https://github.com/flutter/flutter/issues/21617
2018-09-13 11:42:49 -07:00
Jonah Williams
9bf8502fef
Add debug check for localization parent (#20787) 2018-09-13 10:47:31 -07:00
Alexander Aprelev
199422cd2d
Skip first time full dill transfer (#21133)
* Don't sync first full kernel file.

* Update the comment
2018-09-13 09:01:47 -07:00
Hans Muller
d107ff9d48
Make TabBar's tab label padding configurable (#21758) 2018-09-13 08:59:00 -07:00
Gary Qian
28ba95abb1
Default clipBehavior of ClipRect to hardEdge. (#21703)
Previously, the engine did not properly pass the AA flag on ClipRect.clipBehavior. flutter/engine#6199 fixes this and enables AA. However, default AA on clipRects has caused severe regressions in benchmark performance.

To maintain expected performance, we should now default the clipBehavior to hardEdge to disable default AA. This is consistent with any flutter projects that did not previously explicitly set the clipBehavior and should not change app appearance.
2018-09-13 00:32:12 -07:00
Alexander Aprelev
d61b48b75d
Fix integration hot-reload test on mac. (#21741)
Underlying issue with breakpoint was that /var path is a symlink to a /private/var on mac. Because of that breakpoint could not be resolved.
2018-09-12 22:35:21 -07:00
Jonah Williams
23499f4004
Fix typo in MediaQuery.fromWindow and add invertColors flag to images for smart invert. (#21457) 2018-09-12 14:50:49 -07:00
Jonah Williams
5ea987db1d
Adjust floating label height when font size is larrrrgeee (#21248) 2018-09-12 14:17:43 -07:00
Jonah Williams
dd1c22e389
fix_some_padding (#20967) 2018-09-12 14:07:02 -07:00
Jacob Richman
29fae06f48
Temporarily remove screenshot service extension that is causing code size issues (#21749)
* Revert "Avoid ever creating the WidgetInspectorService outside of debug mode. (#21648)"

This reverts commit eeebd8332a5f4f5c79a9c77877781d7f1132d57b.

* Remove inspector screenshot service extension.
2018-09-12 13:30:16 -07:00
Hans Muller
0cc9ee5bf8
Updated Material translations (#21744)
Replaced about 535 "TBD" translations with the real thing.

Added remainingTextFieldCharacterCountTwo, remainingTextFieldCharacterCountMany, remainingTextFieldCharacterCountFew, to GlobalMaterialLocalizations
2018-09-12 13:03:01 -07:00
Joao da Silva
66e5422375 Check for AndroidStudio plugins in the right .dot dir. (#20619)
This fixes issues 11940 and 18155.
2018-09-12 08:15:30 -07:00
Ben Hagen
07dd80712e Call setState() (#21642) 2018-09-12 14:31:50 +02:00
Alexandre Ardhuin
d927c93310
Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
Todd Volkert
d7a0dcaa4a
Fix race condition in resident_runner (#21696)
* Don't set the `vmServices` member variable until it's fully initialized.
* Add a timeout to the future that sends the 'started' event to the IDE

https://github.com/flutter/flutter/issues/16604
2018-09-11 20:58:47 -07:00
Jonah Williams
fa0a857d02
Add material tap target size and text contrast test to gallery (#21581) 2018-09-11 08:27:32 -07:00
Alexandre Ardhuin
387948a239
remove an avoid_void_async lint (#21672) 2018-09-11 08:51:42 +02:00
Alexandre Ardhuin
774ca2f197
enable lint avoid_void_async (#21652) 2018-09-11 07:14:04 +02:00
Dan Field
98ad574d9b
Fix keepalive for large jumps on tabs and lists. (#21350)
* Ensure that the _childElements map is properly traversed as a sparse list and not inflated with garbage collected children.

* Add tests to ensure Lists/Tabs with KeepAlive children can make large jumps, don't lose children (including after rebuild).
2018-09-10 21:01:10 -04:00
Jacob Richman
eeebd8332a
Avoid ever creating the WidgetInspectorService outside of debug mode. (#21648) 2018-09-10 15:20:22 -07:00
jslavitz
9dce4b8259
Shortcuts (#21558)
* added shortcuts and delete functionality

* added first test

*  afew chnages

* a few changes

* hope this works

* small change

* small changes

* fixed nits

* final changes:

* fixed initializing formals

* update comment

* minor change:

* added line

* final changes

* random change

* changed function to void

* one more

* removed line

* dis betta work

* final change

* actual final chnge
2018-09-10 13:47:04 -07:00
Michael Klimushyn
8ebd352511
Add semantic routing to CupertinoAlertDialog (#21583)
Fixes #21250
2018-09-10 13:15:55 -07:00