firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,404 Commits 1 Branch 0 Tags
Commit Graph

27736 Commits

Author SHA1 Message Date
Jonah Williams
c04f249ca0 [Impeller] move more aiks tests to DL. (flutter/engine#53792) 
Move more impeller tests to display list format. This allows our integration tests to also test the display list -> aiks interop and be future compatible with the new canvas backend that removes AIKS.

Part of https://github.com/flutter/flutter/issues/142054
 2024-07-11 18:35:52 +00:00
skia-flutter-autoroll
902e78dd2a Roll Skia from ec4a1e03f7b0 to 004c81523e44 (23 revisions) (flutter/engine#53813) 
https://skia.googlesource.com/skia.git/+log/ec4a1e03f7b0..004c81523e44

2024-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3c9cca49b866 to 2d5b62fa0b39
2024-07-11 robertphillips@google.com [graphite] Make RuntimeEffect precompilation match the rest of the system
2024-07-11 kjlubick@google.com Add presubmit check to detect accidental leakage of src/ into include/
2024-07-11 robertphillips@google.com [graphite] Replace PrecompileChildPtr with a sk_sp<PrecompileBase>
2024-07-11 fmalita@google.com Revert "[graphite] Add non-aa bounds filling renderer"
2024-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from eff9c7d7bfff to bc656cdad31e (3 revisions)
2024-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3c9cca49b866 to 67fb1a1b693f (8 revisions)
2024-07-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f986604e2165 to c7002cf03eb0 (14 revisions)
2024-07-11 sunnyps@chromium.org graphite: Use format index for pipeline render pass key
2024-07-10 fmalita@google.com Remove assert in SubRun deserialization
2024-07-10 jamesgk@google.com Update viewer/android build
2024-07-10 michaelludwig@google.com [graphite] Add non-aa bounds filling renderer
2024-07-10 lokokung@google.com [dawn] Use new device callback types in Graphite
2024-07-10 michaelludwig@google.com [graphite] CoverBoundsRenderStep can be configured with custom DepthStencilSettings
2024-07-10 jvanverth@google.com [graphite] Add colorspace xform to primitive color
2024-07-10 nathanasanchez@google.com Revert "[Graphite] Enable storage buffers in Vulkan"
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 14d1f6cd4cd2 to f986604e2165 (11 revisions)
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9ad77082be54 to eff9c7d7bfff (2 revisions)
2024-07-10 nathanasanchez@google.com [Graphite] Add perspective local matrix shader
2024-07-10 nathanasanchez@google.com [Graphite] Add perspective flag to precompile LMS
2024-07-10 johnstiles@google.com Reject interface blocks containing a boolean.
2024-07-10 nathanasanchez@google.com [Graphite] Enable storage buffers in Vulkan
2024-07-10 michaelludwig@google.com [graphite] Add substruct support to UniformOffsetCalculator

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-11 14:56:37 +00:00
skia-flutter-autoroll
8d354698bb Roll Skia from 2783ba54bf8e to ec4a1e03f7b0 (9 revisions) (flutter/engine#53797) 
https://skia.googlesource.com/skia.git/+log/2783ba54bf8e..ec4a1e03f7b0

2024-07-10 robertphillips@google.com [graphite] Update the runtimeEffect subtest in CombinationBuilderTest
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fa0d147877f0 to 06f0adf6d6df
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8800433c75e6 to 14d1f6cd4cd2 (22 revisions)
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 14b58abf4d15 to 9ad77082be54 (15 revisions)
2024-07-10 kjlubick@google.com Move ContextOptionsPriv from include/private to src/
2024-07-10 brianosman@google.com In the stroker: store tangent vectors, not tangent points
2024-07-10 chengyangyang-hf@loongson.cn [loong64] Fix linker error by undefined symbols.
2024-07-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3ab5644b59e3 to 3c9cca49b866 (8 revisions)
2024-07-10 e2lahav@gmail.com Change instances of true/false to TRUE/FALSE for libjpeg

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-11 13:46:06 +00:00
skia-flutter-autoroll
973ba5a587 Roll Fuchsia Linux SDK from SrAow18WmBW8IDjza... to 0e47sje8wkJ08sGJ6... (flutter/engine#53804) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-11 01:50:33 +00:00
skia-flutter-autoroll
50cac1a36e Roll Dart SDK from c6053ad84f2b to fb546f313557 (1 revision) (flutter/engine#53801) 
https://dart.googlesource.com/sdk.git/+log/c6053ad84f2b..fb546f313557

2024-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-26.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-10 23:38:30 +00:00
Srujan Gaddam
b33b900e77 Remove casts for toDartObject (flutter/engine#53621) 
ExternalDartReference is now generic, so we can just type it and
toDartObject will do the cast for us if needed. Also removes now-stale
ignores.
 2024-07-10 15:47:39 -07:00
Tong Mu
bfc7116202 [macOS] Multiview compositor (flutter/engine#52253) 
This PR makes the macOS `FlutterCompositor` able to handle multiple views by adding methods `AddView` and `RemoveView`.

These two methods must take place on the main queue (platform thread), which is indeed the case, but extra effort is made to assert so. This is important because, due to the constraint of the macOS system that requires rendering to take place on the platform thread (hence `FlutterThreadSynchronizer`), no locks are needed to avoid race condition between `Add/RemoveView` and presenting.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-07-10 21:10:06 +00:00
skia-flutter-autoroll
f7e349e54e Roll Dart SDK from dba0dfbd06eb to c6053ad84f2b (3 revisions) (flutter/engine#53798) 
https://dart.googlesource.com/sdk.git/+log/dba0dfbd06eb..c6053ad84f2b

2024-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-25.0.dev
2024-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-24.0.dev
2024-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-23.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-10 19:27:48 +00:00
Jackson Gardner
76caabd2c4 Reland (x2) "Output .js files as ES6 modules. (flutter#52023)" (flutter/engine#53718) 
Second attempt to reland https://github.com/flutter/engine/pull/52023

Fixes since the previous reland attempt:
* We need to pass the skwasm main JS URI when loading the module so that it can pass that along to the worker. Since the worker uses the workaround to allow a cross script worker, it has trouble locating the main JS URI in relation to itself in a way that actually works for dynamic imports, so passing it along fixes that issue.
* Some of the Google3 tests relied on the relative default canvaskit path. Dynamic module imports seems to not handle relative paths the way we expect, so we do our own URL resolution using the URL constructor before passing it into the dynamic import API. Also cleaned up some of the other relative pathing stuff that we do around the base URI. in flutter.js
 2024-07-10 16:19:28 +00:00
skia-flutter-autoroll
8f0cb56a60 Roll Skia from 46e5bf98158a to 2783ba54bf8e (2 revisions) (flutter/engine#53796) 
https://skia.googlesource.com/skia.git/+log/46e5bf98158a..2783ba54bf8e

2024-07-10 petermcneeley@chromium.org Shader trace for cache load and pipeline creation
2024-07-10 michaelludwig@google.com [graphite] Preliminary update to ShaderSnippet to support aggregate uniforms in structs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-10 15:27:55 +00:00
Chinmay Garde
8c45ce5af9 [Impeller] Fix markdown formatting for blocks with tips. (flutter/engine#53789) 
In the previous patch, I had used the incorrect markdown syntax.

Followup for https://github.com/flutter/engine/pull/53671
 2024-07-10 05:40:20 +00:00
auto-submit[bot]
5a218a1b99 Reverts "dart:ui - drop deprecated hash functions (#53787)" (flutter/engine#53794) 
Reverts: flutter/engine#53787
Initiated by: jiahaog
Reason for reverting: There are still internal users of these hash functions (b/352191023). Flutter also exports it [here](72f83d3237/packages/flutter/lib/src/painting/basic_types.dart (L58)) so its easy for developers to use them even without importing `dart:ui`. Though it's an easy fix, I'd imagine this to be a breaking change for the OSS ecosystem a
Original PR Author: kevmoo

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
These were deprecated a LONG time ago
 2024-07-10 03:16:50 +00:00
auto-submit[bot]
6b738ccea4 Reverts "web_ui: drop internal hash code library (#53783)" (flutter/engine#53793) 
Reverts: flutter/engine#53783
Initiated by: jiahaog
Reason for reverting: There are still internal users of these hash functions (b/352191023). Flutter also exports it [here](72f83d3237/packages/flutter/lib/src/painting/basic_types.dart (L58)) so its easy for developers to use them even without importing `dart:ui`. Though it's an easy fix, I'd imagine this to be a breaking change for the OSS ecosystem a
Original PR Author: kevmoo

Reviewed By: {yjbanov}

This change reverts the following previous change:
We moved to dart:core Object functions a while ago
 2024-07-10 03:16:48 +00:00
skia-flutter-autoroll
3731cb0d3d Manual roll Dart SDK from ffc8bb004a64 to dba0dfbd06eb (23 revisions) (flutter/engine#53791) 
Manual roll requested by asiva@google.com

https://dart.googlesource.com/sdk.git/+log/ffc8bb004a64..dba0dfbd06eb

2024-07-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-22.0.dev
2024-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-21.0.dev
2024-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-20.0.dev
2024-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-19.0.dev
2024-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-18.0.dev
2024-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-17.0.dev
2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-16.0.dev
2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-15.0.dev
2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-14.0.dev
2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-13.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-12.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-11.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-10.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-9.0.dev
2024-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-8.0.dev
2024-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-7.0.dev
2024-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-6.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-5.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-4.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-3.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-2.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-1.0.dev
2024-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-0.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com,bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-10 02:00:22 +00:00
John McDole
ea09bae632 Impeller really wants premultiplied alpha (flutter/engine#53770) 
Fixes flutter/flutter#151210 by premultiplying alpha in the rare case we
get straight alpha.
 2024-07-09 17:07:31 -07:00
Kevin Moore
3ac0cca053 dart:ui - drop deprecated hash functions (flutter/engine#53787) 
These were deprecated a LONG time ago
 2024-07-09 23:50:06 +00:00
Chinmay Garde
e4f189806b [Impeller] Validation errors in tests cause GTest failures. (flutter/engine#53786) 
Earlier, this used to take down the entire process. Now, the entire set of failures will be listed instead.
 2024-07-09 23:48:19 +00:00
Chinmay Garde
8d233c3b90 [Impeller] Update docs that specify how to select the Impeller backend. (flutter/engine#53788) 2024-07-09 23:48:16 +00:00
Chinmay Garde
f3db22d5d9 [Impeller] Validation logs indicate where in code the validation error happened. (flutter/engine#53784) 
Earlier, all validation logs originated from validation.cc which was not
useful at all since you had to find the string in the source.
 2024-07-09 15:09:28 -07:00
skia-flutter-autoroll
b556342b28 Roll Fuchsia Linux SDK from yYs6rINJxWJ8J2vxo... to SrAow18WmBW8IDjza... (flutter/engine#53785) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-09 21:57:21 +00:00
Kevin Moore
7c90831f07 web_ui: drop internal hash code library (flutter/engine#53783) 
We moved to dart:core Object functions a while ago
 2024-07-09 21:52:28 +00:00
Chinmay Garde
f2165798f7 Avoid using a private GTest macro to skip tests. (flutter/engine#53782) 
I admit to using this private macro initially without realizing that the documented way to do this is to use the stream the other macro returns. The non-private variant is actually more powerful since it allows for easier customization of the reason for the skip.

No change in functionality. Just removes the use of the private macros.
 2024-07-09 20:34:51 +00:00
Jonah Williams
aafe60d894 [Impeller] Use downsample shader for blur instead of mip levels. (flutter/engine#53760) 
Fixes https://github.com/flutter/flutter/issues/150973

On a Pixel 7 pro, this speeds up the repeated blur macrobenchmark by 20ms (~65 -> ~45). The mip computation for backdrop filters is especially wasteful, as most of the contents are unused. RIght now, we also need to continually re-generate mips every time we do a texture flip, even if there is only a single blur. This is because the mip level is a property of the texture, which gets reused in the entity pass backdrop.
 2024-07-09 19:58:19 +00:00
Jonah Williams
d11db4f8c9 [engine] support combined UI/Platform thread for iOS/Android. (flutter/engine#53656) 
Experimentally support merging UI and platform thread on Android/iOS. This works by changing the shell holder to set the UI thread to the platform thread. Several shell APIs that post messages from the platform to ui thread were changed to use RunNowOrPostTask to immediately call the UI task if the threads are the same.

Experimentally, this seems to work reasonably well if there are no platform views. On Android with TLHC it works fine either way, while iOS currently takes a big performance hit.

This can be opted into via a Plist:

```
	<key>FLTEnableMergedPlatformUIThread</key>
	<true/>
```

Or via AndroidManifest.xml:

```
 <meta-data
            android:name="io.flutter.embedding.android.EnableMergedPlatformUIThread"
            android:value="true" />
```

https://github.com/flutter/flutter/issues/150525
 2024-07-09 19:32:20 +00:00
Chinmay Garde
0ad423aaea [Impeller] Enable framebuffer fetch tests disabled on OpenGL ES. (flutter/engine#53766) 
The texel fetch fallback used in place of framebuffer fetch isn't supported on ES 100. And this test is explicitly about framebuffer fetch.

Fixes https://github.com/flutter/flutter/issues/144181

<img width="1050" alt="Screenshot 2024-07-08 at 3 21 30 PM" src="https://github.com/flutter/engine/assets/44085/b7468a2d-c385-457c-adf4-2ddb2cbae4a2">
 2024-07-09 19:24:03 +00:00
Jonah Williams
ef889f9d05 [Impeller] implement experimental canvas in snapshot controller. (flutter/engine#53750) 
Fixes https://github.com/flutter/flutter/issues/150994

This ensures that the dart:ui API toImage and toImageSync use the experimental canvas API when the define is set. No other changes.
 2024-07-09 19:19:57 +00:00
Chinmay Garde
64463f4556 [Impeller] Disable OpenGL dithering by default. (flutter/engine#53768) 
My expectation was that all toggles were disabled with OpenGL. But the specification states: "The initial value for each capability with the exception of GL_DITHER is GL_FALSE. The initial value for GL_DITHER is GL_TRUE."

The kind of dithering is implementation dependent and our layered OpenGL implementations choose to do nothing when this is enabled (unless extensions like VK_EXT_legacy_dithering are supported). Since, again, per the spec: "As far as OpenGL layering is concerned, no dithering is technically an acceptable algorithm".

But it does have a cost of older hardware where dithering is supported.

This sets the default to match our other backends and get some performance on hardware that does do dithering.
 2024-07-09 18:03:18 +00:00
Brandon DeRosier
c78799b576 Revert 4 Dart rolls (726cb2467 -> ffc8bb004) to recover engine roll (flutter/engine#53778) 
Tracking bug: https://github.com/flutter/flutter/issues/151473
To resolve engine roll failures starting on roll:
https://github.com/flutter/flutter/pull/151434

Reverts 4 Dart rolls:
- Roll Dart SDK from ffc8bb004a64 to 1679aba20a03 (16 revisions)
(#53761) 998d1fa85578e719607105125169e5a55b9e6f6b
- Roll Dart SDK from 1679aba20a03 to 0ecada960645 (1 revision) (#53767)
0585cb610e02b4831edf3d9a850a3eae21c4b75e
- Roll Dart SDK from 0ecada960645 to 33b65d2fe034 (2 revisions) (#53772)
5bbc45ba606adb1ec5227b52b5fe16c65ce389ff
- Roll Dart SDK from 33b65d2fe034 to 726cb2467f27 (1 revision) (#53776)
4ff005801023f2d70256f69411ead0e550fbf749
 2024-07-09 10:29:47 -07:00
skia-flutter-autoroll
4ff0058010 Roll Dart SDK from 33b65d2fe034 to 726cb2467f27 (1 revision) (flutter/engine#53776) 
https://dart.googlesource.com/sdk.git/+log/33b65d2fe034..726cb2467f27

2024-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-19.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-09 13:58:24 +00:00
skia-flutter-autoroll
b4172d92d6 Roll Skia from 9a6f8dfb9102 to 46e5bf98158a (1 revision) (flutter/engine#53775) 
https://skia.googlesource.com/skia.git/+log/9a6f8dfb9102..46e5bf98158a

2024-07-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 56239a1e581e to 3ab5644b59e3 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-09 06:59:35 +00:00
dependabot[bot]
02a7e2536d Bump actions/upload-artifact from 4.3.3 to 4.3.4 (flutter/engine#53774) 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.3.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Update <code>@​actions/artifact</code> version, bump dependencies by <a href="https://github.com/robherley"><code>@​robherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/584">actions/upload-artifact#584</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.3...v4.3.4">https://github.com/actions/upload-artifact/compare/v4.3.3...v4.3.4</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0b2256b8c0"><code>0b2256b</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/584">#584</a> from actions/robherley/bump-pkgs</li>
<li><a href="488dcefb9b"><code>488dcef</code></a> licensed cache</li>
<li><a href="04c51f5766"><code>04c51f5</code></a> ncc</li>
<li><a href="32a9e276a8"><code>32a9e27</code></a> bump <code>@​actions/artifact</code> and npm audit</li>
<li><a href="552bf3722c"><code>552bf37</code></a> new version</li>
<li><a href="79616d2ded"><code>79616d2</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/565">#565</a> from actions/eggyhead/use-artifact-v2.1.6</li>
<li>See full diff in <a href="65462800fd...0b2256b8c0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.3.3&new-version=4.3.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-07-09 06:49:27 +00:00
skia-flutter-autoroll
5bbc45ba60 Roll Dart SDK from 0ecada960645 to 33b65d2fe034 (2 revisions) (flutter/engine#53772) 
https://dart.googlesource.com/sdk.git/+log/0ecada960645..33b65d2fe034

2024-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-18.0.dev
2024-07-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-17.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-09 05:49:34 +00:00
skia-flutter-autoroll
24dba5994f Roll Skia from 9edafde22cb3 to ced941fdddc4 (2 revisions) (flutter/engine#53769) 
https://skia.googlesource.com/skia.git/+log/9edafde22cb3..ced941fdddc4

2024-07-08 kjlubick@google.com Remove exports_files_legacy
2024-07-08 johnstiles@google.com Use powr(x, y) in Metal instead of pow(x, y).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-09 00:15:17 +00:00
skia-flutter-autoroll
0585cb610e Roll Dart SDK from 1679aba20a03 to 0ecada960645 (1 revision) (flutter/engine#53767) 
https://dart.googlesource.com/sdk.git/+log/1679aba20a03..0ecada960645

2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-16.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-08 23:23:29 +00:00
Dustin Green
6d2812b3fe [fuchsia][sysmem2] move to sysmem2 protocols (flutter/engine#53138) 
Switch flutter from sysmem(1) protocols to sysmem2 protocols.

This is part of the overall sysmem(1) to sysmem2 migration.

fixes flutter/flutter#151154
 2024-07-08 16:22:16 -07:00
Chinmay Garde
580d14040d [Impeller] Exploit dynamic state in OpenGL for fewer program links. (flutter/engine#53764) 
Fixes https://github.com/flutter/flutter/issues/145125
 2024-07-08 22:54:55 +00:00
Jonah Williams
6ba3e46d9a [Impeller] fix incorrect padding/translation in drawVertices with texture coordinates. (flutter/engine#53746) 
Fixes https://github.com/flutter/flutter/issues/151355

The coverage pad introduced by renderToSnapshot is being picked up by drawVertices with texture coordinates. The pad is showing up in the final results, which can appear to be a gap between elements.

Additionally: if the coverage computed from the texture coordinates does not include the origin, then make sure the coverage used for the snapshot is translated onscreen.
 2024-07-08 20:12:49 +00:00
skia-flutter-autoroll
02b5e9bbc3 Roll Skia from c65710d00047 to 9edafde22cb3 (3 revisions) (flutter/engine#53762) 
https://skia.googlesource.com/skia.git/+log/c65710d00047..9edafde22cb3

2024-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3ce1fd54c58a to 14b58abf4d15 (2 revisions)
2024-07-08 kjlubick@google.com Change anonymous enums to constexpr or enum classes where appropriate
2024-07-08 johnstiles@google.com Update SkSL docs to point to named Fiddles.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-08 20:11:05 +00:00
Jonah Williams
8c0ef89160 [Impeller] implement clear color opt for experimental canvas. (flutter/engine#53749) 
Fixes https://github.com/flutter/flutter/issues/150995

Rather than using a separate state bit, we can use whether the current render pass is active as an indicator for whether or not it is safe to apply the clear color optimization.
 2024-07-08 20:09:22 +00:00
Jonah Williams
c4258c8457 [Impeller] add experimental canvas support to screenshotter. (flutter/engine#53751) 
Fixes https://github.com/flutter/flutter/issues/150993

This change allows testing the experimental canvas dispatcher in the playgrounds, which is important for golden testing. The plan to enable requires demonstrating that the goldens are the same.
 2024-07-08 20:05:08 +00:00
Chinmay Garde
609d5e2bcb Add a host_debug_unopt local engine config for Windows. (flutter/engine#53734) 
We have these configs for Linux & macOS.
 2024-07-08 19:10:06 +00:00
skia-flutter-autoroll
998d1fa855 Roll Dart SDK from ffc8bb004a64 to 1679aba20a03 (16 revisions) (flutter/engine#53761) 
https://dart.googlesource.com/sdk.git/+log/ffc8bb004a64..1679aba20a03

2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-15.0.dev
2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-14.0.dev
2024-07-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-13.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-12.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-11.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-10.0.dev
2024-07-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-9.0.dev
2024-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-8.0.dev
2024-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-7.0.dev
2024-07-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-6.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-5.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-4.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-3.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-2.0.dev
2024-07-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-1.0.dev
2024-07-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-0.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-08 19:10:04 +00:00
skia-flutter-autoroll
502fe2211c Roll Skia from 38b17b22312d to c65710d00047 (2 revisions) (flutter/engine#53758) 
https://skia.googlesource.com/skia.git/+log/38b17b22312d..c65710d00047

2024-07-08 michaelludwig@google.com [graphite] Simplify FragSkSLInfo based on what's actually used
2024-07-08 johnstiles@google.com Replace hash-map with array in SkRP builder.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-08 18:07:10 +00:00
skia-flutter-autoroll
d5f02e5155 Roll Skia from 1f85fb9238aa to b2c51b2fe15f (3 revisions) (flutter/engine#53756) 
https://skia.googlesource.com/skia.git/+log/1f85fb9238aa..b2c51b2fe15f

2024-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from e01ce27481d2 to 3ce1fd54c58a (11 revisions)
2024-07-08 kjlubick@google.com Enforce IWYU across src/gpu/ganesh subfolders
2024-07-08 johnstiles@google.com Move `}  // END FIDDLE` onto a separate line.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-08 14:22:35 +00:00
skia-flutter-autoroll
a5d815e8e9 Roll Skia from f1d06de0ae87 to 1f85fb9238aa (2 revisions) (flutter/engine#53753) 
https://skia.googlesource.com/skia.git/+log/f1d06de0ae87..1f85fb9238aa

2024-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 56239a1e581e to c8809f07361f
2024-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6c155414a139 to 56239a1e581e (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-08 07:40:20 +00:00
skia-flutter-autoroll
d5835792df Roll Fuchsia Linux SDK from unavXf_l4lhu23MGg... to RSMFdOFyLxulsvY4_... (flutter/engine#53743) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-06 15:01:25 +00:00
Yegor
b75d1ddcac [web] use semantic tags for headings (h1, h2, etc), and fix missing secondary roles (flutter/engine#53703) 
Switch to using semantic heading tags (h1, h2, etc).

Fix missing secondary roles: focus, live region, route name, and label.
Improves indexability (https://github.com/flutter/flutter/issues/46789)
 2024-07-05 17:59:22 +00:00
skia-flutter-autoroll
690f6f8331 Roll Fuchsia Linux SDK from 5WGhpr75y_pb6u2OO... to unavXf_l4lhu23MGg... (flutter/engine#53739) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-05 13:49:23 +00:00
skia-flutter-autoroll
064d49d547 Roll Skia from 92861012bcc1 to 4a27ce0f92d4 (4 revisions) (flutter/engine#53738) 
https://skia.googlesource.com/skia.git/+log/92861012bcc1..4a27ce0f92d4

2024-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6c155414a139 to aed65f2e3de8
2024-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d35ababad9bf to 6c155414a139 (2 revisions)
2024-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a0ec371d8331 to f23c77132e0b (1 revision)
2024-07-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b29e25b27eda to bbac3636580e (28 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-05 07:03:05 +00:00
skia-flutter-autoroll
12d1eba7d7 Roll Fuchsia Linux SDK from -VgqOfoW5sf04SuJh... to 5WGhpr75y_pb6u2OO... (flutter/engine#53728) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-07-04 12:40:08 +00:00