firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,404 Commits 1 Branch 0 Tags
Commit Graph

36404 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
gaaclarke
956c30fbf3 [impeller] Cleanup blur (flutter/engine#53543) 
This is a refactor, no functional change.

We have a few issues in flight that talk about improving the blur. This
attempts to clean everything up a bit to make it easier for us to
change.


issues: 
- https://github.com/flutter/flutter/issues/150713
- https://github.com/flutter/flutter/issues/150722
- https://github.com/flutter/flutter/issues/150720

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-06-25 08:35:37 -07:00
skia-flutter-autoroll
712cb91027 Roll Skia from 3029f75db702 to 5f21260470cf (2 revisions) (flutter/engine#53557) 
https://skia.googlesource.com/skia.git/+log/3029f75db702..5f21260470cf

2024-06-25 lokokung@google.com Use spontaneous mode for device lost callback in Dawn.
2024-06-25 kjlubick@google.com Update cmake to v3.29.0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 15:02:05 +00:00
Mouad Debbar
2d762001d3 [web] Implement AppLifecycleState.detached as documented (flutter/engine#53506) 
Currently, we are transitioning to the `AppLifecycleState.detached` incorrectly. This is causing the framework to stop pumping frames when the app is still active and visible.

This PR re-implements the transition to `AppLifecycleState.detached` as documented [here](https://api.flutter.dev/flutter/dart-ui/AppLifecycleState.html#detached) (based on whether the app has any views or not).

Fixes https://github.com/flutter/flutter/issues/150636
Fixes https://github.com/flutter/flutter/issues/149417
 2024-06-25 14:14:17 +00:00
skia-flutter-autoroll
833ddf5993 Roll Skia from 335200e57c26 to 3029f75db702 (2 revisions) (flutter/engine#53554) 
https://skia.googlesource.com/skia.git/+log/335200e57c26..3029f75db702

2024-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e080995c5d21 to d6925c2a17cc (4 revisions)
2024-06-25 michaelludwig@google.com Fix NPE in Tagged Images slide

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 10:12:21 +00:00
skia-flutter-autoroll
52fd0b4db7 Roll Dart SDK from bb18127b2a8e to b5fc85cfcf1b (1 revision) (flutter/engine#53552) 
https://dart.googlesource.com/sdk.git/+log/bb18127b2a8e..b5fc85cfcf1b

2024-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-297.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 06:53:24 +00:00
skia-flutter-autoroll
3d334399ff Roll Skia from 5feca3095719 to 335200e57c26 (1 revision) (flutter/engine#53549) 
https://skia.googlesource.com/skia.git/+log/5feca3095719..335200e57c26

2024-06-25 michaelludwig@google.com [graphite] Fix conic_sk_conical_grad_buf_shader signature

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 03:49:08 +00:00
skia-flutter-autoroll
51f6668176 Roll Dart SDK from c187d4b3ec88 to bb18127b2a8e (1 revision) (flutter/engine#53547) 
https://dart.googlesource.com/sdk.git/+log/c187d4b3ec88..bb18127b2a8e

2024-06-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-296.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 02:15:27 +00:00
skia-flutter-autoroll
d767e405d3 Roll Fuchsia Linux SDK from _6HNhJ6G59VMceKoN... to WUN7NQK04NjF9fRmf... (flutter/engine#53545) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-25 01:41:05 +00:00
auto-submit[bot]
c352f44015 Reverts "Re-re-land "Upgrade all[most] androidx dependencies to latest" (#53532)" (flutter/engine#53546) 
Reverts: flutter/engine#53532
Initiated by: gmackall
Reason for reverting: This breaks apps that use plugins that use compileSdk 31, some of which we use in our postsubmit (so it blocks the tree).
Original PR Author: gmackall

Reviewed By: {reidbaker, matanlurey}

This change reverts the following previous change:
Re-re-land https://github.com/flutter/engine/pull/53001

(Reland attempt was at https://github.com/flutter/engine/pull/53462)

Unblocked by https://github.com/flutter/flutter/pull/150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles.

Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on https://github.com/flutter/flutter/issues/149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-25 01:20:29 +00:00
Brandon DeRosier
42a12876fa Bump impeller-cmake-example (flutter/engine#53538) 
- impeller-cmake: https://github.com/bdero/impeller-cmake/pull/25
- impeller-cmake-example: https://github.com/bdero/impeller-cmake-example/pull/23
 2024-06-25 00:13:06 +00:00
skia-flutter-autoroll
87ea39e626 Roll Skia from e20c8b0bac0c to 5feca3095719 (1 revision) (flutter/engine#53544) 
https://skia.googlesource.com/skia.git/+log/e20c8b0bac0c..5feca3095719

2024-06-24 zhusida@bytedance.com Add 16bit BT2020, YCGCO color space support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 23:25:23 +00:00
David Iglesias
0131b53f3c [web] Reland "Fix focus management for text fields (#51009)" (flutter/engine#53537) 
Relands: [**Fix focus management for text fields** (#51009)](https://github.com/flutter/engine/pull/51009) by:

* Reverting commit: 249de68438 (https://github.com/flutter/engine/pull/53502).
* Keeping the new `ViewFocusBinding` disabled, as [suggested](https://github.com/flutter/engine/pull/51009#discussion_r1649500122).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-24 22:15:11 +00:00
skia-flutter-autoroll
f3c89d8f97 Roll Dart SDK from 5df89347bddf to c187d4b3ec88 (1 revision) (flutter/engine#53542) 
https://dart.googlesource.com/sdk.git/+log/5df89347bddf..c187d4b3ec88

2024-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-295.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 22:05:38 +00:00
Chris Bracken
ab3c5ba987 [macOS] Generate universal gen_snapshots (flutter/engine#53524) 
This reverts commit b16181fe6adf18f448058fd4e68ceb4f78f601ab (#52913).
This relands commit f73900ba16ab3873c7f631ab321d4f0ac0194a8e (#52885).

Previously, the `gen_snapshot_arm64` and `gen_snapshot_x64` binaries used by the tool were all built for x64 architecture. As such, developers building apps with Flutter rely on Rosetta translation with every build.

This refactors the gen_snapshot build rules on macOS hosts to consistently produce `gen_snapshot_arm64` and `gen_snapshot_x64` binaries with the target architecture of the build but with as universal binaries with both host architectures.

## arm64 host build

Prior to this patch we emitted:
* gen_snapshot_arm64 (arch: x64, target_arch: simarm64)

After this patch, we emit:
* artifacts_x64/gen_snapshot_arm64 (arch: x64, target_arch: simarm64)
* artifacts_arm64/gen_snapshot_arm64 (arch: arm64, target_arch: arm64)
* gen_snapshot_arm64 (universal binary composed of both of the above)

## x64 host build

Prior to this patch we emitted:
* gen_snapshot_x64 (arch: x64, target_arch: x64)

After this patch, we emit:
* artifacts_x64/gen_snapshot_x64 (arch: x64, target_arch: x64)
* artifacts_arm64/gen_snapshot_x64 (arch: arm64, target_arch: simx64)
* gen_snapshot_x64 (universal binary composed of both of the above)

Note that host builds on macOS currently default to a host architecture of x64 (can be overridden via `--force-mac-arm64`) regardless of host architecture and thus, the build itself relies on Rosetta translation when invoked on Apple Silicon arm64 hardware. This is to ensure a consistent build in CI regardless of bot architecture. See: 0d2b0cd0ed/tools/gn (L502-L505)

Issue: https://github.com/flutter/flutter/issues/101138
Issue: https://github.com/flutter/flutter/issues/69157

Related issue: https://github.com/flutter/flutter/issues/103386

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-24 22:01:09 +00:00
Gray Mackall
f9b2f290ba Re-re-land "Upgrade all[most] androidx dependencies to latest" (flutter/engine#53532) 
Re-re-land https://github.com/flutter/engine/pull/53001

(Reland attempt was at https://github.com/flutter/engine/pull/53462)

Unblocked by https://github.com/flutter/flutter/pull/150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles.

Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on https://github.com/flutter/flutter/issues/149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-24 21:36:22 +00:00
skia-flutter-autoroll
38ce0e731f Roll Skia from 1948fd53e280 to e20c8b0bac0c (1 revision) (flutter/engine#53540) 
https://skia.googlesource.com/skia.git/+log/1948fd53e280..e20c8b0bac0c

2024-06-24 mike@reedtribe.org API to return a scaled version of an image

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 20:52:21 +00:00
skia-flutter-autoroll
a6aa2a974a Roll Skia from 0fa58b6ddba0 to 1948fd53e280 (2 revisions) (flutter/engine#53536) 
https://skia.googlesource.com/skia.git/+log/0fa58b6ddba0..1948fd53e280

2024-06-24 brianosman@google.com Remove asserts about "valid" premultiplied colors in SkPackARGB32
2024-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e53b3ad72322 to 3c472b45024a (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 19:33:23 +00:00
skia-flutter-autoroll
941a47b78c Roll Skia from ea84df425483 to 0fa58b6ddba0 (3 revisions) (flutter/engine#53535) 
https://skia.googlesource.com/skia.git/+log/ea84df425483..0fa58b6ddba0

2024-06-24 michaelludwig@google.com [graphite] Add validation for PaintParamsKeyBuilder::addData
2024-06-24 kjlubick@google.com Build skslc and sksl-minify from the modular Bazel build.
2024-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3a8b46766c4e to ff63e67e4739 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 18:16:19 +00:00
gaaclarke
b6e6849f95 [Impeller] added a fallback that will make sure the blur fragment shader doesn't overflow (flutter/engine#53466) 
issue: https://github.com/flutter/flutter/issues/150462

This makes that usage never crash.  I would like to reevaluate for a better fix later though.  Something like:
1) Rework the downsample logic to make sure this gap doesn't exist.
1) Simply increase the kernel size.  We already did that before and technically we should be clamped to the 500 sigma so we won't have to do it forever.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-24 18:01:00 +00:00
Jonny Wang
c2f5afd59a [fuchsia] Update Fuchsia API level to 19 (flutter/engine#53494) 
Update Fuchsia API level to 19

b/347290402

Tests: cl/645133515

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-06-24 18:56:40 +01:00
skia-flutter-autoroll
0f617fc820 Roll Dart SDK from 95470b2cac1f to 5df89347bddf (1 revision) (flutter/engine#53534) 
https://dart.googlesource.com/sdk.git/+log/95470b2cac1f..5df89347bddf

2024-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-294.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 17:52:49 +00:00
skia-flutter-autoroll
9ba9100068 Roll Skia from f6b4344d73cc to ea84df425483 (1 revision) (flutter/engine#53531) 
https://skia.googlesource.com/skia.git/+log/f6b4344d73cc..ea84df425483

2024-06-24 kjlubick@google.com Remove shims for GrVk* types

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 16:17:07 +00:00
Matan Lurey
233edc0b8f Add SurfaceProducer.Callback lifecycle hooks (flutter/engine#53280) 
Work towards https://github.com/flutter/flutter/issues/148417.
 2024-06-24 08:06:56 -07:00
skia-flutter-autoroll
9430dfd361 Roll Skia from b9671fd75308 to f6b4344d73cc (1 revision) (flutter/engine#53530) 
https://skia.googlesource.com/skia.git/+log/b9671fd75308..f6b4344d73cc

2024-06-24 bungeman@google.com Manual roll of skp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 15:05:05 +00:00
skia-flutter-autoroll
b3af1d33f6 Roll Dart SDK from 8f4cebdb3340 to 95470b2cac1f (1 revision) (flutter/engine#53528) 
https://dart.googlesource.com/sdk.git/+log/8f4cebdb3340..95470b2cac1f

2024-06-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-293.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 13:40:27 +00:00
skia-flutter-autoroll
bea2e775ad Roll Skia from 836eed6a0cd4 to b9671fd75308 (1 revision) (flutter/engine#53527) 
https://skia.googlesource.com/skia.git/+log/836eed6a0cd4..b9671fd75308

2024-06-24 bungeman@google.com Roll FreeType from a4642422 to 73720c7c (31 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 13:22:39 +00:00
Kaylee Lubick
2e2f3e35cd Update uses of GrVkBackendContext and other deprecated type names (flutter/engine#53491) 
As of [this CL](https://skia-review.googlesource.com/c/skia/+/859125),
`GrVkBackendContext` is an alias for `skgpu::VulkanBackendContext`, so
this updates Flutter to use the GPU-backend agnostic version. See
<https://issues.skia.org/issues/309785258>.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-06-24 07:39:16 -04:00
skia-flutter-autoroll
abb2c2086e Roll Skia from 512c20c45fcf to 836eed6a0cd4 (2 revisions) (flutter/engine#53525) 
https://skia.googlesource.com/skia.git/+log/512c20c45fcf..836eed6a0cd4

2024-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e080995c5d21 to 16a043a37412
2024-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from dff0f1ec2fe7 to e080995c5d21 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 07:08:24 +00:00
skia-flutter-autoroll
b6789889a9 Roll Skia from 7c86e7641b34 to 512c20c45fcf (1 revision) (flutter/engine#53523) 
https://skia.googlesource.com/skia.git/+log/7c86e7641b34..512c20c45fcf

2024-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cea33ab2d5ad to de870ac7518f (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,rmistry@google.com,scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 05:52:25 +00:00
skia-flutter-autoroll
10835d2985 Roll Fuchsia Linux SDK from w9HuHL8eFrXxjrgEM... to _6HNhJ6G59VMceKoN... (flutter/engine#53522) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-24 00:26:25 +00:00
skia-flutter-autoroll
65f7ef7126 Roll Fuchsia Linux SDK from NI4SFKzW8h8vX5Jk8... to w9HuHL8eFrXxjrgEM... (flutter/engine#53521) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-22 23:14:22 +00:00
skia-flutter-autoroll
b3dbb1f217 Roll Dart SDK from 56c98c7fae8b to 8f4cebdb3340 (1 revision) (flutter/engine#53520) 
https://dart.googlesource.com/sdk.git/+log/56c98c7fae8b..8f4cebdb3340

2024-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-292.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-22 21:50:07 +00:00
skia-flutter-autoroll
7ad5bd846a Roll Skia from 972da8fb6049 to 7c86e7641b34 (1 revision) (flutter/engine#53519) 
https://skia.googlesource.com/skia.git/+log/972da8fb6049..7c86e7641b34

2024-06-22 bungeman@google.com [pdf] Fix OpenType CFF embedding

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-22 16:50:04 +00:00
skia-flutter-autoroll
b857c5e0f6 Roll Skia from 733c3a81bdc3 to 972da8fb6049 (1 revision) (flutter/engine#53518) 
https://skia.googlesource.com/skia.git/+log/733c3a81bdc3..972da8fb6049

2024-06-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d59daac94bf8 to 3a8b46766c4e (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-22 13:56:22 +00:00
skia-flutter-autoroll
5bb7be82fe Roll Dart SDK from 27e95a7c73aa to 56c98c7fae8b (1 revision) (flutter/engine#53516) 
https://dart.googlesource.com/sdk.git/+log/27e95a7c73aa..56c98c7fae8b

2024-06-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-291.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-22 05:27:23 +00:00
skia-flutter-autoroll
6d37f353a5 Roll Dart SDK from fc1e5912fc94 to 27e95a7c73aa (2 revisions) (flutter/engine#53515) 
https://dart.googlesource.com/sdk.git/+log/fc1e5912fc94..27e95a7c73aa

2024-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-290.0.dev
2024-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-289.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-22 01:12:06 +00:00
skia-flutter-autoroll
725fd161eb Roll Skia from 3c1c17e151b1 to 733c3a81bdc3 (1 revision) (flutter/engine#53514) 
https://skia.googlesource.com/skia.git/+log/3c1c17e151b1..733c3a81bdc3

2024-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from dff0f1ec2fe7 to e080995c5d21

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-22 01:03:06 +00:00
skia-flutter-autoroll
d1a9e71da0 Roll Skia from 8b496fdedbd2 to 3c1c17e151b1 (1 revision) (flutter/engine#53513) 
https://skia.googlesource.com/skia.git/+log/8b496fdedbd2..3c1c17e151b1

2024-06-21 brianosman@google.com Add LLDB type formatter for SkFixed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-21 23:27:39 +00:00
skia-flutter-autoroll
1be4c07583 Roll Skia from 80fe27c13f62 to 8b496fdedbd2 (1 revision) (flutter/engine#53511) 
https://skia.googlesource.com/skia.git/+log/80fe27c13f62..8b496fdedbd2

2024-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 30f8ac1a3f18 to d59daac94bf8 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-21 22:10:00 +00:00
skia-flutter-autoroll
5471e60d25 Roll Fuchsia Linux SDK from iU-B6rJxy0wUYSmmp... to NI4SFKzW8h8vX5Jk8... (flutter/engine#53510) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-21 22:01:54 +00:00
Jim Graham
3bd63a65bb Better clipRect culling accuracy under scaling transforms (flutter/engine#53508) 
The clipRect culling in DisplayListBuilder can sometimes fail to cull a clip due to round-off error in the math and this case happens to trigger when trying to cull against the initial frame bounds of a Pixel 6a with its uncommon 2.625 DPR as a scaling transform. An optimization in the culling tests for axis-aligned transforms (very common in Flutter) happens to do the right thing for this odd case, likely due to less math to incur round-off errors.
 2024-06-21 21:45:14 +00:00
skia-flutter-autoroll
c77583f85e Roll Skia from d3a9075a2b62 to 80fe27c13f62 (18 revisions) (flutter/engine#53505) 
https://skia.googlesource.com/skia.git/+log/d3a9075a2b62..80fe27c13f62

2024-06-21 kjlubick@google.com Replace GrVkYcbcrConversionInfo with skgpu::VulkanYcbcrConversionInfo
2024-06-21 robertphillips@google.com [graphite] Additional PrecompileShader code rearrangement
2024-06-21 robertphillips@google.com [graphite] Rearrange code after making PrecompileColorFilter API public
2024-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1670fffcebe5 to 30f8ac1a3f18 (5 revisions)
2024-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 800ca8d38b69 to e53b3ad72322 (7 revisions)
2024-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0d4c52fc72a9 to dff0f1ec2fe7 (3 revisions)
2024-06-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 0d4c52fc72a9 to dff0f1ec2fe7
2024-06-20 robertphillips@google.com [graphite] Expand CombinationBuilderTest for PrecompileShaders
2024-06-20 jvanverth@google.com [graphite] Minor rewrite of YUV shaders.
2024-06-20 nathanasanchez@google.com [Graphite] Move gradient buffer function to modules
2024-06-20 bungeman@google.com CoreText SkTypeface palette support
2024-06-20 robertphillips@google.com [graphite] Make PrecompileColorFilter part of the public Precompile API
2024-06-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 83e9eca04a1b to 1670fffcebe5 (3 revisions)
2024-06-20 robertphillips@google.com [graphite] Fix Gradient Precompilation and add tests
2024-06-20 nicolettep@google.com [graphite] Add ability to append data on to PaintParamsKey
2024-06-20 nathanasanchez@google.com SkSL LoadFloatBuffer intrinsic implementation
2024-06-20 robertphillips@google.com Reland "[Ganesh] Make GL Protectedness behave more like Vulkan Protectedness"
2024-06-20 nathanasanchez@google.com [Graphite] Cache many stop gradients when using ssbo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-21 20:53:05 +00:00
Jenn Magder
e517aa1ce2 Run safari-dart2js-html tests on macOS 13 (flutter/engine#53497) 
https://github.com/flutter/engine/pull/53402 didn't work. Run these Safari tests on macOS 13 only until it can be fixed for macOS 14.
 2024-06-21 20:50:57 +00:00
jezell
d1e6ca839c Add createImageFromTextureSource method to ui_web (flutter/engine#53483) 
Adds createImageFromTextureSource for flutter web, exposed in dart:web_ui.

```dart
final ui.Image uiImage = renderer.createImageFromTextureSource(bitmap,
            width: 150, height: 150, transferOwnership: false);
```

In canvaskit renderer, this will use MakeLazyImageFromTextureSource. In SkWasmRenderer, it will call imageCreateFromTextureSource, which was already implemented in SkWasm for createImageFromImageBitmap to use, but was not exposed in a way that it could be taken advantage of.

By default, createImageFromTextureSource will create a copy of the object it is passed, but transferOwnership: true may be specified to allow transferable objects to be transferred to the renderer, avoiding the copy.

Fixes: https://github.com/flutter/flutter/issues/150479
Fixes: https://github.com/flutter/flutter/issues/144815
 2024-06-21 20:28:55 +00:00
skia-flutter-autoroll
b60c3db4a5 Roll Skia from 4471ee07e223 to d3a9075a2b62 (4 revisions) (flutter/engine#53489) 
https://skia.googlesource.com/skia.git/+log/4471ee07e223..d3a9075a2b62

2024-06-20 sunnyps@chromium.org Reland "wgsl: Mark more variables as const/immutable"
2024-06-20 kjlubick@google.com Manually Roll Dawn from f13f18d21c1b to b65ac9ea6f70 (62 revisions)
2024-06-20 michaelludwig@google.com [skif] Stage Ganesh to use new blur engine
2024-06-20 bungeman@google.com Fontations scanner to set isFixedPitch

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jsimmons@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-21 19:33:23 +00:00
skia-flutter-autoroll
ea4bcb1b34 Roll Dart SDK from 4483d67ba725 to fc1e5912fc94 (1 revision) (flutter/engine#53503) 
https://dart.googlesource.com/sdk.git/+log/4483d67ba725..fc1e5912fc94

2024-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-288.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-21 14:38:30 +00:00
auto-submit[bot]
249de68438 Reverts "Fix focus management for text fields (#51009)" (flutter/engine#53502) 
Reverts: flutter/engine#51009
Initiated by: jiahaog
Reason for reverting: This causes b/348598454. We're getting test failures with stack traces like the following after this PR:

```
Cannot get renderObject of inactive element.
In order for an element to have a valid renderObject, it must be active, which means it is part of the tree.
Instead, this element is in the _ElementLifecycle.inactive state.
If you called this method from a State object, consider guarding
```

Original PR Author: tugorez

Reviewed By: {mdebbar}

This change reverts the following previous change:
Fix focus management for text fields

This PR:

1. Refactors the DOM `focus` function to take [options][1]
2. Removes the timers sorrounding the `activeDomElement.focus()` so that the input elements get focused as immediate as possible.
3. Prevents the default on pointerdown in a Flutter View and schedules a `requestViewFocusChange` to claim focus in that view after some time. This gives `2` the opportunity to focus the right `<input />` or `<textarea />` element. This helps focus correctly transition from one input element to another (without jumping to a flutter view in between).
4. Deactivating a `TextField` doesn't blur the focused element anymore, it insteads schedules for later a call to move the focus to the flutter view if nothing inside it claimed focus first.
5. Prevents scroll in all the focus calls (this should help with the view jumping when focusing one text field after another).

## Sample apps

1. Full screen mode: https://tugorez.com/flutter_focus_web
2. Embedded mode: https://tugorez.com/flutter_focus_web?embedded

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-06-21 12:56:47 +00:00
skia-flutter-autoroll
274e42fd42 Roll Dart SDK from 19d3e659f49a to 4483d67ba725 (2 revisions) (flutter/engine#53501) 
https://dart.googlesource.com/sdk.git/+log/19d3e659f49a..4483d67ba725

2024-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-287.0.dev
2024-06-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-286.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-06-21 10:14:21 +00:00
Mouad Debbar
00389408cd [web] Add 'flt-semantics-identifier' attribute to semantics nodes (flutter/engine#53278) 
Make [`Semantics(identifier: '...')`](https://api.flutter.dev/flutter/semantics/SemanticsProperties/identifier.html) useful on the web. This PR plugs the Semantics `identifier` property as an HTML attribute `semantics-identifier` onto semantics elements.

This is useful in some scenarios:
- In testing to check if a certain semantics node has made it to the page ([example](https://github.com/flutter/flutter/issues/97455)).
- In apps and/or packages to be able to lookup the DOM element that corresponds to a certain semantics node ([example](https://github.com/flutter/packages/pull/6711)).

Fixes https://github.com/flutter/flutter/issues/97455
 2024-06-20 23:23:15 +00:00
Mouad Debbar
33e1bcf96f [web] Don't add href="#" to semantics links (flutter/engine#53395) 
This is a stopgap for issues like https://github.com/flutter/flutter/issues/146291 until we land better link semantics (in https://github.com/flutter/flutter/issues/150263 and https://github.com/flutter/packages/pull/6711). For the time being, the `href="#"` isn't providing any extra value, and is causing the browser to navigate to to `#` whenever the semantics link is clicked, which is undesirable.

Fixes https://github.com/flutter/flutter/issues/146291
 2024-06-20 23:21:36 +00:00