Jonah Williams
f25812bae5
Revert "replace package:vm_service_client with package:vm_service in the devicelab project ( #41646 )" ( #41960 )
2019-10-03 21:30:37 -07:00
engine-flutter-autoroll
96b4e8cf1a
9db063704 Roll src/third_party/dart 7376167b2a..b4688e9172 (4 commits) ( #41957 )
...
git@github.com:flutter/engine.git/compare/2e163b27805b...9db06370490d
git log 2e163b27805b..9db06370490d --no-merges --oneline
2019-10-04 bkonyi@google.com Roll src/third_party/dart 7376167b2a..b4688e9172 (4 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-03 23:59:43 -04:00
Devon Carew
4de496a4e5
replace package:vm_service_client with package:vm_service in the devicelab project ( #41646 )
2019-10-03 20:43:34 -07:00
escamoteur
2713ee61f0
added questions on Platform / OS Version / Device ( #41651 )
...
* added questions on Platform / OS Version / Design
* changed following the comments
* removed the host platform question
2019-10-03 20:43:04 -07:00
Emmanuel Garcia
00f82d9021
Use mergeResourcesProvider instead of deprecated mergeResources ( #41942 )
2019-10-03 20:42:43 -07:00
Emmanuel Garcia
ed49a79516
Include embedding transitive dependencies in plugins ( #41885 )
2019-10-03 20:42:24 -07:00
stuartmorgan
18d6d9bc7b
Add Profile entry to macOS Podfile ( #41747 )
2019-10-03 20:41:48 -07:00
Greg Spencer
3e2dc8ca7b
Revert ActivateAction PR ( #41945 )
2019-10-03 20:27:37 -07:00
engine-flutter-autoroll
780bddcca5
Roll engine 62e58c5d9fc2..2e163b27805b (4 commits) ( #41954 )
...
git@github.com:flutter/engine.git/compare/62e58c5d9fc2...2e163b27805b
git log 62e58c5d9fc2..2e163b27805b --no-merges --oneline
2019-10-04 dnfield@google.com Revert "Build AOT and test targets, generate FARs when building Fuchsia (#12761 )" (flutter/engine#12781 )
2019-10-03 30870216+gaaclarke@users.noreply.github.com Enabled people to chose if SystemNavigator.pop is animated on iOS. (flutter/engine#12752 )
2019-10-03 30870216+gaaclarke@users.noreply.github.com Added some thread asserts to the code and made ios_surface_ safe since (flutter/engine#12775 )
2019-10-03 dnfield@google.com Build AOT and test targets, generate FARs when building Fuchsia (flutter/engine#12761 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-03 23:11:43 -04:00
Jonah Williams
db9ad60bfe
Deflake web_fs_test.dart in flutter_tools ( #41952 )
2019-10-03 19:07:38 -07:00
Dan Field
6048b62e21
Update label applied for performance template bugs ( #41717 )
2019-10-03 18:56:25 -07:00
LongCatIsLooong
97d191de13
Fix CupertinoActivityIndicator radius ( #41892 )
2019-10-03 18:37:57 -07:00
engine-flutter-autoroll
d85d6eb44f
Roll engine 8aa47326ae73..62e58c5d9fc2 (3 commits) ( #41949 )
...
git@github.com:flutter/engine.git/compare/8aa47326ae73...62e58c5d9fc2
git log 8aa47326ae73..62e58c5d9fc2 --no-merges --oneline
2019-10-03 bkonyi@google.com Roll src/third_party/dart 07a63a17a4..7376167b2a (8 commits)
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 35e0a58278a3..d71344590a2f (11 commits) (flutter/engine#12774 )
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from p319_... to VkAgX... (flutter/engine#12778 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-03 21:37:43 -04:00
Jenn Magder
4331c172d7
Set DEFINES_MODULE=YES in plugin templates ( #41828 )
2019-10-03 18:35:20 -07:00
engine-flutter-autoroll
f8c75305ca
Roll engine 7d67e275ff82..8aa47326ae73 (7 commits) ( #41944 )
...
git@github.com:flutter/engine.git/compare/7d67e275ff82...8aa47326ae73
git log 7d67e275ff82..8aa47326ae73 --no-merges --oneline
2019-10-03 chinmaygarde@google.com Fix Metal builds. (flutter/engine#12777 )
2019-10-03 30870216+gaaclarke@users.noreply.github.com Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#12277 )" (flutter/engine#12773 )
2019-10-03 bkonyi@google.com Roll src/third_party/dart afac6a3714..07a63a17a4 (6 commits)
2019-10-03 dnfield@google.com roll buildroot to 01e923507b28e5d1d3fe7597d2db2b30b0a543e9 (flutter/engine#12771 )
2019-10-03 jonahwilliams@google.com Create a package-able incremental compiler (flutter/engine#12681 )
2019-10-03 47866232+chunhtai@users.noreply.github.com add windows embedding test (flutter/engine#12423 )
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from g-PD1... to wYLiQ... (flutter/engine#12770 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-03 20:12:44 -04:00
Tong Mu
297fe91f51
Refactor: Make MouseTracker test concise with some utility functions ( #41791 )
...
* Extract pointerData and _equalToEventsOnCriticalFields for simplicity
2019-10-03 16:33:31 -07:00
Jonah Williams
6edd79abab
Upload x64 android host release ( #41933 )
2019-10-03 16:23:53 -07:00
engine-flutter-autoroll
32ad3db8e8
7d67e275f Roll src/third_party/skia cb55010652b2..35e0a58278a3 (2 commits) (flutter/engine#12769) ( #41929 )
...
git@github.com:flutter/engine.git/compare/623be87e65e6...7d67e275ff82
git log 623be87e65e6..7d67e275ff82 --no-merges --oneline
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia cb55010652b2..35e0a58278a3 (2 commits) (flutter/engine#12769 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-03 19:20:43 -04:00
engine-flutter-autoroll
2a7395ca46
Roll engine e9edb8e14f6d..623be87e65e6 (12 commits) ( #41928 )
...
git@github.com:flutter/engine.git/compare/e9edb8e14f6d...623be87e65e6
git log e9edb8e14f6d..623be87e65e6 --no-merges --oneline
2019-10-03 bkonyi@google.com Roll src/third_party/dart 967673c005..afac6a3714 (2 commits)
2019-10-03 bkonyi@google.com Roll src/third_party/dart 97bb624cfe..967673c005 (16 commits)
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 087aa99a21ca..cb55010652b2 (1 commits) (flutter/engine#12766 )
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia f070cbec0708..087aa99a21ca (2 commits) (flutter/engine#12765 )
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from EeMsz... to p319_... (flutter/engine#12764 )
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from AGoPT... to g-PD1... (flutter/engine#12763 )
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 40d1246d0c80..f070cbec0708 (10 commits) (flutter/engine#12762 )
2019-10-03 bkonyi@google.com Roll src/third_party/dart 2e99a418a0..97bb624cfe (5 commits)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Expanded channel buffer resize to method channels. (flutter/engine#12725 )
2019-10-02 bkonyi@google.com Roll src/third_party/dart eaf1c308ab..2e99a418a0 (6 commits)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia ce240cc6fd8e..40d1246d0c80 (4 commits) (flutter/engine#12755 )
2019-10-02 chinmaygarde@google.com Fix Metal builds by accounting for the updated SubmitFrame signature. (flutter/engine#12754 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-03 14:55:43 -04:00
Mouad Debbar
61d364f307
[web] Make it clear that lowercase "r" can also perform hot restart ( #41815 )
2019-10-03 11:53:41 -07:00
Mehmet Fidanboylu
6b09543e3a
Allow customization of label styles for semantics debugger ( #41730 )
2019-10-03 11:11:13 -07:00
Zachary Anderson
c7c8a6c498
[flutter_tools] Add more info to pub get failure event ( #41652 )
2019-10-03 11:08:42 -07:00
Jonah Williams
517c08e801
Make output directory a build input ( #41862 )
2019-10-03 11:07:53 -07:00
engine-flutter-autoroll
439dc5cffe
Roll engine 73dd5a33d9d1..e9edb8e14f6d (3 commits) ( #41860 )
...
git@github.com:flutter/engine.git/compare/73dd5a33d9d1...e9edb8e14f6d
git log 73dd5a33d9d1..e9edb8e14f6d --no-merges --oneline
2019-10-02 mouad.debbar@gmail.com Support correct keymap for web (flutter/engine#12712 )
2019-10-02 garyq@google.com Explain vertical font metrics and refactor UpdateLineMetrics. (flutter/engine#11795 )
2019-10-02 mouad.debbar@gmail.com [web] Don't require felt to be in PATH (flutter/engine#12753 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-03 14:05:43 -04:00
Gary Qian
fa7340a328
Return WidgetSpans from getSpanForPosition ( #40635 )
2019-10-02 19:04:50 -04:00
engine-flutter-autoroll
fe46eba67f
Roll engine aa8fcbb65283..73dd5a33d9d1 (4 commits) ( #41856 )
...
git@github.com:flutter/engine.git/compare/aa8fcbb65283...73dd5a33d9d1
git log aa8fcbb65283..73dd5a33d9d1 --no-merges --oneline
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from LSKbP... to EeMsz... (flutter/engine#12751 )
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia a1ea0a96f490..ce240cc6fd8e (13 commits) (flutter/engine#12750 )
2019-10-02 bkonyi@google.com Roll src/third_party/dart 98b286de21..eaf1c308ab (5 commits)
2019-10-02 yjbanov@google.com Add web implementation for channel_buffers.dart (flutter/engine#12747 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-02 18:52:24 -04:00
Shi-Hao Hong
27a12efabf
Update DefaultTabController to allow for zero tabs ( #41625 )
...
* Update DefaultTabController to allow for zero tabs
2019-10-03 06:42:22 +08:00
Shi-Hao Hong
913aca22b3
[Material] Fix Tooltip to respect ambient Directionality ( #41629 )
...
* Fix Tooltip Directionality
* Add regression test comment for tooltip directionality fix
2019-10-03 06:41:23 +08:00
Shi-Hao Hong
e7947c3e92
DropdownButton.style API doc example for differing button and menu item text styles ( #41650 )
...
* Add dropdown button style doc example for unique text styles
2019-10-03 06:41:00 +08:00
gaaclarke
75c07ef1a6
Updated the docstring for SystemNavigator.pop.
...
It had an Android bias and was incorrect for iOS.
2019-10-02 15:36:07 -07:00
Josh
8b9e144e6a
Added notice to docs that setPreferredOrientations does not always work on iPad ( #40743 )
2019-10-02 15:32:52 -07:00
Ori Schwartz
f8310d89e8
Use EdgeInsetsGeometry instead of EdgeInsets ( #40775 )
2019-10-02 15:31:39 -07:00
Tong Mu
0b0942a60c
Refactor: Base tap gesture recognizer ( #41329 )
...
* Extracts the logic of TapGestureRecognizer into an abstract class BaseTapGestureRecognizer
* Fixes ModalBarrier unable to dismiss when competing
2019-10-02 15:28:55 -07:00
Greg Spencer
bedf46d06e
Add shortcuts and actions for default focus traversal ( #40186 )
...
This adds the default shortcuts and actions for keyboard-based focus traversal of apps.
This list of shortcuts includes shortcuts for TAB, SHIFT TAB, RIGHT_ARROW, LEFT_ARROW, UP_ARROW, DOWN_ARROW, and the four DPAD keys for game controllers (because the DPAD produces arrow key events).
It doesn't yet include functionality for triggering a control (e.g. SPACE, ENTER, or controller buttons), because that involves restructuring some of the Flutter controls to trigger animations differently, and so will be done in another PR (#41220 )
2019-10-02 15:21:45 -07:00
Jonah Williams
aeede20785
Handle missing .packages file in the flutter tool for prebuilt artifacts ( #41697 )
2019-10-02 15:18:34 -07:00
engine-flutter-autoroll
415840485c
Roll engine 4651df4d35af..aa8fcbb65283 (15 commits) ( #41809 )
...
git@github.com:flutter/engine.git/compare/4651df4d35af...aa8fcbb65283
git log 4651df4d35af..aa8fcbb65283 --no-merges --oneline
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 7v4fg... to AGoPT... (flutter/engine#12745 )
2019-10-02 gspencergoog@users.noreply.github.com Stop setting the accessibility text if a node has SCOPES_ROUTE set. (flutter/engine#12730 )
2019-10-02 bkonyi@google.com Roll src/third_party/dart 431176ea26..98b286de21 (16 commits)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia cf0a9a628490..a1ea0a96f490 (1 commits) (flutter/engine#12743 )
2019-10-02 jiahaog@users.noreply.github.com Fix parameter naming in docs (flutter/engine#12732 )
2019-10-02 iska.kaushik@gmail.com Update linux toolchain for fuchsia (flutter/engine#12742 )
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1c934fade666..cf0a9a628490 (3 commits) (flutter/engine#12741 )
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 015c2feb1288..1c934fade666 (3 commits) (flutter/engine#12740 )
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from L_AEL... to LSKbP... (flutter/engine#12739 )
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 674f77a24b62..015c2feb1288 (1 commits) (flutter/engine#12738 )
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Q4sFH... to 7v4fg... (flutter/engine#12737 )
2019-10-02 bkonyi@google.com Roll src/third_party/dart cbf6a233fc..431176ea26 (1 commits)
2019-10-02 iska.kaushik@gmail.com [flutter_runner] Make rd and rx uniform (flutter/engine#12733 )
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9e514a183b99..674f77a24b62 (1 commits) (flutter/engine#12734 )
2019-10-01 bkonyi@google.com Roll src/third_party/dart 1103600280..cbf6a233fc (8 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-02 18:13:51 -04:00
Yegor
33f4f8e6df
run services tests on the Web ( #41806 )
2019-10-02 15:11:22 -07:00
Ian Hickson
8c6d60bcfd
Move commands into their own shard ( #39140 )
2019-10-02 12:46:51 -07:00
Jonah Williams
39f85f94ec
Reland: don't update last compile time when compilation is rejected. ( #41580 )
...
* dont update last compiled time when compilation is rejected
* lets try flushing, thats a neat trick
* windows man
* Update hot_reload_test.dart
* Update hot_reload_test.dart
* Update devfs.dart
* Update hot_reload_test.dart
* Update hot_reload_test.dart
* add test that verifies when compile is good that time is updated
* Update devfs_test.dart
2019-10-02 12:46:33 -07:00
Greg Spencer
4512a1c1b7
Add an ActivateAction to controls that use InkWell. ( #41220 )
...
Adds an ActivateAction to controls that use InkWell. Make InkWell host the Focus for those controls, and add the top level binding to the ENTER key. This will make it possible to trigger a button using the enter key, and to get an ink response when the button is triggered.
This is a breaking change because it moves the Focus widget into the InkWell. If you have a component that uses the InkWell directly and you used to wrap that InkWell in a Focus widget to give it its notion of focus, it will now not look for that Focus ancestor for its focus state anymore. In order to control focus on the InkWell, you need to give it a FocusNode directly, via the new focusNode parameter. This should not affect users of widgets like OutlineButton or FloatingActionButton and the like, since those have been modified in this PR.
2019-10-02 12:46:02 -07:00
Jonah Williams
0af2a84cbb
Handle empty entry in asset list and add more explicit validation ( #41735 )
2019-10-02 12:45:51 -07:00
Jonah Williams
b1a6aa3ab8
Add support for downloading x86 Android JIT release artifact ( #41751 )
2019-10-02 12:45:35 -07:00
Jonah Williams
a9f385bbff
Reduce log verbosity by removing individual used files ( #41788 )
2019-10-02 12:45:04 -07:00
engine-flutter-autoroll
5975e86f00
Roll engine 9e6314d348f9..4651df4d35af (2 commits) ( #41743 )
...
git@github.com:flutter/engine.git/compare/9e6314d348f9...4651df4d35af
git log 9e6314d348f9..4651df4d35af --no-merges --oneline
2019-10-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1e9112fbb472..9e514a183b99 (5 commits) (flutter/engine#12729 )
2019-10-01 ychris@google.com Remove unused imports in the scenario app (flutter/engine#12728 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-02 15:44:24 -04:00
liyuqian
cdb94cd675
Revert "Revert "Dsiable CPU/GPU measurement on BackdropFilter test ( #41736 )" ( #41780 )" ( #41795 )
...
This reverts commit 19c08e891d2c862b685c6803b6cce73d1e386b54.
The attempted revert doesn't fix the problem, so we'll reland.
2019-10-02 12:35:42 -07:00
Christopher Fujino
e70236e36c
Fix tools test verifyVersion() regex ( #41744 )
2019-10-02 09:32:30 -07:00
Greg Spencer
19c08e891d
Revert "Dsiable CPU/GPU measurement on BackdropFilter test ( #41736 )" ( #41780 )
...
This reverts c9d920f so that we can attempt to fix the build. The build dashboard clearly shows that things started failing at this change, although it's not totally clear that it is the cause: tests succeed locally.
If it doesn't fix things we can re-land this.
2019-10-02 07:22:25 -07:00
engine-flutter-autoroll
056f7244ef
Roll engine 5c428d924790..9e6314d348f9 (8 commits) ( #41741 )
...
git@github.com:flutter/engine.git/compare/5c428d924790...9e6314d348f9
git log 5c428d924790..9e6314d348f9 --no-merges --oneline
2019-10-01 bkonyi@google.com Roll src/third_party/dart 998f1efbe9..1103600280 (6 commits)
2019-10-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 3Axx8... to L_AEL... (flutter/engine#12726 )
2019-10-01 ychris@google.com Reland "Add iOS platform view mutation XCUITests to the scenario app(#11652 )" (flutter/engine#12707 )
2019-10-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia a7914a872657..1e9112fbb472 (4 commits) (flutter/engine#12724 )
2019-10-01 30870216+gaaclarke@users.noreply.github.com Resize channel buffers (flutter/engine#12402 )
2019-10-01 bkonyi@google.com Roll src/third_party/dart fb1c5a6404..998f1efbe9 (3 commits)
2019-10-01 30870216+gaaclarke@users.noreply.github.com Cleanup: Turned on NS_ASSUME_NONNULL_BEGIN for FlutterViewController. (flutter/engine#12708 )
2019-10-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Jr7x0... to Q4sFH... (flutter/engine#12722 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-01 18:09:24 -04:00
Mouad Debbar
e045ef2969
Keymap for Web ( #41397 )
2019-10-01 14:10:53 -07:00
Slade Capasso
a9c28d5f6c
range_slider_test.dart diagnostics property tests ( #40291 )
...
* Updates to slider_test.dart
Fixed error that required onChanged.
* Updated slider.dart and slider_test.dart debugFillProperties
Updated slider.dart debugFillProperties to include all properties and slider_test debugFillProperties to test all properties
* Updated Slider onChanged property
* Updated debugFillProperties to ignore testing methods that are null in test
Per feedback from Hans/Anthony on Flutter Material
* Updated spacing in debugFillProperties
Per feedback from Hans
* Updated range_slider.dart and range_slider_test.dart to have DiagnosticProperties tests for all properties
* Updated range_slider.dart and range_slider_test.dart per feedback
Preventing null labels from creating an error.
Added made RangeLabels and RangeValues constants in instantiation of Range Slider.
Fixed spacing.
* Updates to start and end labels in diagnostic property tests
Updated per feedback from @clocksmith
2019-10-01 17:06:34 -04:00
