engine-flutter-autoroll
f05e92f764
Roll Packages from 27c98537ccac to ebcc4f0b014c (7 revisions) ( #156000 )
...
27c98537cc...ebcc4f0b0143054281+camsim99@users.noreply.github.com [camerax] Correct assumption about preview being correctly rotated by default on API 29 (flutter/packages#7714 )
2024-09-30 43759233+kenzieschmoll@users.noreply.github.com Replace `initialPage` parameter with `benchmarkPath` (flutter/packages#7743 )
2024-09-30 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.11.0 to 1.12.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7681 )
2024-09-30 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.35.0 to 3.35.1 in /packages/interactive_media_ads/android (flutter/packages#7734 )
2024-09-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Change the location of where the AdsLoader is initialized (flutter/packages#7721 )
2024-09-30 stuartmorgan@google.com [file_selector] Update Windows Pigeon for non-nullable generics (flutter/packages#7730 )
2024-09-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for Android native `AdProgressInfo` (flutter/packages#7723 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-01 16:26:06 +00:00
engine-flutter-autoroll
217dc1b54e
Roll Flutter Engine from 3fdb546bf595 to 794dcaf7a2b9 (2 revisions) ( #155999 )
...
3fdb546bf5...794dcaf7a2skia-flutter-autoroll@skia.org Roll Dart SDK from 23701722ca9e to 0e8b99c3154a (1 revision) (flutter/engine#55556 )
2024-10-01 skia-flutter-autoroll@skia.org Roll Skia from 5baca3730872 to 44d45ac4de6f (1 revision) (flutter/engine#55554 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-01 16:19:25 +00:00
Mikhail Novoseltsev
0975e612c0
[tool][android] Allow --target-platform work properly with --debug mode ( #154476 )
...
This PR addresses an issue where the `--target-platform` flag was not being respected when building APKs in debug mode. Previously, debug builds would always include `x86` and `x64` architectures, regardless of the specified target platform. This change ensures that the `--target-platform` flag is honored across all build modes, including debug.
To achieve this, `BuildApkCommand` has been slightly changed to become responsible for list of archs that should be built in the current run,rather than just parsing arguments. Previously, this responsibility was distributed to gradle, which could be frustrating (in my opinion)
Fixes #153359
2024-10-01 15:24:53 +00:00
AntØn UstinØff
6bba08cbcc
Feat: Add opportunity to change CupertinoTextField suffix alignment ( #154601 )
...
Fixes #152482
2024-10-01 15:13:09 +00:00
engine-flutter-autoroll
b05246d305
Roll Flutter Engine from da28db8ff41d to 3fdb546bf595 (2 revisions) ( #155993 )
...
da28db8ff4...3fdb546bf5skia-flutter-autoroll@skia.org Roll Skia from db59fb03ddd9 to 5baca3730872 (2 revisions) (flutter/engine#55553 )
2024-10-01 skia-flutter-autoroll@skia.org Roll Dart SDK from bff9c6ff642d to 23701722ca9e (2 revisions) (flutter/engine#55551 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-01 13:16:37 +00:00
engine-flutter-autoroll
9e88a28221
Roll Flutter Engine from 6b21b796cc94 to da28db8ff41d (1 revision) ( #155985 )
...
6b21b796cc...da28db8ff4skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from A8lL1H_6clgBKJXHK... to 8CL33jSvLCd1mPDg_... (flutter/engine#55549 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from A8lL1H_6clgB to 8CL33jSvLCd1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-01 09:57:06 +00:00
engine-flutter-autoroll
8f514abecb
Roll Flutter Engine from 259f56c6e91b to 6b21b796cc94 (1 revision) ( #155983 )
...
259f56c6e9...6b21b796ccflutter/engine#55544 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-01 08:17:29 +00:00
engine-flutter-autoroll
cf2657d2b5
Roll Flutter Engine from 6ee04ed763d9 to 259f56c6e91b (1 revision) ( #155981 )
...
6ee04ed763...259f56c6e9skia-flutter-autoroll@skia.org Roll Skia from 6fc00ce22452 to db59fb03ddd9 (1 revision) (flutter/engine#55543 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-01 07:15:08 +00:00
engine-flutter-autoroll
8027caaf10
Roll Flutter Engine from bfb6dddb2b30 to 6ee04ed763d9 (3 revisions) ( #155978 )
...
bfb6dddb2b...6ee04ed763skia-flutter-autoroll@skia.org Roll Skia from b851101c844a to 6fc00ce22452 (1 revision) (flutter/engine#55539 )
2024-10-01 skia-flutter-autoroll@skia.org Roll Dart SDK from d9fb41a4b5ee to bff9c6ff642d (2 revisions) (flutter/engine#55538 )
2024-10-01 skia-flutter-autoroll@skia.org Roll Skia from d1d7deb68f9d to b851101c844a (1 revision) (flutter/engine#55535 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-01 03:48:24 +00:00
engine-flutter-autoroll
e6c955416d
Roll Flutter Engine from e61bc853acb2 to bfb6dddb2b30 (8 revisions) ( #155967 )
...
e61bc853ac...bfb6dddb2bskia-flutter-autoroll@skia.org Roll Skia from 534633fb4bd9 to d1d7deb68f9d (1 revision) (flutter/engine#55534 )
2024-09-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 79863e31de87 to d9fb41a4b5ee (1 revision) (flutter/engine#55533 )
2024-09-30 matanlurey@users.noreply.github.com Introduce a GN rule that (explicitly) generates a `dart test` wrapper (flutter/engine#55475 )
2024-09-30 matanlurey@users.noreply.github.com Remove the need to use `runZoned` by replacing `print` statements (flutter/engine#55530 )
2024-09-30 skia-flutter-autoroll@skia.org Roll Skia from 6c89706638ee to 534633fb4bd9 (2 revisions) (flutter/engine#55531 )
2024-09-30 chinmaygarde@google.com [Impeller] Create a libImpeller dylib and expose symbols. (flutter/engine#55526 )
2024-09-30 30870216+gaaclarke@users.noreply.github.com Added metal validation for `impeller_unittests (flutter/engine#55527 )
2024-09-30 skia-flutter-autoroll@skia.org Roll Skia from dfeeb199b226 to 6c89706638ee (2 revisions) (flutter/engine#55528 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-01 00:20:08 +00:00
Kate Lovett
0fb6774d5e
Disable flaky menu test ( #155968 )
...
Related to https://github.com/flutter/flutter/issues/154858
We think the forceGC method is flaky, as also documented in 621e7ef951/packages/flutter/test/widgets/widget_inspector_test.dart (L336)
2024-10-01 00:18:39 +00:00
Robert Ancell
cf4dace52b
Fix crash in Linux platform channel example. ( #155735 )
...
When running this example it was crashing, so investigated a fixed a
couple of bugs.
2024-10-01 13:09:49 +13:00
Polina Cherkasova
bff135153d
Fix leak in input_decorator [prod-leak-fix] ( #155885 )
...
Introduced by https://github.com/flutter/flutter/pull/153235 .
2024-09-30 23:45:49 +00:00
Renzo Olivares
72edaa3d66
Move platform specific text selection behavior out of styled TextField classes ( #155774 )
...
Fixes #129726
2024-09-30 22:44:20 +00:00
engine-flutter-autoroll
91fd01bf65
Roll Flutter Engine from b466a0dd7834 to e61bc853acb2 (5 revisions) ( #155952 )
...
b466a0dd78...e61bc853acart-snake@yandex-team.ru fix use_of_uninitialized_value in message_loop_task_queues.cc (flutter/engine#55520 )
2024-09-30 chris@bracken.jp iOS: Migrate FlutterEngineGroup to ARC (flutter/engine#55503 )
2024-09-30 jacksongardner@google.com Reland [skwasm] Scene builder optimizations for platform view placement (flutter/engine#55468 )
2024-09-30 skia-flutter-autoroll@skia.org Roll Dart SDK from c55ae50d619a to 79863e31de87 (1 revision) (flutter/engine#55525 )
2024-09-30 skia-flutter-autoroll@skia.org Roll Skia from 06721a724831 to dfeeb199b226 (2 revisions) (flutter/engine#55524 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-30 22:17:27 +00:00
Renzo Olivares
350b4753e0
RenderParagraphs _SelectableFragment.boundingBoxes should consider max line height (#155892 )
...
Fixes #133637
This change updates the `_SelectableFragment.boundingBoxes` logic to consider the max line height. Previously we were using boxes that were tightly bound around each glyph, so you would have to click within the bounds of the glyph for double tap to select word to work. This is different than `SelectableText` which considers the max line height, as well as the native web behavior that also considers the max line height.
## Web
https://github.com/user-attachments/assets/4ce8c0ca-ec6f-4969-88b1-baa356be8278
## Flutter SelectableText
https://github.com/user-attachments/assets/54c22ad3-75d7-475b-856b-e9b2dbe09d54
## Flutter Text widget under SelectionArea
https://github.com/user-attachments/assets/27db0e2b-1d19-43cc-8ab3-16050e3a5bc7
After this change, Flutter's Text widget under a SelectionArea now matches the SelectableText and native web behavior.
This change also:
* Invalidates the cached bounding boxes when the paragraph layout changes.
* Updates `textOffsetToPosition` to consider `preferredLineHeight`. In cases when the text wraps, it was sometimes inaccurate.
2024-09-30 20:16:10 +00:00
engine-flutter-autoroll
9441f9d48f
Roll Packages from 0321757447bf to 27c98537ccac (3 revisions) ( #155945 )
...
0321757447...27c98537cctarrinneal@gmail.com [pigeon] fix int bug (flutter/packages#7725 )
2024-09-28 echo.ellet@gmail.com [pigeon] update deprecated command in README of the example (flutter/packages#7709 )
2024-09-27 84049068+dhiaCodes@users.noreply.github.com [google_maps_flutter] Fix incorrect comment: Change "marker" to "polyline" (flutter/packages#7664 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-30 18:20:27 +00:00
engine-flutter-autoroll
0bf7b10a38
Roll Flutter Engine from f4507e7a4beb to b466a0dd7834 (1 revision) ( #155944 )
...
f4507e7a4b...b466a0dd78chris@bracken.jp iOS: Migrate FlutterHeadlessDartRunner to ARC (flutter/engine#55502 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-30 18:17:06 +00:00
Andrew Kolos
3941346723
when ResidentRunner.tryInitLogReader fails, only log warning on Android ( #155800 )
...
This is a follow-up to the PR https://github.com/flutter/flutter/pull/155049 (which fixed https://github.com/flutter/flutter/issues/154903 ). This PR addresses the resulting issue, https://github.com/flutter/flutter/issues/155795 . It does so in a hacky way for the sake of simplicity (and thus suitability for cherry-picking). I intend to clean this up on the master channel with yet another follow-up PR, https://github.com/flutter/flutter/pull/155796 , which currently exists as a proof-of-concept to make sure I actually have the ability to clean this after myself here.
**I intend to submit a stable hotfix patch with the changes from the original fix (https://github.com/flutter/flutter/issues/154903 ) and the follow-up changes from this PR.**
2024-09-30 17:53:08 +00:00
Denis Gordin
31d6b35b7f
Move FlutterLogo from material to widget ( #155864 )
...
The PR is moving FlutterLogo from `lib/src/material` to `lib/src/widgets` because it has no dependency on Material.
Issue: https://github.com/flutter/flutter/issues/154448
PS: There is [older PR](https://github.com/flutter/flutter/pull/154711 ) for this issue and I don't know the policy on conflicting PRs. Let me know if I need to drop mine.
2024-09-30 17:19:25 +00:00
lizhuo
84f65686d9
fix: support android 15 16k page size for template plugin_ffi ( #155508 )
...
Android 15 support 16k page sizes, it need [enable 16kb elf alignment](https://developer.android.com/guide/practices/page-sizes#compile-r26-lower ).
the current plugin_ffi template will have below error if run on android 15 16k emulator
```
Failed to load dynamic library 'libffigen_app.so': dlopen
failed: empty/missing
DT_HASH/DT_GNU_HASH in
"/data/app/~~Ixsgxu2mj5fKxP1cXpjV6Q==/com.example.ffigen_app_example-6d_efR__WGu
4dsF4tLIaHw==/lib/arm64/libffigen_app.so"
(new hash type from the future?)
```
2024-09-30 15:56:25 +00:00
engine-flutter-autoroll
e3828ec940
Roll Flutter Engine from daf126b38b8f to f4507e7a4beb (1 revision) ( #155932 )
...
daf126b38b...f4507e7a4bskia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to c55ae50d619a (21 revisions) (flutter/engine#55522 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-30 14:54:42 +00:00
engine-flutter-autoroll
e5971fc7cf
Roll Flutter Engine from 734205fbcd62 to daf126b38b8f (1 revision) ( #155929 )
...
734205fbcd...daf126b38bskia-flutter-autoroll@skia.org Roll Skia from 80d141cf32ac to 06721a724831 (1 revision) (flutter/engine#55521 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-30 13:40:20 +00:00
engine-flutter-autoroll
c6fdd842ae
Roll Flutter Engine from 338f09c4ea72 to 734205fbcd62 (1 revision) ( #155923 )
...
338f09c4ea...734205fbcdskia-flutter-autoroll@skia.org Roll Skia from 5f4740b998b3 to 80d141cf32ac (1 revision) (flutter/engine#55519 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-30 11:03:34 +00:00
engine-flutter-autoroll
10ece6191a
Roll Flutter Engine from 897f5caffe2d to 338f09c4ea72 (2 revisions) ( #155917 )
...
897f5caffe...338f09c4easkia-flutter-autoroll@skia.org Roll Skia from 333df70fbcdb to 5f4740b998b3 (1 revision) (flutter/engine#55518 )
2024-09-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aD8sWPlmp-0Zh17vj... to A8lL1H_6clgBKJXHK... (flutter/engine#55517 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from aD8sWPlmp-0Z to A8lL1H_6clgB
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-30 08:55:37 +00:00
engine-flutter-autoroll
15f3f992e0
Roll Flutter Engine from 569abc4044b8 to 897f5caffe2d (1 revision) ( #155912 )
...
569abc4044...897f5caffeskia-flutter-autoroll@skia.org Roll Skia from 2f1e716bbe61 to 333df70fbcdb (1 revision) (flutter/engine#55516 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-30 07:51:08 +00:00
engine-flutter-autoroll
4fdfbd4dde
Roll Flutter Engine from c4784aa7eade to 569abc4044b8 (2 revisions) ( #155894 )
...
c4784aa7ea...569abc4044skia-flutter-autoroll@skia.org Roll Skia from f88a9ae4d9c1 to 2f1e716bbe61 (1 revision) (flutter/engine#55513 )
2024-09-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from yX_hiCzoio2mYXAA8... to aD8sWPlmp-0Zh17vj... (flutter/engine#55512 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from yX_hiCzoio2m to aD8sWPlmp-0Z
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-29 06:21:39 +00:00
engine-flutter-autoroll
3f3eadbf87
Roll Flutter Engine from ff4541712df4 to c4784aa7eade (2 revisions) ( #155889 )
...
ff4541712d...c4784aa7eajonahwilliams@google.com Fix npe during skia dispatch of drawAtlas (flutter/engine#55497 )
2024-09-28 skia-flutter-autoroll@skia.org Roll Skia from 7efc11f2ea9e to f88a9ae4d9c1 (2 revisions) (flutter/engine#55511 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-28 20:57:38 +00:00
Mairramer
29dd03c56b
Fixes column text width calculation in CupertinoDatePicker ( #151128 )
...
Fixes #138305 , #110319
2024-09-28 20:21:48 +00:00
engine-flutter-autoroll
a9b648f750
Roll Flutter Engine from 380fd814448c to ff4541712df4 (1 revision) ( #155886 )
...
380fd81444...ff4541712dchris@bracken.jp Improved description for ios_debug_sim_unopt_arm64 (flutter/engine#55498 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-28 20:08:35 +00:00
Taha Tesser
9f88de930b
Optimize Overlay sample to avoid overflow ( #155861 )
...
Fixes [Optimize official `Overlay` sample to avoid overflowing.](https://github.com/flutter/flutter/issues/155860 )
When checking https://main-api.flutter.dev/flutter/widgets/Overlay-class.html on a laptop screen it overflows as the layout uses Row instead of more robust widget for spacing `Wrap`
Quick Friday night fix. :)
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/user-attachments/assets/eea6f1d9-e860-4ebd-8d16-2d8f4141e1ec " /> | <img src="https://github.com/user-attachments/assets/9f8426ba-d541-44a6-8ea6-2e34636b7e82 " /> |
2024-09-28 09:20:32 +00:00
engine-flutter-autoroll
71fd800e7e
Roll Flutter Engine from f3b11bcd9c37 to 380fd814448c (1 revision) ( #155876 )
...
f3b11bcd9c...380fd81444skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hMFizUI--VpyjP3ht... to yX_hiCzoio2mYXAA8... (flutter/engine#55505 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from hMFizUI--Vpy to yX_hiCzoio2m
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-28 08:52:33 +00:00
engine-flutter-autoroll
10fe74a151
Roll Flutter Engine from 9c8e5cb226e4 to f3b11bcd9c37 (3 revisions) ( #155865 )
...
9c8e5cb226...f3b11bcd9c1961493+harryterkelsen@users.noreply.github.com Revert "Reland "[canvaskit] Further improve overlay optimization by splitting pictures"" (flutter/engine#55501 )
2024-09-28 matanlurey@users.noreply.github.com Migrate `try/finally` calls to `addTearDown`. (flutter/engine#55499 )
2024-09-27 chris@bracken.jp iOS: Migrate FlutterAppDelegate to ARC (flutter/engine#55472 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-28 02:21:25 +00:00
engine-flutter-autoroll
9928ba8bd0
Roll Flutter Engine from f9e4ed28f103 to 9c8e5cb226e4 (1 revision) ( #155857 )
...
f9e4ed28f1...9c8e5cb226jason-simmons@users.noreply.github.com [Impeller] Apply some recent color filter fixes to BlendFilterContents::CreateForegroundAdvancedBlend (flutter/engine#55470 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-28 00:09:24 +00:00
engine-flutter-autoroll
3e4a57fa50
Roll Flutter Engine from f21f2b232b8a to f9e4ed28f103 (2 revisions) ( #155855 )
...
f21f2b232b...f9e4ed28f130870216+gaaclarke@users.noreply.github.com updated Color docstring to address equality (flutter/engine#55496 )
2024-09-27 chris@bracken.jp Make arm64 iOS simulator local engine build unopt (flutter/engine#55493 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-27 23:13:21 +00:00
RamonFarizel
1290ab42d1
Add magnificationScale to CupertinoMagnifier for Zoom Effect ( #155276 )
...
Add `magnificationScale `to `CupertinoMagnifier` for Zoom Effect
The CupertinoMagnifier widget is not displaying the expected zoom effect.
This issue arises because the widget internally wraps the RawMagnifier, which has its magnificationScale attribute set to the default value of 1. As a result, no magnification is applied, and the zoom effect is absent.
Fixes #155275
2024-09-27 23:13:19 +00:00
Jonathan Steele
96291fc0c4
Fix typo on theme_data ( #155644 )
...
Fix one typo on theme_data
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-27 14:33:09 -07:00
engine-flutter-autoroll
2dbd73dbb9
Roll Flutter Engine from 7c603de2dca7 to f21f2b232b8a (6 revisions) ( #155843 )
...
7c603de2dc...f21f2b232b1083941774@qq.com [docs] Fix broken links in docs/ (flutter/engine#55350 )
2024-09-27 skia-flutter-autoroll@skia.org Roll Skia from e77818421e91 to 7efc11f2ea9e (6 revisions) (flutter/engine#55489 )
2024-09-27 jason-simmons@users.noreply.github.com Listen for uncaught exceptions during loading of a web test suite in Chrome (flutter/engine#55166 )
2024-09-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] hash even less stuff per frame. (#55092 )" (flutter/engine#55491 )
2024-09-27 mdebbar@google.com [web] Update builder json generator to reflect recent changes (flutter/engine#55307 )
2024-09-27 jonahwilliams@google.com [Impeller] hash even less stuff per frame. (flutter/engine#55092 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-27 19:59:32 +00:00
Gray Mackall
dec2091c03
Turn the packages roller bot back on ( #155842 )
...
Turns the roller bot back on, as it should have been fixed by https://github.com/flutter/flutter/pull/155794/ .
2024-09-27 19:43:37 +00:00
engine-flutter-autoroll
180f40108b
Roll Packages from f38b780f530f to 0321757447bf (4 revisions) ( #155832 )
...
f38b780f53...0321757447engine-flutter-autoroll@skia.org Roll Flutter from 538e7424d018 to fa402c8057a1 (19 revisions) (flutter/packages#7713 )
2024-09-26 hosam.hasan.ramadan@gmail.com [flutter_markdown] remove backgroundColor from code text theme to enable code selection highlight (flutter/packages#7090 )
2024-09-26 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for iOS native `IMAFriendlyObstruction` (flutter/packages#7696 )
2024-09-26 matanlurey@users.noreply.github.com Add a `@SuppressWarnings` in advance (flutter/packages#7712 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-27 18:11:06 +00:00
Martin Kustermann
ead6b0d17c
Remove left-over traces of "link-dry-run" - which isn't used anywhere in flutter ( #155820 )
...
The "link-dry-run" functionality was never used in flutter (even before
the recent refactoring).
I think we can remove this "link-dry-run" concept everywhere.
PR to remove this in dart-lang/native:
https://github.com/dart-lang/native/pull/1613
2024-09-27 16:45:35 +02:00
engine-flutter-autoroll
9be22b58c4
Roll Flutter Engine from e57b440ec4ee to 7c603de2dca7 (5 revisions) ( #155811 )
...
e57b440ec4...7c603de2dcskia-flutter-autoroll@skia.org Roll Skia from 9ebb7c3640a1 to e77818421e91 (4 revisions) (flutter/engine#55479 )
2024-09-27 jonahwilliams@google.com [ci] make opengles impeller scenario app non-bringup (flutter/engine#55474 )
2024-09-27 jonahwilliams@google.com [Impeller] dont use blend shader for simple drawAtlas calls. (flutter/engine#55420 )
2024-09-27 valentin.haloiu@gmail.com Add `format` field to EGL surface backing store (flutter/engine#54499 )
2024-09-26 jonahwilliams@google.com [Impeller] avoid reading font while parsing sktextblob. (flutter/engine#55442 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-27 08:22:24 +00:00
Bruno Leroux
9ee3fb813f
Fix DropdownMenu rendered behind AppBar ( #155539 )
...
## Description
This PR changes the `MenuAnchor` implementation in order to always show the menu on the root overlay. Doing so menus can't be hidden by other widgets especially when using go_router.
See [[go_router] DropdownMenu behind NavigationBar](https://github.com/flutter/flutter/issues/155034 ) where the DropdownMenu menu was displayed behind the navigation bar.
I did not make this configurable for the moment to avoid introducing a new parameter until there is a clear use case for it.
## Related Issue
Fixes [[go_router] DropdownMenu behind NavigationBar](https://github.com/flutter/flutter/issues/155034 ).
## Tests
Adds 1 test.
2024-09-27 07:18:35 +00:00
engine-flutter-autoroll
7bb9352911
Roll Flutter Engine from 53517772a5b0 to e57b440ec4ee (8 revisions) ( #155799 )
...
53517772a5...e57b440ec41961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55464 )
2024-09-26 jonahwilliams@google.com [Impeller] remove entity pass and re-combine canvas implementations. (flutter/engine#55019 )
2024-09-26 skia-flutter-autoroll@skia.org Roll Skia from e986bd33fb33 to 9ebb7c3640a1 (3 revisions) (flutter/engine#55466 )
2024-09-26 skia-flutter-autoroll@skia.org Roll Skia from 5f6ea5ff8401 to e986bd33fb33 (1 revision) (flutter/engine#55465 )
2024-09-26 matanlurey@users.noreply.github.com Remove and inline dependencies on `build_root` for a constant. (flutter/engine#55441 )
2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418 )" (#55450 )" (flutter/engine#55463 )
2024-09-26 chris@bracken.jp cipd: add mobileprovision CIPD package (flutter/engine#55449 )
2024-09-26 skia-flutter-autoroll@skia.org Roll Skia from b2c5f640cb44 to 5f6ea5ff8401 (1 revision) (flutter/engine#55462 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-27 01:23:28 +00:00
David Iglesias
f9a76aea87
Throw StateError when implicitView is null on wrapWithDefaultView. ( #155734 )
...
This PR tweaks `wrapWithDefaultView` (used by `runApp`) to raise a StateError with a legible error message when the `platformDispatcher.implicitView` is missing (for example, when enabling multi-view embedding on the web), instead of crashing with an unexpected `nullCheck` a few lines below.
* Before:
<img width="619" alt="Screenshot 2024-09-25 at 7 33 47â¯PM" src="https://github.com/user-attachments/assets/4897dd3c-bdd0-4217-9f23-7eee9fab4999 ">
* After:
<img width="613" alt="Screenshot 2024-09-26 at 5 01 49â¯PM" src="https://github.com/user-attachments/assets/3febb91d-a8c3-41b6-bf34-c2c8743b637c ">
## Issues
* Fixes https://github.com/flutter/flutter/issues/153198
## Tests
Added a test to ensure the assertion is thrown when the `implicitView` is missing. Had to hack a little because I couldn't find any clean way of overriding the `implicitView`. The problem is that the flutter_test bindings [use `runApp` internally](8925e1ffdf/packages/flutter_test/lib/src/binding.dart (L1020)
2024-09-27 00:55:31 +00:00
Gray Mackall
cad7418f0a
Roll packages manually ( #155786 )
...
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-09-27 00:49:08 +00:00
Renzo Olivares
799cf16aeb
fix: SelectableText should handle focus changes ( #155771 )
...
This change updates the behavior of `SelectableText`, to clear its selection when it loses focus and the application is currently running. This fixes the behavior where you may have multiple active highlights if you have `SelectableText` along with other "selectable" widgets such as `TextField`, or `Text` widgets under a `SelectionArea`.
If the application is in the background, for example when another window is focused, the selection should be retained so when a user returns to the application it is still there.
This change also updates the behavior of selection on macOS, single tap up, previously it was selecting the word edge closest to the tapped position, the correct behavior on native is to select the precise position. This was causing `onSelectionChanged` to be called twice, once for tap down (sets the precise tapped position, handled by logic in `TextSelectionGestureDetector`), and a second time for single tap up (moves the cursor to closest word edge, handled by logic in `_SelectableTextSelectionGestureDetectorBuilder`). This type of selection inconsistency is related to this issue https://github.com/flutter/flutter/issues/129726 , I plan to look into this further in a separate PR.
Fixes #117573
Fixes #103725
2024-09-27 00:17:05 +00:00
Gray Mackall
5b32f33271
Use flutter from in same repo (not path) in generate_gradle_lockfiles.dart (again) ( #155794 )
...
Fixes another invocation of `flutter`. Follow up to https://github.com/flutter/flutter/pull/155790/ .
Checked that this is the only other one (and also the only use of `exec()` left that is relying on the path and shouldn't be (one other use uses git from the path, which is fine, and the other one uses an absolute path).
2024-09-27 00:13:27 +00:00
Gray Mackall
2c0a4f2d44
Use flutter from in same repo (not path) in generate_gradle_lockfiles.dart ( #155790 )
...
Should hopefully fix https://github.com/flutter/flutter/issues/155704 ð
2024-09-26 22:58:06 +00:00
Renzo Olivares
9a64920bb9
RenderParagraph should invalidate its _SelectableFragments cached rects on window size updates (#155719 )
...
Fixes #155143
Fixes #120578
2024-09-26 22:51:59 +00:00
