Bruno Leroux
a4af12f477
Update app_builder_test.dart for M3 ( #130794 )
...
This PR updates unit tests from app_builder_test.dart for M3 migration.
More info in https://github.com/flutter/flutter/issues/127064
In this particular case, I choose to make the tests Material-agnostic by removing the color theming which was not meaningful to what is tested here.
2023-07-18 23:29:31 +00:00
Ian Hickson
d21109220b
Catch errors in loadStructuredData ( #130748 )
...
Fixes https://github.com/flutter/flutter/issues/42390
2023-07-18 23:02:56 +00:00
fzyzcjy
2d753a621e
Fix super tiny space formatting (hope we have auto formatter in the future) ( #127479 )
...
Just fix a space... I do hope we can have the auto formatter enabled in the future!
2023-07-18 23:01:13 +00:00
engine-flutter-autoroll
0084347e78
Roll Flutter Engine from 71bbecee3010 to adf6142f6738 (2 revisions) ( #130831 )
...
71bbecee30...adf6142f67skia-flutter-autoroll@skia.org Roll Skia from 0adae44dd9cd to 9a0f6d82a6f5 (1 revision) (flutter/engine#43780 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 4e518e65fea0 to 0adae44dd9cd (6 revisions) (flutter/engine#43779 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 22:31:05 +00:00
Bruno Leroux
e29f2b98af
Update SnackBar tests for M2/M3 ( #130717 )
...
This PR updates unit tests for `SnackBar` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-07-18 22:10:17 +00:00
flutter-pub-roller-bot
edcaa335d1
Roll pub packages ( #130821 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-07-18 21:55:17 +00:00
Tae Hyung Kim
c6b93b2db7
Relax syntax for gen-l10n ( #130736 )
...
To preserve backward compatibility with the old parser which would
ignore syntax errors, this PR introduces a way to treat the special
characters `{` and `}` in the following way:
1. If we encounter a `{` which searching for a string token and this `{`
is not followed by a valid placeholder, then we treat the `{` as a
string and continue lexing for strings.
2. If we encounter a `}` while not within some expression (i.e.
placeholders, arguments, plurals, or selects), then we treat the `}` as
a string and continue lexing for strings.
This makes it so that
```
"helloWorld": "{ } { placeholder }",
"@@helloWorld": {
"placeholders": {
"placeholder" {}
}
}
```
treats the `{ }` as a string while `{ placeholder } ` is treated as a
placeholder.
Fixes https://github.com/flutter/flutter/issues/122404 .
2023-07-18 13:59:48 -07:00
engine-flutter-autoroll
bb798e2a84
Roll Flutter Engine from 45851af55bd6 to 71bbecee3010 (7 revisions) ( #130820 )
...
45851af55b...71bbecee30mdebbar@google.com [web] sync => isSync , scuba => golden (flutter/engine#43699 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 219ca2581ab2 to 4e518e65fea0 (2 revisions) (flutter/engine#43777 )
2023-07-18 skia-flutter-autoroll@skia.org Roll ANGLE from 113f847be69f to 52fe3116ead9 (146 revisions) (flutter/engine#43776 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from b7103fe086c1 to 219ca2581ab2 (1 revision) (flutter/engine#43774 )
2023-07-18 chillers@google.com [ci.yaml] Skip windows arm on releases (flutter/engine#43771 )
2023-07-18 gspencergoog@users.noreply.github.com Check FlutterAppDelegate selector support before calling (flutter/engine#43425 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from _CIP-1iUTmGCbCDZ5... to SCshjyIlymHWD9W4D... (flutter/engine#43773 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from _CIP-1iUTmGC to SCshjyIlymHW
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 20:45:06 +00:00
flutter-pub-roller-bot
60425b3c5e
Roll pub packages ( #130608 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-07-18 19:40:23 +00:00
engine-flutter-autoroll
8fa71cbbc5
Roll Flutter Engine from 831da7e9dc3b to 45851af55bd6 (2 revisions) ( #130814 )
...
831da7e9dc...45851af55bzanderso@users.noreply.github.com Reset Dart VM optimization level to 2 (flutter/engine#43770 )
2023-07-18 jonahwilliams@google.com [Impeller] Avoid inserting additional save layers based on clip configuration. (flutter/engine#43759 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 18:52:24 +00:00
Camille Simon
b42879a94e
[Android] Deletes deprecated splash screen meta-data element ( #130744 )
...
Deletes deprecated splash screen meta-data element.
This is no longer needed to present a splash screen in a Flutter application, but will be removed soon. See [go/flutter-splash-screen-migration](http://go/flutter-splash-screen-migration ) for more information.
Part of https://github.com/flutter/flutter/issues/105173 .
2023-07-18 18:38:12 +00:00
Hans Muller
433f93560a
Updated ThemeData.useMaterial3 API doc, default is true ( #130764 )
...
Fixes https://github.com/flutter/flutter/issues/130761
2023-07-18 11:22:02 -07:00
Casey Hillers
ab14a5c356
[labeler] Mark sync-labels as empty ( #130642 )
...
https://github.com/flutter/flutter/issues/128440
Recommendation from https://github.com/actions/labeler/issues/112#issuecomment-1136485391
2023-07-18 18:19:23 +00:00
engine-flutter-autoroll
fc2626a790
Roll Flutter Engine from c27658cc5ade to 831da7e9dc3b (2 revisions) ( #130810 )
...
c27658cc5a...831da7e9dcskia-flutter-autoroll@skia.org Roll Skia from b33cc7da1e23 to b7103fe086c1 (1 revision) (flutter/engine#43769 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 8d3e00a1f25f to b33cc7da1e23 (1 revision) (flutter/engine#43768 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 18:01:54 +00:00
engine-flutter-autoroll
94179a8e3f
Roll Packages from 6889cca8ba78 to 3e8b8130cda3 (9 revisions) ( #130802 )
...
6889cca8ba...3e8b8130cdjkbturek@gmail.com [video_player] Fix iOS crash with multiple players (flutter/packages#4202 )
2023-07-17 stuartmorgan@google.com [pigeon] Enable Android emulator tests in CI (flutter/packages#4484 )
2023-07-17 defuncart@gmail.com [video_player] Add optional web options [Platform interface] (flutter/packages#4433 )
2023-07-17 rexios@rexios.dev [google_maps_flutter_platform_interface] Platform interface changes for #3258 (flutter/packages#4478 )
2023-07-17 yan.outside@gmail.com [video_player] fix: add missing isPlaybackLikelyToKeepUp check. (flutter/packages#3826 )
2023-07-17 43054281+camsim99@users.noreply.github.com [camerax] Add flash configuration for image capture (flutter/packages#3800 )
2023-07-17 stuartmorgan@google.com Remove `equatable` and `xml` allowances (flutter/packages#4489 )
2023-07-17 stuartmorgan@google.com [ci] Switch Linux platform tests to LUCI (flutter/packages#4479 )
2023-07-17 stuartmorgan@google.com [ci] Adjust bot configurations (flutter/packages#4485 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 16:42:10 +00:00
Taha Tesser
b460d49199
Update AppBar and AppBarTheme tests for M2/M3 ( #130790 )
...
Updated unit tests for `AppBar` and `AppBarTheme` to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/issues/127064
2023-07-18 16:24:11 +00:00
Bruno Leroux
86385dce68
Update app tests for M3 ( #130792 )
...
This PR updates unit tests from `app_test.dart` for M3 migration.
More info in https://github.com/flutter/flutter/issues/127064
The diff is somewhat misleading because third test in the original code is now the fourth in the updated one, but because they were very similar git diff does not reflect this swap.
And also, first test is M2 only and last one M3 only.
2023-07-18 16:13:48 +00:00
Greg Spencer
8b768de18f
Add lint check to make sure samples are linked and have tests ( #130523 )
...
## Description
This adds a checker that will check all of the API docs examples to make sure that they are linked from at least one source file in the packages.
It also checks to make sure that all of the examples have an associated test. Since there are a large number that don't have tests at the moment, there is also a large exception list that can be burned down (burn down list is in https://github.com/flutter/flutter/issues/130459 ).
Because there are missing links currently, this PR will only pass after https://github.com/flutter/flutter/pull/130521 is merged.
## Related Issues
- https://github.com/flutter/flutter/issues/129956
- https://github.com/flutter/flutter/issues/130459
## Tests
- Added test for the checker.
2023-07-18 15:26:09 +00:00
engine-flutter-autoroll
3b0b8348fd
Roll Flutter Engine from aaec42812a1f to c27658cc5ade (2 revisions) ( #130799 )
...
aaec42812a...c27658cc5askia-flutter-autoroll@skia.org Roll Dart SDK from b83a63e0181a to ec95774043ec (1 revision) (flutter/engine#43767 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from a4df72ba04bb to 8d3e00a1f25f (1 revision) (flutter/engine#43766 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 15:22:24 +00:00
yaakovschectman
203ef6f7a3
Extract common functionality of iOS platformviews into superclasses ( #128716 )
...
Move most functionality of `UiKitView` and its supporting classes into
superclasses named `DarwinPlatformView`, etc., and create trivial or
near-trivial subclasses with the same names as the old classes.
I am currently awaiting approval for a macOS workstation that would
allow me to run the iOS/macOS tests and make sure all existing
functionality is preserved by this refactor. I can ensure that tests
will pass, but doing so may need to wait for a while.
Addresses [Add
AppKitView](https://github.com/flutter/flutter/issues/128519 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Chris Bracken <chris@bracken.jp>
2023-07-18 10:06:52 -04:00
engine-flutter-autoroll
beb245c749
Roll Flutter Engine from 88be39be7b07 to aaec42812a1f (1 revision) ( #130787 )
...
88be39be7b...aaec42812askia-flutter-autoroll@skia.org Roll Skia from 31be5646930b to a4df72ba04bb (1 revision) (flutter/engine#43763 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 11:25:32 +00:00
engine-flutter-autoroll
5952edb84b
Roll Flutter Engine from b46a8baf8ed9 to 88be39be7b07 (1 revision) ( #130784 )
...
b46a8baf8e...88be39be7bskia-flutter-autoroll@skia.org Roll Dart SDK from 979375f92109 to b83a63e0181a (1 revision) (flutter/engine#43762 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 10:07:25 +00:00
engine-flutter-autoroll
3718aef47d
Roll Flutter Engine from 777fe158f4e7 to b46a8baf8ed9 (1 revision) ( #130782 )
...
777fe158f4...b46a8baf8eflutter/engine#43760 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 09:15:19 +00:00
Taha Tesser
fa6754d362
Fix iconTheme in AppBar doesn't apply custom Colors.white in the dark mode for M3 ( #130574 )
...
fixes [[Material3] AppBar does not respect `foregroundColor` or `iconTheme` for leading and actions in some cases](https://github.com/flutter/flutter/issues/130485 )
### Description
- Fix `Colors.white` not applied in dark mode
- Add regression tests
- make `iconStyle` private for consistency
### Before
### After
2023-07-18 08:26:09 +00:00
engine-flutter-autoroll
b552a0b3e6
Roll Flutter Engine from c6e23288db8d to 777fe158f4e7 (2 revisions) ( #130779 )
...
c6e23288db...777fe158f4skia-flutter-autoroll@skia.org Roll Skia from 48a44e2cda18 to 31be5646930b (3 revisions) (flutter/engine#43758 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 071d5897eb8a to 48a44e2cda18 (1 revision) (flutter/engine#43757 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 08:05:23 +00:00
engine-flutter-autoroll
39c475c379
Roll Flutter Engine from 116eedf769be to c6e23288db8d (3 revisions) ( #130778 )
...
116eedf769...c6e23288dbskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from WZt3P7Fm3_GUvAaDv... to ixKM7wyMrqmPDaQ11... (flutter/engine#43756 )
2023-07-18 jiahaog@users.noreply.github.com Minor fixes for C++20 compatibility (flutter/engine#43674 )
2023-07-18 jiahaog@users.noreply.github.com Revert "Log dlopen errors in opt builds (#41477 )" (flutter/engine#43677 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from WZt3P7Fm3_GU to ixKM7wyMrqmP
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 07:01:24 +00:00
engine-flutter-autoroll
ace12f92de
Roll Flutter Engine from 9d018f00d687 to 116eedf769be (2 revisions) ( #130774 )
...
9d018f00d6...116eedf769skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from jtvD_HgQVBqadF3jX... to _CIP-1iUTmGCbCDZ5... (flutter/engine#43755 )
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from f2a4222bb72e to 071d5897eb8a (1 revision) (flutter/engine#43754 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from jtvD_HgQVBqa to _CIP-1iUTmGC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 06:14:23 +00:00
engine-flutter-autoroll
e14dcf06c6
Roll Flutter Engine from 77ec92371846 to 9d018f00d687 (1 revision) ( #130772 )
...
77ec923718...9d018f00d6skia-flutter-autoroll@skia.org Roll Dart SDK from 32bc5d654e92 to 979375f92109 (1 revision) (flutter/engine#43753 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 05:23:32 +00:00
Ian Hickson
e12d31ad75
Document stack's clipping behaviour better ( #130749 )
...
Fixes https://github.com/flutter/flutter/issues/40216
2023-07-18 03:36:18 +00:00
engine-flutter-autoroll
e276629ffb
Roll Flutter Engine from f2958f9229a4 to 77ec92371846 (1 revision) ( #130769 )
...
f2958f9229...77ec923718zanderso@users.noreply.github.com Add a GN flag to set the
Dart VM's optimization level (flutter/engine#43743 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-17 20:29:46 -07:00
engine-flutter-autoroll
8a8f023466
Roll Flutter Engine from 3cceb705007e to f2958f9229a4 (1 revision) ( #130767 )
...
3cceb70500...f2958f9229skia-flutter-autoroll@skia.org Roll Dart SDK from
78c9ac730629 to 32bc5d654e92 (1 revision) (flutter/engine#43751 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-17 19:46:27 -07:00
engine-flutter-autoroll
11f7c45a6d
Roll Flutter Engine from 09689d37e1d6 to 3cceb705007e (2 revisions) ( #130763 )
...
09689d37e1...3cceb70500brianosman@google.com Fix drawVertices documentation (flutter/engine#43747 )
2023-07-17 zanderso@users.noreply.github.com Revert "Roll Clang from 6d667d4b261e to ebd0b8a0472b" (flutter/engine#43749 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-18 00:59:24 +00:00
Jim Graham
c1f6b32c81
Stabilize hybrid_android_views_integration_test rendering tree ( #130751 )
...
Fixes: https://github.com/flutter/flutter/issues/130738
A widget was added to explicitly and intentionally overlap the
PlatformView so that the rendering tree of Views would always have an
underlay and an overlay to match the test expectations.
2023-07-17 17:56:25 -07:00
Andrew Kolos
236a131cff
update link to good first issues ( #130759 )
...
Today (Jul 17, 2023), I renamed the `good first contribution` label to `good first issue`. This is because
1) `good first issue` is more commonly used for this intent across GitHub and and thus may be (ever so slightly) more recognizable to potential new contributors, and, more importantly,
2) GitHub recognizes the label `good first issue` when surfacing good first issues in specific places in GitHub[^1].
This PR updates Contributing.md to match the new name.
`grep` did not find any other references to `good first contribution` to update in this repo.
[^1]: [Source (GitHub docs)](https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/encouraging-helpful-contributions-to-your-project-with-labels ). Example: https://github.com/flutter/flutter/contribute . If my vague memory serves me correctly, this can also appear in certain emails or the "discovery queue"-type experience that GitHub provides.
2023-07-17 23:51:14 +00:00
LongCatIsLooong
fe7d01ffab
Prevent InputDecorator from supplying its descendants with non-normalized constraints ( #130460 )
...
Fixes https://github.com/flutter/flutter/issues/129611
2023-07-17 23:35:20 +00:00
engine-flutter-autoroll
d0bb56f024
Roll Flutter Engine from 15c15fd75743 to 09689d37e1d6 (3 revisions) ( #130758 )
...
15c15fd757...09689d37e1737941+loic-sharma@users.noreply.github.com [Windows] Remove accessibility bridge helpers from the engine (flutter/engine#43710 )
2023-07-17 jason-simmons@users.noreply.github.com Move Dart licenses into a separate golden file (flutter/engine#43289 )
2023-07-17 skia-flutter-autoroll@skia.org Roll Skia from f29d58569c67 to f2a4222bb72e (1 revision) (flutter/engine#43746 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-17 23:02:23 +00:00
hellohuanlin
1b07c3d798
[tools/ios_build_ipa] fallback to CFBundleName if CFBundleDisplayName is absent ( #130752 )
...
The display name will fallback to CFBundleName if CFBundleDisplayName is absent.
*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/120553
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-07-17 22:21:07 +00:00
Michael Goderbauer
2dbf594fde
Resolve TODOs in channels integration test ( #130745 )
...
They were helpful in diagnosing the flake in https://github.com/flutter/flutter/issues/116663 , but now that that's resolved they have outlived their usefulness. Let's remove 'em!
2023-07-17 22:05:37 +00:00
engine-flutter-autoroll
ede545cd8b
Roll Flutter Engine from ddbe23b374d8 to 15c15fd75743 (2 revisions) ( #130746 )
...
ddbe23b374...15c15fd757skia-flutter-autoroll@skia.org Roll Dart SDK from c1bfb2689f6f to 78c9ac730629 (1 revision) (flutter/engine#43745 )
2023-07-17 skia-flutter-autoroll@skia.org Roll Skia from f0e1963324eb to f29d58569c67 (4 revisions) (flutter/engine#43744 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-17 21:25:11 +00:00
Loïc Sharma
e8231cea4c
Move examples to ListenableBuilder ( #130671 )
...
Updates examples to use the new `ListenableBuilder` if there's no animation. This is slightly more idiomatic.
2023-07-17 21:06:15 +00:00
engine-flutter-autoroll
085d6c9700
Roll Flutter Engine from aa3239cf3c01 to ddbe23b374d8 (3 revisions) ( #130741 )
...
aa3239cf3c...ddbe23b374skia-flutter-autoroll@skia.org Roll Skia from b25cd035db06 to f0e1963324eb (2 revisions) (flutter/engine#43741 )
2023-07-17 skia-flutter-autoroll@skia.org Roll Skia from dc93f341ec38 to b25cd035db06 (2 revisions) (flutter/engine#43740 )
2023-07-17 bdero@google.com [Impeller] Correct coverage hint usage in PipelineBlend (flutter/engine#43708 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-17 20:34:53 +00:00
Polina Cherkasova
e337343ab7
Mark some leaks. ( #130470 )
2023-07-17 12:48:58 -07:00
engine-flutter-autoroll
220b0c4d9f
Roll Flutter Engine from 09fe990ebfcf to aa3239cf3c01 (5 revisions) ( #130735 )
...
09fe990ebf...aa3239cf3c10456171+caroqliu@users.noreply.github.com [fuchsia] flutter-embedder-test and touch-input-test use Flatland Test UI Stack (flutter/engine#43562 )
2023-07-17 skia-flutter-autoroll@skia.org Roll Skia from 4ec9f2497be1 to dc93f341ec38 (10 revisions) (flutter/engine#43739 )
2023-07-17 skia-flutter-autoroll@skia.org Roll Skia from 288c98d7ef0b to 4ec9f2497be1 (1 revision) (flutter/engine#43738 )
2023-07-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VYjne_BEm9inQ5fnq... to jtvD_HgQVBqadF3jX... (flutter/engine#43736 )
2023-07-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 827259dfffb9 to c1bfb2689f6f (1 revision) (flutter/engine#43735 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from VYjne_BEm9in to jtvD_HgQVBqa
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-17 19:48:18 +00:00
Greg Spencer
0df4496cdb
Add missing example links ( #130521 )
...
## Description
This adds some more missing example links.
I also wrote another PR for adding a check to make sure that examples are all linked from a source file and have tests: https://github.com/flutter/flutter/pull/130523
## Related Issues
- https://github.com/flutter/flutter/issues/129956
## Tests
- Documentation and refactoring only.
2023-07-17 18:24:49 +00:00
Greg Price
1937ae6539
Make AbstractNode-derived docs more specific on RenderObject et al. ( #130689 )
...
These methods and/or their docs were recently copied (in #128467 and #128973 ) from their classes' former shared base class AbstractNode. Their wording was fittingly abstract there, but that abstraction is a bit puzzling for a reader finding them on these more concrete classes and not aware of the AbstractNode history. So make them more concrete, in similar terms to the other methods around them.
Also copy some useful points between corresponding methods on different classes (like that the parent of the root is null), and try to clean up the prose on [RenderObject.depth].
We focus on the more outward-facing parts of the API, letting methods like `redepthChildren` continue to talk generically about "nodes".
2023-07-17 18:20:27 +00:00
LongCatIsLooong
b2e22d3558
Replaces textScaleFactor with TextScaler ( #128522 )
...
Deprecate `textScaleFactor` in favor of `textScaler`, in preparation for Android 14 [Non-linear font scaling to 200%](https://developer.android.com/about/versions/14/features#non-linear-font-scaling ). The `TextScaler` class can be moved to `dart:ui` in the future, if we decide to use the Android platform API or AndroidX to get the scaling curve instead of hard coding the curve in the framework.
I haven't put the Flutter version in the deprecation message so the analyzer checks are failing. Will do so after I finish the migration guide.
**Why `TextScaler.textScaleFactor`**
The author of a `TextScaler` subclass should provide a fallback `textScaleFactor`. By making `TextScaler` also contain the `textScaleFactor` information it also makes it easier to migrate: if a widget overrides `MediaQueryData.textScaler` in the tree, for unmigrated widgets in the subtree it would also have to override `MediaQueryData.textScaleFactor`, and that makes it difficult to remove `MediaQueryData.textScaleFactor` in the future.
## A full list of affected APIs in this PR
Deprecated: The method/getter/setter/argument is annotated with a `@Deprecated()` annotation in this PR, and the caller should replace it with `textScaler` instead. Unless otherwise specified there will be a Flutter fix available to help with migration but it's still recommended to migrate case-by-case.
**Replaced**: The method this `textScaleFactor` argument belongs to is rarely called directly by user code and is not overridden by any of the registered custom tests, so the argument is directly replaced by `TextScaler`.
**To Be Deprecated**: The method/getter/setter/argument can't be deprecated in this PR because a registered customer test depends on it and a Flutter fix isn't available (or the test was run without applying flutter fixes first). This method/getter/setter/argument will be deprecated in a followup PR once the registered test is migrated.
### `Painting` Library
| Affected API | State of `textScaleFactor` | Comment |
| --- | --- | --- |
| `InlineSpan.build({ double textScaleFactor = 1.0 })` argument | **Replaced** | |
| `TextStyle.getParagraphStyle({ double TextScaleFactor = 1.0 })` argument | **Replaced** | |
| `TextStyle.getTextStyle({ double TextScaleFactor = 1.0 })` argument| Deprecated | Can't replace: c47fd38dca/super_editor/lib/src/infrastructure/super_textfield/desktop/desktop_textfield.dart (L1903-L1905)cd7b93532e/packages/flutter_markdown/test/text_scale_factor_test.dart (LL39C21-L39C35)cd7b93532e/packages/flutter_markdown/lib/src/_functions_io.dart (L68-L70)cd7b93532e/packages/flutter_markdown/lib/src/builder.dart (L829-L843)914d120da1/packages/rfw/lib/src/flutter/core_widgets.dart (L647)https://github.com/dart-lang/sdk/issues/52664 |
| `Text.rich({ double? TextScaleFactor = 1.0 })` constructor argument | **To Be Deprecated** | The default constructor has an argument that can't be deprecated right away. No Flutter Fix because of https://github.com/dart-lang/sdk/issues/52664 |
| `Text.textScaleFactor` getter | **To Be Deprecated** | A constructor argument can't be deprecated right away |
| `EditableText({ double? TextScaleFactor = 1.0 })` constructor argument | Deprecated | No Flutter Fix because of https://github.com/dart-lang/sdk/issues/52664 |
| `EditableText.textScaleFactor` getter | Deprecated | |
### `Material` Library
| Affected API | State of `textScaleFactor` | Comment |
| --- | --- | --- |
| `SelectableText({ double? TextScaleFactor = 1.0 })` constructor argument | **To Be Deprecated** | cd7b93532e/packages/flutter_markdown/lib/src/builder.dart (L829-L843)https://github.com/dart-lang/sdk/issues/52664 |
| `SelectableText.rich({ double? TextScaleFactor = 1.0 })` constructor argument | **To Be Deprecated** | The default constructor has an argument that can't be deprecated right away. No Flutter Fix because of https://github.com/dart-lang/sdk/issues/52664 |
| `SelectableText.textScaleFactor` getter | **To Be Deprecated** | A constructor argument can't be deprecated right away |
A lot of material widgets (`Slider`, `RangeSlider`, `TimePicker`, and different types of buttons) also change their layout based on `textScaleFactor`. These need to be handled in a case-by-case fashion and will be migrated in follow-up PRs.
2023-07-17 17:56:07 +00:00
LongCatIsLooong
0d1cc33b65
_RenderScaledInlineWidget constrains child size (#130648 )
...
Fixes https://github.com/flutter/flutter/issues/130588
2023-07-17 17:46:03 +00:00
LongCatIsLooong
bf4d659726
Allow OverlayPortal to be added/removed from the tree in a layout callback ( #130670 )
...
Fixes https://github.com/flutter/flutter/issues/130668
2023-07-17 17:46:00 +00:00
Lau Ching Jun
d64cc47920
Make ProxiedDevices a subclass of PollingDeviceDiscovery. ( #130640 )
...
The daemon ignores all device discovery that is not a PollingDeviceDiscovery. Make ProxiedDevices a PollingDeviceDiscovery so that it can be used in flutter daemon.
Note that there is a TODO item added in the test, which I intend to attempt fixing in a subsequent PR.
2023-07-17 17:40:12 +00:00
Michael Goderbauer
e06650bdbe
Guard access to dart:developer with !kReleaseMode ( #130627 )
2023-07-17 17:40:07 +00:00
