8942 Commits

Author SHA1 Message Date
Ian Hickson
c319b890b3
Allow ChangeNotifier to be mixed in again (#23631)
Luckily this class didn't actually need to extend its superclass, it
only implements the interface. So we can change `extends` to
`implements` and that's close enough, while allowing the class to be
mixed in again.
2018-10-29 19:44:36 -07:00
Ian Hickson
4a094de290
[H] Cleanup (#23632)
* Avoid abbreviations

* Sample code for AppBar.leading

* Add a test for OverflowBox/FractionallySizedBox

* Minor wording improvements in the text.

The words "note that" here don't really contribute to the flow.
2018-10-29 19:44:00 -07:00
Alexander Aprelev
5fc6b87174
Reland change that speeds up multiple devices hot-reload (#23695)
* Revert "Revert "Run reload asynchronously so that multiple devices can reload in parallel. (#22693)" (#23598)"

This reverts commit 0b68068d6a33f35cec568ae6a9b394ff2a9fdb76.

* Fix refreshViews so it sends app-wide(rather than per-isolate) service request.

Sending per-isolate request caused dead-lock in the engine in case of more-than-one ui isolate.
2018-10-29 18:51:57 -07:00
Devon Carew
0dada102fe
remove unnecessary overrides (#23650) 2018-10-29 18:51:29 -07:00
Hans Muller
047f9a9e03
Updated supportedLocales doc, etc (#23683) 2018-10-29 17:09:26 -07:00
Ben Konyi
b1a23299e1
Added '--check-for-remote-artifacts' option for Flutter Doctor. (#23543)
* Added '--check-for-remote-artifacts' option for Flutter Doctor.

This option takes a Flutter engine revision and issues HEAD requests to
determine whether or not artifacts for the provided engine revision are
available from cloud storage. This functionality is needed for the Dart
SDK autoroller to avoid creating a PR to roll the engine into the
framework while artifacts haven't finished building, which would cause
Cirrus tests to fail.
2018-10-29 17:03:22 -07:00
Nurlan Zhussupov
d8bf21a3b7 Add examples to documentation of TimeOfDay class. (#23452) 2018-10-29 16:52:51 -07:00
Jacob Richman
10bcddcc5c
Add option to track widget rebuilds and repaints from the Flutter inspector. (#23534) 2018-10-29 16:32:26 -07:00
Andrew Davies
b722a744e6
[frdp] Add includeNonFlutterIsolates flag. (#23693)
Previously there was no way to add this flag when searching for
Isolates.
2018-10-29 16:18:30 -07:00
Ian Hickson
5b4a5da78e
Revert "[O] Fix a race condition in vmservice_test.dart" (#23647)
* Revert "[H] Created a variant of InheritedWidget specifically for Listenables (#23393)"

This reverts commit 931328596ac48a848953f330a192fc33425a378a.

* Revert "Fix a race condition in vmservice_test.dart (#23529)"

This reverts commit 5e7b0a366b3fe55b99fa79461a94140c59ab3f07.
2018-10-28 13:43:15 -07:00
Ian Hickson
931328596a
[H] Created a variant of InheritedWidget specifically for Listenables (#23393)
* Created a variant of InheritedWidget specifically for Listenables

* Add more documentation per review comments
2018-10-27 16:51:39 -07:00
Ian Hickson
5e7b0a366b
Fix a race condition in vmservice_test.dart (#23529)
Fixes https://github.com/flutter/flutter/issues/19273
2018-10-27 16:50:53 -07:00
Alexander Aprelev
0b68068d6a
Revert "Run reload asynchronously so that multiple devices can reload in parallel. (#22693)" (#23598)
This reverts commit 709f54f4bbd776cb256a0edf885a64848121a894 as it seems to have broken two tests: flutter_gallery__back_button_memory, named_isolates_test.
2018-10-26 18:56:49 -07:00
Greg Spencer
dc2cc6375c
Simplify the version string for customer consumption. (#23578)
Fixes #21825
2018-10-26 13:21:36 -07:00
xster
17d068d724
Allow heroes to fly across navigators and restrict Cupertino nav bars to per navigator by default (#23322) 2018-10-26 12:12:13 -07:00
xster
87ca3d52a9
Back swipe hero (#23320) 2018-10-26 12:11:50 -07:00
Stanislav Baranov
c7b10a2d80
Propagate pointer size from Android MotionEvent. (#23536) 2018-10-26 11:48:00 -07:00
Alexander Aprelev
709f54f4bb
Run reload asynchronously so that multiple devices can reload in parallel. (#22693)
* Run reload asynchronously so that multiple devices can reload in parallel.
2018-10-26 10:32:25 -07:00
Ian Hickson
53308465c7
Fix bugs in RenderSizedOverflowBox and RenderFractionallySizedOverflowBox (#23492)
Bug #1: These didn't work with directional alignments, due to an error
in the types of the constructor arguments.

Bug #2: Pretty sure RenderSizedOverflowBox never worked at all. As
soon as I wrote a test for it, the test showed that there was a
fundamental bug in its performLayout method: it didn't set
parentUsesSize, but it immediately tried to use the child's size.
2018-10-26 10:31:37 -07:00
Ian Hickson
48a5804dd8
[O] Cleanup (#23530)
* Improve documentation

* Potential performance win in hit testing

Rather than copying the list every time we access `path`, this just
exposes it as an `Iterable`. People who want to copy it can use
`toList()`.

(This isn't a breaking change since code that expects a `List` is
still going to get one.)

* Enforce the Oxford Comma.
2018-10-26 10:30:59 -07:00
Gary Qian
6827d0920b
Same cursor offset within lines for all TextAffinities to prevent cursor shifting/moving. (#23485) 2018-10-26 10:21:25 -07:00
Alexander Aprelev
558ee42b2e
Register expression compiler in flutter test setting. (#23511)
* Register expression compiler in flutter test setting so that debugger expression evaluation is functional there.

* Fix analyzer lints
2018-10-26 08:04:58 -07:00
MH Johnson
3f179d80f6
[Material] Add custom shape parameter for Dialogs. (#23443)
* [Material] Add custom shape parameter for Dialogs.

* [Material] Add custom shape parameter for Dialogs.

* Address Hans' first round comments.

* Address Hans' first round comments.

* Address Hans' Second round comments.
2018-10-26 08:35:07 -04:00
Ian Hickson
5343bd8955
Add some documentation to the GestureBinding explaining the lifecycle. (#23484) 2018-10-25 15:40:22 -07:00
Jonah Williams
80fffe5ac4
Follow up scroll semantics update with documentation fixes (#23444) 2018-10-25 15:09:41 -07:00
liyuqian
883e2dc272
Maintain dirtiness and use retained engine layers (#23434)
For #21756
2018-10-25 14:17:12 -07:00
Dan Field
628e8ec0b9
Revert "Xcode backend refactor (#23387)" (#23528)
This reverts commit def1d80566024950f5e7aa748e5680e7f1480bcb.
2018-10-25 13:25:09 -07:00
Dan Field
def1d80566
Xcode backend refactor (#23387)
* Use Xcode build configurations to drive Flutter build mode
2018-10-25 11:29:31 -07:00
jslavitz
60de2deb4d
Adds custom control builder functionality to Stepper (#23310)
* Adds test and builder
2018-10-25 10:59:14 -07:00
jslavitz
bc56a7a6c5
Snack color (#23255)
* added test
2018-10-25 10:56:59 -07:00
Yegor
4452bd0a6b
Revert "Revert "make LocalHistoryRoute a proper super-mixin (#23382)"… (#23482)
* Revert "Revert "make LocalHistoryRoute a proper super-mixin (#23382)" (#23430)"

This reverts commit 3bbb3082b89ada4b0c44396148f3c2de731d1c6d.

This relands the LocalHistoryRoute change. The analyzer bug has been fixed.

* mark dartdocs as flaky
2018-10-25 09:56:23 -07:00
Martin
3b13761111 Update doc header in Opacity class to fix issue #23311 (#23475) 2018-10-25 09:32:57 -07:00
Jason Simmons
711eb99b06
Fix a type error in Slider (#23483)
Fixes https://github.com/flutter/flutter/issues/23340
2018-10-25 09:29:37 -07:00
Jason Simmons
549e8e07c6
Support launching flutter_tools from a package URI (#23476) 2018-10-24 14:41:16 -07:00
xster
d00a549f2d
Support RTL Cupertino nav bar transitions between routes (#23221) 2018-10-24 14:37:22 -07:00
Stefan Mitev
125b5d623c Fixes gradle error: 'Could not find lint-gradle-api.jar' (#23095) (#23397)
* Fixes gradle error: 'Could not find lint-gradle-api.jar' (#23095)
2018-10-24 14:33:39 -07:00
Danny Tuppeny
9dfc0f3aaa
Log received messages for exceptions as well as timeouts (#23287) 2018-10-24 07:22:08 +01:00
Danny Tuppeny
64bf567b0e
Push breakpoint URIs to Project and remove unused string paths (#23395) 2018-10-24 07:21:48 +01:00
Danny Tuppeny
aa83f77a49
Fix --pid-file not working for --machine + add to attach command (#23242)
* Fix --pid-file not working for --machine + add to attach

Fixes #23201.

* Add tests for --pid-file in run+attach
2018-10-24 07:21:36 +01:00
Jonah Williams
b21d0de0d6
Revert "Add explicit completed status trace to hot reload and restart commands" (#23445)
* Revert "Remove duplicate code comment in flutter_gallery (#23422)"

This reverts commit 8039620bb41047b3a43ca7e0ed48752cfb22ff51.

* Revert "Add explicit completed status trace to hot reload and restart commands (#23338)"

This reverts commit 245ef023b2aa26dbd59868d0d5705c115c18cfc3.
2018-10-23 19:02:42 -07:00
Jonah Williams
245ef023b2
Add explicit completed status trace to hot reload and restart commands (#23338) 2018-10-23 18:12:34 -07:00
Yegor
3bbb3082b8
Revert "make LocalHistoryRoute a proper super-mixin (#23382)" (#23430)
This reverts commit a3e0b0aee28038816e4a016feda14f9e87454bcf.

This change broke the analyzer during the dartdoc step.
2018-10-23 15:26:10 -07:00
Jacob Richman
b21fb8c27d
Run flutter tests with --track-widget-creation as part of the build. (#23415) 2018-10-23 14:10:53 -07:00
Gary Qian
02d659e82a
Support null locale before locale initialization, Roll engine to cdd592f5be97e824 (#23417)
cdd592f5b Reland 'Pass null instead of 'none' locale' (#6632)
2cd89200c Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) (#6631)
edfe02481 13771 - iOS dictation bug (#6607)
cadf4405b Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (#6626)
2018-10-23 13:57:43 -07:00
Greg Spencer
65d3ddd5d1
Dartdoc snippet extension to inject full featured code snippets in to API docs. (#23281)
This creates a custom dartdoc tool that will generate snippet blocks in our API docs that allow the user to copy easily to the clipboard, and will also embed the snippet code into a template to show it in a larger context with an app.

This PR adds the snippet tool, a template, and a couple of HTML skeleton files, one for snippets that are designed to be in an application setting, and one where it simply puts a nice container around existing snippets, making them easier to copy to the clipboard.
2018-10-23 13:50:24 -07:00
Yegor
a3e0b0aee2
make LocalHistoryRoute a proper super-mixin (#23382) 2018-10-23 13:43:02 -07:00
Jacob Richman
f5f70f0c99
Include .track in file names for cached dill files for builds with --track-widget-creation (#23299)
Ensure that cached dill files for builds with --track-widget-creation
always have .track. in the file name to avoid mixing transformed and
untransformed kernel files.
2018-10-23 10:09:18 -07:00
xster
b63ced55b4
Add a CupertinoTextField (#23194) 2018-10-22 19:20:17 -07:00
Michael Goderbauer
dc36195cb3
Reland "Remove all service extensions from release mode (#23038)" (#23291) 2018-10-23 03:53:29 +02:00
Jason Simmons
a6a1607888
Roll engine to 4c79e423dc6f89f98d8ceb263a5ca78e2f2da996 (#23384)
Also includes
  * Updates to affected tests
  * Change flutter_tools to pass package URIs to the Dart front end
    instead of filesystem paths
2018-10-22 18:03:50 -07:00