12317 Commits

Author SHA1 Message Date
Ian Hickson
c319b890b3
Allow ChangeNotifier to be mixed in again (#23631)
Luckily this class didn't actually need to extend its superclass, it
only implements the interface. So we can change `extends` to
`implements` and that's close enough, while allowing the class to be
mixed in again.
2018-10-29 19:44:36 -07:00
Ian Hickson
4a094de290
[H] Cleanup (#23632)
* Avoid abbreviations

* Sample code for AppBar.leading

* Add a test for OverflowBox/FractionallySizedBox

* Minor wording improvements in the text.

The words "note that" here don't really contribute to the flow.
2018-10-29 19:44:00 -07:00
Alexander Aprelev
5fc6b87174
Reland change that speeds up multiple devices hot-reload (#23695)
* Revert "Revert "Run reload asynchronously so that multiple devices can reload in parallel. (#22693)" (#23598)"

This reverts commit 0b68068d6a33f35cec568ae6a9b394ff2a9fdb76.

* Fix refreshViews so it sends app-wide(rather than per-isolate) service request.

Sending per-isolate request caused dead-lock in the engine in case of more-than-one ui isolate.
2018-10-29 18:51:57 -07:00
Devon Carew
0dada102fe
remove unnecessary overrides (#23650) 2018-10-29 18:51:29 -07:00
Hans Muller
047f9a9e03
Updated supportedLocales doc, etc (#23683) 2018-10-29 17:09:26 -07:00
Ben Konyi
b1a23299e1
Added '--check-for-remote-artifacts' option for Flutter Doctor. (#23543)
* Added '--check-for-remote-artifacts' option for Flutter Doctor.

This option takes a Flutter engine revision and issues HEAD requests to
determine whether or not artifacts for the provided engine revision are
available from cloud storage. This functionality is needed for the Dart
SDK autoroller to avoid creating a PR to roll the engine into the
framework while artifacts haven't finished building, which would cause
Cirrus tests to fail.
2018-10-29 17:03:22 -07:00
Nurlan Zhussupov
d8bf21a3b7 Add examples to documentation of TimeOfDay class. (#23452) 2018-10-29 16:52:51 -07:00
Jacob Richman
10bcddcc5c
Add option to track widget rebuilds and repaints from the Flutter inspector. (#23534) 2018-10-29 16:32:26 -07:00
Andrew Davies
b722a744e6
[frdp] Add includeNonFlutterIsolates flag. (#23693)
Previously there was no way to add this flag when searching for
Isolates.
2018-10-29 16:18:30 -07:00
Dan Field
946553307f
Revert to last known good engine (#23700)
One of the devicelab tests is broken after this commit - rolling to last known good commit while I investigate.

/cc @bkonyi
2018-10-29 15:47:28 -07:00
engine-flutter-autoroll
d34bc3687e
Roll engine 2f06a53a8d19..7352251ebec6 (2 commits) (#23667)
2f06a53a8d...7352251ebe

git log 2f06a53a8d19..7352251ebec6 --no-merges --oneline
7352251eb Roll src/third_party/skia 79c96811863f..797197a772b8 (1 commits) (flutter/engine#6683)
3dac47e4d Roll src/third_party/skia 38e4fd0c5654..79c96811863f (1 commits) (flutter/engine#6682)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-29 16:52:22 -04:00
engine-flutter-autoroll
6eadbe24ab
Roll engine a1d7cad70c81..2f06a53a8d19 (1 commits) (#23654)
a1d7cad70c...2f06a53a8d

git log a1d7cad70c81..2f06a53a8d19 --no-merges --oneline
2f06a53a8 Roll src/third_party/skia b53f1f46982d..38e4fd0c5654 (1 commits) (flutter/engine#6681)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-29 00:21:22 -04:00
engine-flutter-autoroll
be86614198
Roll engine 162b2e98c036..a1d7cad70c81 (10 commits) (#23646)
162b2e98c0...a1d7cad70c

git log 162b2e98c036..a1d7cad70c81 --no-merges --oneline
a1d7cad70 Fix inconsistent include syntax (flutter/engine#6680)
236661cd8 Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (flutter/engine#6679)
c4f50611d Roll buildroot to pick up Mac toolchain updates. (flutter/engine#6678)
ba8f6aa71 Handle Windows headers defining ERROR to 0 in log levels. (flutter/engine#6677)
505d2a923 Roll buildroot to pick up updates to custom toolchains. (flutter/engine#6674)
6c2a0b3a6 Undefine ERROR in platform_view_layer.cc (flutter/engine#6675)
55e12993a Update FlutterPlugin.h docs, suppress warning for older API (flutter/engine#6672)
f7970048d Attach and position embedded UIVIews (flutter/engine#6614)
df85722fa Plumb the iOS PlatformViewsController into flow. (flutter/engine#6603)
2bfb893cf iOS Embedding Refactor (flutter/engine#6447)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-28 17:30:22 -04:00
Ian Hickson
5b4a5da78e
Revert "[O] Fix a race condition in vmservice_test.dart" (#23647)
* Revert "[H] Created a variant of InheritedWidget specifically for Listenables (#23393)"

This reverts commit 931328596ac48a848953f330a192fc33425a378a.

* Revert "Fix a race condition in vmservice_test.dart (#23529)"

This reverts commit 5e7b0a366b3fe55b99fa79461a94140c59ab3f07.
2018-10-28 13:43:15 -07:00
Ian Hickson
931328596a
[H] Created a variant of InheritedWidget specifically for Listenables (#23393)
* Created a variant of InheritedWidget specifically for Listenables

* Add more documentation per review comments
2018-10-27 16:51:39 -07:00
Ian Hickson
5e7b0a366b
Fix a race condition in vmservice_test.dart (#23529)
Fixes https://github.com/flutter/flutter/issues/19273
2018-10-27 16:50:53 -07:00
liyuqian
d245b4c3b3
Revert "Roll engine 162b2e98c036..6c2a0b3a6d93 (5 commits) (#23612)" (#23628)
This reverts commit 0f34f526204d180e117d2fc296084155651cf8da.

Reverts flutter/flutter#23612 as it broke the following two bots:
1. platform_view__start_up
2. platform_interaction_test_ios

Merge on red to fix the rope.
2018-10-27 13:35:26 -07:00
engine-flutter-autoroll
0f34f52620
Roll engine 162b2e98c036..6c2a0b3a6d93 (5 commits) (#23612)
162b2e98c0...6c2a0b3a6d

git log 162b2e98c036..6c2a0b3a6d93 --no-merges --oneline
6c2a0b3a6 Undefine ERROR in platform_view_layer.cc (flutter/engine#6675)
55e12993a Update FlutterPlugin.h docs, suppress warning for older API (flutter/engine#6672)
f7970048d Attach and position embedded UIVIews (flutter/engine#6614)
df85722fa Plumb the iOS PlatformViewsController into flow. (flutter/engine#6603)
2bfb893cf iOS Embedding Refactor (flutter/engine#6447)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-27 00:48:21 -04:00
engine-flutter-autoroll
bce610f2c9
Roll engine 3236b49ceac5..162b2e98c036 (1 commits) (#23593)
3236b49cea...162b2e98c0

git log 3236b49ceac5..162b2e98c036 --no-merges --oneline
162b2e98c Roll src/third_party/skia a944142412cd..3b79aa3a5ad0 (15 commits) (flutter/engine#6671)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-26 23:52:22 -04:00
Alexander Aprelev
0b68068d6a
Revert "Run reload asynchronously so that multiple devices can reload in parallel. (#22693)" (#23598)
This reverts commit 709f54f4bbd776cb256a0edf885a64848121a894 as it seems to have broken two tests: flutter_gallery__back_button_memory, named_isolates_test.
2018-10-26 18:56:49 -07:00
engine-flutter-autoroll
c54cf0484c
Roll engine dd791f36aca8..3236b49ceac5 (1 commits) (#23587)
dd791f36ac...3236b49cea

git log dd791f36aca8..3236b49ceac5 --no-merges --oneline
3236b49ce Add missing includes (flutter/engine#6670)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-26 16:28:22 -04:00
Greg Spencer
dc2cc6375c
Simplify the version string for customer consumption. (#23578)
Fixes #21825
2018-10-26 13:21:36 -07:00
Yegor
223826247f
deflake the dartdocs test (#23582) 2018-10-26 13:12:14 -07:00
xster
17d068d724
Allow heroes to fly across navigators and restrict Cupertino nav bars to per navigator by default (#23322) 2018-10-26 12:12:13 -07:00
xster
87ca3d52a9
Back swipe hero (#23320) 2018-10-26 12:11:50 -07:00
Stanislav Baranov
c7b10a2d80
Propagate pointer size from Android MotionEvent. (#23536) 2018-10-26 11:48:00 -07:00
Alexander Aprelev
709f54f4bb
Run reload asynchronously so that multiple devices can reload in parallel. (#22693)
* Run reload asynchronously so that multiple devices can reload in parallel.
2018-10-26 10:32:25 -07:00
Ian Hickson
53308465c7
Fix bugs in RenderSizedOverflowBox and RenderFractionallySizedOverflowBox (#23492)
Bug #1: These didn't work with directional alignments, due to an error
in the types of the constructor arguments.

Bug #2: Pretty sure RenderSizedOverflowBox never worked at all. As
soon as I wrote a test for it, the test showed that there was a
fundamental bug in its performLayout method: it didn't set
parentUsesSize, but it immediately tried to use the child's size.
2018-10-26 10:31:37 -07:00
Ian Hickson
48a5804dd8
[O] Cleanup (#23530)
* Improve documentation

* Potential performance win in hit testing

Rather than copying the list every time we access `path`, this just
exposes it as an `Iterable`. People who want to copy it can use
`toList()`.

(This isn't a breaking change since code that expects a `List` is
still going to get one.)

* Enforce the Oxford Comma.
2018-10-26 10:30:59 -07:00
Gary Qian
6827d0920b
Same cursor offset within lines for all TextAffinities to prevent cursor shifting/moving. (#23485) 2018-10-26 10:21:25 -07:00
engine-flutter-autoroll
340c158f32
Roll engine 6c2ade9fa2b5..9c46333e143b (5 commits) (#23570)
6c2ade9fa2...9c46333e14

git log 6c2ade9fa2b5..9c46333e143b --no-merges --oneline
9c46333e1 Roll src/third_party/skia 603c5da17491..e2fd74b48f6f (1 commits) (flutter/engine#6668)
d53c2be11 Roll src/third_party/skia 3f5b4ee4adfd..603c5da17491 (1 commits) (flutter/engine#6667)
074e67a7e Roll src/third_party/skia f5eaee917bb7..3f5b4ee4adfd (1 commits) (flutter/engine#6666)
7286e9acd Roll src/third_party/skia 2cf29ce4dbbf..f5eaee917bb7 (4 commits) (flutter/engine#6664)
3930b7c0d Roll src/third_party/skia a2272ef92640..2cf29ce4dbbf (8 commits) (flutter/engine#6661)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-26 11:27:22 -04:00
Alexander Aprelev
558ee42b2e
Register expression compiler in flutter test setting. (#23511)
* Register expression compiler in flutter test setting so that debugger expression evaluation is functional there.

* Fix analyzer lints
2018-10-26 08:04:58 -07:00
MH Johnson
3f179d80f6
[Material] Add custom shape parameter for Dialogs. (#23443)
* [Material] Add custom shape parameter for Dialogs.

* [Material] Add custom shape parameter for Dialogs.

* Address Hans' first round comments.

* Address Hans' first round comments.

* Address Hans' Second round comments.
2018-10-26 08:35:07 -04:00
engine-flutter-autoroll
d8cbb80206
Roll engine a6e816b2a67c..6c2ade9fa2b5 (4 commits) (#23532)
a6e816b2a6...6c2ade9fa2

git log a6e816b2a67c..6c2ade9fa2b5 --no-merges --oneline
6c2ade9fa Update contributing.md for xcode_backend refactor notes (flutter/engine#6642)
69dced915 Dart SDK roll for 2018-10-25
3edf5fa82 Roll src/third_party/skia dfca8f6adb6b..a2272ef92640 (4 commits) (flutter/engine#6659)
cf75289b6 TextField is only a live region when it has input focus (flutter/engine#6649)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-26 01:30:21 -04:00
Ian Hickson
2f63044604
[W] Mention new gitter channel (#22974)
* Mention new gitter channel

* Update CONTRIBUTING.md
2018-10-25 15:40:35 -07:00
Ian Hickson
5343bd8955
Add some documentation to the GestureBinding explaining the lifecycle. (#23484) 2018-10-25 15:40:22 -07:00
Jonah Williams
80fffe5ac4
Follow up scroll semantics update with documentation fixes (#23444) 2018-10-25 15:09:41 -07:00
liyuqian
883e2dc272
Maintain dirtiness and use retained engine layers (#23434)
For #21756
2018-10-25 14:17:12 -07:00
Dan Field
628e8ec0b9
Revert "Xcode backend refactor (#23387)" (#23528)
This reverts commit def1d80566024950f5e7aa748e5680e7f1480bcb.
2018-10-25 13:25:09 -07:00
Dan Field
def1d80566
Xcode backend refactor (#23387)
* Use Xcode build configurations to drive Flutter build mode
2018-10-25 11:29:31 -07:00
jslavitz
60de2deb4d
Adds custom control builder functionality to Stepper (#23310)
* Adds test and builder
2018-10-25 10:59:14 -07:00
jslavitz
bc56a7a6c5
Snack color (#23255)
* added test
2018-10-25 10:56:59 -07:00
engine-flutter-autoroll
b715cf142d
Roll engine 2586e9412257..a6e816b2a67c (14 commits) (#23513)
2586e94122...a6e816b2a6

git log 2586e9412257..a6e816b2a67c --no-merges --oneline
a6e816b2a Roll src/third_party/skia 4f598e8c829a..dfca8f6adb6b (7 commits) (flutter/engine#6658)
ff0525f59 Add missing entry-points. (flutter/engine#6634)
08771fe14 Revert dart before engine commit 26e8840de5d6fe801378301dd36d54c92b25bd3b (flutter/engine#6656)
914551bfa Dart SDK roll for 2018-10-24
9f2e2ba7b Add/expose API for Paragraph.getBoxesForRange BoxHeightStyle and BoxWidthStyle. (flutter/engine#6644)
9669b70e1 Add an iOS PlatformViewsController for creating/disposing UIViews. (flutter/engine#6569)
6c2477bd2 fix setter for viewOpaque (flutter/engine#6653)
2bd8c94fc Roll src/third_party/skia a7682c8c73e4..4f598e8c829a (8 commits) (flutter/engine#6654)
e1e60933b Realize kernel asset mappings on a worker thread if one is available. (flutter/engine#6648)
d3874a9ca Roll src/third_party/skia 3b57279fd65a..a7682c8c73e4 (9 commits) (flutter/engine#6652)
3dddf4d5b Roll src/third_party/skia 8429c7930291..3b57279fd65a (2 commits) (flutter/engine#6650)
7b3bb62a8 Roll src/third_party/skia 3aca39df7b22..8429c7930291 (5 commits) (flutter/engine#6647)
26e8840de Dart SDK roll for 2018-10-23
9829c51a9 Roll src/third_party/skia b46c4d0925ad..3aca39df7b22 (12 commits) (flutter/engine#6643)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-10-25 13:28:22 -04:00
Yegor
4452bd0a6b
Revert "Revert "make LocalHistoryRoute a proper super-mixin (#23382)"… (#23482)
* Revert "Revert "make LocalHistoryRoute a proper super-mixin (#23382)" (#23430)"

This reverts commit 3bbb3082b89ada4b0c44396148f3c2de731d1c6d.

This relands the LocalHistoryRoute change. The analyzer bug has been fixed.

* mark dartdocs as flaky
2018-10-25 09:56:23 -07:00
Martin
3b13761111 Update doc header in Opacity class to fix issue #23311 (#23475) 2018-10-25 09:32:57 -07:00
Jason Simmons
711eb99b06
Fix a type error in Slider (#23483)
Fixes https://github.com/flutter/flutter/issues/23340
2018-10-25 09:29:37 -07:00
Jason Simmons
549e8e07c6
Support launching flutter_tools from a package URI (#23476) 2018-10-24 14:41:16 -07:00
xster
d00a549f2d
Support RTL Cupertino nav bar transitions between routes (#23221) 2018-10-24 14:37:22 -07:00
Stefan Mitev
125b5d623c Fixes gradle error: 'Could not find lint-gradle-api.jar' (#23095) (#23397)
* Fixes gradle error: 'Could not find lint-gradle-api.jar' (#23095)
2018-10-24 14:33:39 -07:00
Michael Klimushyn
ce434022b5
Fix "E2E test setting and using isolate names (#23388)" (#23438)
Updates gradle.

This reverts commit d07c09c9a1a8bd9a0860c579154974437da14024.
2018-10-24 11:44:45 -07:00