20609 Commits

Author SHA1 Message Date
Rulong Chen(陈汝龙)
a5c60f4128
Limit the PlatformView ID within the range of 32-bit integers. (#121203)
Limit the PlatformView ID within the range of 32-bit integers.
2023-02-27 14:52:40 +00:00
Ben Konyi
fbae472fc3
Reland "Remove references to Observatory (#118577)" (#121215)
This reverts commit 298d8c76ba78007deb5b96f320a11ccefe97a794.
2023-02-27 09:26:43 -05:00
Christopher Fujino
6b3f95832a
show web-server in flutter devices (#121373)
[flutter_tools] show web-server in flutter devices
2023-02-24 23:52:06 +00:00
Michael Goderbauer
b1b7284a72
Move semantic-related bindings to SemanticsBinding (#121289)
Move semantic-related bindings to SemanticsBinding
2023-02-24 19:30:57 +00:00
Mitchell Goodwin
cb67ecd97d
Add adaptive RefreshIndicator (#121249) 2023-02-24 10:51:37 -08:00
Bruno Leroux
5d99748c7a
Remove accessibleNavigation reference from BottomSheet (#121132)
Remove accessibleNavigation reference from BottomSheet
2023-02-24 17:22:28 +00:00
Taha Tesser
219ff64574
Reland "Update ExpansionTile to support Material 3 & add an example" (#121212) 2023-02-24 06:30:33 -08:00
Hans Muller
1c753635b1
Added identical(a,b) short circuit to painting Library lerp methods (#121346) 2023-02-23 14:23:39 -08:00
Qun Cheng
07b0252da4
Change mouse cursor to be SystemMouseCursors.click when not focusable (#121353)
Co-authored-by: Qun Cheng <quncheng@google.com>
2023-02-23 14:23:11 -08:00
Greg Spencer
b1d8a4e4c7
Modify focus traversal policy search to use focus tree instead of widget tree (#121186)
* Modify focus traversal policy search to use focus tree instead of widget tree

* Eliminate unnecessary inherited widget

* Remove unintentional change

* Look for focus nodes without creating a dependency.

* Add test

* Review Changes

* Fix debug_test.dart

* Rebase onto master
2023-02-23 21:15:54 +00:00
Flutter GitHub Bot
5d36cb77fb
roll packages (#121358) 2023-02-23 20:20:25 +00:00
Lioness100
26b6c1bedd
Fix typos (#121171)
* Fix typos

* lowercase animated & opacity

* Undo typo fix

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
David Neuy
3681b27a47
Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props. (#114338)
* Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props.

* Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props - add tests.

* Fix analysis errors

* Review changes.

* Add asserts for dataRowMinHeight and dataRowMaxHeight

* Add asserts for dataRowMinHeight and dataRowMaxHeight

* Make dataRowHeight a computed getter

* Remove get only dataRowHeight from hashCode...

* Update deprecated after

* Add new line at end of AUTHORS

* Apply suggestions from code review

* Update packages/flutter/test/material/data_table_test.dart

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 19:32:29 +00:00
Greg Price
97938859e0
Fix buggy formula for critically-damped springs (#120488)
Fixes #109675.

This formula would produce an initial velocity quite different
from the one specified as an argument.

To update the test, I computed the expected results separately
by using the physical formula.

Happily, the framework by default never ends up actually exercising
this code.  Of the four SpringDescription call sites within the
framework, two are explicitly overdamped; the other two are by
design critically damped, but due to rounding they end up being
treated as (very slightly) overdamped too.  Details here:
  https://github.com/flutter/flutter/issues/109675#issuecomment-1423674855

So the only way an app could be affected by this bug is if it called
a SpringDescription constructor itself, and managed to create a spring
description where the distinguishing formula in _SpringSolution comes
out exactly equal to zero.  It's likely nobody has ever shipped such
an app, because the behavior this produces would be so wildly wrong
that it'd be hard to miss when exercised.

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 19:29:32 +00:00
Flutter GitHub Bot
8080becadf
roll packages (#120951) 2023-02-23 19:21:53 +00:00
chunhtai
660992a161
Fix text.rich to merge widget span (#113461)
* Fix text.rich to merge widget span

* migrate to new API

* update

* addressing comment

* addressing comments

* update

* addressing comment

* Update
2023-02-23 17:38:52 +00:00
Taha Tesser
56e1bddc59
Fix SliverAppBar.medium & SliverAppBar.large title overlap with leading/actions widgets, leading width, and title spacing (#120780)
* Fix `SliverAppBar.medium` & `SliverAppBar.large` title overlap with leading/actions widgets, leading width, and title spacing

* Add `titleSpacing` theme tests and consolidate multiple tests for the same widgets
2023-02-23 17:12:11 +00:00
Eilidh Southren
0c1ed75915
Remove newline (#121090)
* remove newline

* update crswap

* add const constructor

* update const
2023-02-23 10:39:41 +00:00
Bruno Leroux
046d907f53
Fix TextSelectionGestureDetectorBuilder wrong cause for onDoubleTapDown (#121093)
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
2023-02-23 09:24:17 +00:00
Todd Volkert
71c4570932
Add ResizeImage.policy (#121154)
* Add ResizeImage.policy

This adds a new `ResizeImage.policy` property that controls how `ResizeImage`
will interpret its `width` and `height` properties. The existing behavior is
preserved via `ResizeImagePolicy.exact` (default), but there is now the option
to use `ResizeImagePolicy.fit`, which satisfies the use case outlined in
flutter/flutter#118543.

The API doc assets were added in flutter/assets-for-api-docs#209

Fixes flutter/flutter#118543

* Docuemnt public member

* Remove protected annotation from overrides - was failing tests

* Fixed analysis of code in Dartdoc

* More dartdoc code analysis fixes

* One more fix

* Review comments
2023-02-23 03:53:05 +00:00
suragch
9619c33348
Remove obsolete comment (#120265)
* Remove obsolete comment

The method `_stopCursorTimer` no longer exists.

* Add edited comment back in

Addresses these comments:
- https://github.com/flutter/flutter/pull/120265#discussion_r1101673834
- https://github.com/flutter/flutter/pull/120265#discussion_r1102120022

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 02:46:16 +00:00
codiss
156c6614bf
Fix Material3 TabBarTheme.dividerColor not working (#119690)
* Fixed Material3 TabBarTheme.dividerColor not working

* Add 'Material3 - TabBar inherits the dividerColor of TabBarTheme' test

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 02:46:11 +00:00
Michael Goderbauer
4ef1fe4434
Work-around for channels flake (#121261) 2023-02-23 02:46:08 +00:00
Michael Goderbauer
1737233567
Fix typo (#121291) 2023-02-23 02:46:06 +00:00
Greg Spencer
a50bdcfd18
Add getInheritedWidgetOfExactType to BuildContext (#121276)
* Add getInheritedWidgetOfExactType to BuildContext

* Use the new API in all the places

* Fix doc error

* Review Changes
2023-02-23 01:09:51 +00:00
David Skelly
368537b910
Add padding to DropdownButton (#115806)
* add padding param to DropdownButton

* improve padding comment

* update test

* Add more context to documentation

* update padding documentation with more detail

---------

Co-authored-by: Kate Lovett <katelovett@google.com>
2023-02-23 01:07:51 +00:00
Casey Hillers
8f7ccd4c41
Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution (#118782)" (#121220)
This reverts commit e3db0488adaf1ca1330c800bef9aa06749d30a7a.
2023-02-23 00:13:33 +00:00
Casey Hillers
9241426828
Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#119597)" (#119656)
This reverts commit 7ba440655a801e50e1c02117beedeb2923391b6c.
2023-02-22 13:51:03 -08:00
Michael Goderbauer
5ccb4d4b95
Rename WindowPadding to ViewPadding (#121152)
* Rename WindowPadding to ViewPadding

* dart fix

* typos
2023-02-22 21:32:40 +00:00
Mushaheed Syed
7d85a585da
Add ActionButtonIconsData for overriding action icons (#118229)
* Add ActionButtonIconsData for overriding action icons

* Fix formatting issues

* Add missing exports in material library and add copyWith method in ActionButtonIconsData

* Move all action buttons, and icons to action_buttons.dart

* Rename actionButtonIcons to actionIconTheme

* Refactor buttons in action_buttons.dart to extend a private class for common implementation

* Refactor icons in action_buttons

* Fix docs in action_buttons_theme

* Fix #107646 always use 'Icons.arrow_back' as a back_button icon in web

* Update documentation for action buttons and add style parameter to every action button

* Fix analyzer warnings

* Add missing style argument in IconButton of _ActionButton

* Add tests for action buttons, action icon theme, drawer buttons, and back buttons

* Add example (+test) for action icon button's action icon theme in examples/api

* Fix analysis errors

* Add missing license header in action_icon_theme.0.dart

* Fix deprecation notice in theme_data.dart

* Update theme data tests for actionIconTheme

* Remove iconSize parameter from ActionButtons and update docs

* Fix failing tests

* Update button color during backbutton tests to red

* Fix analytics issues

* Fix format
2023-02-22 09:22:44 -08:00
suragch
dad9eb21f9
fix spelling typo (#120062)
* fix spelling typo

* _index not nullable

This address the comment here: https://github.com/flutter/flutter/pull/120062#issuecomment-1421424676
2023-02-21 23:16:23 +00:00
Jessica Pereira
aa29358c5e
Fix license page rtl (#120497)
* fix license page rtl

* fix editor spacings, tests to lateral view

* fix defaultSize and setSurfaceSize

* add validation for packageList position

* fix spacing

* simplify align
2023-02-21 21:54:39 +00:00
Kate Lovett
c6e1a4dc9a
Fix formatting (#121167) 2023-02-21 21:34:19 +00:00
David Iglesias
a463bb82c4
[tool][web] Makes flutter.js more G3 friendly. (#120504)
* Allow any JS file in flutter loader.

* Nag only if service worker API is completely unavailable.

* Add info about Secure Contexts if that may be the reason why serviceworker is not available.

* Update sanity test.

* If service worker settings are null, do not even check if the API is available.
2023-02-21 20:51:37 +00:00
Kate Lovett
09518ac725
Remove single axis assertion (#120738) 2023-02-21 18:05:07 +00:00
Kate Lovett
4acbe9706f
Remove alternate axis assertion from StretchingOverscrollIndicator (#120734)
* remove axes assertion

* Update packages/flutter/lib/src/widgets/overscroll_indicator.dart
2023-02-21 18:05:04 +00:00
Enguerrand ARMINJON
6259b690f6
feature/clean-a-specific-scheme: Add this-scheme new flag for clean command (#116733)
Co-authored-by: Enguerrand_ARMINJON_MAC_2 <earminjon@sqli.com>
2023-02-21 17:35:13 +00:00
Mouad Debbar
902d86e09c
[web] Unify line boundary expectations on web and non-web (#121006)
* [web] Temporarily disable a line boundary test

* [web] Unify line boundary expectations on web and non-web
2023-02-21 17:28:13 +00:00
Mateus Felipe C. C. Pinto
ebbc94bc2b
allow passing --file-reporter option to test running refs #69425 (#120716)
* allow passing --file-reporter option to test running refs #69425

* Add trailing comma to help to meet style requirements

* Add space between tests for clarity

---------

Co-authored-by: daniel-v <dvarga@skawa.hu>
2023-02-21 17:24:11 +00:00
Andrew Kolos
e3db0488ad
Speed up first asset load by using the binary-formatted asset manifest for image resolution (#118782)
* add asset manifest bin loading and asset manifest api

* use new api for image resolution

* remove upfront smc data casting

* fix typecasting issue

* remove unused import

* fix tests

* lints

* lints

* fix import

* fix outdated type name

* restore AssetManifest docstrings

* update test

* update other test

* make error message for invalid keys more useful
2023-02-21 16:05:12 +00:00
Eilidh Southren
ae8d05184e
[M3] Update checkbox shape value (#120976)
* update m3 values

* update test formatting

* update crswap

* update test

* update token value

* update tests
2023-02-20 11:38:26 +00:00
Michael Goderbauer
2b4c960885
Remove more references to dart:ui.window (#120994)
* Remove more references to dart:ui.window

* two more doc referenes

* revert icon_color_test.dart
2023-02-18 01:50:08 +00:00
Qun Cheng
f99f472807
Remove the deprecated accentColor from ThemeData (#120932)
Co-authored-by: Qun Cheng <quncheng@google.com>
2023-02-18 01:50:05 +00:00
chunhtai
1daa0be4f9
Fix scrollable to clear inner semantics node if it does not use two p… (#120996)
* Fix scrollable to clear inner semantics node if it does not use two panel

* g

* add more check
2023-02-17 22:33:15 +00:00
Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) (#120842)
* lerp documentation

* Remove Note, Note That from repo

* Improve BorderSide documentation.

* apply review comments
2023-02-17 22:27:33 +00:00
Jenn Magder
9fe556705b
Print sub process that failed to run in tool (#120999) 2023-02-17 22:02:51 +00:00
Mouad Debbar
f785136852
[web] Temporarily disable a line boundary test (#121005) 2023-02-17 21:50:11 +00:00
Taha Tesser
c3587c62e4
Add InheritedTheme support to ScrollbarTheme (#120970) 2023-02-17 19:51:05 +00:00
Renzo Olivares
9367641ce2
clean up (#120934)
Co-authored-by: Renzo Olivares <roliv@google.com>
2023-02-17 18:42:09 +00:00
yim
c4d40cc152
Modify the updateChildren method deep copy _children (#120773)
* Modify the updateChildren method deep copy _children

* add test

* fix some small nits

* Simplified newChildren declaration in updateChildren
2023-02-17 18:29:02 +00:00